> The main reason for this is to identify backups residing on an old backup
> store like an archive.
>
>
>
> But I am open. Would you prefer having a manifest included in the archive or
> as a separate file on the same storage?
The backup archive already contains the full VM config. I
I totally agree, but wanted to point out that while this solution is not the
prettiest, but the information is exactly where it needs to be.
The main reason for this is to identify backups residing on an old backup store
like an archive.
But I am open. Would you prefer having a manifest
> IMHO this is the wrong way to store additional information about
> the backup.
I am thinking about adding a manifest.json file which may contain
such information
___
pve-devel mailing list
pve-devel@pve.proxmox.com
IMHO this is the wrong way to store additional information about
the backup.
> On 13 November 2019 15:02 Marco Gabriel wrote:
>
>
> Signed-off-by: Marco Gabriel
> ---
> PVE/VZDump/Common.pm | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/PVE/VZDump/Common.pm
Thanks for clarification.
I'd update the wiki page accordingly.
Best regards,
Marco
inett GmbH
>> Ihr IT Systemhaus in Saarbrücken
Marco Gabriel
Geschäftsführer
t: 0681-410993-0
e: mgabr...@inett.de
www.inett.de
Technische Fragen:
Support E-Mail: supp...@inett.de
Support Hotline:
On 11/13/19 3:02 PM, Marco Gabriel wrote:
> *** BLURB HERE ***
>
> Marco Gabriel (1):
> vzdump: added "includename" option
>
> PVE/VZDump/Common.pm | 6 ++
> 1 file changed, 6 insertions(+)
>
FYI, some pointers for sending patches with git/mail
It's nice if related patches are send
*** BLURB HERE ***
Marco Gabriel (1):
vzdump: added "includename" option
PVE/VZDump/Common.pm | 6 ++
1 file changed, 6 insertions(+)
--
2.20.1
___
pve-devel mailing list
pve-devel@pve.proxmox.com
Signed-off-by: Marco Gabriel
---
PVE/VZDump/Common.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm
index 4789a50..0a70b0c 100644
--- a/PVE/VZDump/Common.pm
+++ b/PVE/VZDump/Common.pm
@@ -213,6 +213,12 @@ my $confdesc = {
type =>
Signed-off-by: Marco Gabriel
---
vzdump.adoc | 8
1 file changed, 8 insertions(+)
diff --git a/vzdump.adoc b/vzdump.adoc
index fd7f13f..624bf3b 100644
--- a/vzdump.adoc
+++ b/vzdump.adoc
@@ -147,6 +147,14 @@ That way it is possible to store several backup in the same
directory. The
*** BLURB HERE ***
Marco Gabriel (1):
vzdump: docs: added "includename" option in vzdump docs
vzdump.adoc | 8
1 file changed, 8 insertions(+)
--
2.20.1
___
pve-devel mailing list
pve-devel@pve.proxmox.com
*** BLURB HERE ***
Marco Gabriel (1):
vzdump: added "includename" option
PVE/VZDump/Common.pm | 6 ++
1 file changed, 6 insertions(+)
--
2.20.1
___
pve-devel mailing list
pve-devel@pve.proxmox.com
Signed-off-by: Marco Gabriel
---
PVE/VZDump/Common.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm
index 4789a50..0a70b0c 100644
--- a/PVE/VZDump/Common.pm
+++ b/PVE/VZDump/Common.pm
@@ -213,6 +213,12 @@ my $confdesc = {
type =>
Signed-off-by: Marco Gabriel
---
PVE/API2/Backup.pm| 6 ++
PVE/VZDump.pm | 19 ++-
www/manager6/dc/Backup.js | 10 +-
3 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 86377c0a..316d6800
Hi,
On 11/13/19 2:44 PM, Marco Gabriel - inett GmbH wrote:
> Hi,
>
> long time ago, I requested adding the container hostname or vm name in
> bugzilla request #438. As I wanted to practice developing features for pve
> and how to use the git repos, I implemented the feature. I should have
*** BLURB HERE ***
Marco Gabriel (1):
vzdump: added "includename" option which adds the name or hostname of
a vm or container to a backup filename. Can be used optionally,
defaults to old behaviour without host/vmname. If enabled,
host/vmname will be added after timestamp and before
On 11/13/19 2:44 PM, Marco Gabriel - inett GmbH wrote:
Hi,
Hi,
long time ago, I requested adding the container hostname or vm name in bugzilla
request #438. As I wanted to practice developing features for pve and how to
use the git repos, I implemented the feature. I should have asked
a few issues , we talked with wolfgang off-list so he'll
send a v3.
* target directories are not created when hotplugging
* apparmor profile needs to be adapted
* missing case for hotplugging unused disks, they are currently
registered as a change and not a new mount, the code doesn't handle
On 11/13/19 1:30 PM, Oguz Bektas wrote:
> hi,
>
> On Wed, Nov 13, 2019 at 10:33:11AM +0100, Wolfgang Bumiller wrote:
>> Signed-off-by: Wolfgang Bumiller
>> ---
>> New patch
>>
>> src/PVE/LXC/Tools.pm | 18 ++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git
Hi,
long time ago, I requested adding the container hostname or vm name in bugzilla
request #438. As I wanted to practice developing features for pve and how to
use the git repos, I implemented the feature. I should have asked before, but I
haven't. So I am not upset if the feature won't make
hi,
On Wed, Nov 13, 2019 at 10:33:11AM +0100, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> New patch
>
> src/PVE/LXC/Tools.pm | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/src/PVE/LXC/Tools.pm b/src/PVE/LXC/Tools.pm
> index
On 11/13/19 9:55 AM, Thomas Lamprecht wrote:
On 11/12/19 11:03 AM, Fabian Ebner wrote:
The minimum value for timeout in vm_shutdown is changed from 0 to 1, since a
value of 0 would trigger a hard stop for HA managed VMs. Like this the API
description stays valid for all cases.
Signed-off-by:
On 11/12/19 5:26 PM, Oguz Bektas wrote:
> there _is_ actually reboot triggers for lxc which are used by the
> prestart hook and similar, however i think it's better if we can
> differentiate between reboot requests from inside the container and from
> API. (inadvertently this also allows to reboot
Changes:
Add a helper to LXC::PVE::Tools to check for availability of the new
mount api (new patch 1), and use that in the prestart hook and mount
functions.
Add a check to the mount hotplug code to not attempt to perform
hotplugging on older kernels.
Wolfgang Bumiller (9):
tools: add
Signed-off-by: Wolfgang Bumiller
---
New patch
src/PVE/LXC/Tools.pm | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/PVE/LXC/Tools.pm b/src/PVE/LXC/Tools.pm
index bebd7d8..0256b6a 100644
--- a/src/PVE/LXC/Tools.pm
+++ b/src/PVE/LXC/Tools.pm
@@ -2,6 +2,8 @@
package
for reuse in hotplug code
Signed-off-by: Wolfgang Bumiller
---
No changes.
src/PVE/LXC/Config.pm | 65 ++-
1 file changed, 39 insertions(+), 26 deletions(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 39de691..44d7f93 100644
---
Signed-off-by: Wolfgang Bumiller
---
Changes to v1:
Use the new can_use_new_mount_api() to prevent mp hotplug attempts on
older kernels.
src/PVE/LXC.pm| 44 +++
src/PVE/LXC/Config.pm | 28 ++-
2 files changed, 71
Signed-off-by: Wolfgang Bumiller
---
No changes.
src/PVE/LXC.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index c07a597..6bea0b7 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1048,6 +1048,19 @@ my $enter_namespace = sub {
This way we operate on defined paths in the monitor
namespace (/run/pve/mountpoint/{rootfs,mp0,mp1,...}) while
performing the mount, and can use `move_mount()` without
passing the MOVE_MOUNT_T_SYMLINKS flag when putting the
hierarchy in place.
Signed-off-by: Wolfgang Bumiller
---
Changes to v1:
Signed-off-by: Wolfgang Bumiller
---
No changes.
src/PVE/LXC.pm | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 6bea0b7..77b1a43 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -11,7 +11,7 @@ use
Getting a pid and acting on it is always a race, so add
safer helpers for this.
Signed-off-by: Wolfgang Bumiller
---
No changes.
src/PVE/LXC.pm | 38 ++
1 file changed, 38 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index ea54518..c51e59e
Staging a mount point requires the new kernel mount API and
will mount the volume at a fixed path, then use open_tree()
to "pick it up" into a file descriptor.
For most of our volumes we wouldn't need the temp directory,
but some things cannot be handled with _only_ the new API
(like single-step
Signed-off-by: Wolfgang Bumiller
---
No changes.
src/PVE/LXC.pm | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index c51e59e..c07a597 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1033,12 +1033,18 @@ sub update_ipconfig
we maybe want to backport this for pve5 also.. (should apply i guess)
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
the code returns undef in case there is no 'tos', and the code
calling this api call handles a non-existing tos already, but
fails in that case becasue of the failing return value verification
Signed-off-by: Dominik Csapak
---
PVE/API2/ACMEAccount.pm | 1 +
1 file changed, 1 insertion(+)
diff
On 11/12/19 5:26 PM, Oguz Bektas wrote:
code for create_reboot_request and clear_reboot_request is from qemu, the only
difference is that we use /run/lxc/$vmid.reboot path instead of
/run/qemu-server.
there _is_ actually reboot triggers for lxc which are used by the
prestart hook and similar,
On 11/12/19 11:03 AM, Fabian Ebner wrote:
> The minimum value for timeout in vm_shutdown is changed from 0 to 1, since a
> value of 0 would trigger a hard stop for HA managed VMs. Like this the API
> description stays valid for all cases.
>
> Signed-off-by: Fabian Ebner
> ---
>
> In vm_shutdown
On Tue, Nov 12, 2019 at 03:09:27PM +0100, Oguz Bektas wrote:
> hi,
>
> built the latest git version of pve-common and pve-container with
> wolfgang's patches.
>
> with running kernel: 5.0.21-4-pve
> and the latest pve-kernel-5.3
>
> found a small issue while testing.
>
> when one has an older
37 matches
Mail list logo
