Re: [pve-devel] [PATCH pve-manager 0/3] sdn: split vnets/zones/controllers plugins

2019-11-14 Thread Thomas Lamprecht
Hi, On 11/15/19 12:03 AM, Alexandre DERUMIER wrote: > Did somebody had time to review it ? it looks OK, needs the network stuff too or, is that already applied (sorry, do not remember.. :/) else I can merge it as is. > > I'll rebase it to master soon, as I see that big rework in >

Re: [pve-devel] [PATCH pve-manager 0/3] sdn: split vnets/zones/controllers plugins

2019-11-14 Thread Alexandre DERUMIER
Hi, Did somebody had time to review it ? I'll rebase it to master soon, as I see that big rework in pve-cluster,qemu,... packages are coming. - Mail original - De: "aderumier" À: "pve-devel" Cc: "aderumier" Envoyé: Mardi 22 Octobre 2019 16:59:17 Objet: [PATCH pve-manager 0/3] sdn:

[pve-devel] [PATCH frr] bump to 7.2

2019-11-14 Thread Alexandre Derumier
This release fix last evpn bugs. (need to update proxmox frr mirror to frr-7.2 tag) --- Makefile | 2 +- debian/changelog | 6 ++ debian/control | 18 -- 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 18e994f..3359748

[pve-devel] applied-series: [PATCH stable-5 container 1/2] add upcoming Ubuntu 19.10 Eoan as supported

2019-11-14 Thread Thomas Lamprecht
On 10/31/19 4:45 PM, Oguz Bektas wrote: > From: Thomas Lamprecht > > Signed-off-by: Thomas Lamprecht > (cherry picked from commit 5c5d57f05b0bb8daedb24625ec69dd30133b8dc7) > Signed-off-by: Oguz Bektas > --- > src/PVE/LXC/Setup/Ubuntu.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2019-11-14 Thread Thomas Lamprecht
On 11/14/19 6:30 AM, Dietmar Maurer wrote: >> The main reason for this is to identify backups residing on an old backup >> store like an archive. >> >> But I am open. Would you prefer having a manifest included in the archive or >> as a separate file on the same storage? > > The backup

[pve-devel] applied-series: [PATCH v2 qemu-server] Use crm-command stop to allow shutdown with timeout and hard stop for HA

2019-11-14 Thread Thomas Lamprecht
On 11/14/19 12:23 PM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * don't change the API > applied both, with follow-up versioned dependency bump in debian/control, thanks! ___ pve-devel mailing list

Re: [pve-devel] [PATCH storage 2/2] fix #2085: Handle non-default mount point in path() using storage property 'path' for mount point

2019-11-14 Thread Thomas Lamprecht
On 11/14/19 11:33 AM, Fabian Ebner wrote: > Since other storage plugins use a property called 'path' for the mount point, > it was used here as well; not to be confused with the subroutine path(). but those other storage plugins are all Filesystem based, while we do not use ZFS as file system

[pve-devel] applied: [PATCH storage 1/2] Introduce zfs_get_properties helper

2019-11-14 Thread Thomas Lamprecht
On 11/14/19 11:33 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/Storage/ZFSPoolPlugin.pm | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > applied, thanks! ___ pve-devel mailing list

[pve-devel] [PATCH v2 container] Use crm-command stop to allow shutdown with timeout and hard stop for HA

2019-11-14 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Changes from v1: * don't change the API src/PVE/API2/LXC/Status.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm index 1b7a71d..166c731 100644 --- a/src/PVE/API2/LXC/Status.pm

[pve-devel] [PATCH v2 qemu-server] Use crm-command stop to allow shutdown with timeout and hard stop for HA

2019-11-14 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Changes from v1: * don't change the API PVE/API2/Qemu.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c31dd1d..8e162aa 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2111,7

[pve-devel] applied: [PATCH widget-toolkit 5/6] add reboot for containers into task description table

2019-11-14 Thread Thomas Lamprecht
On 11/12/19 5:27 PM, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > Utils.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Utils.js b/Utils.js > index e3dcfcd..3a8fa9a 100644 > --- a/Utils.js > +++ b/Utils.js > @@ -494,6 +494,7 @@ Ext.define('Proxmox.Utils', { utilities: { >

Re: [pve-devel] [PATCH qemu-server] Use crm-command stop to allow shutdown with timeout and hard stop for HA

2019-11-14 Thread Thomas Lamprecht
On 11/13/19 12:55 PM, Fabian Ebner wrote: > On 11/13/19 9:55 AM, Thomas Lamprecht wrote: >> On 11/12/19 11:03 AM, Fabian Ebner wrote: >>> The minimum value for timeout in vm_shutdown is changed from 0 to 1, since a >>> value of 0 would trigger a hard stop for HA managed VMs. Like this the API >>>

[pve-devel] applied: [PATCH master/stable-5 access-control] API: fix calls to raise_param_exc

2019-11-14 Thread Thomas Lamprecht
On 11/14/19 11:00 AM, Fabian Grünbichler wrote: > the parameter needs to be a hash reference, not a hash. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > checked other code, seems like this was the only instance of mis-use. > > PVE/API2/AccessControl.pm | 6 +++--- > 1 file

[pve-devel] [PATCH docs] Add description for path property

2019-11-14 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pve-storage-zfspool.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pve-storage-zfspool.adoc b/pve-storage-zfspool.adoc index f53a598..0f213b0 100644 --- a/pve-storage-zfspool.adoc +++ b/pve-storage-zfspool.adoc @@ -32,6 +32,12 @@ sparse:: Use ZFS

[pve-devel] [PATCH storage 1/2] Introduce zfs_get_properties helper

2019-11-14 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/Storage/ZFSPoolPlugin.pm | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index 16fb0d6..b8adf1c 100644 --- a/PVE/Storage/ZFSPoolPlugin.pm +++

[pve-devel] [PATCH storage 2/2] fix #2085: Handle non-default mount point in path() using storage property 'path' for mount point

2019-11-14 Thread Fabian Ebner
Since other storage plugins use a property called 'path' for the mount point, it was used here as well; not to be confused with the subroutine path(). When adding a zfspool storage with 'pvesm add' the mount point is now added automatically to the storage configuration if it can be determined.

[pve-devel] [PATCH master/stable-5 access-control] API: fix calls to raise_param_exc

2019-11-14 Thread Fabian Grünbichler
the parameter needs to be a hash reference, not a hash. Signed-off-by: Fabian Grünbichler --- Notes: checked other code, seems like this was the only instance of mis-use. PVE/API2/AccessControl.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [pve-devel] [PATCH v2 container 1/9] tools: add can_use_new_mount_api helper

2019-11-14 Thread Thomas Lamprecht
On 11/14/19 9:45 AM, Wolfgang Bumiller wrote: > On Wed, Nov 13, 2019 at 02:46:57PM +0100, Thomas Lamprecht wrote: >> On 11/13/19 1:30 PM, Oguz Bektas wrote: >>> On Wed, Nov 13, 2019 at 10:33:11AM +0100, Wolfgang Bumiller wrote: +sub can_use_new_mount_api() { >>> >>> i don't like these names..

[pve-devel] applied: [PATCH qemu-server] fix destroy_vm by using correct Config package

2019-11-14 Thread Thomas Lamprecht
On 11/14/19 9:49 AM, Dominik Csapak wrote: > We are in the QemuServer package not in LXC, so use the correct > package for the Config, namely QemuConfig > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied, thanks!

[pve-devel] [PATCH qemu-server] fix destroy_vm by using correct Config package

2019-11-14 Thread Dominik Csapak
We are in the QemuServer package not in LXC, so use the correct package for the Config, namely QemuConfig Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1890448..54c8c88 100644

Re: [pve-devel] [PATCH v2 container 1/9] tools: add can_use_new_mount_api helper

2019-11-14 Thread Wolfgang Bumiller
On Wed, Nov 13, 2019 at 02:46:57PM +0100, Thomas Lamprecht wrote: > On 11/13/19 1:30 PM, Oguz Bektas wrote: > > hi, > > > > On Wed, Nov 13, 2019 at 10:33:11AM +0100, Wolfgang Bumiller wrote: > >> Signed-off-by: Wolfgang Bumiller > >> --- > >> New patch > >> > >> src/PVE/LXC/Tools.pm | 18