On 5/6/20 8:11 PM, Thomas Lamprecht wrote:
On 5/6/20 4:31 PM, Dominik Csapak wrote:
this series adapts the node->certificates->acme panel to include
an 'accountselector' and to be able to add/edit/remove single domains,
including ones with a plugin
changes from v1:
* drop fieldLabel in
On 5/6/20 4:31 PM, Dominik Csapak wrote:
> this series adapts the node->certificates->acme panel to include
> an 'accountselector' and to be able to add/edit/remove single domains,
> including ones with a plugin
>
> changes from v1:
> * drop fieldLabel in ACMEAccountSelector
> * reword 'Account'
- Le 6 Mai 20, à 17:46, Thomas Lamprecht t.lampre...@proxmox.com a écrit :
> On 5/6/20 5:28 PM, Thomas Lamprecht wrote:
>> On 5/6/20 5:21 PM, Daniel Berteaud wrote:
>>> Just opened [ https://bugzilla.proxmox.com/show_bug.cgi?id=2719 |
>>> https://bugzilla.proxmox.com/show_bug.cgi?id=2719 ]
On 5/6/20 5:28 PM, Thomas Lamprecht wrote:
> On 5/6/20 5:21 PM, Daniel Berteaud wrote:
>> Just opened [ https://bugzilla.proxmox.com/show_bug.cgi?id=2719 |
>> https://bugzilla.proxmox.com/show_bug.cgi?id=2719 ]
>> It's rather important, as it might cut remote access (and not everyone has
>> an
On 5/6/20 5:21 PM, Daniel Berteaud wrote:
> Just opened [ https://bugzilla.proxmox.com/show_bug.cgi?id=2719 |
> https://bugzilla.proxmox.com/show_bug.cgi?id=2719 ]
> It's rather important, as it might cut remote access (and not everyone has an
> IPMI console available)
>
> ++
>
I'll take a
On 5/6/20 5:20 PM, Stefan Reiter wrote:
> On 5/6/20 4:52 PM, Thomas Lamprecht wrote:
>> On 5/4/20 12:58 PM, Stefan Reiter wrote:
>>> More API calls will follow for this path, for now add the 'index' call to
>>> list all custom and default CPU models.
>>>
>>> Any user can list the default CPU
Just opened [ https://bugzilla.proxmox.com/show_bug.cgi?id=2719 |
https://bugzilla.proxmox.com/show_bug.cgi?id=2719 ]
It's rather important, as it might cut remote access (and not everyone has an
IPMI console available)
++
--
[ https://www.firewall-services.com/ ]
Daniel Berteaud
On 5/6/20 4:52 PM, Thomas Lamprecht wrote:
On 5/4/20 12:58 PM, Stefan Reiter wrote:
More API calls will follow for this path, for now add the 'index' call to
list all custom and default CPU models.
Any user can list the default CPU models, as these are public anyway, but
custom models are
On 3/23/20 1:41 PM, Stefan Reiter wrote:
> v2 -> v3:
> * add patch 1 (localization fix)
> * implement changes from Dominik's review:
> * use 'let' in new code
> * use references for element lookup
> * some code style nits
> * fix formatting (simpler in general with hbox, and also should
On 4/30/20 4:03 PM, Dominik Csapak wrote:
> username can include some special characters, so we have
> to escape them
>
> Signed-off-by: Dominik Csapak
> ---
> window/TaskViewer.js | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/window/TaskViewer.js
On 4/30/20 4:04 PM, Dominik Csapak wrote:
> username can include some special characters, so we have
> to escape them
>
> Signed-off-by: Dominik Csapak
> ---
> www/manager6/Workspace.js | 2 +-
> www/manager6/dc/ACLView.js | 2 +-
> www/manager6/dc/GroupView.js | 1 +
>
On 5/4/20 12:58 PM, Stefan Reiter wrote:
> More API calls will follow for this path, for now add the 'index' call to
> list all custom and default CPU models.
>
> Any user can list the default CPU models, as these are public anyway, but
> custom models are restricted to users with Sys.Audit on
On 5/4/20 12:58 PM, Stefan Reiter wrote:
> Explicitly allows changing other properties than the cputype, even if
> the currently set cputype is not accessible by the user. This way, an
> administrator can assign a custom CPU type to a VM for a less privileged
> user without breaking edit
On 5/6/20 2:00 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> PVE/API2/AccessControl.pm | 48 +++
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
applied, thanks!
___
pve-devel mailing list
On 5/6/20 2:00 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> www/manager6/Workspace.js | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
applied, thanks!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
On 5/6/20 2:00 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> www/manager6/Workspace.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
> index 20d8c692..ffc5b175 100644
> --- a/www/manager6/Workspace.js
> +++
On 5/6/20 12:34 PM, Stefan Reiter wrote:
> There's no graphs on screen, so no reason to collapse the notes to save
> space. Besides, it looked a bit funky expanding the notes on smaller
> screens, since they always jumped to the bottom to fill the space...
>
> Signed-off-by: Stefan Reiter
> ---
On 5/5/20 5:27 PM, Alwin Antreich wrote:
> to clean service directories as well as disable and stop Ceph services.
> Addtionally provide the option to remove crash and log information.
>
> This patch is also in addtion to #2607, as the current cleanup doesn't
> allow to re-configure Ceph, without
On 5/6/20 10:14 AM, Fabian Ebner wrote:
> Previously, the blank '' would be passed along and lead to a
> parameter verfication failure.
>
> For LXC the default behavior in the backend is to use 'local', so
> disallow blank and auto-select the first storage supporting'rootdir'
> instead.
>
> For
since we decode the domain list in parseACME into an array, we
have to join them again to a string when printing
otherwise printPropertyString attaches them just with ',' which
does not work here
Signed-off-by: Dominik Csapak
---
www/manager6/Parser.js | 7 +++
1 file changed, 7
which expects a nodeconfig (for digest and domaincount)
and for the edit case, the parsed 'domain' object
this editwindow has three fields:
* type selector (standalone/dns)
* domain
* plugin (only for dns)
if the user chooses dns but there are already the maximum count of
acmedomainX entries,
This is basically a complete rework of the ACME grid.
Instead of having an ObjectGrid, we now have a normal
GridPanel which allows us to show a row for each Domain.
But to achieve this, we need to manually fill the store with data
from the 'acme' and 'acmedomainX' entries of the node config.
We
to convieniently add and remove domains from a parsed ACME object
they also make domains unique in the array
also add the count of configureable acmedomainX entries
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 23 +++
1 file changed, 23 insertions(+)
diff
filter the plugins by type === 'dns'
and add a convenience method for ACMEAccountSelector to check if there
are any accounts
Signed-off-by: Dominik Csapak
---
changes from v1:
* drop fieldLabel in ACMEAccountSelector
www/manager6/Makefile| 2 ++
this series adapts the node->certificates->acme panel to include
an 'accountselector' and to be able to add/edit/remove single domains,
including ones with a plugin
changes from v1:
* drop fieldLabel in ACMEAccountSelector
* reword 'Account' in 'Used Account'
* use different approach to change
On 5/5/20 1:07 PM, Fabian Grünbichler wrote:
> fixing the following two issues:
> - the legacy code path was never converted to the new fork_tunnel
> signature (which probably means that nothing triggers it in practice
> anymore?)
> - the NBD Unix socket got forwarded multiple times if more than
On 5/6/20 10:57 AM, Fabian Grünbichler wrote:
> instead of storage config to determine whether we are in 'PBS mode'
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> requires a break on pve-manager << version setting this option,
> since the dependency is the other way round
>
>
On 5/4/20 3:32 PM, Dominik Csapak wrote:
> explaining the main Requirements and limitations, as well as the
> most important sync options
>
> Signed-off-by: Dominik Csapak
> ---
> changes from v2:
> * incorporated suggestions from aaron
> @aaron, regarding linking to character limitations,
>
On 5/6/20 2:51 PM, Aaron Lauterer wrote:
> fixes behavior introduced with commit
> 940e2a3a06b3ea47aae144519e2aaa881a80e437
>
> Qemu 4.1 will fail to start a guest with an audio device set with
> `Property '.audiodev' not found`.
>
> Signed-off-by: Aaron Lauterer
> ---
>
> Users reported this
fixes behavior introduced with commit
940e2a3a06b3ea47aae144519e2aaa881a80e437
Qemu 4.1 will fail to start a guest with an audio device set with
`Property '.audiodev' not found`.
Signed-off-by: Aaron Lauterer
---
Users reported this problem in the forum today [0].
I was able to reproduce this
On 5/6/20 2:17 PM, Stefan Reiter wrote:
> It's possible to have a VM with OVMF but without an efidisk, so don't
> call parse_drive on a potential undef value.
>
> Partial revert of 818c3b8d91 ("cfg2cmd: ovmf: code cleanup")
>
> Signed-off-by: Stefan Reiter
> ---
> PVE/QemuServer.pm | 3 ++-
>
On 5/6/20 11:56 AM, Fabian Grünbichler wrote:
> redirecting to the saved STDOUT in case of a template backup or a VM
> without any disks failed because of the erroneous '=':
>
> Backup of VM 123123 failed - command '/usr/bin/vma create -v -c [...]' failed:
> Bad filehandle: =5 at
On 5/5/20 4:53 PM, Stefan Reiter wrote:
> If /dev/hwrng exists, but no actual generator is connected (or it is
> disabled on the host), QEMU will happily start the VM but crash as soon
> as the guest accesses the VirtIO RNG device.
>
> To prevent this unfortunate behaviour, check if a useable
It's possible to have a VM with OVMF but without an efidisk, so don't
call parse_drive on a potential undef value.
Partial revert of 818c3b8d91 ("cfg2cmd: ovmf: code cleanup")
Signed-off-by: Stefan Reiter
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
filter the plugins by type === 'dns'
and add a convenience method for ACMEAccountSelector to check if there
are any accounts
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile| 2 ++
www/manager6/form/ACMEAccountSelector.js | 22 ++
this series adapts the node->certificates->acme panel to include
an 'accountselector' and to be able to add/edit/remove single domains,
including ones with a plugin
Dominik Csapak (5):
ui: add ACME selector formfields for account and plugins
ui: Parser: add printACME
ui: Utils: add helper
to convieniently add and remove domains from a parsed ACME object
they also make domains unique in the array
also add the count of configureable acmedomainX entries
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 23 +++
1 file changed, 23 insertions(+)
diff
since we decode the domain list in parseACME into an array, we
have to join them again to a string when printing
otherwise printPropertyString attaches them just with ',' which
does not work here
Signed-off-by: Dominik Csapak
---
www/manager6/Parser.js | 7 +++
1 file changed, 7
which expects a nodeconfig (for digest and domaincount)
and for the edit case, the parsed 'domain' object
this editwindow has three fields:
* type selector (standalone/dns)
* domain
* plugin (only for dns)
if the user chooses dns but there are already the maximum count of
acmedomainX entries,
This is basically a complete rework of the ACME grid.
Instead of having an ObjectGrid, we now have a normal
GridPanel which allows us to show a row for each Domain.
But to achieve this, we need to manually fill the store with data
from the 'acme' and 'acmedomainX' entries of the node config.
We
Signed-off-by: Tim Marx
---
Utils.js | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/Utils.js b/Utils.js
index 22eddd2..b190ce4 100644
--- a/Utils.js
+++ b/Utils.js
@@ -31,6 +31,10 @@ Ext.Ajax.on('beforerequest', function(conn, options) {
}
Signed-off-by: Tim Marx
---
PVE/API2/AccessControl.pm | 48 +++
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm
index 5b63d2b..25230ac 100644
--- a/PVE/API2/AccessControl.pm
+++
Signed-off-by: Tim Marx
---
PVE/API2/AccessControl.pm | 29 +
1 file changed, 29 insertions(+)
diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm
index 25230ac..0a1b836 100644
--- a/PVE/API2/AccessControl.pm
+++ b/PVE/API2/AccessControl.pm
@@ -717,4
Signed-off-by: Tim Marx
---
www/manager6/Workspace.js | 5 ++
www/manager6/window/LoginWindow.js | 129 ++---
2 files changed, 105 insertions(+), 29 deletions(-)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 12ad70e4..20d8c692 100644
Signed-off-by: Tim Marx
---
www/manager6/Workspace.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 20d8c692..ffc5b175 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -37,6 +37,7 @@
Signed-off-by: Tim Marx
---
www/manager6/Workspace.js | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 01b462c7..12ad70e4 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
There's no graphs on screen, so no reason to collapse the notes to save
space. Besides, it looked a bit funky expanding the notes on smaller
screens, since they always jumped to the bottom to fill the space...
Signed-off-by: Stefan Reiter
---
www/manager6/panel/NotesView.js | 2 +-
1 file
Signed-off-by: Fabian Grünbichler
---
makes starting VMs fail, see
https://forum.proxmox.com/threads/failed-to-start-vm-failed-to-remove-default-vlan-tags-of-tap104i0-command-sbin-bridge-bridge-vlan-del-dev-tap104i0-vid-1-4094-failed-exit-code.69375/
src/PVE/Network.pm | 4 ++--
1 file changed,
I forgot to mention in the notes, that this patch and the other manager
patch with the tests needs the following series applied beforehand!
https://pve.proxmox.com/pipermail/pve-devel/2020-May/043340.html
___
pve-devel mailing list
Move the logic which mountpoints are included in the backup job to its
own method and adapt the VZDump code accordingly. This makes it possible
to develop other features around backup jobs.
Signed-off-by: Aaron Lauterer
---
v4->v5:
* use new `foreach_volume`
* change $ret_volumes to
Signed-off-by: Aaron Lauterer
---
nothing changed to previous series'
src/PVE/LXC/Config.pm | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index dcc8755..34f657a 100644
--- a/src/PVE/LXC/Config.pm
+++
redirecting to the saved STDOUT in case of a template backup or a VM
without any disks failed because of the erroneous '=':
Backup of VM 123123 failed - command '/usr/bin/vma create -v -c [...]' failed:
Bad filehandle: =5 at /usr/share/perl/5.28/IPC/Open3.pm line 58.
The `guest include` logic handling `all` and `exclude` parameters was in
the `PVE::VZDump->exec_backup()` method. Moving this logic into the
`get_included_guests` method allows us to simplify and generalize it.
This helps to make the overall logic easier to test and develop other
features around
Now, with the logic for `all` and `exclude` in the same single method,
additional tests for these cases are possible.
Adapt to hash return value of `get_included_guests`.
Signed-off-by: Aaron Lauterer
---
test/vzdump_guest_included_test.pl | 123 ++---
1 file changed,
This patch series provides needed changes to make other features around
VZDUMP backups possible.
It is moving the following logic into its own separate methods:
* which guests are included in a vzdump job
adds missing `all` and `exclude` handling. Needs the following
patches [0] to be
Move the logic which volumes are included in the backup job to its own
method and adapt the VZDump code accordingly. This makes it possible to
develop other features around backup jobs.
Signed-off-by: Aaron Lauterer
---
v4->v5:
* use new foreach_volume call
* change $ret_volumes to
On 5/6/20 10:57 AM, Fabian Grünbichler wrote:
> this unifies the logic into a single place instead of all over this
> module and the plugins.
>
> it also fixes tons of 'uninitialized value' warnings when backing up
> with --dumpdir but no --storage set, since the existing conditions for
> PBS
instead of storage config to determine whether we are in 'PBS mode'
Signed-off-by: Fabian Grünbichler
---
Notes:
requires a break on pve-manager << version setting this option,
since the dependency is the other way round
src/PVE/VZDump/LXC.pm | 4 ++--
1 file changed, 2 insertions(+),
instead of storage config to determine whether we are in 'PBS mode'
Signed-off-by: Fabian Grünbichler
---
Notes:
requires a break on pve-manager << version setting this option,
since the dependency is the other way round.
PVE/VZDump/QemuServer.pm | 2 +-
1 file changed, 1
this unifies the logic into a single place instead of all over this
module and the plugins.
it also fixes tons of 'uninitialized value' warnings when backing up
with --dumpdir but no --storage set, since the existing conditions for
PBS targets are missing a definedness check.
Signed-off-by:
Previously, the blank '' would be passed along and lead to a
parameter verfication failure.
For LXC the default behavior in the backend is to use 'local', so
disallow blank and auto-select the first storage supporting'rootdir'
instead.
For QEMU the default behavior in the backend is to use the
On 5/5/20 1:40 PM, Thomas Lamprecht wrote:
On 5/5/20 1:20 PM, Fabian Ebner wrote:
Previously, the blank '' would be passed along and lead to a
parameter verfication failure.
For LXC the default behavior in the backend is to use 'local' as
the storage, so disallow blank and auto-select the
62 matches
Mail list logo
