[pve-devel] applied: [PATCH acme] dns challenge: provide schema for more providers

2020-05-07 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- src/PVE/ACME/DNSChallenge.pm | 111 --- 1 file changed, 104 insertions(+), 7 deletions(-) diff --git a/src/PVE/ACME/DNSChallenge.pm b/src/PVE/ACME/DNSChallenge.pm index 3bf8300..b720cd7 100644 --- a/src/PVE/ACME/DNSChallenge.pm

[pve-devel] applied: [PATCH docs] remove SLAAC reference from cloudinit docs

2020-05-07 Thread Thomas Lamprecht
On 5/4/20 3:41 PM, Mira Limbeck wrote: > As we don't currently support SLAAC in the nocloud network format code, remove > the reference from the docs. > > Signed-off-by: Mira Limbeck > --- > We have removed SLAAC from the GUI a while ago because cloud-init did > not support it back then but misse

[pve-devel] applied: [PATCH v3 docs] add section about backup compression algorithms

2020-05-07 Thread Thomas Lamprecht
On 5/7/20 4:40 PM, Alwin Antreich wrote: > as a short description about the different algorithms in use by vzdump. > > Signed-off-by: Alwin Antreich > --- > v1 -> v2: > * add Aaron's suggestions > > v2 -> v3: > * remove 'And' on sentence beginning, as Aaron's preference, ;) > other

[pve-devel] applied: [PATCH qemu-server] qmrestore: fix restore from STDIN

2020-05-07 Thread Thomas Lamprecht
On 5/7/20 9:15 AM, Fabian Grünbichler wrote: > the special case was dropped when moving this to pve-storage. > > Signed-off-by: Fabian Grünbichler > --- > PVE/QemuServer.pm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 8e3fadf..6461da3

[pve-devel] [PATCH v3 docs] add section about backup compression algorithms

2020-05-07 Thread Alwin Antreich
as a short description about the different algorithms in use by vzdump. Signed-off-by: Alwin Antreich --- v1 -> v2: * add Aaron's suggestions v2 -> v3: * remove 'And' on sentence beginning, as Aaron's preference, ;) otherwise the same as v2 vzdump.adoc | 35 ++

Re: [pve-devel] [PATCH v2 docs] add section about backup compression algorithms

2020-05-07 Thread Aaron Lauterer
With one optional nit inline: Reviewed-By: Aaron Lauterer On 5/7/20 4:16 PM, Alwin Antreich wrote: as a short description about the different algorithms in use by vzdump. Signed-off-by: Alwin Antreich --- v1 -> v2: * incorporate Aaron's suggestions https://pve.proxmox.com/piperma

[pve-devel] [PATCH v2 docs] add section about backup compression algorithms

2020-05-07 Thread Alwin Antreich
as a short description about the different algorithms in use by vzdump. Signed-off-by: Alwin Antreich --- v1 -> v2: * incorporate Aaron's suggestions https://pve.proxmox.com/pipermail/pve-devel/2020-May/043481.html vzdump.adoc | 35 ++- 1 file changed,

[pve-devel] applied-series: [PATCH manager 1/3] ui: ACMEAccountCreate: make name only optional if no default exists

2020-05-07 Thread Thomas Lamprecht
On 5/7/20 2:00 PM, Dominik Csapak wrote: > if the 'default' account exists, make the name field required and > remove the emptytext > > get the information by querying the grid store. this may be not > up-to-date, but it is less intrusive that an extra api call that > blocks the window > > Signed

Re: [pve-devel] [PATCH docs] add section about backup compression algorithms

2020-05-07 Thread Aaron Lauterer
Some nits inline. either in s/x/y/ syntax or just a rewrite of a sentence. On 5/7/20 2:42 PM, Alwin Antreich wrote: as a short description about the different algorithms in use by vzdump. Signed-off-by: Alwin Antreich --- vzdump.adoc | 36 +++- 1 file change

[pve-devel] applied: [PATCH manager] fix #2708: ui: increase default memory in VM create wizard to 2GiB

2020-05-07 Thread Thomas Lamprecht
as nowadays a lot of VMs won't even start the installer with 512 MB. Signed-off-by: Thomas Lamprecht --- www/manager6/qemu/MemoryEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/MemoryEdit.js b/www/manager6/qemu/MemoryEdit.js index d1284716..a8f87771 100644 --- a/www

[pve-devel] [PATCH docs] add section about backup compression algorithms

2020-05-07 Thread Alwin Antreich
as a short description about the different algorithms in use by vzdump. Signed-off-by: Alwin Antreich --- vzdump.adoc | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/vzdump.adoc b/vzdump.adoc index 404ad09..3fd9ca9 100644 --- a/vzdump.adoc

[pve-devel] [PATCH v2 widget-toolkit] adapt auth utils for proxmox token authentication

2020-05-07 Thread Tim Marx
Signed-off-by: Tim Marx --- Notes: changed since v1: * store user info as product independent object Utils.js | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/Utils.js b/Utils.js index 22eddd2..85b4a35 100644 --- a/Utils.js +++ b/Utils.js @@ -

[pve-devel] [PATCH v2 manager] ui: auth: add api token authentication to login window

2020-05-07 Thread Tim Marx
Signed-off-by: Tim Marx --- Notes: changed since v1: * store token including the product prefix * add token id to username to make it more obvious that it's note the actual user www/manager6/Workspace.js | 5 ++ www/manager6/window/LoginWindow.js | 129 ++

[pve-devel] [PATCH manager 1/3] ui: ACMEAccountCreate: make name only optional if no default exists

2020-05-07 Thread Dominik Csapak
if the 'default' account exists, make the name field required and remove the emptytext get the information by querying the grid store. this may be not up-to-date, but it is less intrusive that an extra api call that blocks the window Signed-off-by: Dominik Csapak --- www/manager6/dc/ACMECluster

[pve-devel] [PATCH manager 2/3] ui: dc/ACMEClusterView: load the correct store on reload

2020-05-07 Thread Dominik Csapak
if we use a diff/update store combo, we have to load the updatestore not the diff store, else we get spurious empty grids Signed-off-by: Dominik Csapak --- www/manager6/dc/ACMEClusterView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/ACMEClusterView.j

[pve-devel] [PATCH manager 3/3] ui: dc/ACMEClusterView: show TaskProgress on account removal

2020-05-07 Thread Dominik Csapak
this is not a synchronous api call, so open a taskprogress window and reload after the task is done Signed-off-by: Dominik Csapak --- www/manager6/dc/ACMEClusterView.js | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/ACMEClusterView.js b/www/m

[pve-devel] [PATCH v3 manager 1/5] api: backup: add endpoint to list included guests and volumes

2020-05-07 Thread Aaron Lauterer
This patch adds a new API endpoint that returns a list of included guests, their volumes and whether they are included in a backup. The output is formatted to be used with the extJS tree panel. Signed-off-by: Aaron Lauterer --- The return types are `qemu`, `lxc` and `unknown`. The latter is the

[pve-devel] [PATCH manager v2 5/5] fix #2609 gui: backup: add summary window

2020-05-07 Thread Aaron Lauterer
Adds a new `Summary` button to the backup panel which opens a new window containing a searchable view of all guests and whether they are backed up by any job or not. Signed-off-by: Aaron Lauterer --- I took the code for the search field from the ResourceGrid, simplified it and adapted it more to

[pve-devel] [PATCH v3 manager 3/5] gui: dc/backup: add new backup job detail view

2020-05-07 Thread Aaron Lauterer
The new detail view for backup jobs shows the settings similar to the edit dialog but read only. Additionally it does show a list of all included guests with their volumes and whether these volumes will be included in the backup. Signed-off-by: Aaron Lauterer --- v2->v3: * made the comment why w

[pve-devel] [PATCH v3 manager 0/5] add backup detail and summary view

2020-05-07 Thread Aaron Lauterer
This series adds a new detail view for backup jobs to show which volumes of a guest would be included. Additionally it adds a second view to the backup panel which shows a list of all guests and if they are included in any backup. This makes it easy to find guests which are not yet backed up at al

[pve-devel] [PATCH v3 manager 2/5] gui: dc/backup: move renderers to Utils.js

2020-05-07 Thread Aaron Lauterer
Moving the following renderers to Utils.js to be able to use them in more than one place: * render_backup_days_of_week * render_backup_selection Signed-off-by: Aaron Lauterer --- v1 -> v2 ->v3: rebased www/manager6/Utils.js | 61 +++ www/manager6/dc/Back

[pve-devel] [PATCH v2 manager 4/5] fix #2609 api: backupsummary: add non job specific endpoint

2020-05-07 Thread Aaron Lauterer
Adds a new api endpoint at cluster/backupsummary for cluster wide backup stuff. This is necessary because cluster/backup expects a backup job ID at the next level and thus other endpoints are hard to impossible to implement under that hierarchy. The only api endpoint available for now is the `incl

[pve-devel] applied: [PATCH manager] ACME: fix fallback to implicit standalone plugin

2020-05-07 Thread Thomas Lamprecht
On 5/7/20 10:01 AM, Fabian Grünbichler wrote: > we need to parse the config even if it does not exist - it will return > the 'standalone' entry that's needed to be backwards compatible with > existing setups. > > Signed-off-by: Fabian Grünbichler > --- > Note: there is an issue when attempting to

[pve-devel] applied-series: [PATCH widget-toolkit/manager] fixups for ACME UI

2020-05-07 Thread Thomas Lamprecht
On 5/7/20 10:27 AM, Dominik Csapak wrote: > this series fixes some problems and improves the ACME UI, namely: > * auto update dc->Acme grids > * add emptyText > * adds missing stopUpdates > * improve order button enable logic > * reuse existing store for account verification > * add auto-create/des

Re: [pve-devel] [PATCH manager 3/7] ui: dc/ACMEClusterView: use a diff/update store combo for the grids

2020-05-07 Thread Dominik Csapak
On 5/7/20 1:08 PM, Thomas Lamprecht wrote: On 5/7/20 10:27 AM, Dominik Csapak wrote: so that they are get automatically reloaded with the default interval (3seconds) Signed-off-by: Dominik Csapak --- this patch needs the widget-toolkit patches applied we can of course leave those out, and t

Re: [pve-devel] [PATCH manager 3/7] ui: dc/ACMEClusterView: use a diff/update store combo for the grids

2020-05-07 Thread Thomas Lamprecht
On 5/7/20 10:27 AM, Dominik Csapak wrote: > so that they are get automatically reloaded with the default interval > (3seconds) > > Signed-off-by: Dominik Csapak > --- > this patch needs the widget-toolkit patches applied > we can of course leave those out, and to it manually in initComponent, >

Re: [pve-devel] [PATCH widget-toolkit] adapt auth utils for pve token authentication

2020-05-07 Thread Thomas Lamprecht
On 5/6/20 2:00 PM, Tim Marx wrote: > Signed-off-by: Tim Marx > --- > Utils.js | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/Utils.js b/Utils.js > index 22eddd2..b190ce4 100644 > --- a/Utils.js > +++ b/Utils.js > @@ -31,6 +31,10 @@ Ext.Ajax.on('befo

[pve-devel] [PATCH manager 2/7] ui: ACME: add emptyText and add minHeight

2020-05-07 Thread Dominik Csapak
without the minHeight, the panel does resize weirdly on the first load Signed-off-by: Dominik Csapak --- www/manager6/dc/ACMEClusterView.js | 6 ++ www/manager6/node/ACME.js | 2 ++ 2 files changed, 8 insertions(+) diff --git a/www/manager6/dc/ACMEClusterView.js b/www/manager6/dc/

[pve-devel] [PATCH manager 1/7] NodeConfig/get_acme_conf: make domains always a hash

2020-05-07 Thread Dominik Csapak
on all call sites, we assume $cfg->{domains} is a hash, but if we do not have any domains configured, that fails with 'Can't use an undefined value as a HASH reference at ...' so always make domains a hash to avoid this Signed-off-by: Dominik Csapak --- PVE/NodeConfig.pm | 1 + 1 file changed,

[pve-devel] [PATCH manager 4/7] ui: node/ACME: fix some eslint errors/warnings

2020-05-07 Thread Dominik Csapak
* unneeded brackets for arrow function * unused variables * me not defined * trailing commas Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js

[pve-devel] [PATCH widget-toolkit 1/2] data/DiffStore: add autoDestroyRstore flag

2020-05-07 Thread Dominik Csapak
when this flag is set, the diffstore will automatically try to destroy the rstore when it is destroyed itself for this we have to move the rstore into the object (instead of using a closure) Signed-off-by: Dominik Csapak --- data/DiffStore.js | 26 +- 1 file changed, 21

[pve-devel] [PATCH manager 6/7] ui: node/ACME: only enable order button when it should work

2020-05-07 Thread Dominik Csapak
to order a ceritificate, we need at least one configured domain, and the configured account (or default) must exist so track the domaincount in the viewmodel and introduce a 'canOrder' formula which is only true when domaincount > 0 and account is set (if the configured account does not exist, or

[pve-devel] [PATCH widget-toolkit 2/2] data/DiffStore: auto-create the rstore if its just a config

2020-05-07 Thread Dominik Csapak
when rstore is not instanciated but only a config, auto-create it with its type this allows us to configure an diff/rstore combination completely declaratively like this: store: { type: 'diff', autoDestroy: true, autoDestroyRstore: true, rstore: { type: 'update', m

[pve-devel] [PATCH widget-toolkit/manager] fixups for ACME UI

2020-05-07 Thread Dominik Csapak
this series fixes some problems and improves the ACME UI, namely: * auto update dc->Acme grids * add emptyText * adds missing stopUpdates * improve order button enable logic * reuse existing store for account verification * add auto-create/destroy feature to the diffstore path 3/7 from manager nee

[pve-devel] [PATCH manager 5/7] ui: node/ACME: use accountselector for verification

2020-05-07 Thread Dominik Csapak
instead of using API2Request manually, just reload the store of the accountselector and check if the configured account is in it this should fix the spurious loading mask of the panel when loading the accounts Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 23

[pve-devel] [PATCH manager 7/7] ui: node/{ACME, Certificates}: add stopUpdate on destruction

2020-05-07 Thread Dominik Csapak
else the stores never stop updating Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 1 + www/manager6/node/Certificates.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index d21d18e4..0418f406 100644 --- a/www/m

[pve-devel] [PATCH manager 3/7] ui: dc/ACMEClusterView: use a diff/update store combo for the grids

2020-05-07 Thread Dominik Csapak
so that they are get automatically reloaded with the default interval (3seconds) Signed-off-by: Dominik Csapak --- this patch needs the widget-toolkit patches applied we can of course leave those out, and to it manually in initComponent, but this is a pattern we often use and maybe we can remove

[pve-devel] [PATCH manager] ACME: fix fallback to implicit standalone plugin

2020-05-07 Thread Fabian Grünbichler
we need to parse the config even if it does not exist - it will return the 'standalone' entry that's needed to be backwards compatible with existing setups. Signed-off-by: Fabian Grünbichler --- Note: there is an issue when attempting to WRITE the config if /etc/pve/priv/acme does not exist, but

[pve-devel] [PATCH qemu-server] qmrestore: fix restore from STDIN

2020-05-07 Thread Fabian Grünbichler
the special case was dropped when moving this to pve-storage. Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8e3fadf..6461da3 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -565