[pve-devel] applied-series: Re: [PATCH V2 pve-network 0/6] always use a vnet bridge model

2020-05-19 Thread Thomas Lamprecht
On 5/19/20 6:37 PM, Alexandre Derumier wrote: > Hi, > > this is a rework of vlan && qinq plugin to always use a vnet=20 > bridge for all plugin. > > Avoid to tag vmport directly on vlan-aware bridge or ovs. > Instead, plug the vm interface on a vnet bridge, and plug the > vnet bridge on the

[pve-devel] applied-series: Re: [PATCH pve-manager 0/3] sdn: updates

2020-05-19 Thread Thomas Lamprecht
On 5/19/20 6:39 PM, Alexandre Derumier wrote: > Following last pve-network series > > Alexandre Derumier (3): > vnetview: remove mtu field > sdn: restrict zone && vnet name to 8 characters > qinq: add vlan-protocol option > > www/manager6/sdn/Browser.js | 4 ++-- >

[pve-devel] applied: Re: [PATCH widget-toolkit 1/1] add pmxRoleSelector

2020-05-19 Thread Thomas Lamprecht
On 5/19/20 4:48 PM, Dominik Csapak wrote: > copied+refactored from pve-manager > for use with other projects > > also show privs now in the combobox > > Signed-off-by: Dominik Csapak > --- > Makefile | 1 + > form/RoleSelector.js | 41 + > 2

[pve-devel] [PATCH pve-manager 0/3] sdn: updates

2020-05-19 Thread Alexandre Derumier
Following last pve-network series Alexandre Derumier (3): vnetview: remove mtu field sdn: restrict zone && vnet name to 8 characters qinq: add vlan-protocol option www/manager6/sdn/Browser.js | 4 ++-- www/manager6/sdn/VnetEdit.js | 2 +-

[pve-devel] [PATCH pve-manager 1/3] vnetview: remove mtu field

2020-05-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/Browser.js | 4 ++-- www/manager6/sdn/VnetView.js | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/Browser.js b/www/manager6/sdn/Browser.js index 339fedb1..20944bd5 100644 ---

[pve-devel] [PATCH pve-manager 3/3] qinq: add vlan-protocol option

2020-05-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/zones/QinQEdit.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/sdn/zones/QinQEdit.js b/www/manager6/sdn/zones/QinQEdit.js index 9d0fdb67..beb2573e 100644 --- a/www/manager6/sdn/zones/QinQEdit.js +++

[pve-devel] [PATCH pve-manager 2/3] sdn: restrict zone && vnet name to 8 characters

2020-05-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/VnetEdit.js | 2 +- www/manager6/sdn/controllers/EvpnEdit.js | 2 +- www/manager6/sdn/zones/EvpnEdit.js | 2 +- www/manager6/sdn/zones/QinQEdit.js | 2 +- www/manager6/sdn/zones/VxlanEdit.js | 2 +- 5 files

[pve-devel] [PATCH V2 pve-network 5/6] evpn: prefix interfaces

2020-05-19 Thread Alexandre Derumier
vnets can have random name, prefix other interfaces to avoid conflicts Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +- PVE/Network/SDN/Zones/EvpnPlugin.pm | 24 +++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git

[pve-devel] [PATCH V2 pve-network 4/6] qinq: use new model + ovs/classic bridge support

2020-05-19 Thread Alexandre Derumier
Always create a vnet bridge for each vnet, and avoid to tag vm port directly. As we don't manage tap|veth vlan tag in /etc/network/interfaces, this could break on reload if user change vlan value on a vnet. ovs --- eth0--->ovsintport(dot1q-tunnel

[pve-devel] [PATCH V2 pve-network 2/6] retrict vnet name to 8 characters

2020-05-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/VnetPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN/VnetPlugin.pm b/PVE/Network/SDN/VnetPlugin.pm index b0280fc..179bfa4 100644 --- a/PVE/Network/SDN/VnetPlugin.pm +++

[pve-devel] [PATCH V2 pve-network 3/6] vlan: use new model

2020-05-19 Thread Alexandre Derumier
Always create a vnet bridge for each vnet, and avoid to tag vm port directly. As we don't manage tap|veth vlan tag in /etc/network/interfaces, this could break on reload if user change vlan value on a vnet. ovs --- eth0ovs vmbr0--(ovsintport tag)>vnet>vm vlanawarebridge

[pve-devel] [PATCH V2 pve-network 1/6] restrict zone name to 8 characters

2020-05-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN/Zones/Plugin.pm b/PVE/Network/SDN/Zones/Plugin.pm index 2335d9e..9ea7a50 100644 --- a/PVE/Network/SDN/Zones/Plugin.pm +++

[pve-devel] [PATCH V2 pve-network 0/6] always use a vnet bridge model

2020-05-19 Thread Alexandre Derumier
Hi, this is a rework of vlan && qinq plugin to always use a vnet=20 bridge for all plugin. Avoid to tag vmport directly on vlan-aware bridge or ovs. Instead, plug the vm interface on a vnet bridge, and plug the vnet bridge on the ovs|bridge-vlan-aware|... and do the tag here. This will help a

[pve-devel] [PATCH V2 pve-network 6/6] vxlan: prefix interfaces

2020-05-19 Thread Alexandre Derumier
vnets can have random name, prefix other interfaces to avoid conflicts Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/VxlanPlugin.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/Network/SDN/Zones/VxlanPlugin.pm

Re: [pve-devel] applied: [PATCH V2 ifupdown2 1/1] openvswitch: don't remove tap|veth interfaces when adding an internal ovs port

2020-05-19 Thread Alexandre DERUMIER
>>I saw that ifupdown2 3.0.0 got tagged recently, seems to be partly for python3 >>compat, AFAICS. yes, it's full rewrite in python3. >>Or do you know of bigger featuers/fixes om that version? They are newer features, like 1vxlan tunnel mapping with multiple vlans. (I don't use it currently).

Re: [pve-devel] [PATCH pve-network 1/7] don't sort interfaces in /etc/network/interfaces.d/sdn

2020-05-19 Thread Alexandre DERUMIER
I have retest all plugins with last code, I don't have this problem anymore, I think I have some bad config during my rework and ifupdown2 couldn't handle it correclty. I'll remove this patch. - Mail original - De: "aderumier" À: "Thomas Lamprecht" Cc: "pve-devel" Envoyé: Mardi 19

Re: [pve-devel] [PATCH pve-network 3/7] retrict vnet name to 8 characters

2020-05-19 Thread Alexandre DERUMIER
damn, sorry - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Envoyé: Mardi 19 Mai 2020 16:43:59 Objet: Re: [pve-devel] [PATCH pve-network 3/7] retrict vnet name to 8 characters On 5/19/20 3:48 PM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier >

Re: [pve-devel] [PATCH pve-network 1/7] don't sort interfaces in /etc/network/interfaces.d/sdn

2020-05-19 Thread Alexandre DERUMIER
>>makes no sense, this is a hash and perl actively re-orders the return >>set of keys pseudo-randomly .. >> >>If order is really required use an array. Damn, you are right. I think I'm going to make some ordering by kind of interfaces, like for /etc/network/interfaces - Mail original -

[pve-devel] [PATCH widget-toolkit 1/1] add pmxRoleSelector

2020-05-19 Thread Dominik Csapak
copied+refactored from pve-manager for use with other projects also show privs now in the combobox Signed-off-by: Dominik Csapak --- Makefile | 1 + form/RoleSelector.js | 41 + 2 files changed, 42 insertions(+) create mode 100644

[pve-devel] [PATCH manager 2/2] use RealmCombobox from widget-toolkit

2020-05-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/dc/UserEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js index 692eb277..584fe19f 100644 --- a/www/manager6/dc/UserEdit.js +++ b/www/manager6/dc/UserEdit.js @@

[pve-devel] [PATCH manager 1/2] ui: use RoleSelector from widget-toolkit

2020-05-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 - www/manager6/dc/ACLView.js| 2 +- www/manager6/form/RoleSelector.js | 50 --- 3 files changed, 1 insertion(+), 52 deletions(-) delete mode 100644 www/manager6/form/RoleSelector.js

[pve-devel] [PATCH widget-toolkit/manager] move RoleSelector to widget-toolkit

2020-05-19 Thread Dominik Csapak
for use in other projects also fixes a missing rename of the RealmCombobox in dc/UserEdit (manager 2/2) proxmox-widget-toolkit: Dominik Csapak (1): add pmxRoleSelector Makefile | 1 + form/RoleSelector.js | 41 + 2 files changed, 42

Re: [pve-devel] [PATCH pve-network 3/7] retrict vnet name to 8 characters

2020-05-19 Thread Thomas Lamprecht
On 5/19/20 3:48 PM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/VnetPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/Network/SDN/VnetPlugin.pm b/PVE/Network/SDN/VnetPlugin.pm > index b0280fc..169f694 100644 > ---

Re: [pve-devel] [PATCH pve-network 1/7] don't sort interfaces in /etc/network/interfaces.d/sdn

2020-05-19 Thread Thomas Lamprecht
On 5/19/20 3:48 PM, Alexandre Derumier wrote: > Sometime, ifupdown2 can't handle depend correctly, and interface order is used > makes no sense, this is a hash and perl actively re-orders the return set of keys pseudo-randomly .. If order is really required use an array. > Signed-off-by:

[pve-devel] [PATCH pve-docs] sdn: update qinq plugin doc

2020-05-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- pvesdn.adoc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 4277bb2..f890003 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -164,10 +164,12 @@ NOTE: Your physical network switches must support stacked

[pve-devel] [PATCH pve-network 0/7] always use a vnet bridge model

2020-05-19 Thread Alexandre Derumier
Hi, this is a rework of vlan && qinq plugin to always use a vnet bridge for all plugin. Avoid to tag vmport directly on vlan-aware bridge or ovs. Instead, plug the vm interface on a vnet bridge, and plug the vnet bridge on the ovs|bridge-vlan-aware|... and do the tag here. This will help a lot

[pve-devel] [PATCH pve-network 6/7] evpn: prefix interfaces

2020-05-19 Thread Alexandre Derumier
vnets can have random name, prefix other interfaces to avoid conflicts Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +- PVE/Network/SDN/Zones/EvpnPlugin.pm | 24 +++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git

[pve-devel] [PATCH pve-network 1/7] don't sort interfaces in /etc/network/interfaces.d/sdn

2020-05-19 Thread Alexandre Derumier
Sometime, ifupdown2 can't handle depend correctly, and interface order is used Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN/Zones.pm b/PVE/Network/SDN/Zones.pm index 436b103..435e40b 100644 ---

[pve-devel] [PATCH pve-network 2/7] restrict zone name to 8 characters

2020-05-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN/Zones/Plugin.pm b/PVE/Network/SDN/Zones/Plugin.pm index 2335d9e..9ea7a50 100644 --- a/PVE/Network/SDN/Zones/Plugin.pm +++

[pve-devel] [PATCH pve-network 5/7] qinq: use new model + ovs/classic bridge support

2020-05-19 Thread Alexandre Derumier
Always create a vnet bridge for each vnet, and avoid to tag vm port directly. As we don't manage tap|veth vlan tag in /etc/network/interfaces, this could break on reload if user change vlan value on a vnet. ovs --- eth0--->ovsintport(dot1q-tunnel

[pve-devel] [PATCH pve-network 7/7] vxlan: prefix interfaces

2020-05-19 Thread Alexandre Derumier
vnets can have random name, prefix other interfaces to avoid conflicts Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/VxlanPlugin.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/Network/SDN/Zones/VxlanPlugin.pm

[pve-devel] [PATCH pve-network 4/7] vlan: use new model

2020-05-19 Thread Alexandre Derumier
Always create a vnet bridge for each vnet, and avoid to tag vm port directly. As we don't manage tap|veth vlan tag in /etc/network/interfaces, this could break on reload if user change vlan value on a vnet. ovs --- eth0ovs vmbr0--(ovsintport tag)>vnet>vm vlanawarebridge

[pve-devel] [PATCH pve-network 3/7] retrict vnet name to 8 characters

2020-05-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/VnetPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN/VnetPlugin.pm b/PVE/Network/SDN/VnetPlugin.pm index b0280fc..169f694 100644 --- a/PVE/Network/SDN/VnetPlugin.pm +++

[pve-devel] [PATCH manager] ui: migration: add maxHeight to migration window

2020-05-19 Thread Tim Marx
to prevent indefinite growth in case of e.g. many local disks Signed-off-by: Tim Marx --- www/manager6/window/Migrate.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js index 61bc6a49..e022bee7 100644 ---

[pve-devel] [PATCH storage v2 1/3] Recursive search for iso and vztmpl

2020-05-19 Thread Dominic Jäger
Each content type has a predefined location in a storage where they can be found. iso and vztmpl files can now be found and and also uploaded in subdirectories of those locations, too. Add a parameter "recursive" (default off) to the API at storage/{storage}/content, to perform this search.

[pve-devel] [PATCH manager v2 3/3] gui: settings: Add recursive search default

2020-05-19 Thread Dominic Jäger
Add a radiobox to the settings to control if search should be done recursively as default or not. Set to no recursion as default. Signed-off-by: Dominic Jäger --- v2: Like patch 2/3 www/manager6/storage/ContentView.js | 6 +++-- www/manager6/window/Settings.js | 38

[pve-devel] [PATCH manager v2 2/3] gui: content view: Add checkbox for recursive search

2020-05-19 Thread Dominic Jäger
Default is no recursion. This commit depends on "Recursive search for iso and vztmpl" in pve-storage. Signed-off-by: Dominic Jäger --- v2: Dominik's Feedback - Use helper function for url => No more strange casts - Template string - Better separation of patches

[pve-devel] [PATCH pve-manager] api, ui: allow to remove subscription

2020-05-19 Thread Moayad Almalat
Signed-off-by: Moayad Almalat --- PVE/API2/Subscription.pm | 21 + PVE/CLI/pvesubscription.pm| 1 + www/manager6/node/Subscription.js | 9 + 3 files changed, 31 insertions(+) diff --git a/PVE/API2/Subscription.pm b/PVE/API2/Subscription.pm index

[pve-devel] [PATCH v2 manager] Fix 2718: GUI: handle localtime option correctly

2020-05-19 Thread Fabian Ebner
The backend treats an undefined value and 0 differently. If the option is undefined, it will still be set for Windows in config_to_command. Replace the checkbox with a combobox covering all options. Signed-off-by: Fabian Ebner --- Changes from v1: * use a combobox with all options to allow

[pve-devel] [PATCH kernel-meta 2/2] pve-efiboot-tool: format: show real path in warning if needed

2020-05-19 Thread Aaron Lauterer
Show the real path of the partition in case when the basename couldn't be determined and the partition given is a symlinked one like /dev/disk/by-id// Signed-off-by: Aaron Lauterer --- I hope this is not a too hacky solution :) bin/pve-efiboot-tool | 5 - 1 file changed, 4 insertions(+),

[pve-devel] [PATCH kernel-meta 1/2] pve-efiboot-tool: format: fix handling of disk/by-id

2020-05-19 Thread Aaron Lauterer
The format command will fail when using other paths like /dev/disk/by-id/ instead of /dev/sdXY directly. It cannot find the path /sys/block///partition path. The part name in /dev/disk/by-id is a symlink to /dev/sdXY. At that point we already have the symlink resolved to the real path. It is

[pve-devel] applied: [PATCH V2 ifupdown2 1/1] openvswitch: don't remove tap|veth interfaces when adding an internal ovs port

2020-05-19 Thread Thomas Lamprecht
On 5/16/20 2:07 PM, Alexandre Derumier wrote: > Currently, tap|veth interfaces are removed if user add a new ovs internal > port and reload. > > add ovs-ports-condone-regex option, like for bridge (to have the patch > upstream). > default options to "tap|veth|fwpr" > > to avoid to remove