> >>Do you want to allocate IPs on VM creation time, or VM start time?
>
> I think at vm creation time, or nic hotplug/unplug.
> the ipam api is called, return free ip address, and we write somewhere in vm
> config the ip address.
> (for nic hotplug/unplug, we need to handle ipam removal on confi
>>Do you want to allocate IPs on VM creation time, or VM start time?
I think at vm creation time, or nic hotplug/unplug.
the ipam api is called, return free ip address, and we write somewhere in vm
config the ip address.
(for nic hotplug/unplug, we need to handle ipam removal on config revert)
L
> >>You you also do not store the cidr there, and instead
> >>store the some pool ID retured by IPAM?
>
> cidr should be the key/id of the subnet. Almost all ipam use the cidr as key.
Ok, that makes sense now.
Do you want to allocate IPs on VM creation time, or VM start time?
__
LGTM, what do you think about the following follow-up:
--8<-
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index b2ba9f7..d28143d 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -1878,9 +1878,12 @@ sub generate_typetext {
sub print_property_string {
my
On May 25, 2020 9:41 am, Fabian Ebner wrote:
> This reverts commit 95015dbbf24b710011965805e689c03923fb830c.
>
> parse_volname always gives 'images' and not 'rootdir'. In most
> cases the volume name alone does not contain the needed information,
> e.g. vm-123-disk-0 can be both a VM volume or a c
On June 22, 2020 3:55 pm, Oguz Bektas wrote:
> initializing 'mounts' array in the panel scope causes edits on subsequent
> containers to get the values (mount=nfs) from the previous container. fix
> this by
> initializing the 'mounts' array in 'onGetValues' and 'setValues'
> separately.
>
> Signe
On Mon, Jun 22, 2020 at 02:54:02PM +0200, Stefan Reiter wrote:
> Zero out clusters after the end of the device, this makes restore handle
> it correctly (even if it may try to write those zeros, it won't fail and
> just ignore the out-of-bounds write to disk).
>
> For not even 4k-aligned disks, th
>>You you also do not store the cidr there, and instead
>>store the some pool ID retured by IPAM?
cidr should be the key/id of the subnet. Almost all ipam use the cidr as key.
Alexandre Derumier
Ingénieur système et stockage
Manager Infrastructure
Fixe : +33 3 59 82 20 10
> No,no, I don't want to store ips in subnets.cfg, it's done in ipam. (or it
> could be done in a localipam database if no ipam exist).
You you also do not store the cidr there, and instead
store the some pool ID retured by IPAM?
___
pve-devel mail
>>No. I mean you store all subnets and IPs in subnets.cfg, so why do we
>>need/want IPAM plugins?
oh ok sorry.
No,no, I don't want to store ips in subnets.cfg, it's done in ipam. (or it
could be done in a localipam database if no ipam exist).
the "allocation-pools" option, was for: in this su
Looks mosty ok, but i noticed two things:
1. We use this grid also on datacenter and node level, so we should
adapt the message for those somehow
2. is inline
On 6/23/20 11:31 AM, Dominic Jäger wrote:
Currently people add firewall rules but forget to activate the firewall on
guest level. Thi
LGTM, except for one minor nit. could you please send a CLA as described
in our Developer Documentation to off...@proxmox.com ?
https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
Thanks in advance!
On June 22, 2020 12:10 pm, Fabian Möller wrote:
> ---
> PVE/Nod
> >>But you already mange subnets and allocation pools in subnets.cfg, so what
> >>it the purpose
> >>of those ipam plugins? I am unable to see the point? Keeping those
> >>reservations in sync
> >>looks hard to me.
>
> do you mean sync between dhcp && ipam ?
No. I mean you store all subnets
Currently people add firewall rules but forget to activate the firewall on
guest level. This commit adds a warning to the top bar of the firewall panel to
make them aware of this if necessary.
It seems a little cheaper but still sufficient to check only if some rule
exists and not for every rule i
Hi Bruce,
Once you've submitted the CLA, a member of the release team will take care of
this patch.
You will be notified when it is committed or when something is missing.
Regards
Wolfgang
> On 06/22/2020 2:38 PM Bruce Wainer wrote:
>
>
> Wolfgang,
> Thanks for the confirmation. What is th
>>But you already mange subnets and allocation pools in subnets.cfg, so what it
>>the purpose
>>of those ipam plugins? I am unable to see the point? Keeping those
>>reservations in sync
>>looks hard to me.
do you mean sync between dhcp && ipam ?
I'm more thinking about static dhcp reservation
16 matches
Mail list logo
