On 6/22/20 2:54 PM, Stefan Reiter wrote:
> Suggested-by: Lars Ellenberg
> Signed-off-by: Stefan Reiter
> ---
> vma-writer.c | 2 ++
> vma.c| 2 ++
> 2 files changed, 4 insertions(+)
>
>
applied series, thanks!
___
pve-devel mailing list
Am 6/24/20 um 11:32 AM schrieb Dominic Jäger:
> Fixup for #2815: The existence of a rule alone should NOT yet trigger the
> warning. Only if it is enabled but the whole firewall for that level is not.
>
> Signed-off-by: Dominic Jäger
> ---
> Didn't exist in v1. Not sure if we want this. If yes
On 6/24/20 11:51 AM, Fabian Grünbichler wrote:
On June 3, 2020 3:58 pm, Mira Limbeck wrote:
This allows setting ciuser, cipassword and all other cloudinit settings that
are not part of the network without VM.Config.Network permissions.
Signed-off-by: Mira Limbeck
---
PVE/API2/Qemu.pm | 5
On June 3, 2020 3:58 pm, Mira Limbeck wrote:
> This allows setting ciuser, cipassword and all other cloudinit settings that
> are not part of the network without VM.Config.Network permissions.
>
> Signed-off-by: Mira Limbeck
> ---
> PVE/API2/Qemu.pm | 5 -
> 1 file changed, 4 insertions(+),
On June 24, 2020 10:54 am, Stefan Reiter wrote:
> On 6/23/20 3:39 PM, Fabian Grünbichler wrote:
>> LGTM, what do you think about the following follow-up:
>>
>> --8<-
>>
>> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
>> index b2ba9f7..d28143d 100644
>> ---
Currently people add firewall rules but forget to activate the firewall on
guest level. This commit adds a warning to the top bar of the firewall panel to
make them aware of this if necessary.
It avoids one O(n) lookup and might be sufficient to check only if some rule
exists and not for every
Fixup for #2815: The existence of a rule alone should NOT yet trigger the
warning. Only if it is enabled but the whole firewall for that level is not.
Signed-off-by: Dominic Jäger
---
Didn't exist in v1. Not sure if we want this. If yes you can just apply both or
squash. Of course, I can also
Am 6/16/20 um 8:53 PM schrieb Bruce Wainer:
> Signed-off-by: Bruce Wainer
> ---
> pve-zsync | 42 +-
> 1 file changed, 25 insertions(+), 17 deletions(-)
>
With Wolfgangs T-b/R-b tags: applied, thanks to both!
Am 6/22/20 um 4:34 PM schrieb Aaron Lauterer:
> The first part of this series which touched pve-manager has been applied
> with v6 [0][1].
>
> Missing are the qemu-server and pve-container patches. With the last
> suggestions [2] incorporated it is also necessary to update the
> AbstractConfig.pm
>>why not use PVE::Tools::split_list ? it's our standard helper for these
>>kind of things, and also correctly trims whitespace and has support for
>>\0-separated lists ;
I have take it from ceph code ;)
/usr/share/perl5/PVE/CephConfig.pm:my $monhosts = [ split (/[ ,;]+/,
On 6/23/20 3:39 PM, Fabian Grünbichler wrote:
LGTM, what do you think about the following follow-up:
--8<-
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index b2ba9f7..d28143d 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -1878,9 +1878,12 @@ sub
Am 6/19/20 um 4:25 PM schrieb Stoiko Ivanov:
> Tested locally in a VM:
> The setsid was necessary to give the bash job-control (otherwise Ctrl+C would
> simply kill the shell).
>
> Signed-off-by: Stoiko Ivanov
> ---
> unconfigured.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
had quite a
On June 5, 2020 1:33 pm, Mark Schouten wrote:
>
> Hi!
>
> I'm building Linux Images in Gitlab to distribute over customer clusters
> easily. We have an (daDup.eu) s3 bucket where we place the vma-files and
> mount that bucket via s3fs (works pretty well!). But, to create the VMA, I
> need to
why not use PVE::Tools::split_list ? it's our standard helper for these
kind of things, and also correctly trims whitespace and has support for
\0-separated lists ;)
On June 12, 2020 6:14 pm, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier
> ---
>
a bit of a rationale would be nice ;) isn't this just a simple map
transformation that can be done client-side?
my $hash = { map { my $key = delete $_->{key}; return ($key => $_); } @$array };
or in whatever language you need. filtering/sorting/limiting server-side
makes sense for some calls
On June 24, 2020 9:32 am, Dominik Csapak wrote:
> so that each new instance has an empty mounts list
>
> Signed-off-by: Dominik Csapak
> ---
> @fabian @oguz, i remembered that i know this issue and had a fix already^^
> www/manager6/lxc/FeaturesEdit.js | 8 +++-
> 1 file changed, 7
Am 6/22/20 um 10:17 AM schrieb Stefan Reiter:
>>> @@ -89,7 +97,8 @@ sub get_pci_addr_map {
>>> $pci_addr_map = {
>>> piix3 => { bus => 0, addr => 1, conflict_ok => qw(ehci) },
>>> ehci => { bus => 0, addr => 1, conflict_ok => qw(piix3) }, # instead
>>> of piix3 on arm
>>> -
so that each new instance has an empty mounts list
Signed-off-by: Dominik Csapak
---
@fabian @oguz, i remembered that i know this issue and had a fix already^^
www/manager6/lxc/FeaturesEdit.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
> >>Do you want to allocate IPs on VM creation time, or VM start time?
>
> I think at vm creation time, or nic hotplug/unplug.
> the ipam api is called, return free ip address, and we write somewhere in vm
> config the ip address.
> (for nic hotplug/unplug, we need to handle ipam removal on
>>Do you want to allocate IPs on VM creation time, or VM start time?
I think at vm creation time, or nic hotplug/unplug.
the ipam api is called, return free ip address, and we write somewhere in vm
config the ip address.
(for nic hotplug/unplug, we need to handle ipam removal on config revert)
20 matches
Mail list logo
