Re: [pve-devel] [PATCH qemu-server] fix #1013 : migrate : sync_disk : --targetstorage with offline disk

2018-12-10 Thread Alexandre DERUMIER
5 Objet: Re: [pve-devel] [PATCH qemu-server] fix #1013 : migrate : sync_disk : --targetstorage with offline disk On 12/7/18 12:03 PM, Alexandre Derumier wrote: > targetsid was not used, for disk unused (offline copy) > --- > PVE/QemuMigrate.pm | 3 ++- > 1 file changed, 2 ins

Re: [pve-devel] [PATCH v3 qemu-server 1/7] api2 : add migrate_vm_external

2018-12-10 Thread Alexandre DERUMIER
pected. Still need some time to go through your patches in detail, but one thing inline: On 11/27/18 4:38 PM, Alexandre Derumier wrote: > qm migrate_external [--targetstorage otherstorage] > [--targetbridge otherbridge] > --- > PVE/API2/Qemu.pm | 79 > ++

[pve-devel] [PATCH qemu-server] fix #1013 : migrate : sync_disk : --targetstorage with offline disk

2018-12-07 Thread Alexandre Derumier
targetsid was not used, for disk unused (offline copy) --- PVE/QemuMigrate.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index e9e9075..f422f2e 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -446,6 +446,7 @@ sub

[pve-devel] [PATCH qemu-server] clone_disk : cloudinit drive: don't clone snapname

2018-12-06 Thread Alexandre Derumier
we don't snapshot cloudinit drive, this fix "qm clone --snapname mysnap" when a cloudinit drive exist --- PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a162db9..1e9dec6 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm

Re: [pve-devel] pve-firewall : nftables ?

2018-11-28 Thread Alexandre DERUMIER
rumier" Cc: "pve-devel" Envoyé: Mercredi 28 Novembre 2018 10:54:28 Objet: Re: [pve-devel] pve-firewall : nftables ? On Wed, Nov 28, 2018 at 09:21:53AM +0100, Alexandre DERUMIER wrote: > >>sysctl net.bridge.bridge-nf-call-iptables=1 > >>(don't have t

Re: [pve-devel] pve-firewall : nftables ?

2018-11-28 Thread Alexandre DERUMIER
n bridge filtering :( seem to be a blocking point for now - Mail original - De: "Alexandre Derumier" À: "Wolfgang Bumiller" Cc: "pve-devel" Envoyé: Mardi 27 Novembre 2018 15:19:41 Objet: Re: [pve-devel] pve-firewall : nftables ? > >>The

Re: [pve-devel] pve-firewall : nftables ?

2018-11-27 Thread Alexandre DERUMIER
jet: Re: [pve-devel] pve-firewall : nftables ? Also, it seem than conntrack is not yet implemented on bridge filtering :( seem to be a blocking point for now - Mail original - De: "Alexandre Derumier" À: "Wolfgang Bumiller" Cc: "pve-devel" En

Re: [pve-devel] pve-firewall : nftables ?

2018-11-27 Thread Alexandre DERUMIER
Also, it seem than conntrack is not yet implemented on bridge filtering :( seem to be a blocking point for now - Mail original - De: "Alexandre Derumier" À: "Wolfgang Bumiller" Cc: "pve-devel" Envoyé: Mardi 27 Novembre 2018 15:19:41 Objet: Re: [pve-

[pve-devel] [PATCH v3 qemu-server 6/7] migrate : phase3_cleanup : migrate_external

2018-11-27 Thread Alexandre Derumier
we don't move original config --- PVE/QemuMigrate.pm | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 9e963d3..ed8df71 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -1000,6 +1000,8

[pve-devel] [PATCH v3 qemu-server 7/7] migrate: add sshkey in /etc/pve/priv/migrate_external/

2018-11-27 Thread Alexandre Derumier
ssh key need to be in /etc/pve/priv/migrate_external/id_rsa_mytargetnode --- PVE/API2/Qemu.pm | 5 + PVE/QemuMigrate.pm | 2 ++ 2 files changed, 7 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index b85fd6d..d31fd96 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@

[pve-devel] [PATCH v3 qemu-server 1/7] api2 : add migrate_vm_external

2018-11-27 Thread Alexandre Derumier
qm migrate_external [--targetstorage otherstorage] [--targetbridge otherbridge] --- PVE/API2/Qemu.pm | 79 PVE/CLI/qm.pm| 2 ++ 2 files changed, 81 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index

[pve-devel] [PATCH v3 qemu-server 5/7] migrate : phase2_cleanup : migrate_external

2018-11-27 Thread Alexandre Derumier
we destroy target vm in case of failure in phase2 --- PVE/QemuMigrate.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index b4dc8f7..9e963d3 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -915,6 +915,9

[pve-devel] [PATCH v3 qemu-server 4/7] migrate : phase2 : migrate external

2018-11-27 Thread Alexandre Derumier
--- PVE/API2/Qemu.pm | 18 +++--- PVE/QemuMigrate.pm | 21 ++--- PVE/QemuServer.pm | 20 3 files changed, 45 insertions(+), 14 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index b23db56..b85fd6d 100644 --- a/PVE/API2/Qemu.pm

[pve-devel] [PATCH v3 qemu-server 2/7] migrate : prepare : add create_vm for external migration

2018-11-27 Thread Alexandre Derumier
Create vm on target cluster with same options. Disks are created with same size and same options than source --- PVE/QemuMigrate.pm | 88 ++ 1 file changed, 83 insertions(+), 5 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm

[pve-devel] [PATCH v3 qemu-server 0/7] online vm migration to external cluster

2018-11-27 Thread Alexandre Derumier
api root permission) - add targetbridge option - fix targetremotenode fqdn resolution - use pvesh to get nextvmid on remote cluster - add sshkey - add missing "\n" in some die messages. Alexandre Derumier (7): api2 : add migrate_vm_external migrate : prepare : add create_vm for

[pve-devel] [PATCH v3 qemu-server 3/7] migrate : phase1 : skip sync_disk for external migration

2018-11-27 Thread Alexandre Derumier
we don't need sync_disk as we mirror all disks through qemu --- PVE/QemuMigrate.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 922d76c..1dea286 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -568,7 +568,7 @@ sub

Re: [pve-devel] pve-firewall : nftables ?

2018-11-27 Thread Alexandre DERUMIER
etter than iptables, with all the new features like vmap,...) >>The iptables part would be considered feature-frozen from that point on I'd >>say/hope/think... Still missing some log features. (Currently I can't have any log on an accept/reject rule) - Mail original - De: "Wolf

Re: [pve-devel] pve-firewall : nftables ?

2018-11-27 Thread Alexandre DERUMIER
ecated by dscp - Mail original - De: "Josef Johansson" À: "pve-devel" Envoyé: Mardi 27 Novembre 2018 14:58:31 Objet: Re: [pve-devel] pve-firewall : nftables ? On 11/27/18 2:55 PM, Wolfgang Bumiller wrote: > On Mon, Nov 26, 2018 at 09:00:47AM +0100, Alexandre DERU

[pve-devel] pve-firewall : nftables ?

2018-11-26 Thread Alexandre DERUMIER
Hi, I would like to known if somebody have already made some test with nftables recently ? Mainly, is not possible to use physdev direction, like: -A PVEFW-FWBR-OUT -m physdev --physdev-in tap160i1 --physdev-is-bridged -j tap160i1-OUT I wonder if a simple vmap like this could work: ?

Re: [pve-devel] pve-firewall : log conntrack sessions ?

2018-11-21 Thread Alexandre DERUMIER
>>Will look into it. Thanks ! - Mail original - De: "David Limbeck" À: "pve-devel" Envoyé: Mercredi 21 Novembre 2018 11:14:17 Objet: Re: [pve-devel] pve-firewall : log conntrack sessions ? Will look into it. On 11/21/18 7:50 AM, Alexandre DERUMIER wrote:

[pve-devel] pve-firewall : can't have log on drop/reject rules

2018-11-21 Thread Alexandre DERUMIER
Hi, I'm not sure it was working before, but I can't get any log for a vm rule with a drop/reject. It's only works with default vm drop/reject action. I found an old patch about adding log by rules https://pve.proxmox.com/pipermail/pve-devel/2017-September/028816.html But I don't see

[pve-devel] [PATCH v2 pve-common] Network : veth pair : fix mtu

2018-11-21 Thread Alexandre Derumier
The ip link set command which create the veth pair is not setting mtu on both peers example: vm 106 is on a bridge with mtu 9000 222: tap160i1: mtu 9000 qdisc pfifo_fast master fwbr160i1 state UNKNOWN group default qlen 1000 223: fwbr160i1: mtu 1500 qdisc noqueue state UP group default qlen

[pve-devel] [PATCH pve-common] Network : veth pair : fix mtu

2018-11-21 Thread Alexandre Derumier
The ip link set command which create the veth pair is not setting mtu on both peers example: vm 106 is on a bridge with mtu 9000 222: tap160i1: mtu 9000 qdisc pfifo_fast master fwbr160i1 state UNKNOWN group default qlen 1000 223: fwbr160i1: mtu 1500 qdisc noqueue state UP group default qlen

[pve-devel] pve-firewall : log conntrack sessions ?

2018-11-20 Thread Alexandre DERUMIER
Hi, I'm currently to finally use proxmox firewall in production next year, and I missing piece is session logging (create in conntrack, end in conntrack). It's currently possible with ulogd2, but ulogd2 don't start with pve fw logger is running. I have found a blog about it:

[pve-devel] [PATCH v2 qemu-server 5/7] migrate : phase2_cleanup : migrate_external

2018-11-19 Thread Alexandre Derumier
we destroy target vm in case of failure in phase2 --- PVE/QemuMigrate.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 87afde6..6059a10 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -913,6 +913,9

[pve-devel] [PATCH v2 qemu-server 3/7] migrate : phase1 : skip sync_disk for external migration

2018-11-19 Thread Alexandre Derumier
we don't need sync_disk as we mirror all disks through qemu --- PVE/QemuMigrate.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index e965e2b..c54f655 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -568,7 +568,7 @@ sub

[pve-devel] [PATCH v2 qemu-server 2/7] migrate : prepare : add create_vm for external migration

2018-11-19 Thread Alexandre Derumier
Create vm on target cluster with same options. Disks are created with same size and same options than source --- PVE/QemuMigrate.pm | 88 ++ 1 file changed, 83 insertions(+), 5 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm

[pve-devel] [PATCH v2 qemu-server 0/7] online vm migration to external cluster

2018-11-19 Thread Alexandre Derumier
missing "\n" in some die messages. Alexandre Derumier (7): api2 : add migrate_vm_external migrate : prepare : add create_vm for external migration migrate : phase1 : skip sync_disk for external migration migrate : phase2 : migrate external migrate : phase2_cleanup

[pve-devel] [PATCH v2 qemu-server 4/7] migrate : phase2 : migrate external

2018-11-19 Thread Alexandre Derumier
--- PVE/API2/Qemu.pm | 20 PVE/QemuMigrate.pm | 17 +++-- PVE/QemuServer.pm | 20 3 files changed, 43 insertions(+), 14 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e40c6a0..9971e73 100644 --- a/PVE/API2/Qemu.pm +++

[pve-devel] [PATCH v2 qemu-server 7/7] migrate: add sshkey in /etc/pve/priv/migrate_external/

2018-11-19 Thread Alexandre Derumier
ssh key need to be in /etc/pve/priv/migrate_external/id_rsa_mytargetnode --- PVE/API2/Qemu.pm | 5 + PVE/QemuMigrate.pm | 2 ++ 2 files changed, 7 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 9971e73..549b129 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@

[pve-devel] [PATCH v2 qemu-server 6/7] migrate : phase3_cleanup : migrate_external

2018-11-19 Thread Alexandre Derumier
we don't move original config --- PVE/QemuMigrate.pm | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 6059a10..a1d9cdd 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -998,6 +998,8 @@

[pve-devel] [PATCH v2 qemu-server 1/7] api2 : add migrate_vm_external

2018-11-19 Thread Alexandre Derumier
qm migrate_external [--targetstorage otherstorage] [--targetbridge otherbridge] --- PVE/API2/Qemu.pm | 79 PVE/CLI/qm.pm| 2 ++ 2 files changed, 81 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index

Re: [pve-devel] [PATCH qemu-server 1/7] api2 : migrate_vm : add migration_type "external"

2018-11-14 Thread Alexandre DERUMIER
>>@Alexandre: please set the permissions to root@pam only for this new API >>path. yes, sure. >>I see the following problematic aspects otherwise: >>- potential back channel from a user/attacker-controlled target host to >>the source node via bugs in Qemu (might not even require a bug?)

Re: [pve-devel] [PATCH qemu-server 1/7] api2 : migrate_vm : add migration_type "external"

2018-11-13 Thread Alexandre DERUMIER
>>Feel free to choose a better name ;-) We can the mark this API as >>unstable/experimental, and modify >>the parameters/types. IMHO most existing parameters does not really makes >>sense with external migration. >>I guess it is still possible to factor out most common code to avoid code

Re: [pve-devel] [PATCH pve-manager] Add "SSD" property to IDE, SATA, and SCSI hard drives

2018-11-07 Thread Alexandre DERUMIER
er use this value ? - Mail original - De: "Nick Chevsky" À: "pve-devel" Cc: "Thomas Lamprecht" Envoyé: Mercredi 7 Novembre 2018 18:59:57 Objet: Re: [pve-devel] [PATCH pve-manager] Add "SSD" property to IDE, SATA, and SCSI hard drives

Re: [pve-devel] [PATCH pve-manager] Add "SSD" property to IDE, SATA, and SCSI hard drives

2018-11-07 Thread Alexandre DERUMIER
Hi, my 2cents: if rotational is already always enabled by default on virtio-scsi && virtio-blk, why not enabled it by default for ide,sata, on next qemu version ? (without any additional option). - Mail original - De: "Nick Chevsky" À: "Dominik Csapak" Cc: "Thomas Lamprecht" ,

Re: [pve-devel] [PATCH qemu-server 2/7] qm: add nextvmid

2018-11-07 Thread Alexandre DERUMIER
"pve-devel" Envoyé: Mercredi 7 Novembre 2018 16:25:02 Objet: Re: [pve-devel] [PATCH qemu-server 2/7] qm: add nextvmid why not use pvesh to get the next id in cluster instead of adding a new command? On 10/29/18 4:38 PM, Alexandre Derumier wrote: > return the next vmid free > ---

Re: [pve-devel] [PATCH qemu-server 0/7] online vm migration to external cluster

2018-11-07 Thread Alexandre DERUMIER
it and it seems to overall work. One thing we're still discussing internally is the SSH tunnel, we're not sure how we want to go forward (maybe a different solution). We'll let you know once we've further discussed this. On 10/29/18 4:38 PM, Alexandre Derumier wrote: > This add support to

[pve-devel] [PATCH qemu-server 5/7] migrate : phase2 : migrate external

2018-10-29 Thread Alexandre Derumier
--- PVE/API2/Qemu.pm | 4 ++-- PVE/QemuMigrate.pm | 21 + PVE/QemuServer.pm | 24 +--- 3 files changed, 36 insertions(+), 13 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index ac8b907..509747c 100644 --- a/PVE/API2/Qemu.pm +++

[pve-devel] [PATCH qemu-server 1/7] api2 : migrate_vm : add migration_type "external"

2018-10-29 Thread Alexandre Derumier
qm migrate --migration_type external [--targetstorage monpoolceph_vm] --online Allow to migrate to an external cluster node. --targetstorage is optionnal, if not defined it's used same storagename than source --- PVE/API2/Qemu.pm | 26 +++--- 1 file changed, 19

[pve-devel] [PATCH qemu-server 7/7] migrate : phase3_cleanup : migrate_external

2018-10-29 Thread Alexandre Derumier
we don't move original config --- PVE/QemuMigrate.pm | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 856a7db..a36ce85 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -992,6 +992,8 @@

[pve-devel] [PATCH qemu-server 2/7] qm: add nextvmid

2018-10-29 Thread Alexandre Derumier
return the next vmid free --- PVE/API2/Qemu.pm | 1 - PVE/CLI/qm.pm| 19 +++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 64eaa0e..ac8b907 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -389,7 +389,6 @@

[pve-devel] [PATCH qemu-server 6/7] migrate : phase2_cleanup : migrate_external

2018-10-29 Thread Alexandre Derumier
we destroy target vm in case of failure in phase2 --- PVE/QemuMigrate.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 6eb629b..856a7db 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -907,6 +907,9

[pve-devel] [PATCH qemu-server 3/7] migrate : prepare : add create_vm for external migration

2018-10-29 Thread Alexandre Derumier
Create vm on target cluster with same options. Disks are created with same size and same options than source --- PVE/QemuMigrate.pm | 82 ++ 1 file changed, 77 insertions(+), 5 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm

[pve-devel] [PATCH qemu-server 0/7] online vm migration to external cluster

2018-10-29 Thread Alexandre Derumier
source targetremotenode is a fqdn host from another cluster. (source node must be able to root ssh to target node with public key) source vm is not deleted currently for safety, just stopped and the migrate lock keeped to avoid to restart it. Please review and comment Alexandre Alexandre Derumier

[pve-devel] [PATCH qemu-server 4/7] migrate : phase1 : skip sync_disk for external migration

2018-10-29 Thread Alexandre Derumier
we don't need sync_disk as we mirror all disks through qemu --- PVE/QemuMigrate.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index ce43fc9..3e50f07 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -562,7 +562,7 @@ sub

Re: [pve-devel] [PATCH pve-manager] add 'ssbd', 'ibpb', 'virt-ssbd', 'amd-ssbd', 'amd-no-ssb' cpu flags option

2018-10-24 Thread Alexandre DERUMIER
2018 08:41:43 Objet: Re: [pve-devel] [PATCH pve-manager] add 'ssbd', 'ibpb', 'virt-ssbd', 'amd-ssbd', 'amd-no-ssb' cpu flags option On 9/2/18 7:54 AM, Alexandre Derumier wrote: > --- > www/manager6/qemu/ProcessorEdit.js | 42 > +- > 1 fil

Re: [pve-devel] [PATCH qemu-server 4/4] implement a 'real' reboot for vms

2018-10-17 Thread Alexandre DERUMIER
Wonderful ! It could be great to have something like, shutdown (clean shutdown) + start. - Mail original - De: "Dominik Csapak" À: "pve-devel" Envoyé: Mardi 16 Octobre 2018 12:07:06 Objet: [pve-devel] [PATCH qemu-server 4/4] implement a 'real' reboot for vms instead of letting qemu

[pve-devel] [PATCH pve-docs] vxlan evpn : remove rp_filter=0 for symetric model

2018-10-16 Thread Alexandre Derumier
This seem be to fixed in frr 6.0. (it was packetloss with vm migration, race condition when refreshing routing table) --- vxlan-and-evpn.adoc | 3 --- 1 file changed, 3 deletions(-) diff --git a/vxlan-and-evpn.adoc b/vxlan-and-evpn.adoc index 5115d78..66194e2 100644 --- a/vxlan-and-evpn.adoc

[pve-devel] [PATCH v3 frr 6/8] d/rules: delay restart on upgrade

2018-10-15 Thread Alexandre Derumier
--- debian/rules | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 811d45b..ab9c4c5 100755 --- a/debian/rules +++ b/debian/rules @@ -193,11 +193,14 @@ override_dh_auto_install: sed -i "/dependency_libs/ s/'.*'/''/"

[pve-devel] [PATCH v3 frr 8/8] enable zebra && bgp daemons by default

2018-10-15 Thread Alexandre Derumier
b39c6b5bc6835fac2ad91f7805f77089a38685a6 Mon Sep 17 00:00:00 2001 +From: Alexandre Derumier +Date: Fri, 15 Jun 2018 03:18:54 +0200 +Subject: [PATCH] enable zebra and bgp daemons + +--- + tools/etc/frr/daemons | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/tools/etc/frr/daemons b/tools/etc

[pve-devel] [PATCH v3 frr 1/8] add Makefile

2018-10-15 Thread Alexandre Derumier
--- Makefile | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 Makefile diff --git a/Makefile b/Makefile new file mode 100644 index 000..18861d0 --- /dev/null +++ b/Makefile @@ -0,0 +1,43 @@ +PACKAGE=frr +VER=6.0 +PKGREL=0+pve +

[pve-devel] [PATCH v3 frr 0/8] frr 6.0 package

2018-10-15 Thread Alexandre Derumier
/FRRouting/frr I have take inspiration from this packaging https://github.com/exoscale/pkg-frr/ This is needed for vxlan + bgp-evpn implementation. *** BLURB HERE *** Alexandre Derumier (8): add Makefile add frr git submodule import debianpkg directory as debian add python3-dev to build

[pve-devel] [PATCH v3 frr 2/8] add frr git submodule

2018-10-15 Thread Alexandre Derumier
--- .gitmodules | 3 +++ frr | 1 + 2 files changed, 4 insertions(+) create mode 100644 .gitmodules create mode 16 frr diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 000..5f1c9e1 --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule "frr"] + path

[pve-devel] [PATCH v3 frr 7/8] source: switch to 3.0 (quilt) format

2018-10-15 Thread Alexandre Derumier
--- debian/source/format | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/source/format b/debian/source/format index af745b3..163aaf8 100644 --- a/debian/source/format +++ b/debian/source/format @@ -1 +1 @@ -3.0 (git) +3.0 (quilt) -- 2.11.0

[pve-devel] [PATCH v3 frr 4/8] add python3-dev to build dependencies

2018-10-15 Thread Alexandre Derumier
--- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 71c412a..829e302 100644 --- a/debian/control +++ b/debian/control @@ -4,7 +4,7 @@ Priority: optional Maintainer: Nobody Uploaders: Nobody XSBC-Original-Maintainer:

[pve-devel] [PATCH v3 frr 5/8] add proxmox release in debian/changelog

2018-10-15 Thread Alexandre Derumier
7d3480..753347b 100644 --- a/debian/changelog.in +++ b/debian/changelog @@ -1,4 +1,10 @@ -frr (@VERSION@) RELEASED; urgency=medium +frr (6.0-0+pve) RELEASED; urgency=medium + + * Proxmox initial release. + + -- Alexandre Derumier Mon, 15 Oct 2018 04:46:06 +0200 + +frr (6.0-0) RELEASED; urgency=

Re: [pve-devel] [RFC PATCH qemu-server] add qemumonitor.c

2018-10-10 Thread Alexandre DERUMIER
ow (maybe catch disk-io errors), but could be interesting indeed. - Mail original - De: "Dominik Csapak" À: "pve-devel" Envoyé: Mardi 9 Octobre 2018 16:58:24 Objet: Re: [pve-devel] [RFC PATCH qemu-server] add qemumonitor.c On 10/9/18 4:50 PM, Alexandre DERUMIER wrote

Re: [pve-devel] [RFC PATCH qemu-server] add qemumonitor.c

2018-10-09 Thread Alexandre DERUMIER
>>this adds a program that can listen to qemu qmp events on a given socket Does it work in parallel with sending qmp command ? As far I remember, some year ago, it was not possible to have 2 qmp clients at the same time. (and needed some kind of proxy betweens clients and qemu) Maybe more

Re: [pve-devel] applied: [PATCH v4 pve-manager] API2 : Network : add network config reload

2018-10-08 Thread Alexandre DERUMIER
uot;pve-devel" , "aderumier" Envoyé: Lundi 8 Octobre 2018 13:36:21 Objet: applied: [pve-devel] [PATCH v4 pve-manager] API2 : Network : add network config reload applied, and added a few cleanups on top. Please can you try to solve those issues marked as 'clean me'? > On

[pve-devel] [PATCH qemu-server] qemu_img_convert : use "-l snapshot.name" instead -s for internal snapshot

2018-10-07 Thread Alexandre Derumier
qemu-img convert -s has been removed in qemu 3.0 https://git.qemu.org/?p=qemu.git;a=commit;h=46e8d272baa0608adcfdbd8bc1d2312bea06da40 we should use qemu-img convert -l snapshot.name=, introduced in qemu 2.0 in 2013 http://patchwork.ozlabs.org/patch/296457/ --- PVE/QemuServer.pm | 2 +- 1 file

[pve-devel] [PATCH v4 pve-manager] API2 : Network : add network config reload

2018-10-02 Thread Alexandre Derumier
This add a new api to online reload networking configuration with ifupdown2. This work with native ifupdown2 modules, as ifupdown2 have interface dependency relationships. Some specific interfaces options can't be reloaded online (because kernel don't implement it), it this case, we ifdown/ifup

[pve-devel] [PATCH V2 pve-common 2/2] improve lookup_type_prio

2018-10-01 Thread Alexandre Derumier
- use d->{type} instead regex on ifname - add stacked vlan support --- src/PVE/INotify.pm | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 1a60708..c42f885 100644 --- a/src/PVE/INotify.pm +++

[pve-devel] [PATCH V2 pve-common 1/2] Inotify: add support for 802.1ad stacked vlans

2018-10-01 Thread Alexandre Derumier
--- src/PVE/INotify.pm | 11 +-- test/etc_network_interfaces/t.create_network.pl | 14 ++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index f837596..1a60708 100644 --- a/src/PVE/INotify.pm

[pve-devel] [PATCH V2 pve-common 0/2] Add support for 802.1ad stacked vlans

2018-10-01 Thread Alexandre Derumier
inet manual vlan-protocol 802.1ad auto eth0.100.10 iface eth0.100.10 inet manual Alexandre Derumier (2): Inotify: add support for 802.1ad stacked vlans improve lookup_type_prio src/PVE/INotify.pm | 48 ++--- test/etc_network_interfaces

Re: [pve-devel] [PATCH pve-common 1/2] Inotify: add support for 802.1ad stacked vlans

2018-09-26 Thread Alexandre DERUMIER
quot;Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Mardi 25 Septembre 2018 14:55:17 Objet: Re: [pve-devel] [PATCH pve-common 1/2] Inotify: add support for 802.1ad stacked vlans On Mon, Sep 24, 2018 at 09:52:46AM +0200, Alexandre Derumier wrote: > -

Re: [pve-devel] [PATCH v3 pve-manager] API2 : Network : add network config reload

2018-09-26 Thread Alexandre DERUMIER
it/rebase-apply/patch:78: trailing whitespace. raise_param_exc({ config => "reloading config with ovs changes is not possible currently\n" }) warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors. more comments inline > On September 25, 2018 at 10:03 AM Alex

Re: [pve-devel] [PATCH pve-common 1/2] Inotify: add support for 802.1ad stacked vlans

2018-09-25 Thread Alexandre DERUMIER
'm unaware of any real switch implementation. AFAIK, only 1 802.1Q on top of 802.1ad seem to be possible on cisco,juniper,arista, - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Mardi 25 Septembre 2018 14:55:17

[pve-devel] [PATCH v3 pve-manager] API2 : Network : add network config reload

2018-09-25 Thread Alexandre Derumier
This add a new api to online reload networking configuration with ifupdown2. This work with native ifupdown2 modules, as ifupdown2 have interface dependency relationships. Some specific interfaces options can't be reloaded online (because kernel don't implement it), it this case, we ifdown/ifup

Re: [pve-devel] [PATCH v2 pve-manager] API2 : Network : add network config reload

2018-09-24 Thread Alexandre DERUMIER
>>Any idea why json output is not supported? seem to work with -o instead -t: ifquery -a -o json -o {native,json}, --format {native,json} interface display format -t seem to be for input format. BTW, it seem possible to compare running vs

Re: [pve-devel] [PATCH v2 pve-manager] API2 : Network : add network config reload

2018-09-24 Thread Alexandre DERUMIER
>>This looks fragile. Maybe we should first 'reload', and only rewrite if >>reload is successful? Even better, a 'reload' should return the applied >>configuration, and we only commit that? It's possible to test the syntax of configuration with "ifreload -a -s" ifupdown2 reload should work

[pve-devel] [PATCH pve-common 1/2] Inotify: add support for 802.1ad stacked vlans

2018-09-24 Thread Alexandre Derumier
--- src/PVE/INotify.pm | 26 - test/etc_network_interfaces/t.create_network.pl | 14 + 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index f837596..de61d79 100644 ---

[pve-devel] [PATCH pve-common 0/2] Add support for 802.1ad stacked vlans

2018-09-24 Thread Alexandre Derumier
add support of vlan-protocol option (ifupdown2), to enable 802.1ad vlans (QinQ). and add support for stacked vlan interface example --- auto eth0.100 iface eth0.100 inet manual vlan-protocol 802.1ad auto eth0.100.10 iface eth0.100.10 inet manual Alexandre Derumier (2): Inotify

[pve-devel] [PATCH pve-common 2/2] improve lookup_type_prio

2018-09-24 Thread Alexandre Derumier
- use d->{type} instead regex on ifname - add stacked vlan support --- src/PVE/INotify.pm | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index de61d79..9d4f6d4 100644 --- a/src/PVE/INotify.pm +++

Re: [pve-devel] [PATCH v2 pve-manager] API2 : Network : add network config reload

2018-09-23 Thread Alexandre DERUMIER
Hi, seem to be lost in the mailing, can somebody review this V2 ? - Mail original - De: "aderumier" À: "pve-devel" Cc: "aderumier" Envoyé: Mercredi 27 Juin 2018 04:53:57 Objet: [PATCH v2 pve-manager] API2 : Network : add network config reload changelog: - remove restart option -

Re: [pve-devel] [PATCH qemu-server] qemu 3.0 : add hv_synic && hv_stimer hyperv enlightment

2018-09-13 Thread Alexandre DERUMIER
umiller" À: "aderumier" Cc: "pve-devel" Envoyé: Jeudi 13 Septembre 2018 11:13:41 Objet: Re: [pve-devel] [PATCH qemu-server] qemu 3.0 : add hv_synic && hv_stimer hyperv enlightment On Fri, Aug 31, 2018 at 03:43:01PM +0200, Alexandre Derumier wrote: > This fi

[pve-devel] [PATCH pve-docs v2 0/2] add docs about vlan mgmt with vlan aware bridge

2018-09-11 Thread Alexandre Derumier
Add some documentation about vlan management with bridge vlan aware. (tagging the vmbrX.Y) Alexandre Derumier (2): add vlanaware bridge management vlan configuration remove note about vlan management interface pve-network.adoc | 29 +++-- 1 file changed, 23

[pve-devel] [PATCH pve-docs v2 2/2] remove note about vlan management interface

2018-09-11 Thread Alexandre Derumier
This seem wrong, it's possible to setup management vlan interface on vlanaware bridge without conflict with vm. (If vlan management is setup with vmbrX.Y) --- pve-network.adoc | 4 1 file changed, 4 deletions(-) diff --git a/pve-network.adoc b/pve-network.adoc index f31362f..55e2fbf 100644

[pve-devel] [PATCH pve-docs v2 1/2] add vlanaware bridge management vlan configuration

2018-09-11 Thread Alexandre Derumier
--- pve-network.adoc | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/pve-network.adoc b/pve-network.adoc index 1ac5b28..f31362f 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -407,7 +407,7 @@ function of VLAN 5 in the guest network, but in

Re: [pve-devel] [PATCH pve-docs 1/2] add vlanaware bridge management vlan configuration

2018-09-10 Thread Alexandre DERUMIER
r" À: "pve-devel" , "aderumier" Envoyé: Mardi 11 Septembre 2018 06:25:23 Objet: Re: [pve-devel] [PATCH pve-docs 1/2] add vlanaware bridge management vlan configuration comments/questions inline > On September 10, 2018 at 5:31 PM Alexandre Derumier &

[pve-devel] [PATCH pve-docs 0/2] add docs about vlan mgmt with vlan aware bridge

2018-09-10 Thread Alexandre Derumier
Add some documentation about vlan management with bridge vlan aware. (tagging the vmbrX.Y) Alexandre Derumier (2): add vlanaware bridge management vlan configuration remove note about vlan management interface pve-network.adoc | 59

[pve-devel] [PATCH pve-docs 2/2] remove note about vlan management interface

2018-09-10 Thread Alexandre Derumier
This seem wrong, it's possible to setup management vlan interface on vlanaware bridge without conflict with vm. (If vlan management is setup with vmbrX.Y) --- pve-network.adoc | 4 1 file changed, 4 deletions(-) diff --git a/pve-network.adoc b/pve-network.adoc index d61619f..10fe550 100644

[pve-devel] [PATCH pve-docs 1/2] add vlanaware bridge management vlan configuration

2018-09-10 Thread Alexandre Derumier
--- pve-network.adoc | 55 +-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/pve-network.adoc b/pve-network.adoc index 1ac5b28..d61619f 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -407,7 +407,7 @@ function of VLAN 5

[pve-devel] [PATCH pve-common V3] Inotify: fix mtu check

2018-09-04 Thread Alexandre Derumier
- special check for bond, set parent mtu from slaves mtu if no defined. - error if parent mtu is lower than child mtu (not bigger) - return if child mtu is not defined - fix vlan check (parent/child was inverted) --- changelog: v2: bond with ifupdown2 is working like ifupdown v3: cleanup

Re: [pve-devel] [PATCH pve-common V2] Inotify: fix mtu check

2018-09-04 Thread Alexandre DERUMIER
;>$pmtu = 1500 if !$pmtu; seem to be ok for me, I'll resent a v3. Thanks ! - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Mardi 4 Septembre 2018 14:39:44 Objet: Re: [pve-devel] [PATCH pve-common V2] Inotify: fi

[pve-devel] [PATCH pve-docs V2] improve spectre/meltdown cpu flags documentation

2018-09-04 Thread Alexandre Derumier
-add new cpuflags for spectre v4. -split cpuflags between amd && intel processors --- qm.adoc | 104 1 file changed, 79 insertions(+), 25 deletions(-) diff --git a/qm.adoc b/qm.adoc index 1451f5d..718ecb6 100644 --- a/qm.adoc +++

Re: [pve-devel] [PATCH v3 pve-common 5/5] Inotify : add mtu option

2018-09-03 Thread Alexandre DERUMIER
010 > Mobil: +49 171 12 62 761 > E-Mail: dennis.bu...@stacktrace.de > De-Mail: dennis.bu...@gmx.de-mail.de > > Am 05.07.2018 um 02:56 schrieb Alexandre Derumier: >> also check if mtu value is lower than parent interface >> >> fixme: vxlan interface should b

[pve-devel] [PATCH pve-common V2] Inotify: fix mtu check

2018-09-03 Thread Alexandre Derumier
changelog: bond with ifupdown2 is working like ifupdown - special check for bond, set parent mtu from slaves mtu if no defined. - error if parent mtu is lower than child mtu (not bigger) - child inherit from parent mtu if not defined - fix vlan check (parent/child was inverted) ---

[pve-devel] [PATCH pve-common] Inotify: fix mtu check

2018-09-03 Thread Alexandre Derumier
- special check for bond, ifupdown set parent mtu from slaves mtu if no defined. - error if parent mtu is lower than child mtu (not bigger) - child inherit from parent mtu if not defined - fix vlan check (parent/child was inverted) --- src/PVE/INotify.pm | 16 ++-- 1 file changed,

Re: [pve-devel] [PATCH v3 pve-common 5/5] Inotify : add mtu option

2018-09-03 Thread Alexandre DERUMIER
>>mmm,ok. I didn't known that's could work. >>So setting mtu to bond device, force mtu to slaves too ? Ok I have tried with iface bond0 inet manual slaves eth0 eth1 mtu 9000 with ifupdown , indeed, the slaves mtu are equal to bond mtu but with ifupdown2, the slave still have 1500

Re: [pve-devel] [PATCH v3 pve-common 5/5] Inotify : add mtu option

2018-09-03 Thread Alexandre DERUMIER
>>Just every configuration, where you change /etc/network/interfaces in a >>way like: >> >> >>iface bond0 inet manual >>... >>slaves eno18 eno19 >>mtu 9000 >> >> >>without also writing the "mtu 9000" in the eno18 and eno19 sections. It >>will work, but every try of

Re: [pve-devel] [PATCH pve-manager] add 'ssbd', 'ibpb', 'virt-ssbd', 'amd-ssbd', 'amd-no-ssb' cpu flags option

2018-09-03 Thread Alexandre DERUMIER
t could be great to be able to filter list from the cpu model. - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Envoyé: Lundi 3 Septembre 2018 08:41:43 Objet: Re: [pve-devel] [PATCH pve-manager] add 'ssbd', 'ibpb', 'virt-ssbd', 'amd-ssb

[pve-devel] [PATCH pve-manager] add 'ssbd', 'ibpb', 'virt-ssbd', 'amd-ssbd', 'amd-no-ssb' cpu flags option

2018-09-01 Thread Alexandre Derumier
--- www/manager6/qemu/ProcessorEdit.js | 42 +- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js index 3ecea205..eaec0773 100644 --- a/www/manager6/qemu/ProcessorEdit.js +++

[pve-devel] [PATCH pve-manager] cpumodelselector : add EPYC

2018-09-01 Thread Alexandre Derumier
--- www/manager6/form/CPUModelSelector.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js index d3315513..9eb5b0e9 100644 --- a/www/manager6/form/CPUModelSelector.js +++ b/www/manager6/form/CPUModelSelector.js @@

[pve-devel] [PATCH qemu-server] qemu 3.0 : add hv_synic && hv_stimer hyperv enlightment

2018-08-31 Thread Alexandre Derumier
This fix cpu bug on last win10 updates --- PVE/QemuServer.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 9bfb4a1..52b0163 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6700,6 +6700,11 @@ sub add_hyperv_enlightenments {

Re: [pve-devel] [PATCH qemu-server] add mtu option to virtio-net device

2018-08-31 Thread Alexandre DERUMIER
e-devel" , "aderumier" Envoyé: Vendredi 31 Août 2018 15:02:03 Objet: Re: [pve-devel] [PATCH qemu-server] add mtu option to virtio-net device I really dislike options that only works for specific cases ... > On August 31, 2018 at 1:11 PM Alexandre Derumier wrote: > >

[pve-devel] [PATCH pve-manager] qemu: add mtu advanced option.

2018-08-31 Thread Alexandre Derumier
Allow to setup mtu in guest. Improve me: disable mtu option if model != virtio --- www/manager6/Parser.js | 5 + www/manager6/qemu/NetworkEdit.js | 21 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/www/manager6/Parser.js

[pve-devel] [PATCH qemu-server] add mtu option to virtio-net device

2018-08-31 Thread Alexandre Derumier
This allow to setup mtu inside the guest, only working with virtio-net. --- PVE/QemuServer.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 015f8f7..9bfb4a1 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -715,6 +715,12 @@ my

Re: [pve-devel] [PATCH pve-docs] improve spectre/meltdown cpu flags documentation

2018-08-29 Thread Alexandre DERUMIER
about this ? - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Mardi 28 Août 2018 13:09:12 Objet: Re: [pve-devel] [PATCH pve-docs] improve spectre/meltdown cpu flags documentation On Mon, Aug 20, 2018 at 08:02:51PM +

[pve-devel] [PATCH pve-common] Inotify : check bridgeport: fix vlan interface not defined

2018-08-28 Thread Alexandre Derumier
We can add to a bridge a non defined vlan interface. We only need to check that physical interface exist example --- auto eno1 iface eno1 inet manual auto vmbr0 iface vmbr0 inet manual bridge_ports eno1.1 --- src/PVE/INotify.pm | 1 + 1 file changed, 1 insertion(+) diff --git

<    5   6   7   8   9   10   11   12   13   14   >