[pve-devel] [PATCH docs v2 10/10] pveceph: add attribute ceph_codename

2019-11-06 Thread Alwin Antreich
To change the codename for Ceph in one place, the patch adds the asciidoc attribute 'ceph_codename'. Replaces the outdated references to luminous and the http -> https on the links in pveceph.adoc. Signed-off-by: Alwin Antreich --- pveceph.adoc

[pve-devel] [PATCH docs v2 08/10] pveceph: correct CephFS subtitle

2019-11-06 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index e97e2e6..66ea111 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -659,8 +659,8 @@ refer to the ceph documentation. footnote:[Configuring

[pve-devel] [PATCH docs v2 07/10] pveceph: Reorganize TOC for new sections

2019-11-06 Thread Alwin Antreich
-off-by: Alwin Antreich --- pveceph.adoc | 95 +--- 1 file changed, 53 insertions(+), 42 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index dbfe909..e97e2e6 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -212,8 +212,8 @@ This sets up an `apt

[pve-devel] [PATCH docs v2 06/10] pveceph: switch note for Creating Ceph Manager

2019-11-06 Thread Alwin Antreich
to be more consistent with other sections, the note for creating the Ceph Manager was moved below the command. Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 5933cc8..dbfe909 100644 --- a

[pve-devel] [PATCH docs v2 09/10] Fix #1958: pveceph: add section Ceph maintenance

2019-11-06 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 55 1 file changed, 55 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index 66ea111..0d62943 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -331,6 +331,7 @@ network. It is recommended

[pve-devel] [PATCH docs v2 00/10] pveceph: update doc

2019-11-06 Thread Alwin Antreich
mands" Review and suggestions are very welcome. Thanks. :) Alwin Antreich (10): pveceph: add section - Destroying Ceph OSDs pveceph: add section - Destroying Ceph Monitor pveceph: add Ceph Monitor screenshot pveceph: add section - Destroying Ceph Manager pveceph: add section - Destroyi

[pve-devel] [PATCH docs 01/11] pveceph: old style commands to subcommands

2019-11-04 Thread Alwin Antreich
Replace remaining old style single commands with current subcommands Signed-off-by: Alwin Antreich --- pveceph.adoc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index ebf9ef7..cfb86a8 100644 --- a/pveceph.adoc +++ b/pveceph.adoc

[pve-devel] [PATCH docs 11/11] pveceph: add attribute ceph_codename

2019-11-04 Thread Alwin Antreich
To change the codename for Ceph in one place, the patch adds the asciidoc attribute 'ceph_codename'. Replaces the outdated references to luminous and the http -> https on the links in pveceph.adoc. Signed-off-by: Alwin Antreich --- pveceph.adoc

[pve-devel] [PATCH docs 09/11] pveceph: rename CephFS subtitles

2019-11-04 Thread Alwin Antreich
to reflect the same active voice style as the other subtitles in pveceph Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 2972a68..087c4d0 100644 --- a/pveceph.adoc +++ b/pveceph.adoc

[pve-devel] [PATCH docs 07/11] pveceph: switch note for Creating Ceph Manager

2019-11-04 Thread Alwin Antreich
to be more consistent with other sections, the note for creating the Ceph Manager was moved below the command. Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index a4f2e4e..9806401 100644 --- a

[pve-devel] [PATCH docs 00/11] pveceph: update doc

2019-11-04 Thread Alwin Antreich
In patch 11 I have added an attribute to asciidoc-pve.conf to replace Ceph's codename. I hope this is the right location for this. Review and suggestions are very welcome. Thanks. :) Alwin Antreich (11): pveceph: old style commands to subcommands pveceph: add section - Destroying Ceph

[pve-devel] [PATCH docs 08/11] pveceph: Reorganize TOC for new sections

2019-11-04 Thread Alwin Antreich
-off-by: Alwin Antreich --- pveceph.adoc | 79 ++-- 1 file changed, 45 insertions(+), 34 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 9806401..2972a68 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -234,11 +234,8 @@ configuration file

[pve-devel] [PATCH docs 10/11] Fix #1958: pveceph: add section Ceph maintenance

2019-11-04 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 54 1 file changed, 54 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index 087c4d0..127e3bb 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -331,6 +331,7 @@ network. In a Ceph cluster

[pve-devel] [PATCH qemu-server v3] Fix #2171: VM statefile was not activated

2019-10-17 Thread Alwin Antreich
$conf->{vmstate} so config_to_command can activate, generate and assign the path to '-loadstate'. Any file/device based statefile will be added directly to -loadstate. Signed-off-by: Alwin Antreich --- Note: V1 -> V2: re-use resume code for rollback, incorporate

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-14 Thread Alwin Antreich
On Mon, Oct 14, 2019 at 11:44:59AM +0200, Thomas Lamprecht wrote: > On 10/11/19 1:45 PM, Alwin Antreich wrote: > > On Fri, Oct 11, 2019 at 12:17:28PM +0200, Thomas Lamprecht wrote: > >> On 10/11/19 12:02 PM, Alwin Antreich wrote: > >>> On Fri, Oct 11, 2019 at 07:1

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-11 Thread Alwin Antreich
On Fri, Oct 11, 2019 at 12:17:28PM +0200, Thomas Lamprecht wrote: > On 10/11/19 12:02 PM, Alwin Antreich wrote: > > On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrote: > >> On 10/10/19 3:58 PM, Alwin Antreich wrote: > >>> Machine states that were cr

Re: [pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-11 Thread Alwin Antreich
On Fri, Oct 11, 2019 at 07:10:53AM +0200, Thomas Lamprecht wrote: > On 10/10/19 3:58 PM, Alwin Antreich wrote: > > Machine states that were created on snapshots with memory could not be > > restored on rollback. The state volume was not activated so KVM couldn't > > loa

[pve-devel] [PATCH qemu-server v2] Fix #2171: VM statefile was not activated

2019-10-10 Thread Alwin Antreich
turn disallows the use of path based statefiles when used with the '--stateuri' option on 'qm start'. Only 'tcp', 'unix' and our storage based URIs can be used now. Signed-off-by: Alwin Antreich --- PVE/QemuConfig.pm | 3 +-- PVE/QemuServer.pm | 8 +---

Re: [pve-devel] [PATCH qemu-server] Fix #2171: VM statefile was not activated

2019-10-08 Thread Alwin Antreich
On Tue, Oct 08, 2019 at 12:31:06PM +0200, Fabian Grünbichler wrote: > On October 8, 2019 11:25 am, Alwin Antreich wrote: > > On Tue, Oct 08, 2019 at 08:36:57AM +0200, Fabian Grünbichler wrote: > >> On October 7, 2019 2:41 pm, Alwin Antreich wrote: > >> > Machi

Re: [pve-devel] [PATCH qemu-server] Fix #2171: VM statefile was not activated

2019-10-08 Thread Alwin Antreich
On Tue, Oct 08, 2019 at 08:36:57AM +0200, Fabian Grünbichler wrote: > On October 7, 2019 2:41 pm, Alwin Antreich wrote: > > Machine states that were created on snapshots with memory could not be > > restored on rollback. The state volume was not activated so KVM couldn'

[pve-devel] [PATCH qemu-server] Fix #2171: VM statefile was not activated

2019-10-07 Thread Alwin Antreich
Machine states that were created on snapshots with memory could not be restored on rollback. The state volume was not activated so KVM couldn't load the state. This patch moves the path generation into vm_start and de-/activates the state volume. Signed-off-by: Alwin Antreich ---

[pve-devel] [PATCH storage v2] Fix #2346: rbd storage shows wrong %-usage

2019-09-03 Thread Alwin Antreich
d' now has the data after replication for the pool. The new calculation will be used only if all OSDs are running with the on-disk format introduced by Ceph 14.2.2. Signed-off-by: Alwin Antreich --- v1 -> v2: checks now if key is defined and not for just truth PVE/Storage/RBDPlugin.pm |

[pve-devel] [PATCH storage] Fix #2346: rbd: storage shows wrong %-usage

2019-09-02 Thread Alwin Antreich
d' now has the data after replication for the pool. The new calculation will be used only if all OSDs are running with the on-disk format introduced by Ceph 14.2.2. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [pve-devel] applied: [PATCH qemu-server] use new pcie port hardware

2019-07-30 Thread Alwin Antreich
On Tue, Jul 30, 2019 at 12:19:28PM +0300, Dmitry Petuhov wrote: > Under Windows 7 I've just hit bug of q35-4.0 that timer runs few times > faster than it should. See > https://bugzilla.redhat.com/show_bug.cgi?id=1704375 > > Had to switch machine type to i440fx from q35 to workaround it. To set the

[pve-devel] [PATCH qemu-server] fix: qemu: uninitialized value in multiplication

2019-07-24 Thread Alwin Antreich
key is not set. Signed-off-by: Alwin Antreich --- PVE/QemuConfig.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index 8fae4fc..84d601a 100644 --- a/PVE/QemuConfig.pm +++ b/PVE/QemuConfig.pm @@ -137,12 +137,14 @@ sub

[pve-devel] [PATCH manager 2/3] pvenode: add public key size & type to cert info

2019-07-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/CLI/pvenode.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index 1989e8b3..fd3cf52d 100644 --- a/PVE/CLI/pvenode.pm +++ b/PVE/CLI/pvenode.pm @@ -123,7 +123,7 @@ __PACKAGE__->register_met

[pve-devel] [PATCH manager 3/3] pve5to6: cert: check certificates key size

2019-07-22 Thread Alwin Antreich
Debian Buster raised the default security level (1 -> 2) for TLS connections. This moves from the 80 bit security level to the 112 bit security level and will require 2048 bit or larger RSA and DHE keys, 224 bit or larger ECC keys, and SHA-2. Signed-off-by: Alwin Antreich --- PVE/CLI/pve5

[pve-devel] [PATCH 0/5] cert: public key size & type

2019-07-22 Thread Alwin Antreich
This patch series adds the certificates public key type and size. It is later on used in the pve5to6 command to check if the certificates have the required key size, since Debian Buster raised the default security level for TLS connections. Alwin Antreich (5): gui: cert: add public key type

[pve-devel] [PATCH manager 1/3] gui: cert: add public key type & size to certs view

2019-07-22 Thread Alwin Antreich
by default the fields are hidden Signed-off-by: Alwin Antreich --- www/manager6/node/Certificates.js | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/www/manager6/node/Certificates.js b/www/manager6/node/Certificates.js index d8032ffd..df2fd7de

[pve-devel] [PATCH common 2/2] cert: add public key type & size to JSON schema

2019-07-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/Certificate.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm index 65c5c8f..5ab920f 100644 --- a/src/PVE/Certificate.pm +++ b/src/PVE/Certificate.pm @@ -78,6 +78,16 @@ PVE::JSONSchema

[pve-devel] [PATCH common 1/2] cert: add public key type and size to info

2019-07-22 Thread Alwin Antreich
From: Fabian Grünbichler Signed-off-by: Fabian Grünbichler Co-Authored-By: Alwin Antreich --- src/PVE/Certificate.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm index 691e70b..65c5c8f 100644 --- a/src/PVE/Certificate.pm +++ b/src

[pve-devel] [PATCH manager] cleanup: don't copy ceph's admin keyring to /etc/ceph

2019-07-10 Thread Alwin Antreich
As this is done only on the first node that runs pveceph init, it might be confusing for users to see it only on one node in the cluster. The client section in the ceph.conf references the key under /etc/pve/priv/, so all ceph tools will look for it there anyway. Signed-off-by: Alwin Antreich

[pve-devel] [PATCH manager 2/2] keyring: use ckeyring_path variable in chown cmd

2019-07-10 Thread Alwin Antreich
A fixed path for the ceph.client.admin.keyring was used in the chown command. This patch uses the ckeyring_path variable instead, to minimize changes should the path change. Signed-off-by: Alwin Antreich --- PVE/Ceph/Tools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[pve-devel] [PATCH manager 1/2] Fix: typo in ckeyring_path

2019-07-10 Thread Alwin Antreich
pveceph init failed, as it couldn't chown the keyring Signed-off-by: Alwin Antreich --- PVE/Ceph/Tools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm index f8ec4302..d6d21ff2 100644 --- a/PVE/Ceph/Tools.pm +++ b/PVE/Ceph/Too

[pve-devel] [PATCH qemu-server] Fix: rtcflags: ignore startdate 'now'

2019-07-04 Thread Alwin Antreich
If 'now' is passed to the startdate option, the kvm start fails with below failure. kvm: invalid datetime format valid formats: '2006-06-17T16:01:21' or '2006-06-17' With this patch, 'now' is ignored and not passed to the rtcflags (-rtc). Signed-off-by

[pve-devel] [PATCH storage 3/3] decompress: use hash instead of if statement

2019-06-14 Thread Alwin Antreich
For less and cleaner code, use a hash for de-compressor commands instead of the 'long' if-elsif statement. Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm ind

[pve-devel] [PATCH storage 1/3] Fix #2124: Add support for zstd

2019-06-14 Thread Alwin Antreich
This patch adds zstd for backup/restore. It also factors out the common parts on the decompression tools. Sadly tar 1.31 (includes zstd) was not available at the time of writing this patch. Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 124

[pve-devel] [PATCH storage 2/3] Remove dup code from extract_vzdump_config_vma

2019-06-14 Thread Alwin Antreich
This patch removes the code duplication from extract_vzdump_config_vma, as it has been factored out for wider use. With the introduction of the zstd decompression, most parts of this code has been used also for the CT backup extraction and was previously duplicated. Signed-off-by: Alwin Antreich

[pve-devel] [PATCH container] Fix #2124: restore: support external de-compressor

2019-06-14 Thread Alwin Antreich
This patch adds support to restore archives that have been compressed with a compressor not natively supported by tar. This had to be added for zstd support. Signed-off-by: Alwin Antreich --- src/PVE/LXC/Create.pm | 31 +-- 1 file changed, 21 insertions(+), 10

[pve-devel] Fix #2124: Add support for zstd

2019-06-14 Thread Alwin Antreich
file; QemuServer.pm) * maybe unify extraction via sysopen (see LXC/Create.pm) or archive path to compressor (see Storage.pm) (which would be better?) What's your take on these ideas? Alwin Antreich (6): Fix #2124: Add support for zstd Remove dup code from extract_vzdump_config_vma decomp

[pve-devel] [PATCH qemu-server] Fix #2124: restore: add zstd de-compression

2019-06-14 Thread Alwin Antreich
Recognize the .zst file extention for the zstd de-compression Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 341e0b0..48361d0 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm

[pve-devel] [PATCH storage v2] cephfs: Exclude _netdev when mounting with fuse

2019-06-12 Thread Alwin Antreich
CephFS kernel client mounts the storage. It seems _netdev is not needed anyway for the fuse mount, as the connection is closed, once the fuse process gets killed on shutdown. Signed-off-by: Alwin Antreich --- Changes v1 -> v2: * moved push into if statement * added hopefully more context

[pve-devel] [PATCH storage] cephfs: Exclude _netdev when mounting with fuse

2019-06-11 Thread Alwin Antreich
fuse 2.9.x does not support the _netdev option and a cephfs storage mount fails. This patch ignores the _netdev option if 'fuse 1' is set on the cephfs storage. Signed-off-by: Alwin Antreich --- Note: fuse3 (3.4.1) in buster supports _netdev PVE/Storage/CephFSPlugin.pm | 2 +- 1 fi

[pve-devel] [PATCH container] Fix: check if compression_map format is undefined

2019-05-23 Thread Alwin Antreich
We want to check for an supported compression type, but the check was not correct as this only works if both sides are scalars, but an assignment to an array is always "truthy", so actually check explicitly if the compression type is supported before. Signed-off-by: Alwin Antreich Co-a

[pve-devel] [PATCH librados2-perl] Add a hint to why a mon command may have timed out

2019-04-11 Thread Alwin Antreich
With this patch a timed out mon command returns a more descriptive message, as to just a 'got timeout', when the MON could not be reached. Signed-off-by: Alwin Antreich --- Note: this is after some more thought and discussion, of my previously send ceph status check. Just extending

[pve-devel] [PATCH manager] Ceph status: is public net IP available on host

2019-04-10 Thread Alwin Antreich
Checks if the host has an interface with an IP of ceph's public network active, when ceph's status is requested. With this check the status returns a more descriptive message when no network connection exists, as to just a time out, when the MON could not be reached. Signed-off

[pve-devel] [PATCH manager] pveceph: install ceph service print sucess message

2019-04-09 Thread Alwin Antreich
This patch adds a success message on successful ceph.service installation. And adds a newline to make a successful ceph package installation more visible. Signed-off-by: Alwin Antreich --- PVE/CLI/pveceph.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/CLI

[pve-devel] [PATCH manager] Ceph MON - Reword error message on IP config

2019-04-08 Thread Alwin Antreich
Reword the error message in find_mon_ip to make it more clear, that there is no active IP configuration for the ceph public network. Signed-off-by: Alwin Antreich --- Note: this is only my personal suggestion for the message. PVE/API2/Ceph/MON.pm | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH qemu-server] Create linked clone failed, uninitialized storage

2019-04-05 Thread Alwin Antreich
-off-by: Alwin Antreich --- PVE/API2/Qemu.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 5469089..638455e 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2854,7 +2854,9 @@ __PACKAGE__->register_met

[pve-devel] [PATCH docs v2] Expand the Precondition section

2019-04-04 Thread Alwin Antreich
This patch adds more information about hardware preconditions and practices. Signed-off-by: Alwin Antreich --- V1 -> V2: tried to simplify english, as discussed off list. pveceph.adoc | 60 ++-- 1 file changed, 54 insertions(+)

[pve-devel] [PATCH docs 4/4] Add monitoring & troubleshooting section

2019-04-03 Thread Alwin Antreich
To give a little overview on where to look if trouble arise. Signed-off-by: Alwin Antreich --- pveceph.adoc | 24 1 file changed, 24 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index b7378d5..7db2039 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -580,6

[pve-devel] [PATCH docs 1/4] Change heading style for Multiple Active MDS

2019-04-03 Thread Alwin Antreich
The current heading style produces the below warning when executing make: asciidoc: WARNING: pveceph.adoc: line 505: missing section: [sect5] With the heading style used in this patch the warning is gone and the heading style is aligned with others of the same indentation. Signed-off-by: Alwin

[pve-devel] [PATCH docs 0/4] extend pveceph docs

2019-04-03 Thread Alwin Antreich
last section could get more information, but I hope it is already a fair start. Thanks in advance for suggestions and corrections. Alwin Antreich (4): Change heading style for Multiple Active MDS Extend recommendation in TIP box Expand the Precondition section Add monitoring & troubl

[pve-devel] [PATCH docs 2/4] Extend recommendation in TIP box

2019-04-03 Thread Alwin Antreich
Extends the TIP after 'Ceph consists of' with more emphasis and an additional link to Ceph's architecture. Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 72b7643..f5ccd

[pve-devel] [PATCH docs 3/4] Expand the Precondition section

2019-04-03 Thread Alwin Antreich
This patch adds more information about hardware preconditions and practices. Signed-off-by: Alwin Antreich --- pveceph.adoc | 57 +++-- 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index f5ccdd1

[pve-devel] [PATCH docs v2] Reword krbd option description

2019-03-19 Thread Alwin Antreich
Reword the description and add an extra note box for the KRBD option to reflect its current use. As containers needs to use KRBD for a mapped device anyway and they are not affected by this option. Signed-off-by: Alwin Antreich --- V1 -> V2: puts clarification into a note box pve-stor

Re: [pve-devel] [PATCH docs] Reword krbd option description

2019-03-19 Thread Alwin Antreich
On Tue, Mar 19, 2019 at 01:00:29PM +0100, Thomas Lamprecht wrote: > On 3/19/19 12:56 PM, Alwin Antreich wrote: > > Reword the description of the KRBD option to reflect its current use for > > VMs only. A container needs to use KRBD for a mapped device anyway and > > is not af

[pve-devel] [PATCH docs] Reword krbd option description

2019-03-19 Thread Alwin Antreich
Reword the description of the KRBD option to reflect its current use for VMs only. A container needs to use KRBD for a mapped device anyway and is not affected by this option. Signed-off-by: Alwin Antreich --- pve-storage-rbd.adoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [pve-devel] [PATCH container v3] Fix #2109: resize rbd volume for container failed

2019-03-11 Thread Alwin Antreich
On Mon, Mar 11, 2019 at 09:44:17AM +0100, Thomas Lamprecht wrote: > Am 3/8/19 um 3:41 PM schrieb Alwin Antreich: > > On resizing a container's disk image the filesystem is extended and in > > the case of RBD the returned path of the volume was not a path to a > > mapped d

[pve-devel] [PATCH container v3] Fix #2109: resize rbd volume for container failed

2019-03-08 Thread Alwin Antreich
s not returned then the path method is tried. Currently only the RBD storage plugin returns a path on map_volume. Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 27d26d5..26

Re: [pve-devel] [PATCH container v3] Fix #2109: resize rbd volume for container failed

2019-03-08 Thread Alwin Antreich
On Fri, Mar 08, 2019 at 03:11:54PM +0100, Alwin Antreich wrote: > On resizing a container's disk image the filesystem is extended and in > the case of RBD the returned path of the volume was not a path to a > mapped device. > > This patch uses map_volume (respectively un

[pve-devel] [PATCH container v3] Fix #2109: resize rbd volume for container failed

2019-03-08 Thread Alwin Antreich
s not returned then the path method is tried. Currently only the RBD storage plugin returns a path on map_volume. Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 27d26d5..e7

Re: [pve-devel] [PATCH container v2] Fix #2109: resize rbd volume for container failed

2019-03-07 Thread Alwin Antreich
On Wed, Mar 06, 2019 at 11:23:51AM +0100, Thomas Lamprecht wrote: > On 3/5/19 12:07 PM, Alwin Antreich wrote: > > The returned path of the volume was not a mapped device. This patch uses > > un-/map_volume for rbd storage to get a device mapped and its path. > > commit messag

[pve-devel] [PATCH container v2] Fix #2109: resize rbd volume for container failed

2019-03-05 Thread Alwin Antreich
The returned path of the volume was not a mapped device. This patch uses un-/map_volume for rbd storage to get a device mapped and its path. Signed-off-by: Alwin Antreich --- V1 -> V2: implemented suggestions from Thomas https://pve.proxmox.com/pipermail/pve-devel/2019-March/035896.h

[pve-devel] [PATCH container] Fix #2109: resize rbd volume for container failed

2019-03-05 Thread Alwin Antreich
The returned path of the volume was not a mapped device. This patch uses un-/map_volume for rbd storage to get a device mapped and its path. Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src

[pve-devel] [PATCH docs] Update recommended system requirements

2019-02-25 Thread Alwin Antreich
Adds additional recommendations for Ceph and ZFS Signed-off-by: Alwin Antreich --- pve-system-requirements.adoc | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc index 52aa608..bb6dce3 100644

[pve-devel] [PATCH docs] Update recommended system requirements

2019-02-21 Thread Alwin Antreich
removes and incorporates the minimal requirements into the recommended one. Adds additional recommendations for Ceph and ZFS. Signed-off-by: Alwin Antreich --- pve-system-requirements.adoc | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a

[pve-devel] [PATCH firewall] Fix unitialized value $mark in bitwise operation

2019-02-13 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- src/PVE/FirewallSimulator.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/FirewallSimulator.pm b/src/PVE/FirewallSimulator.pm index b01e45b..188c38f 100644 --- a/src/PVE/FirewallSimulator.pm +++ b/src/PVE/FirewallSimulator.pm

[pve-devel] [PATCH docs v2] Fix #2018: CephFS client needs newer binaries

2019-02-13 Thread Alwin Antreich
To run cephfs client the debian stock packages need to be updated to luminous to get it running. This patch adds a section with our Ceph repositories to our package repo chapter to where the cephfs storage plugin chapter links to. Signed-off-by: Alwin Antreich --- V1 -> V2: Correcti

[pve-devel] [PATCH docs 2/3] Fix #2015: add how to get a auth secret for cephfs

2019-02-12 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pve-storage-cephfs.adoc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pve-storage-cephfs.adoc b/pve-storage-cephfs.adoc index 2613d64..96f4991 100644 --- a/pve-storage-cephfs.adoc +++ b/pve-storage-cephfs.adoc @@ -71,13 +71,20

[pve-devel] [PATCH docs 1/3] asciidoc-pve: ignore link targets for non-manpages

2019-02-12 Thread Alwin Antreich
Signed-off-by: Thomas Lamprecht Signed-off-by: Alwin Antreich --- asciidoc-pve.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/asciidoc-pve.in b/asciidoc-pve.in index 70848ca..d1a754d 100644 --- a/asciidoc-pve.in +++ b/asciidoc-pve.in @@ -146,7 +146,10 @@ sub replace_man_

[pve-devel] [PATCH docs 0/3] cephfs client documentation improvements

2019-02-12 Thread Alwin Antreich
Whit the help of Thomas, this series adds our ceph repositories to the documentation and updates the missing installation information for a working cephfs storage client. Thomas patch is needed to get the Fix #2018 applied, as it references a non-manpage. Alwin Antreich (2): Fix #2015: add how

[pve-devel] [PATCH docs 3/3] Fix #2018: CephFS client needs newer binaries

2019-02-12 Thread Alwin Antreich
To run cephfs client the debian stock packages need to be updated to luminous to get it running. This patch adds a section with our Ceph repositories to our package repo chapter to where the cephfs storage plugin chapter links to. Signed-off-by: Alwin Antreich --- pve-package-repos.adoc | 28

[pve-devel] [PATCH manager v4 2/2] Cleanup parsing proc/mounts on OSD destroy

2019-02-07 Thread Alwin Antreich
Instead of opening proc/mounts through IO::File directly for parsing, the patch uses ProcFSTools. This way it also takes care of eventual decoding. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/OSD.pm | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Ceph

[pve-devel] [PATCH manager v4 1/2] Fix #2051: preserve DB/WAL disk on destroy

2019-02-07 Thread Alwin Antreich
'pveceph osd destroy --cleanup' When executing the command above, all disks associated with the OSD are at the moment wiped with dd (incl. separate disks with DB/WAL). The patch adds the ability to 'wipe_disks' to wipe the partition instead of the whole disk. Signed-of

[pve-devel] [PATCH manager v3] Fix #2051: preserve DB/WAL disk on destroy

2019-02-05 Thread Alwin Antreich
'pveceph osd destroy --cleanup' When executing the command above, all disks associated with the OSD are at the moment wiped with dd (incl. separate disks with DB/WAL). The patch adds the ability to 'wipe_disks' to wipe the partition instead of the whole disk. Signed-of

[pve-devel] [PATCH manager v2] Fix #2051: preserve DB/WAL disk on destroy

2019-01-30 Thread Alwin Antreich
'pveceph osd destroy --cleanup' When executing the command above, all disks associated with the OSD are at the moment wiped with dd (incl. separate disks with DB/WAL). The patch adds the ability to 'wipe_disks' to wipe the partition instead of the whole disk. Signed-of

[pve-devel] [PATCH manager] Fix #2051: sub wipe_disks wipes partitions too

2019-01-21 Thread Alwin Antreich
s the sparate DB/WAL disks. Signed-off-by: Alwin Antreich --- PVE/API2/Ceph/OSD.pm | 8 +++- PVE/Ceph/Tools.pm| 20 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index b4dc277e..939958d9 100644 --- a/PVE/AP

[pve-devel] [PATCH proxmox-ve v2 3/3] Removed double wording in apthook message

2019-01-09 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- debian/apthook/pve-apt-hook | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index d49a2ce..0ec017d 100755 --- a/debian/apthook/pve-apt-hook +++ b/debian/apthook/pve-apt-hook @@ -58,7

[pve-devel] [PATCH proxmox-ve v2 2/3] Add a purge proxmox-ve to the warning message

2019-01-09 Thread Alwin Antreich
When the package proxmox-ve is not purged the apt config is still there and hinders further use of apt, as it complains about the missing hook. Signed-off-by: Alwin Antreich --- debian/apthook/pve-apt-hook | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/apthook/pve-apt-hook b/debian

[pve-devel] [PATCH proxmox-ve v2 1/3] change wording in apthook

2019-01-09 Thread Alwin Antreich
this patch removes the wording for the apt-get invocation in favour of only using apt. Signed-off-by: Alwin Antreich --- debian/apthook/pve-apt-hook | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index f925090

[pve-devel] [PATCH storage] Exclude general MON section in get_monaddr_list

2019-01-09 Thread Alwin Antreich
If a general MON section exists in the ceph.conf, the get_monaddr_list adds a undefined entry and a cephfs storage can't be mounted anymore. Signed-off-by: Alwin Antreich --- PVE/CephConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CephConfig.pm

Re: [pve-devel] [PATCH storage 0/2] Fix #2046 and disksize-mismatch with shared LVM

2019-01-04 Thread Alwin Antreich
On Fri, Jan 04, 2019 at 02:06:23PM +0100, Stoiko Ivanov wrote: > The issue was observed recently and can lead to potential dataloss. When using > a shared LVM storage (e.g. over iSCSI) in a clustered setup only the node, > where > a guest is active notices the size change upon disk-resize > (lvex

Re: [pve-devel] [PATCH proxmox-ve] Add a purge proxmox-ve to the warning message

2019-01-03 Thread Alwin Antreich
On Thu, Jan 03, 2019 at 09:30:38AM +0100, Wolfgang Bumiller wrote: > On Wed, Nov 28, 2018 at 12:39:15PM +0100, Alwin Antreich wrote: > > When the package proxmox-ve is not purged the apt config is still there and > > hinders further use of apt, as it complains about t

[pve-devel] [PATCH docs] Correction of the cephfs delete command

2018-12-10 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveceph.adoc b/pveceph.adoc index 48901aa..0e06b21 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -543,7 +543,7 @@ on each {pve} node hosting a MDS daemon. Then, you can remove

[pve-devel] [PATCH docs] Fix #2015: How to update ceph client packages only

2018-12-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pve-storage-cephfs.adoc | 2 ++ pveceph.adoc| 19 +++ 2 files changed, 21 insertions(+) diff --git a/pve-storage-cephfs.adoc b/pve-storage-cephfs.adoc index 5111ad1..3d495fc 100644 --- a/pve-storage-cephfs.adoc +++ b/pve-storage

[pve-devel] [PATCH docs] Fix #2015: Improve CephFS docs

2018-12-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- This does not address the package update yet. pve-storage-cephfs.adoc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/pve-storage-cephfs.adoc b/pve-storage-cephfs.adoc index b7f3f4d..5111ad1 100644 --- a/pve-storage-cephfs.adoc +++ b/pve-storage

[pve-devel] [PATCH storage] Fix #2019: CephFS storage misses maxfiles

2018-12-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/CephFSPlugin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Storage/CephFSPlugin.pm b/PVE/Storage/CephFSPlugin.pm index 1bfdd01..ebd6eec 100644 --- a/PVE/Storage/CephFSPlugin.pm +++ b/PVE/Storage/CephFSPlugin.pm @@ -118,6 +118,7 @@ sub

[pve-devel] [PATCH manager] Fix #2019: CephFS storage misses Max Backups

2018-12-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- www/manager6/storage/CephFSEdit.js | 13 - www/manager6/storage/RBDEdit.js| 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/www/manager6/storage/CephFSEdit.js b/www/manager6/storage/CephFSEdit.js index 0580e8fc..fff68b1d

Re: [pve-devel] [PATCH firewall 2/2] fix #2004: do not allow backwards ranges

2018-11-30 Thread Alwin Antreich
On Fri, Nov 30, 2018 at 09:53:50AM +0100, Dominik Csapak wrote: > ranges like 10:5 are allowed by us, but iptables throws an error > that is only visible in the syslog and the firewall rules do not > get updated > > Signed-off-by: Dominik Csapak > --- > src/PVE/Firewall.pm | 1 + > 1 file change

[pve-devel] [PATCH proxmox-ve] Add a purge proxmox-ve to the warning message

2018-11-28 Thread Alwin Antreich
When the package proxmox-ve is not purged the apt config is still there and hinders further use of apt, as it complains about the missing hook. Signed-off-by: Alwin Antreich --- debian/apthook/pve-apt-hook | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/apthook/pve-apt-hook b/debian

Re: [pve-devel] [PATCH docs] pveceph: add initial CephFS documentation

2018-11-28 Thread Alwin Antreich
+1 for the doc, but some suggestions inline. ;) On Wed, Nov 28, 2018 at 10:19:51AM +0100, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > pveceph.adoc | 115 +++ > 1 file changed, 115 insertions(+) > > diff --git a/pveceph.adoc b

[pve-devel] [PATCH docs] Update the default PG number to 128

2018-11-28 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 4132545..695af7e 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -284,10 +284,10 @@ A pool is a logical group for storing objects. It holds

[pve-devel] [PATCH manager] Raise the default pg_num to 128

2018-11-28 Thread Alwin Antreich
PGCalc and the ceph recommendation say 128 PGs for up to 5 OSDs Signed-off-by: Alwin Antreich --- PVE/API2/Ceph.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index d74bd016..f5b3a859 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2

[pve-devel] [PATCH manager v2] Factoring the wipe_disk out into CephTools

2018-11-27 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/API2/Ceph.pm | 9 +++-- PVE/CephTools.pm | 13 + 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index d74bd016..f9be80e4 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -312,6

[pve-devel] [PATCH manager] Add wipe_disk to createosd

2018-11-26 Thread Alwin Antreich
Factoring the wipe_disk out into CephTools Signed-off-by: Alwin Antreich --- PVE/API2/Ceph.pm | 11 +-- PVE/CephTools.pm | 11 +++ 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index d74bd016..ec9bce64 100644 --- a/PVE/API2

[pve-devel] [PATCH manager 0/2] MDS create/destroy & CephFS create

2018-11-14 Thread Alwin Antreich
eady, so I can include additions for a v2 with the API together. Thanks. Alwin Antreich (2): Create/destroy Ceph MDS Add createcephfs to pveceph PVE/API2/Makefile | 1 + PVE/API2/Ceph.pm | 6 ++ PVE/API2/CephFS.pm | 212 + PVE/CLI/pvecep

[pve-devel] [PATCH manager 1/2] Create/destroy Ceph MDS

2018-11-14 Thread Alwin Antreich
* introduce generic ceph service create/destroy methods * add API for createmds/destroymds * add createmds/destroymds to pveceph CLI Signed-off-by: Alwin Antreich --- PVE/API2/Makefile | 1 + PVE/API2/Ceph.pm | 6 +++ PVE/API2/CephFS.pm | 131

[pve-devel] [PATCH manager 2/2] Add createcephfs to pveceph

2018-11-14 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/API2/CephFS.pm | 81 ++ PVE/CLI/pveceph.pm | 1 + 2 files changed, 82 insertions(+) diff --git a/PVE/API2/CephFS.pm b/PVE/API2/CephFS.pm index b1c32b4f..fd4d7154 100644 --- a/PVE/API2/CephFS.pm +++ b/PVE

[pve-devel] [PATCH container v3] Close #1234: pct: implement rescan

2018-11-12 Thread Alwin Antreich
This patch implements the same feature as for qm 'rescan'. Signed-off-by: Alwin Antreich --- src/PVE/CLI/pct.pm | 34 + src/PVE/LXC.pm | 144 + 2 files changed, 178 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/s

<    1   2   3   4   >