[pve-devel] [PATCH xtermjs] termproxy: rewrite in rust

termproxy is now completely written in rust (instead of perl) but it is a drop-in replacement this contains all other necessary changes to the build-system for it to successfully build Signed-off-by: Dominik Csapak --- changelog needs to be adapted to have 'rust-termproxy' as src package

[pve-devel] [PATCH manager 1/1] ui: use ZFS components and functions from widget-toolkit

render_zfs_health is now in widget-toolkit as well as the 'MultiDiskSelector' and the Detailwindow and drop the now unnecessary classes Signed-off-by: Dominik Csapak --- www/manager6/Utils.js| 26 www/manager6/node/ZFS.js | 255 +-- 2 files changed

[pve-devel] [PATCH widget-toolkit 2/3] add form/MultiDiskSelector

from pve's ZFSCreate window, refactored to be self-contained using field mixin, as well as be configureable enough to be used by pve as well as other products Signed-off-by: Dominik Csapak --- src/Makefile | 1 + src/form/MultiDiskSelector.js | 164

[pve-devel] [PATCH widget-toolkit 3/3] add window/ZFSDetail

inspired by pve's detail window, which used two sub components (ZFSStatus, ZFSDevices; which were never used elsewhere) combined into one self-contained window Signed-off-by: Dominik Csapak --- src/Makefile| 1 + src/window/ZFSDetail.js | 152

[pve-devel] [PATCH widget-toolkit/manager] move/refactor ZFS related gui components into widget-toolkit

to be used outside of pve includes some refactor/rewriting, but the components are not that big, so it should be rather straightforward manager patches depend on widget-toolkit, but they do not conflict so we could apply manager sometime later proxmox-widget-toolkit: Dominik Csapak (3): Utils

[pve-devel] [PATCH widget-toolkit 1/3] Utils: add render_zfs_health

from pve-manager Signed-off-by: Dominik Csapak --- src/Utils.js | 25 + 1 file changed, 25 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index b5b1acb..d959dee 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -740,6 +740,31 @@ utilities: { return

[pve-devel] [PATCH manager] fix #2810: reset state of mounts array in initComponent

so that each new instance has an empty mounts list Signed-off-by: Dominik Csapak --- @fabian @oguz, i remembered that i know this issue and had a fix already^^ www/manager6/lxc/FeaturesEdit.js | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/www/manager6/lxc

Re: [pve-devel] [PATCH manager] ui: fw: Close #2815: Add warning if fw is disabled

Looks mosty ok, but i noticed two things: 1. We use this grid also on datacenter and node level, so we should adapt the message for those somehow 2. is inline On 6/23/20 11:31 AM, Dominic Jäger wrote: Currently people add firewall rules but forget to activate the firewall on guest level.

Re: [pve-devel] [PATCH qemu-server] vncproxy: allow to request a generated VNC password

the node where the api call is made is always the local node (tunneling is over ssh) but since it really does not matter if we do it at all, we can simply omit the novnc patch for now and leave it optional Tested-By: Dominik Csapak Reviewed-By: Dominik Csapak On 6/18/20 6:20 PM, Thomas Lamprecht

Re: [pve-devel] [PATCH widget-toolkit v2 3/4] TaskViewer: show endtime and duration in status

On 6/16/20 11:19 AM, Thomas Lamprecht wrote: Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: but only when the caller gives us the endtime, since the status api call does not give us the endtime Signed-off-by: Dominik Csapak --- changes from v1: * always show duration and calculate the endtime

[pve-devel] [PATCH widget-toolkit/manager] move diskrelated code to widget-toolkti

so that we can reuse it. where applicable i refactored some code or added some mappings/properties, but nothing substantial proxmox-widget-toolkit: Dominik Csapak (2): add DiskSelector from PVE add DiskSmart window and DiskList from PVE src/Makefile | 3 + src/form

[pve-devel] [PATCH manager 1/2] ui: use pmxDiskSelector from widget-toolkit

Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 - www/manager6/ceph/OSD.js | 6 +-- www/manager6/form/DiskSelector.js | 80 --- www/manager6/node/Directory.js| 2 +- www/manager6/node/LVM.js | 2 +- www/manager6/node

[pve-devel] [PATCH widget-toolkit 1/2] add DiskSelector from PVE

to be usable with other products. also add a parameter 'typeProperty' to be able to configure the backend property for the usage type Signed-off-by: Dominik Csapak --- src/Makefile | 1 + src/form/DiskSelector.js | 80 2 files changed, 81

[pve-devel] [PATCH widget-toolkit 2/2] add DiskSmart window and DiskList from PVE

window) Signed-off-by: Dominik Csapak --- src/Makefile| 2 + src/grid/DiskList.js| 233 src/window/DiskSmart.js | 133 +++ 3 files changed, 368 insertions(+) create mode 100644 src/grid/DiskList.js create mode 100644 src

[pve-devel] [PATCH manager 2/2] ui: use pmxDiskList from widget-toolkit

Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 - www/manager6/node/Config.js | 3 +- www/manager6/node/Disks.js | 387 3 files changed, 2 insertions(+), 389 deletions(-) delete mode 100644 www/manager6/node/Disks.js diff --git a/www

[pve-devel] [PATCH widget-toolkit v2 2/4] show Task warnings differently

tasks can now show also 'WARNINGS: ' filter it out and provide a 'parse_task_status' function for easy reuse Signed-off-by: Dominik Csapak --- src/Utils.js | 17 + src/css/ext6-pmx.css | 4 src/node/Tasks.js| 22 -- 3 files changed, 37

[pve-devel] [PATCH widget-toolkit v2 3/4] TaskViewer: show endtime and duration in status

but only when the caller gives us the endtime, since the status api call does not give us the endtime Signed-off-by: Dominik Csapak --- changes from v1: * always show duration and calculate the endtime from 'now' src/node/Tasks.js| 1 + src/window/TaskViewer.js | 25

[pve-devel] [PATCH widget-toolkit v2 1/4] ProxmoxProxy: add duration fields for proxmox-tasks

Signed-off-by: Dominik Csapak --- changes from v1: * do not truncate the decimal places src/data/ProxmoxProxy.js | 12 1 file changed, 12 insertions(+) diff --git a/src/data/ProxmoxProxy.js b/src/data/ProxmoxProxy.js index 53e92f3..7df8f28 100644 --- a/src/data/ProxmoxProxy.js

[pve-devel] [PATCH widget-toolkit v2 4/4] format_duration_human: say <0.1s instead of 0s

if we get a duration of <=0.1s it should actually be somewhere betweeen 0 and 0.1 so return <0.1s Signed-off-by: Dominik Csapak --- changes from v1: * change <1s to <0.1s which is more inline with our normal display (e.g. 1.5s) src/Utils.js | 4 ++-- 1 file changed, 2 inse

[pve-devel] [PATCH widget-toolkit 2/4] show Task warnings differently

tasks can now show also 'WARNINGS: ' filter it out and provide a 'parse_task_status' function for easy reuse Signed-off-by: Dominik Csapak --- src/Utils.js | 17 + src/css/ext6-pmx.css | 4 src/node/Tasks.js| 22 -- 3 files changed, 37

[pve-devel] [PATCH widget-toolkit 4/4] format_duration_human: say <1s instead of 0s

if we get a duration of <=0s it should actually be somewhere betweeen 0 and 1s so return <1s Signed-off-by: Dominik Csapak --- src/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Utils.js b/src/Utils.js index 2163794..a914795 100644 --- a/src/Utils.js +++

[pve-devel] [PATCH widget-toolkit 3/4] TaskViewer: show endtime and duration in status

but only when the caller gives us the endtime, since the status api call does not give us the endtime Signed-off-by: Dominik Csapak --- src/node/Tasks.js| 1 + src/window/TaskViewer.js | 23 +++ 2 files changed, 24 insertions(+) diff --git a/src/node/Tasks.js b/src

[pve-devel] [PATCH widget-toolkit 1/4] ProxmoxProxy: add duration fields for proxmox-tasks

Signed-off-by: Dominik Csapak --- src/data/ProxmoxProxy.js | 12 1 file changed, 12 insertions(+) diff --git a/src/data/ProxmoxProxy.js b/src/data/ProxmoxProxy.js index 53e92f3..40fdc08 100644 --- a/src/data/ProxmoxProxy.js +++ b/src/data/ProxmoxProxy.js @@ -43,6 +43,18

[pve-devel] [PATCH widget-toolkit] button: make xtype of parent configurable

to get the selection model of the parent, we use by default the xtype 'grid', but sometimes we want to use something else (e.g. 'treepanel') to be flexible we make this configurable Signed-off-by: Dominik Csapak --- we could of course fall back to 'treepanel' directly in the code if thats

[pve-devel] [PATCH http-server 2/2] fix post if variable declaration

Signed-off-by: Dominik Csapak --- PVE/APIServer/AnyEvent.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm index e5f2cb4..efb8168 100644 --- a/PVE/APIServer/AnyEvent.pm +++ b/PVE/APIServer/AnyEvent.pm @@ -1322,7 +1322,8

[pve-devel] [PATCH http-server 1/2] fix #2766: allow application/json as content-type for post/put requests

this makes creating an api client much nicer Signed-off-by: Dominik Csapak --- PVE/APIServer/AnyEvent.pm | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm index 3d755d4..e5f2cb4 100644 --- a/PVE/APIServer

[pve-devel] [PATCH manager] ui: add checkbox for vmid filter for backupview

instead of hardcoding the text 'type-id-' into the searchbar to accomodate for the additional size, add an overflowHandler to the toolbar (for very small display sizes) Signed-off-by: Dominik Csapak --- www/manager6/grid/BackupView.js | 49 ++--- 1 file changed, 39

[pve-devel] [PATCH manager 1/2] ui: fix missing change from 'pve-' to 'pmx-' models

we forgot to change these Signed-off-by: Dominik Csapak --- www/manager6/dc/AuthView.js | 2 +- www/manager6/dc/RoleView.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc/AuthView.js b/www/manager6/dc/AuthView.js index 3e5a8517..bb5ec851 100644 --- a/www

[pve-devel] [PATCH manager 2/2] ui: fix HotplugFeatureSelector

we recently changed the setValue behaviour of the inputpanel and editwindow (we now set all fields with the same names), which leads to wrong behaviour here use a different name for the internal checkboxes to avoid this Signed-off-by: Dominik Csapak --- www/manager6/form

[pve-devel] [PATCH widget-toolkit/manager] some refactorings

just moving things to widget-toolkit manager patches need the toolkit ones, but they are not breaking manager proxmox-widget-toolkit: Dominik Csapak (2): Utils: add duration format/render css: add icon colors Utils.js | 27 +++ css/ext6-pmx.css | 25

[pve-devel] [PATCH manager 1/2] ui: Replication: use render_duration from widget-toolkit

Signed-off-by: Dominik Csapak --- www/manager6/Utils.js| 27 --- www/manager6/grid/Replication.js | 2 +- 2 files changed, 1 insertion(+), 28 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 676f56a8..5c81d7f8 100644 --- a/www

[pve-devel] [PATCH widget-toolkit 1/2] Utils: add duration format/render

from pve-manager Signed-off-by: Dominik Csapak --- Utils.js | 27 +++ 1 file changed, 27 insertions(+) diff --git a/Utils.js b/Utils.js index 56b1c9a..328164d 100644 --- a/Utils.js +++ b/Utils.js @@ -145,6 +145,26 @@ Ext.define('Proxmox.Utils', { utilities

[pve-devel] [PATCH manager 2/2] css: remove icon colors

they are now in the widget-toolkit Signed-off-by: Dominik Csapak --- www/css/ext6-pve.css | 25 - 1 file changed, 25 deletions(-) diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index 4294f659..8f0407df 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6

[pve-devel] [PATCH widget-toolkit 2/2] css: add icon colors

from pve-manager Signed-off-by: Dominik Csapak --- css/ext6-pmx.css | 25 + 1 file changed, 25 insertions(+) diff --git a/css/ext6-pmx.css b/css/ext6-pmx.css index 9b15392..37ee6aa 100644 --- a/css/ext6-pmx.css +++ b/css/ext6-pmx.css @@ -13,3 +13,28 @@ .proxmox-invalid

Re: [pve-devel] [RFC manager 2/2] hardware view: Add disk import button

sry for the delay of the review a few comments inline On 5/22/20 12:08 PM, Dominic Jäger wrote: Is it a bad idea to move column2 as I did here? Seems strange to have column1 and 2 so different but I haven't found an easier way to make it available to the subclass yet. @Thomas Is this sort

[pve-devel] [PATCH widget-toolkit] improve error extraction for monStoreErrors

by printing the whole error body when it cannot be parsed as JSON Signed-off-by: Dominik Csapak --- Utils.js | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/Utils.js b/Utils.js index 33c9b77..56b1c9a 100644 --- a/Utils.js +++ b/Utils.js @@ -244,17 +244,22

[pve-devel] [PATCH widget-toolkit] return cookie again in authOK

the calling code did require that authOK returns the cookie if there is a valid one make it now very explicit that the cookie gets returned instead of using implicit short-circuit behaviour Signed-off-by: Dominik Csapak --- Utils.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion

[pve-devel] [PATCH widget-toolkit] fix #2758: reject 'tfa' cookies

return false on authOK when the ticket is a tfa ticket (starts with PVE:tfa!) when a user now loads the page with only a tfa ticket, it shows the login window again Signed-off-by: Dominik Csapak --- Utils.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Utils.js b

[pve-devel] [PATCH widget-toolkit 1/1] add pmxRoleSelector

copied+refactored from pve-manager for use with other projects also show privs now in the combobox Signed-off-by: Dominik Csapak --- Makefile | 1 + form/RoleSelector.js | 41 + 2 files changed, 42 insertions(+) create mode 100644 form

[pve-devel] [PATCH manager 2/2] use RealmCombobox from widget-toolkit

Signed-off-by: Dominik Csapak --- www/manager6/dc/UserEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js index 692eb277..584fe19f 100644 --- a/www/manager6/dc/UserEdit.js +++ b/www/manager6/dc/UserEdit.js

[pve-devel] [PATCH manager 1/2] ui: use RoleSelector from widget-toolkit

Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 - www/manager6/dc/ACLView.js| 2 +- www/manager6/form/RoleSelector.js | 50 --- 3 files changed, 1 insertion(+), 52 deletions(-) delete mode 100644 www/manager6/form/RoleSelector.js

[pve-devel] [PATCH widget-toolkit/manager] move RoleSelector to widget-toolkit

for use in other projects also fixes a missing rename of the RealmCombobox in dc/UserEdit (manager 2/2) proxmox-widget-toolkit: Dominik Csapak (1): add pmxRoleSelector Makefile | 1 + form/RoleSelector.js | 41 + 2 files changed, 42

[pve-devel] [PATCH manager 2/2] ui: remove Realm model and RealmComboBox

and use it from widget-toolkit Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 2 - www/manager6/data/model/Realm.js | 30 -- www/manager6/form/RealmComboBox.js | 65 -- www/manager6/window/LoginWindow.js | 2 +- 4 files changed

[pve-devel] [PATCH widget-toolkit 2/3] add PMX.image.Logo

copied from pmg-gui, adapted to be able to set a custom url prefix when we want to use something other than '/pve2' Signed-off-by: Dominik Csapak --- Logo.js | 21 + Makefile | 1 + 2 files changed, 22 insertions(+) create mode 100644 Logo.js diff --git a/Logo.js b

[pve-devel] [PATCH manager 1/2] ui: use PMX.image.Logo from widget-toolkit

Signed-off-by: Dominik Csapak --- www/manager6/Workspace.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 57cb1bb9..8d224f5b 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js @@ -307,8 +307,7

[pve-devel] [PATCH widget-toolkit 1/3] window/Edit: read digest also from top level response

we want to have the digest in the top level object, like: { data: { /* the real data */ }, digest: "fa123asf123123123", // the digest } instead of in the data itself, so read it preferably from there (with fallback to stay compatible) Signed-off-by: Dominik Csapak --- wind

[pve-devel] [PATCH pmg-gui 1/1] remove Logo.js

it is now in the widget-toolkit Signed-off-by: Dominik Csapak --- js/Logo.js | 14 -- js/Makefile | 1 - 2 files changed, 15 deletions(-) delete mode 100644 js/Logo.js diff --git a/js/Logo.js b/js/Logo.js deleted file mode 100644 index 96ec14b..000 --- a/js/Logo.js +++ /dev

[pve-devel] [PATCH widget-toolkit 3/3] add Realm model and RealmComboBox

copied from pve-manager, with adaptions for modern js (let, parameter destructuring,...) and dropped the not needed 'needOTP' method Signed-off-by: Dominik Csapak --- Makefile | 2 ++ data/model/Realm.js | 29 ++ form/RealmComboBox.js | 57

[pve-devel] [RFC PATCH manager] ui: ACMEAccountCreate: improve layout of account dialog

by increasing the space for the link, and using a boxLabel instead of fieldLabel, which has better spacing for longer text also move the e-mail before the directory to have all textboxes together Signed-off-by: Dominik Csapak --- not really sure if it looks good now, but the current layout

[pve-devel] [PATCH stable-5 manager 3/3] pve5to6: add check for ovmf vms with potentially broken efi disk

we wrongly mapped some efidisks into the vm, and fixed it in pve6 this potentially needs manual intervention, so warn the user about which vms might be affected Signed-off-by: Dominik Csapak --- PVE/CLI/pve5to6.pm | 35 +++ 1 file changed, 35 insertions(+) diff

[pve-devel] [PATCH stable-5 manager 2/3] pve5to6: add check for stock debian kernel package

on current debian buster, stock kernel images recommend firmware-linux-free which conflict with our pve-firmware package which leads to apt wanting to remove promxox-ve check for the meta package in the update check script Signed-off-by: Dominik Csapak --- PVE/CLI/pve5to6.pm | 14

[pve-devel] [PATCH stable-5 manager 1/3] ui: fix missing htmlEncodes

username can include some special characters, so we have to escape them backport from pve6 Signed-off-by: Dominik Csapak --- www/manager6/Workspace.js | 2 +- www/manager6/dc/ACLView.js| 2 +- www/manager6/dc/Log.js| 2 ++ www/manager6/dc/TFAEdit.js| 1

[pve-devel] [PATCH manager] ui: dc/ACME: fix not refreshing api column

When using a diffstore, we have to specify all fields that are displayed, otherwise the store does not know which fields to check for change for the acme plugin view, 'api' was missing Signed-off-by: Dominik Csapak --- www/manager6/dc/ACMEClusterView.js | 2 +- 1 file changed, 1 insertion

[pve-devel] [PATCH docs] pveum.adoc: use correct cli command for realm sync

Signed-off-by: Dominik Csapak --- pveum.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveum.adoc b/pveum.adoc index 8f229a6..0057564 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -178,7 +178,7 @@ It is possible to sync users and groups for LDAP based realms. You can use

[pve-devel] [PATCH access-control] LDAP: skip anonymous bind when clientcert/key is given

_dn, but it is not really clear if Net::LDAP does this automatically when searching (other libraries do this), so leave the anonymous bind (for compatibility with PMG) but skip it when a client certificate and key is given. Signed-off-by: Dominik Csapak --- PVE/Auth/LDAP.pm | 14 +++--- 1 file changed

[pve-devel] [PATCH manager] dc/Realms: fix adding of new ldap realm

we cannot pass 'delete' on create api call, and we have to make sure that 'default_opts' and 'sync_attributes' are alwyas available, since they are used in onGetValues (they were only created during setValues, which is not called when adding a new realm) Signed-off-by: Dominik Csapak --- www

[pve-devel] [PATCH manager 1/3] ui: ACMEAccountCreate: make name only optional if no default exists

if the 'default' account exists, make the name field required and remove the emptytext get the information by querying the grid store. this may be not up-to-date, but it is less intrusive that an extra api call that blocks the window Signed-off-by: Dominik Csapak --- www/manager6/dc

[pve-devel] [PATCH manager 2/3] ui: dc/ACMEClusterView: load the correct store on reload

if we use a diff/update store combo, we have to load the updatestore not the diff store, else we get spurious empty grids Signed-off-by: Dominik Csapak --- www/manager6/dc/ACMEClusterView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/dc

[pve-devel] [PATCH manager 3/3] ui: dc/ACMEClusterView: show TaskProgress on account removal

this is not a synchronous api call, so open a taskprogress window and reload after the task is done Signed-off-by: Dominik Csapak --- www/manager6/dc/ACMEClusterView.js | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/ACMEClusterView.js b/www

Re: [pve-devel] [PATCH manager 3/7] ui: dc/ACMEClusterView: use a diff/update store combo for the grids

On 5/7/20 1:08 PM, Thomas Lamprecht wrote: On 5/7/20 10:27 AM, Dominik Csapak wrote: so that they are get automatically reloaded with the default interval (3seconds) Signed-off-by: Dominik Csapak --- this patch needs the widget-toolkit patches applied we can of course leave those out

[pve-devel] [PATCH manager 2/7] ui: ACME: add emptyText and add minHeight

without the minHeight, the panel does resize weirdly on the first load Signed-off-by: Dominik Csapak --- www/manager6/dc/ACMEClusterView.js | 6 ++ www/manager6/node/ACME.js | 2 ++ 2 files changed, 8 insertions(+) diff --git a/www/manager6/dc/ACMEClusterView.js b/www/manager6/dc

[pve-devel] [PATCH manager 1/7] NodeConfig/get_acme_conf: make domains always a hash

on all call sites, we assume $cfg->{domains} is a hash, but if we do not have any domains configured, that fails with 'Can't use an undefined value as a HASH reference at ...' so always make domains a hash to avoid this Signed-off-by: Dominik Csapak --- PVE/NodeConfig.pm | 1 + 1 file chan

[pve-devel] [PATCH manager 4/7] ui: node/ACME: fix some eslint errors/warnings

* unneeded brackets for arrow function * unused variables * me not defined * trailing commas Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js

[pve-devel] [PATCH widget-toolkit 1/2] data/DiffStore: add autoDestroyRstore flag

when this flag is set, the diffstore will automatically try to destroy the rstore when it is destroyed itself for this we have to move the rstore into the object (instead of using a closure) Signed-off-by: Dominik Csapak --- data/DiffStore.js | 26 +- 1 file changed, 21

[pve-devel] [PATCH manager 6/7] ui: node/ACME: only enable order button when it should work

ist, or no account exists at all we set 'account' to 'null') Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index 1e91be4e..d21d18e4 100644 --- a/www/manager6/n

[pve-devel] [PATCH widget-toolkit 2/2] data/DiffStore: auto-create the rstore if its just a config

', model: 'some-model', autoStart: true, interval: 5000, }, }, the only thing we have to be careful about is to either do a manual 'stopUpdate' somewhere, or use the 'autoDestroyRstore' flag Signed-off-by: Dominik Csapak --- we might want to set the 'autoDestroyRstore

[pve-devel] [PATCH widget-toolkit/manager] fixups for ACME UI

ger needs the widget-toolkit patches applied, but all others do not need them proxmox-widget-toolkit: Dominik Csapak (2): data/DiffStore: add autoDestroyRstore flag data/DiffStore: auto-create the rstore if its just a config data/DiffStore.js | 35 +-- 1 f

[pve-devel] [PATCH manager 5/7] ui: node/ACME: use accountselector for verification

instead of using API2Request manually, just reload the store of the accountselector and check if the configured account is in it this should fix the spurious loading mask of the panel when loading the accounts Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 23

[pve-devel] [PATCH manager 7/7] ui: node/{ACME, Certificates}: add stopUpdate on destruction

else the stores never stop updating Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 1 + www/manager6/node/Certificates.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index d21d18e4..0418f406 100644 --- a/www

[pve-devel] [PATCH manager 3/7] ui: dc/ACMEClusterView: use a diff/update store combo for the grids

so that they are get automatically reloaded with the default interval (3seconds) Signed-off-by: Dominik Csapak --- this patch needs the widget-toolkit patches applied we can of course leave those out, and to it manually in initComponent, but this is a pattern we often use and maybe we can remove

Re: [pve-devel] [PATCH manager v2 0/5] ACME node adaptions for plugins

On 5/6/20 8:11 PM, Thomas Lamprecht wrote: On 5/6/20 4:31 PM, Dominik Csapak wrote: this series adapts the node->certificates->acme panel to include an 'accountselector' and to be able to add/edit/remove single domains, including ones with a plugin changes from v1: * drop fiel

[pve-devel] [PATCH manager v2 2/5] ui: Parser: add printACME

since we decode the domain list in parseACME into an array, we have to join them again to a string when printing otherwise printPropertyString attaches them just with ',' which does not work here Signed-off-by: Dominik Csapak --- www/manager6/Parser.js | 7 +++ 1 file changed, 7 insertions

[pve-devel] [PATCH manager v2 4/5] ui: node/ACME: add ACMEDomainEdit

, the type field gets invalid (with a error tooltip) the onGetValues method is non-trivial, because of the mixing of acmedomainX and acme.domain values, so we have to be careful that we delete/edit the correct entry Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 136

[pve-devel] [PATCH manager v2 5/5] ui: node/ACME: rework ACME grid for plugin based domains

also add an AccountSelector to the tbar and a link to the datacenter->acme panel (when there is no account) this also removes the 'register account' and 'view account' buttons, since those are now available in datacenter->acme Signed-off-by: Dominik Csapak --- changes from v1: * dif

[pve-devel] [PATCH manager v2 3/5] ui: Utils: add helper functions for acme domains

to convieniently add and remove domains from a parsed ACME object they also make domains unique in the array also add the count of configureable acmedomainX entries Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 23 +++ 1 file changed, 23 insertions(+) diff

[pve-devel] [PATCH manager v2 1/5] ui: add ACME selector formfields for account and plugins

filter the plugins by type === 'dns' and add a convenience method for ACMEAccountSelector to check if there are any accounts Signed-off-by: Dominik Csapak --- changes from v1: * drop fieldLabel in ACMEAccountSelector www/manager6/Makefile| 2 ++ www/manager6/form

[pve-devel] [PATCH manager v2 0/5] ACME node adaptions for plugins

change the account (use viewModel and a displayfield/combobox/editbutton to better see when the account actually changes) Dominik Csapak (5): ui: add ACME selector formfields for account and plugins ui: Parser: add printACME ui: Utils: add helper functions for acme domains ui: node/ACM

[pve-devel] [PATCH manager 1/5] ui: add ACME selector formfields for account and plugins

filter the plugins by type === 'dns' and add a convenience method for ACMEAccountSelector to check if there are any accounts Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 2 ++ www/manager6/form/ACMEAccountSelector.js | 22 ++ www/manager6

[pve-devel] [PATCH manager 0/5] ACME node adaptions for plugins

this series adapts the node->certificates->acme panel to include an 'accountselector' and to be able to add/edit/remove single domains, including ones with a plugin Dominik Csapak (5): ui: add ACME selector formfields for account and plugins ui: Parser: add printACME ui: Utils: add

[pve-devel] [PATCH manager 3/5] ui: Utils: add helper functions for acme domains

to convieniently add and remove domains from a parsed ACME object they also make domains unique in the array also add the count of configureable acmedomainX entries Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 23 +++ 1 file changed, 23 insertions(+) diff

[pve-devel] [PATCH manager 2/5] ui: Parser: add printACME

since we decode the domain list in parseACME into an array, we have to join them again to a string when printing otherwise printPropertyString attaches them just with ',' which does not work here Signed-off-by: Dominik Csapak --- www/manager6/Parser.js | 7 +++ 1 file changed, 7 insertions

[pve-devel] [PATCH manager 4/5] ui: node/ACME: add ACMEDomainEdit

, the type field gets invalid (with a error tooltip) the onGetValues method is non-trivial, because of the mixing of acmedomainX and acme.domain values, so we have to be careful that we delete/edit the correct entry Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 136

[pve-devel] [PATCH manager 5/5] ui: node/ACME: rework ACME grid for plugin based domains

ed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 420 +++--- 1 file changed, 254 insertions(+), 166 deletions(-) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index a8bb39d6..f6499d6e 100644 --- a/www/manager6/node/ACME.js +++ b/www/ma

[pve-devel] [PATCH manager 1/6] ACMEPlugin: check digest on update

and extract the param, otherwise the check dies because of an unknown field 'digest' Signed-off-by: Dominik Csapak --- PVE/API2/ACMEPlugin.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/ACMEPlugin.pm b/PVE/API2/ACMEPlugin.pm index 92e0dfb6..71f53a35 100644 --- a/PVE/API2

[pve-devel] [PATCH 1/2] DNSChallenge: make plugins a hash with an optional schema

so that we can use that schema to generate form fields in the gui Signed-off-by: Dominik Csapak --- src/PVE/ACME/DNSChallenge.pm | 235 --- 1 file changed, 132 insertions(+), 103 deletions(-) diff --git a/src/PVE/ACME/DNSChallenge.pm b/src/PVE/ACME

[pve-devel] [PATCH 2/2] add note that the data has to be base64 encoded

but only via api, on the cli it is a file which contains the data in plaintext Signed-off-by: Dominik Csapak --- src/PVE/ACME/DNSChallenge.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/ACME/DNSChallenge.pm b/src/PVE/ACME/DNSChallenge.pm index 8a393f4..534922d

[pve-devel] [PATCH proxmox-acme/pve-manager] add crud for acme accounts/plugin

this series adds the gui (and necessary api calls) for adding/editing/deleting acme accounts and plugins gui parts still missing are: * changing the account on the node * selecting a plugin for a domain proxmox-acme: Dominik Csapak (2): DNSChallenge: make plugins a hash with an optional

[pve-devel] [PATCH manager 6/6] ui: add ACMEClusterView

to show the list of accounts and defined plugins for now we ignore 'standalone' plugins here and only show 'dns' ones Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/dc/ACMEClusterView.js | 206 + www/manager6/dc/Config.js

[pve-devel] [PATCH manager 2/6] ACME: add challengeschema api call

which returns a list of challenge api types with the schema of their required data (if it exists) Signed-off-by: Dominik Csapak --- PVE/API2/ACMEAccount.pm | 55 + 1 file changed, 55 insertions(+) diff --git a/PVE/API2/ACMEAccount.pm b/PVE/API2

[pve-devel] [PATCH manager 4/6] ui: add ACMEAPiSelector field

which return all api types from /cluster/acme/challengeschema and has a convenience method for getting the schema of the current value Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/form/ACMEAPiSelector.js | 40 2 files

[pve-devel] [PATCH manager 5/6] ui: add ACMEPluginEdit window

with/from the generic 'data' field (so that if a plugin has some extra fields that we did not include in the schema the user can still enter them) Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/Parser.js| 17 ++- www/manager6/dc

[pve-devel] [PATCH manager 3/6] ui: ACMEAccountCreate: add optional name field

so that we can create multiple accounts, but leave it empty and set the emptyText to the default name 'default' Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 7 +++ 1 file changed, 7 insertions(+) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index

[pve-devel] [PATCH docs v3] add documenation for ldap syncing

explaining the main Requirements and limitations, as well as the most important sync options Signed-off-by: Dominik Csapak --- changes from v2: * incorporated suggestions from aaron @aaron, regarding linking to character limitations, sadly no, this is a sub based format, so even if we would have

[pve-devel] [PATCH manager] ui: fix missing htmlEncodes

username can include some special characters, so we have to escape them Signed-off-by: Dominik Csapak --- www/manager6/Workspace.js | 2 +- www/manager6/dc/ACLView.js | 2 +- www/manager6/dc/GroupView.js | 1 + www/manager6/dc/Log.js | 2 ++ www/manager6/dc

[pve-devel] [PATCH widget-toolkit] add missing htmlEncodes

username can include some special characters, so we have to escape them Signed-off-by: Dominik Csapak --- window/TaskViewer.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/window/TaskViewer.js b/window/TaskViewer.js index 347542e..bbbf716 100644 --- a/window

[pve-devel] [PATCH docs v2] add documenation for ldap syncing

explaining the main Requirements and limitations, as well as the most important sync options Signed-off-by: Dominik Csapak --- changes from v1: * incorporated suggestions from Alwin, thanks :) * re-worded the sentence about limitations to specify the character limitations of user.cfg

Re: [pve-devel] [PATCH manager 2/3] Allow setting targetstorage for offline migration

On 4/30/20 1:15 PM, Fabian Ebner wrote: Let's make this one an RFC ;) The problem is that offline migration with target storage might not always work depending on supported export/import formats. Then users might start an offline migration, which then fails after a few disks have already

Re: [pve-devel] [PATCH manager 1/3] Don't show empty parentheses when size is not known

one comment inline On 4/30/20 12:59 PM, Fabian Ebner wrote: The size of VM state files and the size of unused disks not referenced by any snapshot is not saved in the VM configuration, so it's not available here either. Signed-off-by: Fabian Ebner --- www/manager6/window/Migrate.js | 2 +-

[pve-devel] [PATCH manager] ui: dc/SyncWindow: add help button

with link to the LDAP Syncing section of the documentation Signed-off-by: Dominik Csapak --- www/manager6/dc/SyncWindow.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/dc/SyncWindow.js b/www/manager6/dc/SyncWindow.js index e85e5b88..9355c551 100644 --- a/www/manager6

[pve-devel] [PATCH docs] add documenation for ldap syncing

explaining the main Requirements and limitations, as well as the most important sync options Signed-off-by: Dominik Csapak --- pveum.adoc | 47 +++ 1 file changed, 47 insertions(+) diff --git a/pveum.adoc b/pveum.adoc index c89d4b8..5881fa9 100644

  1   2   3   4   5   6   7   8   9   10   >