this will be used for the dashboard to show outdated services/osds
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 4
1 file changed, 4 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 67e461f5..87457078 100644
--- a/www/manager6/Utils.js
+++ b/www
and use the cluster wide api call if no nodename is given
Signed-off-by: Dominik Csapak
---
www/manager6/ceph/Status.js | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js
index 78b6c925..8ab74ab3 100644
will be handled in ceph/Services.js
Signed-off-by: Dominik Csapak
---
www/manager6/ceph/StatusDetail.js | 144 +-
1 file changed, 2 insertions(+), 142 deletions(-)
diff --git a/www/manager6/ceph/StatusDetail.js
b/www/manager6/ceph/StatusDetail.js
index
this way, we can control if we want to fire the 'statechanged' event
when we set a value in the stateprovider
Signed-off-by: Dominik Csapak
---
www/manager6/StateProvider.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/StateProvider.js b/www/manager6
filesystem about the services,
as well as the 'ceph YYY metadata' info we get from ceph.
with this info we can convieniently display which services exists,
which are running and which versions they have
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 115
so that we have a list of all existing ceph services in the cluster
Signed-off-by: Dominik Csapak
---
PVE/Service/pvestatd.pm | 28
1 file changed, 28 insertions(+)
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index ce2adbbd..6cbd59fb 100755
returns html code for a ceph health icon, will be used in Services.js
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 9 +
1 file changed, 9 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 87457078..a159445b 100644
--- a/www/manager6/Utils.js
Also we do not have a bounty program (or similar), but if you
can find something that is willing to implement it for you
s/something/someone/
of course :)
___
pve-devel mailing list
pve-devel@pve.proxmox.com
in 'broadcast_node_kv' we send the status and make sure its always
a scalar so it gets send as a null terminated string via pack(Z*)
when we get it back from pmxcfs we have to unpack(Z*) again, or
we get a string with a trailing '\0'
Signed-off-by: Dominik Csapak
---
data/PVE/Cluster.pm | 2
beforehand.
(To avoid unnecessary work and patch revisions)
Thanks,
Victor
I hope i could help you
Regards,
Dominik
0: https://git.proxmox.com/?p=pve-docs.git;a=summary
1: https://pve.proxmox.com/wiki/Developer_Documentation
2: https://bugzilla.proxmox.com
On Fri, May 24, 2019 at 6:49 PM Domin
On 5/24/19 9:52 AM, Thomas Lamprecht wrote:
On 5/24/19 9:36 AM, Fabian Grünbichler wrote:
On Fri, May 24, 2019 at 08:24:17AM +0200, Dominik Csapak wrote:
LGTM, i introduced this seemingly sometime last year... (oops)
the question remains why it sometimes takes so long for a rename
hi,
i now tested it successfully
my /etc/pve/domains.cfg looks like this:
8<
ldap: google
base_dn dc=anguslab,dc=io
server1 ldap.google.com
user_attr uid
verify 1
cert /root/google.crt
certkey /root/google.key
default 0
LGTM, i introduced this seemingly sometime last year... (oops)
the question remains why it sometimes takes so long for a rename to
be propagated
in my opinion this violates the assumptions we make regarding ownership
of files/vms since it seems here that nobody own the vm when this happens
(the
On 5/23/19 5:46 PM, Victor Hooi wrote:
G Suite also has audit records for the Secure LDAP service:
https://i.imgur.com/rvV9BXL.png
In this case - I can see entries for each time I used ldapsearch.
However, I do *not* see any entries for each time I try to login on
Proxmox. So it seems like
On 5/23/19 1:11 PM, Victor Hooi wrote:
Hi,
I thought I'd try setting the "secure" value to true:
```
# pvesh create /access/domains --realm anguslab.io --type ldap --base_dn
dc=anguslab,dc=io --server1 ldap.google.com --port 636 --cert
/root/Google_2022_05_22_3494.crt --certkey /root/Google_20
On 5/23/19 6:34 AM, Victor Hooi wrote:
*(Sending again with screenshots removed)*
Hi,
Hi,
Aha, I am glad to know it's meant to work out of the box - I merely had
some concerns around support for LDAP certificate authentication (forum post
On 5/22/19 3:16 AM, Victor Hooi wrote:
Hi,
Hi,
I'm interested in getting Proxmox's LDAP integrated with the Secure LDAP
feature from G Suite.
Does anybody know how difficult this would be, or what would be involved?
As far as i can see from their guide[0], this should generally work
out
first of all, great that you include tests :) +1
second, i am not really happy with the approach, since it
is quite a bit of code, for not that much gain
On 5/14/19 12:20 PM, Dominic Jäger wrote:
When creating a backup the log for a single job can be to big to be
transferred by mail. To ensure
similar to how we handle the cluster wide tasklist and rrd data,
have an interface that can sync data across the cluster
this data is only transient and will not be written to disk
we can use this for a number of things, e.g. listing ceph services
across the cluster, etc.
Signed-off-by: Dominik
this series add a new generic interface to broadcast (transient) data
to the cluster members
Dominik Csapak (2):
pmxcfs: make status entry removable
add generic data broadcast interface
data/PVE/Cluster.pm | 54 +
data/src/status.c | 4
we can now do a CFS_IPC_SET_STATUS with no data, which results in
removal of the entry in the kv entries
Signed-off-by: Dominik Csapak
---
new in v4
data/PVE/Cluster.pm | 6 ++
data/src/status.c | 4 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/data/PVE/Cluster.pm b
i would really like to have some kind of multiselect combobox instead
of 4+ new checkboxes
On 5/15/19 6:15 PM, Oguz Bektas wrote:
adds atime related options (noatime, nodiratime, relatime,
strictatime) and other extra mount options for performance (nobarrier) and
security (noexec, nosuid,
hmm, i am not sure if we want to add a seperate option for each one?
maybe it would be better to have one 'mountoptions' option
that is a ';' seperated list like the qemu cpu flags?
@Wolfgang, @Thomas what do you say?
On 5/15/19 6:15 PM, Oguz Bektas wrote:
added atime-related options (noatime,
On 5/15/19 5:19 PM, David Hedbor wrote:
I'm testing out ZFS over iSCSI with a Oracle Solaris 11.3 server
(Sparc based specifically). It almost works - what doesn't work is
when I try to act on the disk in any way (such as start
KVM). Specifically it is unable to find the LUN.
Looking at the
faster since it does not have to look for '\0'
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 3be348e..d5c55fd 100644
--- a/src/mini-journalreader.c
by either fixing the type, or manually casting
this makes the types more explicit
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index fd229b9..0747d7c
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 0747d7c..1586592 100644
--- a/src/mini-journalreader.c
+++ b/src/mini-journalreader.c
@@ -110,11 +110,9
this changes link behaviour and those functions are not exported to other
files when some c code is linked against our code
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/src/mini
fixes various type issues and changes to fwrite_unlocked from write
for more details see the commit messages
changes from v1:
* more detailed commit messages
Dominik Csapak (5):
add static to functions
fix implicit type conversions
reuse get_timestamp
use fwrite_unlocked instead
this does the same as our old code, but is a lot shorter,
so it was uneccessary to have and the performance is the same
(no measureable difference)
we still need a wrapper to be sure that we wrote everything
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 34
we still need a wrapper to be sure that we wrote everything
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 34 ++
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 1586592
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 3be348e..d5c55fd 100644
--- a/src/mini-journalreader.c
+++ b/src/mini-journalreader.c
@@ -91,12 +91,12
fixes various type issues and changes to fwrite_unlocked from write
Dominik Csapak (5):
add static to functions
fix implicit type conversions
reuse get_timestamp
use fwrite_unlocked instead of manually printing to buffer
use memcpy/cmp instead of strncpy/cmp
src/mini-journalreader.c
by either fixing the type, or manually casting
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index fd229b9..0747d7c 100644
--- a/src/mini-journalreader.c
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 508de02..fd229b9 100644
--- a/src/mini-journalreader.c
+++ b/src/mini-journalreader.c
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 0747d7c..1586592 100644
--- a/src/mini-journalreader.c
+++ b/src/mini-journalreader.c
@@ -110,11 +110,9
disregard this for now, copying was not enough
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
this uses the new journalreader instead of journalctl, which is a bit
faster and can read from/to cursor and returns a start/end cursor
also you can give an unix epoch as time parameters
Signed-off-by: Dominik Csapak
---
PVE/API2/Nodes.pm | 71
Signed-off-by: Dominik Csapak
---
www/manager6/node/Config.js | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index 831d2e02..700ca611 100644
--- a/www/manager6/node/Config.js
+++ b/www/manager6/node/Config.js
-> lastentries
* add the same api call to pmg-api (i will send the pmg-gui patch later)
* add dependency of pve-manager/pmg-api
proxmox-widget-toolkit:
Dominik Csapak (1):
add panel/JournalView
Makefile | 1 +
panel/JournalView.js | 335 +++
this uses the new journalreader instead of journalctl, which is a bit
faster and can read from/to cursor and returns a start/end cursor
also you can give an unix epoch as time parameters
Signed-off-by: Dominik Csapak
---
PMG/API2/Nodes.pm | 71
-off-by: Dominik Csapak
---
Makefile | 1 +
panel/JournalView.js | 335 +++
2 files changed, 336 insertions(+)
create mode 100644 panel/JournalView.js
diff --git a/Makefile b/Makefile
index d2b905c..049a1fb 100644
--- a/Makefile
+++ b
works like expected, there is some issue in the context though (comment
inline)
On 5/14/19 4:24 PM, Thomas Lamprecht wrote:
the delete parameter get's injected by the SectionConfigs
updateSchem, but we need to handle it ourself in the code
This makes the following possible:
pvesm set
of entries when updating an entry of
a different type, since all entries of the original types suddenly
did not satisfy their required options and would not get parsed
by read_file anymore (thus missing when a successful write_file was done)
Signed-off-by: Dominik Csapak
---
src/PVE
similar to how we handle the cluster wide tasklist and rrd data,
have an interface that can sync data across the cluster
this data is only transient and will not be written to disk
we can use this for a number of things, e.g. listing ceph services
across the cluster, etc.
Signed-off-by: Dominik
On 5/13/19 4:32 PM, Dietmar Maurer wrote:
comments inline
On 13 May 2019 at 14:49 Dominik Csapak wrote:
this uses the new journalreader instead of journalctl, which is a bit
faster and can read from/to cursor and returns a start/end cursor
also you can give an unix epoch as time parameters
i found an error (comment inline)
On 5/13/19 2:49 PM, Dominik Csapak wrote:
this uses the new journalreader instead of journalctl, which is a bit
faster and can read from/to cursor and returns a start/end cursor
also you can give an unix epoch as time parameters
Signed-off-by: Dominik Csapak
there is an error in this patch(comment inline)
On 5/13/19 2:49 PM, Dominik Csapak wrote:
similar to LogView, but expects the result from the /node/journal api call,
which is an array of strings, with start/endcursor instead of
an array of objects with line numbers
the new api call also does
which uses the new journalreader tool instead of journalctl,
with different parameters and a different return format:
array of strings with a start/end cursor
Signed-off-by: Dominik Csapak
---
src/PVE/Tools.pm | 25 +
1 file changed, 25 insertions(+)
diff --git a/src
-off-by: Dominik Csapak
---
Makefile | 1 +
panel/JournalView.js | 335 +++
2 files changed, 336 insertions(+)
create mode 100644 panel/JournalView.js
diff --git a/Makefile b/Makefile
index d2b905c..049a1fb 100644
--- a/Makefile
+++ b
provides a minimalistic binary to show the journal content
shows a cursor after and before the output
Signed-off-by: Dominik Csapak
---
Makefile | 23
debian/changelog | 5 +
debian/compat| 1 +
debian/control | 13 ++
debian/copyright | 22
this uses the new journalreader instead of journalctl, which is a bit
faster and can read from/to cursor and returns a start/end cursor
also you can give an unix epoch as time parameters
Signed-off-by: Dominik Csapak
---
PVE/API2/Nodes.pm | 52
structure, but found no good way to keep
backwards compatibility
pve-journalreader:
Dominik Csapak (1):
inital commit for journalreader
pve-common:
Dominik Csapak (1):
add Tools::print_journal
src/PVE/Tools.pm | 25 +
1 file changed, 25 insertions(+)
proxmox-widget
Signed-off-by: Dominik Csapak
---
www/manager6/node/Config.js | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index 831d2e02..700ca611 100644
--- a/www/manager6/node/Config.js
+++ b/www/manager6/node/Config.js
On 5/13/19 8:23 AM, Thomas Lamprecht wrote:
Am 5/10/19 um 2:52 PM schrieb Oguz Bektas:
this enables us to specify an nfs version while editing/creating an nfs
mount. it used to default to vers=3 without the ability to change it in
gui. now it supports: 3, 4, 4.1 and 4.2
it should also be
On 5/9/19 6:32 PM, Thomas Lamprecht wrote:
On 5/8/19 11:12 AM, Dominik Csapak wrote:
the memory stat is not available if the user has no audit privilges on
/nodes/NODENAME but the status is always available
but couldn't it be argued that this is desired behaviour?
Or is it out of consistency
the memory stat is not available if the user has no audit privilges on
/nodes/NODENAME but the status is always available
also it makes simple more sense to check if it is online not only if the
memory value is there
Signed-off-by: Dominik Csapak
---
www/manager6/form/NodeSelector.js | 2 +-
1
If a dependency of a formula returns undefined, it will not get updated,
even if the other parts of the formula would work.
So we change the default to 'null' which gets handled differently,
but serves the same purpose for us.
Signed-off-by: Dominik Csapak
---
www/manager6/dc/TFAEdit.js | 10
with the api call to userid/tfa we get the users tfa type as well
as the realm tfa type, so we can replace the call to the realm
with this
to properly show the loadmask, we want to initiate the api call when
the window is already shown, the 'show' event works for this
Signed-off-by: Dominik
i would prefer that it behaves like the update_vm_api sub in
PVE/API2/Qemu.pm (line ~1000)
there we have a parameter 'background_delay' which we could use to
make the removal async (this can already work in the gui)
and the return value is type string but optional, so
you could return undef
we skip offline nodes, check for nodes without subscription,
and finally check for different levels
if for some reason we do not get any subscription status (should not happen)
we show 'unknown'
Signed-off-by: Dominik Csapak
---
changes from v1:
* explicitely check for offline nodes
On 5/3/19 1:38 PM, Tim Marx wrote:
It looks like this: can't migrate VM which uses local
devices-usb1-usb2-usb0-hostpci0
Seems ok for me?
mhmm looks weird to me since devices-1-2-3-4
is not a real word/sentence/...
would it not also work to build an array and simply return that?
if some
afaics, the error will look like:
"can't migrate VM which uses local devicesivshmem-usb0-hostpci1'
?
would it not be better to do something like
my $loc_res = [];
loop {
push @$loc_res, 'local_resource';
}
return join(", ", @$loc_res)?
On 5/3/19 1:25 PM, Tim Marx wrote:
Signed-off-by:
across the cluster, etc.
Signed-off-by: Dominik Csapak
---
sending it alone, awaiting review of the rest of my series
changes from v1:
* use modern sub syntax
* better naming
data/PVE/Cluster.pm | 47 +++
1 file changed, 47 insertions(+)
diff --git
this api call will be used to display the right kind of tfa for the gui
Signed-off-by: Dominik Csapak
---
i send only this for now in v2, waiting for the review of the gui
changes from v1:
* enums in return values
* no postif variable declarations
PVE/API2/User.pm | 59
Signed-off-by: Dominik Csapak
---
node/NetworkView.js | 45 +
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/node/NetworkView.js b/node/NetworkView.js
index b38a07e..e3f7e60 100644
--- a/node/NetworkView.js
+++ b/node/NetworkView.js
ave a new field that
contains that information again (cidr)
Signed-off-by: Dominik Csapak
---
changes from v1:
* moved the cidr parsing into the if condition
src/PVE/INotify.pm | 32
1 file changed, 32 insertions(+)
diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.p
On 4/18/19 1:46 PM, Dominik Csapak wrote:
so we have a more 'web-app' like appearance for the user
the menu contains links to:
* browser localstorage settings
* password change
* tfa change
* logout
any comment?
___
pve-devel mailing list
pve-devel
so one can use the mapping from outside the module
Signed-off-by: Dominik Csapak
---
src/PVE/JSONSchema.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 51ef3ab..d458ec1 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE
to also allow to set it directly and not via address/netmask
Signed-off-by: Dominik Csapak
---
changes from v1:
* indented correctly
PVE/API2/Network.pm | 44 +++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Network.pm b/PVE
and vms
changes from v1:
* moved the cidr parsing in the if condition
* indented correctly
i send it only to pve-devel from now on
pve-common:
Dominik Csapak (2):
JSONSchema: add get_netmask_bits and missing netmask
INotify: map address/netmask to cidr while parsing interfaces
src/PVE
to also allow to set it directly and not only via address/netmask
Signed-off-by: Dominik Csapak
---
changes from v1:
* indented correctly
PMG/API2/Network.pm | 44 +++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/PMG/API2/Network.pm b
this makes the ui easier and is consistent with the rest of our ui
(container and cloud init)
Signed-off-by: Dominik Csapak
---
node/NetworkEdit.js | 68 +++--
1 file changed, 8 insertions(+), 60 deletions(-)
diff --git a/node/NetworkEdit.js b
do not poll the syslog api call multiple times simultaneously,
since it can be very costly, depending on the journal size
with this, there is always only one per client
Signed-off-by: Dominik Csapak
---
panel/LogView.js | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
not yet really sure about this, or better said, I'm sure I don't want this for
locks, but for things like ceph service states it could be OK.
yeah i am not sure about this either, hence i sent it as RFC ;)
i would prefer it for locks over the config parsing in the api call though
hmm, I'm
On 4/26/19 10:47 AM, Thomas Lamprecht wrote:
Am 4/26/19 um 8:21 AM schrieb Dominik Csapak:
this returns a hash of existing service links for
mds/mgr/mons so that we know which services exists
this is necessary since ceph itself does not save if a service is
defined somewhere, only when it runs
On 4/26/19 10:43 AM, Thomas Lamprecht wrote:
Am 4/26/19 um 8:21 AM schrieb Dominik Csapak:
similar to how we handle the cluster wide tasklist and rrd data,
have an interface that can sync data across the cluster
this data is only transient and will not be written to disk
we can use
so that we have a list of all existing ceph services in the cluster
Signed-off-by: Dominik Csapak
---
PVE/Service/pvestatd.pm | 14 ++
1 file changed, 14 insertions(+)
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index ce2adbbd..b8abc8f2 100755
--- a/PVE/Service
across the cluster, etc.
Signed-off-by: Dominik Csapak
---
data/PVE/Cluster.pm | 47 +++
1 file changed, 47 insertions(+)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index 5af11e6..ea36a0a 100644
--- a/data/PVE/Cluster.pm
+++ b/data/PVE
filesystem about the services,
as well as the 'ceph YYY metadata' info we get from ceph.
with this info we can convieniently display which services exists,
which are running and which versions they have
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 64
this returns a hash of existing service links for
mds/mgr/mons so that we know which services exists
this is necessary since ceph itself does not save if a service is
defined somewhere, only when it runs
Signed-off-by: Dominik Csapak
---
PVE/Ceph/Services.pm | 18 ++
1 file
option,
or a compelling opinion for any other of the options, please share it
Dominik Csapak (1):
add generic data broadcast interface
data/PVE/Cluster.pm | 47 +++
1 file changed, 47 insertions(+)
pve-manager:
Dominik Csapak (3):
add
ceph nautilus changed the structure of 'pg dump osds'
they moved the data one level below
parse both new and old format, and bail if it returns anything else
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph/OSD.pm | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git
not happen)
we show 'unknown'
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Summary.js | 36
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/www/manager6/dc/Summary.js b/www/manager6/dc/Summary.js
index 091ece76..b26eeb92 100644
--- a/www/manager6/dc
so we have a more 'web-app' like appearance for the user
the menu contains links to:
* browser localstorage settings
* password change
* tfa change
* logout
Signed-off-by: Dominik Csapak
---
this patch needs my previous series for tfa, to correctly use the TFAEdit window
www/manager6
this api call will be used to display the right kind of tfa for the gui
Signed-off-by: Dominik Csapak
---
PVE/API2/User.pm | 56
1 file changed, 56 insertions(+)
diff --git a/PVE/API2/User.pm b/PVE/API2/User.pm
index 4458fc1..afdbfee
this series adds a new api call to get the tfa type(s) and uses that
in the tfa panel to show/hide/disable the correct things, while doing this
we optimize the panel a bit
Dominik Csapak (1):
add /access/user/{id}/tfa api call to get tfa types
PVE/API2/User.pm | 56
instead of that, simply enable or disable the component directly
(especially since this was only called once anyway)
keep the viewmodel for things that can change dynamically, e.g. the
tab or the validity
Signed-off-by: Dominik Csapak
---
www/manager6/dc/TFAEdit.js | 163
Signed-off-by: Dominik Csapak
---
www/manager6/dc/UserEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js
index 8dd1ae53..1665f4b0 100644
--- a/www/manager6/dc/UserEdit.js
+++ b/www/manager6/dc/UserEdit.js
@@ -17,7
so one can setup a new u2f key when one is already set, otherwise
showing anything at all makes no sense
Signed-off-by: Dominik Csapak
---
www/manager6/dc/TFAEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/TFAEdit.js b/www/manager6/dc/TFAEdit.js
index
if we have no info about TFA in the userview (x as key instead of
x!oath or x!u2f) we disabled the whole window and the only action
was to delete
instead show all options, so the user can overwrite the setting
Signed-off-by: Dominik Csapak
---
www/manager6/dc/TFAEdit.js | 4 ++--
1 file
Signed-off-by: Dominik Csapak
---
node/NetworkView.js | 45 +
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/node/NetworkView.js b/node/NetworkView.js
index b38a07e..e3f7e60 100644
--- a/node/NetworkView.js
+++ b/node/NetworkView.js
ave a new field that
contains that information again (cidr)
Signed-off-by: Dominik Csapak
---
src/PVE/INotify.pm | 32
1 file changed, 32 insertions(+)
diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm
index c52d992..83c592a 100644
--- a/src/PVE/INotify.pm
+++ b/src
to also allow to set it directly and not only via address/netmask
Signed-off-by: Dominik Csapak
---
PMG/API2/Network.pm | 44 +++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/PMG/API2/Network.pm b/PMG/API2/Network.pm
index 6636553
this makes the ui easier and is consistent with the rest of our ui
(container and cloud init)
Signed-off-by: Dominik Csapak
---
node/NetworkEdit.js | 68 +++--
1 file changed, 8 insertions(+), 60 deletions(-)
diff --git a/node/NetworkEdit.js b
to also allow to set it directly and not only via address/netmask
Signed-off-by: Dominik Csapak
---
PVE/API2/Network.pm | 44 +++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 0284410a
and vms
pve-common:
Dominik Csapak (2):
JSONSchema: add get_netmask_bits and missing netmask
INotify: map address/netmask to cidr while parsing interfaces
src/PVE/INotify.pm| 32
src/PVE/JSONSchema.pm | 6 ++
2 files changed, 38 insertions(+)
pve
using the same logic like serialX: socket
users need VM.Config.HWType for usbX: spice
but only root can add/remove real devices
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE
since we do not want the user to change a device which has a real
devices already set, we have to check it later when we have the config
so we do not have to give the params to vm_check_modify_config_perm anymore
also improve the regex to \d+
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm
use VM.Config.HWType for 'socket' and root@pam for real serial devices
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index d8c9726..7195ec2 100644
--- a/PVE/API2
701 - 800 of 3073 matches
Mail list logo
