[pve-devel] [PATCH manager] Update french translation

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- po/fr.po | 369 ++- 1 file changed, 153 insertions(+), 216 deletions(-) diff --git a/po/fr.po b/po/fr.po index 48e03045..b55a8f32 100644 --- a/po/fr.po +++ b/po/fr.po @

[pve-devel] [PATCH manager] Allow change of Datacenter wide default console without browser refresh

The previous implementation was relying on PVE.VersionInfo.console, which is set after login and never refreshed after that. We execute the API call before setting the button handler, otherwise the browser would fire its popup blocker Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.

[pve-devel] [PATCH manager 2/4] Add new icon for xtermjs consoles, based on xtermjs logo

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/images/Makefile| 4 www/images/xtermjs.png | Bin 0 -> 729 bytes 2 files changed, 4 insertions(+) create mode 100644 www/images/xtermjs.png diff --git a/www/images/Makefile b/www/images/Makefile index c76d7aee.

[pve-devel] [PATCH manager 4/4] Set Console Button icon style at definition time

This will allow the 'Upgrade' button to get an icon too. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/button/ConsoleButton.js | 2 ++ www/manager6/lxc/Config.js | 3 +-- www/manager6/node/Config.js | 3 +-- www/manager6/qemu/Config.js

[pve-devel] [PATCH manager 3/4] Use the new xterm.js icon with the corresponding Menu Item

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/css/ext6-pve.css | 6 ++ www/manager6/button/ConsoleButton.js | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index c8fabd6f..2c6de752

[pve-devel] [PATCH manager 1/4] jslint: remove trailing comma after last objects property

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/button/ConsoleButton.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/button/ConsoleButton.js b/www/manager6/button/ConsoleButton.js index a3bf7464..1392c555 100644 --- a/www/ma

[pve-devel] [PATCH manager 2/2] Set ZFS over ISCSI window to proper title

This will now Display 'ZFS over iSCSI'. This was reported by users during a Proxmox Training. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- NB: Strings returned by format_storage_type() are not gettext'ed. This is fine, as nobody should try to translate 'LVM-thin' or 'ZFS over

[pve-devel] [PATCH manager 1/2] Fix Indentation to use Proxmox style

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/storage/ZFSEdit.js | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/www/manager6/storage/ZFSEdit.js b/www/manager6/storage/ZFSEdit.js index bc9d8baf..22f24cb2

Re: [pve-devel] PVE Minimal Debian Appliance

On 12/18/2017 12:09 AM, c.mo...@web.de wrote: > Hello! > > Can you consider to provide a PVE Minimal Debian Appliance considering > things like > "Removing Packages for dealing with hardware. This is not usually done > within a container" und "Removing Packages for interactive use." BTW, the

Re: [pve-devel] [PATCH docs v2 2/3] Update path to Backup.txt in new git repo

Any feedback on this and serie ? I clicked again on that old link while doing a PVE training ... On 11/21/2017 04:58 PM, Emmanuel Kasper wrote: > Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> > --- > vzdump.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

[pve-devel] [PATCH pve-container 2/2] Return proper error message when CT is not running for pct exec

instead of the uglier lx-attach: : attach.c: lxc_attach: 794 Failed to attach and multiple tabs Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- src/PVE/CLI/pct.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 1818551..d

[pve-devel] [PATCH pve-container 1/2] Test for arguments at beginning of 'pct exec'

Also derefence the given parameters once, for readability Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- src/PVE/CLI/pct.pm | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 05fcb29..1818551 100755 ---

Re: [pve-devel] [PATCH qemu-server] Use schema default values as default values

On 11/20/2017 02:38 PM, Fabian Grünbichler wrote: > On Wed, Nov 15, 2017 at 11:58:29AM +0100, Emmanuel Kasper wrote: >> Any feedback on this ? > > there already is a "load_defaults" in QemuServer.pm, I'd re-use that. > what about options with default values besides th

[pve-devel] [PATCH qemu-server v3] Use default values from load_defaults() when none is specified in conf

This also fixes a bug where VMs with no memory defined in the config where reported as using 0MB instead of 512. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- changes since V1: use load_defaults() instead of $confdesc for consistency with the rest of the codebase

[pve-devel] [RFC PATCH] Explain that concurrent modifications of the VM config are the error cause

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- While doing PVE trainings last week, I noticed that this error message was not clear to most people when it popped up on the GUI. Reusing here the wording that apt uses when called multiple times ( Unable to lock the administ

[pve-devel] [PATCH manager v3 1/3] Fix JSLint type confusion warnings

The type confusion warnings arose from string and integer concatenation, and object properties of the name which were alternatively set with strings and integers. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 29 ++

[pve-devel] [PATCH manager v3 0/3] Introduce Detach Button for used disks

as a button property Emmanuel Kasper (3): Fix JSLint type confusion warnings Fix #1526: Use 'detach' instead of 'remove' when the disk is used Add a proper confirmation message when we detach an used disk www/manager6/qemu/HardwareView.js | 70 ++- 1 file

[pve-devel] [PATCH manager v3 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 43337c36..bc22cc98

[pve-devel] [PATCH manager v3 3/3] Add a proper confirmation message when we detach an used disk

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index bc22cc98..112410c2 100644 --- a/www/ma

Re: [pve-devel] XenServer to Proxmox in a single step

On 11/23/2017 02:22 PM, Gandalf Corvotempesta wrote: > Here you are: > > https://pastebin.com/raw/4E6rTuqe For discoverability I would advise you to post this too on one of the free git hosting services. ___ pve-devel mailing list

[pve-devel] [PATCH manager] Add each host SSL fingerprint to each node status

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- PVE/API2/Nodes.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index b7210d4d..15437dc9 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1746,6 +1746,7 @@ __PACKAGE__->regist

[pve-devel] [PATCH cluster 0/2] Prepare SSL finger information via API call

of simply disabling SSL host verification when addressing hosts with self signed certificates * on the long term, provide the info necessary to build a cluster using only API calls Emmanuel Kasper (2): Refactor host fingerprint calculation in two extra subs Add utility method to get a SSL finger

[pve-devel] [PATCH cluster 1/2] Refactor host fingerprint calculation in two extra subs

This will be used later for feeding an extra API call Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- data/PVE/Cluster.pm | 51 --- 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Clus

[pve-devel] [PATCH cluster 2/2] Add utility method to get a SSL finger print from a nodename

This will be used to feed an extra field for an API call Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- data/PVE/Cluster.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 5d69f0c..051e815 100644 --- a/data/PVE/Cluster.pm

[pve-devel] [PATCH docs v2 1/3] Fix vzdump backup stop mode description

The VM goes to normal operation after the backup is started, not at end of backup. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- vzdump.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index 7643ec6..f21a75f

[pve-devel] [PATCH docs v2 2/3] Update path to Backup.txt in new git repo

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- vzdump.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vzdump.adoc b/vzdump.adoc index f21a75f..babf407 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -85,7 +85,7 @@ consistency. A technical ov

[pve-devel] [PATCH docs v2 3/3] Explain why shut down VMs appear as running when backed up

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- vzdump.adoc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vzdump.adoc b/vzdump.adoc index babf407..da8ea19 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -89,7 +89,10 @@ https://git.proxmox.com/?p=pve-qe

Re: [pve-devel] [PATCH docs] Fix vzdump backup stop mode description

On 11/21/2017 12:26 PM, Dietmar Maurer wrote: > IMHO it is still not clear that this provides snapshot semantics ... > (snapshot of the stopped VM). Actually, a note a bit below the backup modes actually mention that :) But we were still missing an explanation on the VM apparently running when a

[pve-devel] [PATCH docs] Fix vzdump backup stop mode description

The VM goes to normal operation after the backup is started, not at end of backup. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- vzdump.adoc | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index 7643ec6..d354732

Re: [pve-devel] [PATCH qemu-server] Use schema default values as default values

Any feedback on this ? On 10/23/2017 10:45 AM, Emmanuel Kasper wrote: > This fix a bug where VMs where the memory parameter was not > set where reported as having 0MB instead of 512 via `qm list` > > Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> > --- >

[pve-devel] [PATCH manager v2 3/3] Add a proper confirmation message when we detach an used disk

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 2cd0c940..e6bc0231 100644 --- a/www/ma

[pve-devel] [PATCH manager v2 1/3] Fix JSLint type confusion warnings

The type confusion warnings arose from string and integer concatenation, and object properties of the name which were alternatively set with strings and integers. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 29 ++

[pve-devel] [PATCH manager v2 0/3] Introduce 'Detach' text for used disks

change since V2: * do not call gettext twice on the same string * use 'render' event instead of 'boxready' when computing an optimal box size Emmanuel Kasper (3): Fix JSLint type confusion warnings Fix #1526: Use 'detach' instead of 'remove' when the disk is used Add a proper

[pve-devel] [PATCH manager v2 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 43337c36..2cd0c940

Re: [pve-devel] [PATCH manager] buildsys: add excludes to dh_fixperms

Tested-By: Emmanuel Kasper <e.kas...@proxmox.com> Acked-By: Emmanuel Kasper <e.kas...@proxmox.com> On 11/13/2017 10:37 AM, Wolfgang Bumiller wrote: > Instead of fixing up permissions manually as the make > install target is actually responsible for this (and already > doing

[pve-devel] [PATCH manager 0/3] Change 'remove' to 'detach' when removing an used disk

A fix for #1526 Emmanuel Kasper (3): Fix JSLint type confusion warnings Fix #1526: Use 'detach' instead of 'remove' when the disk is used Add a proper confirmation message when we detach an used disk www/manager6/qemu/HardwareView.js | 67 +-- 1 file

[pve-devel] [PATCH manager 1/3] Fix JSLint type confusion warnings

The type confusion warnings arose from string and integer concatenation, and object properties of the name which were alternatively set with strings or intergers. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 29 ++

[pve-devel] [PATCH manager 2/3] Fix #1526: Use 'detach' instead of 'remove' when the disk is used

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 43337c36..3b0f00f6

[pve-devel] [PATCH manager 3/3] Add a proper confirmation message when we detach an used disk

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 3b0f00f6..605958e1 100644 --- a/www/ma

Re: [pve-devel] Call to translaters: Proxmox VE has new features and need your translations !

On 11/09/2017 03:00 PM, Jostein Hove-Henriksen wrote: > I've updated the Norwegian bokmål (nb) and Norwegian nynorsk (nn) > translation. > > (I'll see if I can learn more about /git/ later...) Thanks Jostein, I had a look at both files, and they look good to me. Did you already sign our

[pve-devel] Call to translaters: Proxmox VE has new features and need your translations !

Dear Pve Translators (and dear future PVE translators) ! We always add new features to the PVE gui like Storage Replication, Ceph Dashboard, but unfortunately the translations tend to lag behind for many languages, resulting in a mix of English and Locale language when a different language is

[pve-devel] [PATCH manager 5/6] Do not translate PC hardware specific terms

The SKU (Stock Keeping Unit) field was never translated anyway in our po files, probably because nobody knew what the initials meant. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/Smbios1Edit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pve-devel] [PATCH manager 4/6] Do not translate Qemu specific terms

Multiqueue is the proper name as used by Qemu, as seen in https://www.linux-kvm.org/page/Multiqueue Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/qemu/HDEdit.js | 2 +- www/manager6/qemu/NetworkEdit.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[pve-devel] [PATCH manager 3/6] Do not translate IT specific terms

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/grid/Replication.js | 2 +- www/manager6/lxc/Network.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js index 2c8f3cf9..65

[pve-devel] [PATCH manager 2/6] Do not translate PC hardware specific terms

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/form/HotplugFeatureSelector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/form/HotplugFeatureSelector.js b/www/manager6/form/HotplugFeatureSelector.js index 71187cf6..cb373b69

[pve-devel] [PATCH manager 6/6] Do not translate Unix/Linux specific terms

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/lxc/ResourceEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/ResourceEdit.js b/www/manager6/lxc/ResourceEdit.js index 9770de8d..48e5b57a 100644 --- a/www/manager6/lxc/ResourceE

[pve-devel] [PATCH manager 0/6] Do not add useless gettext entries to translate

split the removals in multiple patch so that the committer can apply / reject the removals individually. Emmanuel Kasper (6): Do not translate Ceph specific terms Do not translate PC hardware specific terms Do not translate IT specific terms Do not translate Qemu specific terms Do

[pve-devel] [PATCH manager 1/6] Do not translate Ceph specific terms

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/ceph/StatusDetail.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/ceph/StatusDetail.js b/www/manager6/ceph/StatusDetail.js index 5373e2d5..7625b366 100644 --- a/www/manager

[pve-devel] [PATCH docs 1/2] Fix formatting failure

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- pct.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pct.adoc b/pct.adoc index 7a7bcc6..c509308 100644 --- a/pct.adoc +++ b/pct.adoc @@ -325,7 +325,7 @@ Backup of Containers mount points By default addi

[pve-devel] [PATCH docs 2/2] Create a 10 gibibytes diskimage instead of 10 gigabytes

Otherwise the disk import may fail on block storages requiring volumes size to be a multiple of the block size, like ZFS. This fixes the error: 'volume size must be a multiple of volume block size' when importing the generated disk image as a zvol. Signed-off-by: Emmanuel Kasper <e.

[pve-devel] [PATCH manager v2 3/3] Move Max Backups field below the Content Type Selector

Since the Max Backups field is now depending of having the Content Type set to 'backup', it makes sense to group these two fields. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/storage/DirEdit.js | 22 +++--- www/manager6/storage/GlusterFsE

[pve-devel] [PATCH manager v2 1/3] Add Storage Controller class

This controller will display the 'Max Backups' field only if the storage can hold backups. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/Makefile | 1 + www/manager6/controller/StorageEdit.js | 18 ++ 2 files changed, 19 inse

[pve-devel] [PATCH manager v2 2/3] Fix #1523: Display the Max Backups field only if relevant

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/storage/DirEdit.js | 3 +++ www/manager6/storage/GlusterFsEdit.js | 3 +++ www/manager6/storage/NFSEdit.js | 3 +++ 3 files changed, 9 insertions(+) diff --git a/www/manager6/storage/DirEdit.js b/www/ma

[pve-devel] [PATCH manager v2 0/3] Fix #1523: Disable 'Max Backup' entry when not applicable

changes since V1: * remove wrong whitespace in DirEdit.js * reset Max Backups value before disabling it in StorageEdit.js Emmanuel Kasper (3): Add Storage Controller class Fix #1523: Display the Max Backups field only if relevant Move Max Backups field below the Content Type Selector

[pve-devel] [PATCH manager 1/3] Add Storage Controller class

This controller will display the 'Max Backups' field only if the storage can hold backups. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/Makefile | 1 + www/manager6/controller/StorageEdit.js | 18 ++ 2 files changed, 19 inse

[pve-devel] [PATCH manager 3/3] Move Max Backups field below the Content Type Selector

Since the Max Backups field is now depending of having the Content Type set to 'backup', it makes sense to group these two fields. Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/storage/DirEdit.js | 22 +++--- www/manager6/storage/GlusterFsE

[pve-devel] [PATCH manager 0/3] Fix #1523: Disable 'Max Backup' entry when not applicable

This patch serie fixes #1523. Instead of writing for each Storage a new ViewController, I created new ViewController class to be reused. Emmanuel Kasper (3): Add Storage Controller class Fix #1523: Display the Max Backups field only if relevant Move Max Backups field below the Content Type

[pve-devel] [PATCH manager 2/3] Fix #1523: Display the Max Backups field only if relevant

Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- www/manager6/storage/DirEdit.js | 3 +++ www/manager6/storage/GlusterFsEdit.js | 3 +++ www/manager6/storage/NFSEdit.js | 3 +++ 3 files changed, 9 insertions(+) diff --git a/www/manager6/storage/DirEdit.js b/www/ma

Re: [pve-devel] [PATCH manager] prevent visual flashing of button when changing element in the tree

Acked-by: Emmanuel Kasper <e.kas...@proxmox.com> On 10/30/2017 03:03 PM, Dominik Csapak wrote: > when changing between elements in the tree, either the > start or shutdown buttons were visually flashing (meaning they are > enabled/disabled for a short time and change stat

[pve-devel] [PATCH qemu-server] Use schema default values as default values

This fix a bug where VMs where the memory parameter was not set where reported as having 0MB instead of 512 via `qm list` Signed-off-by: Emmanuel Kasper <e.kas...@proxmox.com> --- PVE/QemuServer.pm | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

Re: [pve-devel] [PATCH manager 1/2] ui: pveWindowEdit: allow sane onlineHelp specification for edit windows

On 10/17/2017 02:29 PM, Thomas Lamprecht wrote: > instead of heuristically choosing the onlineHelp entry from our first > item prefer the one we have in our config, if noone the fallback to > the old heuristic. > > Signed-off-by: Thomas Lamprecht > --- >

Re: [pve-devel] [PATCH manager 7/7] ui: lxc: add 'more' button with HA manage menu item to panel

On 10/11/2017 12:09 PM, Thomas Lamprecht wrote: > Move the remove button into the more button and add a 'Manage HA' > button there, mirroring the changes from the qemu panel. > > Allows to add an unmanaged CT to HA or to edit the HA settings of a > managed one. > > Fixes: #1518 > Signed-off-by:

Re: [pve-devel] [PATCH manager 0/7] WebUI: make HA management easier

On 10/16/2017 01:48 PM, Thomas Lamprecht wrote: > On 10/16/2017 01:39 PM, Wolfgang Bumiller wrote: >> On Wed, Oct 11, 2017 at 12:09:40PM +0200, Thomas Lamprecht wrote: >>> First two patches make adding a new services over DC->HA->Add more >>> confortable by switching out the simple VMID integer

[pve-devel] [PATCH qemu v3 4/5] Provides a qemu-system-x86 virtual package

This allows adding additional debian packages on pve hosts which depends on a qemu binary being installed. The following install paths were tested: * install of proxmox-ve on debian systems with standard package set: works as expected * install of proxmox-ve on debian having the debian qemu

Re: [pve-devel] [PATCH qemu v2 0/5] Provides a qemu-system-x86 virtual package

> In general, looks good to me. > > Upstream package provides also the following man pages[1]: > /usr/share/man/man1/qemu-system-i386.1.gz > /usr/share/man/man1/qemu-system-x86_64.1.gz > Which we do not (we have only qemu), would it make sense > to make a link to these? yes makes sense, we

Re: [pve-devel] Include dpkg-reconfigure in Makefile

On 10/13/2017 08:13 AM, Thomas wrote: > Hello! > > How can I include /dpkg-reconfigure tzdata/ (Europe/Berlin) and > /dpkg-reconfigure/ locales (de_DE.UTF-8) in the Makefile? Hi Thomas Not sure I understand your question because server specific setup is usually not done with Make. You should

Re: [pve-devel] [PATCH manager] fix updateStore destroy

look goods to me maybe we should have mentioned that this is needed for having the 'autoDestroy' store property working properly. Otherwise it is not clear why we needed this in the pve context, as all updates store are unqueued manually with component.on('destroy', componentstore.stopUpdate);

[pve-devel] [PATCH qemu v2 2/5] Install userspace utilities and UEFI roms via dh_install

--- debian/pve-qemu-kvm.install | 9 + debian/rules| 12 +--- 2 files changed, 10 insertions(+), 11 deletions(-) create mode 100644 debian/pve-qemu-kvm.install diff --git a/debian/pve-qemu-kvm.install b/debian/pve-qemu-kvm.install new file mode 100644 index

[pve-devel] [PATCH qemu v2 3/5] Bump dephelper compatibility level to 10

The debian package content was found to be the same with diffoscope. No functional change. --- debian/compat | 2 +- debian/control | 2 +- debian/rules | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/debian/compat b/debian/compat index 7ed6ff8..f599e28 100644 ---

[pve-devel] [PATCH qemu v2 4/5] Provides a qemu-system-x86 virtual package

This allows adding additional debian packages on pve hosts which depends on a qemu binary being installed. The following install paths were tested: * install of proxmox-ve on debian systems with standard package set: works as expected * install of proxmox-ve on debian having the debian qemu

[pve-devel] [PATCH qemu v2 5/5] Add a 'Conflicts' with qemu-system-common from Debian

Both qemu-system-common and our pve-qemu-kvm package install the file /usr/bin/virtfs-proxy-helper. Since qemu-system-common does not have reverse dependencies in Debian for packages besides qemu-system-, and ovmf, which we don't want to install anyway, we do not need a 'Provides' for it. ---

[pve-devel] [PATCH qemu v2 0/5] Provides a qemu-system-x86 virtual package

package we 'Provides'. Emmanuel Kasper (5): Remove deprecated dh_clean -k Install userspace utilities and UEFI roms via dh_install Bump dephelper compatibility level to 10 Provides a qemu-system-x86 virtual package Add a 'Conflicts' with qemu-system-common from Debian debian/compat

[pve-devel] [PATCH qemu v2 1/5] Remove deprecated dh_clean -k

--- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 98637c7..28723df 100755 --- a/debian/rules +++ b/debian/rules @@ -80,7 +80,7 @@ endif install: build dh_testdir dh_testroot - dh_clean -k + dh_prep

[pve-devel] [PATCH storage] ISCSIPlugin: Use long options for readability

We otherwise use the long options everywhere in the plugin. This will build the following command: iscsiadm --mode session --sid 1 --rescan Rescanning session [sid: 1, target: xxx, portal: yyy] --- PVE/Storage/ISCSIPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [pve-devel] [PATCH manager] fix #1516: fix mouse-scrolling of overflowhandlers in firefox

On 10/04/2017 10:04 AM, Dominik Csapak wrote: > this is a workaround for scrolling in toolbars, etc. in firefox with the > mouse > > while the result is not very "pretty", it maintains the old behaviour > for all other browsers and makes it work in firefox > > we can drop this when we update to

[pve-devel] [PATCH manager v5 7/8] Update VM SCSI controller type after OS selection in Wizard

This was done previously without any kind of user visible feedback, so users would not know that they had a Virtio SCSI controller as default controller for Linux VMs. --- rebase after changes in 5/8 www/manager6/qemu/CreateWizard.js | 5 - www/manager6/qemu/OSDefaults.js | 2 +-

[pve-devel] [PATCH manager v5 6/8] Update VM SCSI type based on iothread value when inside the wizard

We keep the same logic as before: once the iothread option is selected, the SCSI controller is switched to virtio-scsi-single, until iothread is unselected again. --- rebase after 5/8 changed www/manager6/qemu/HDEdit.js | 21 + 1 file changed, 17 insertions(+), 4 deletions(-)

[pve-devel] [PATCH manager v5 5/8] Add a field to show which SCSI controller type we are currently using

We use the field label 'SCSI Controller'. 'Type' is redundant, otherwise we would have Network Card Type, Display Type, Network Card type, etc ... --- changes since v4: * rename the field label to SCSI Controller, and the associated component reference to scsiController.

Re: [pve-devel] [PATCH manager v3 5/8] Add a field to show which SCSI controller type we are currently using

On 10/05/2017 11:25 AM, Thomas Lamprecht wrote: > On 09/28/2017 03:10 PM, Emmanuel Kasper wrote: >> On 09/27/2017 11:27 AM, Thomas Lamprecht wrote: >>> On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >>>> --- >>>>   www/manager6/qemu/HDEdit.js | 15

Re: [pve-devel] [PATCH qemu 1/2] Provides a qemu-system-x86 virtual package

n 10/04/2017 04:10 PM, Thomas Lamprecht wrote: > On 10/04/2017 03:53 PM, Emmanuel Kasper wrote: >> This allows adding additional debian packages on pve hosts >> which depends on those. >> >> The following install paths were tested: >> >> * install of pro

[pve-devel] [PATCH qemu 0/2] Provides a qemu-system-x86 virtual package

Evaluation See http://libguestfs.org/guestfs-faq.1.html for the relation between libguestfs and libvirt. Emmanuel Kasper (2): Provides a qemu-system-x86 virtual package Add a 'Conflicts' with qemu-system-common from Debian debian/control | 6 +- debian/rules | 8 ++-- 2 files c

[pve-devel] [PATCH qemu 1/2] Provides a qemu-system-x86 virtual package

This allows adding additional debian packages on pve hosts which depends on those. The following install paths were tested: * install of proxmox-ve on debian systems with standard package set: works as expected * install of proxmox-ve on debian having the debian qemu package installed:

[pve-devel] [PATCH qemu 2/2] Add a 'Conflicts' with qemu-system-common from Debian

Both qemu-system-common and our pve-qemu-kvm package install the file /usr/bin/virtfs-proxy-helper. Since qemu-system-common does not have reverse dependencies in Debian for packages besides qemu-system-, and ovmf, which we don't want to install anyway, we do not need a 'Provides' for it. ---

[pve-devel] [PATCH docs] Add a paragraph to explain how network models match use cases

Also : * explain more clearly when PVE switched to persistent device naming. (5.0) * use eno1 instead of eno0 everywhere when refering to the first onboard device * use IP addresses from the range IPv4 Address Blocks for Documentation (rfc5737) instead of private IPv4 addresses when giving

Re: [pve-devel] [PATCH manager] fix #1510: do not scroll back to focus when view gets refreshed

On 10/02/2017 02:53 PM, Thomas Lamprecht wrote: > Seems to works good, the small code change you made to the > original function looks also good to me: > Reviewed-by: Thomas Lamprecht Fine for me too, I tested this with IE11 and this works as expected.

[pve-devel] [PATCH manager v4 7/8] Update VM SCSI controller type after OS selection in Wizard

This was done previously without any kind of user visible feedback, so users would not know that they had a Virtio SCSI controller as default controller for Linux VMs. --- www/manager6/qemu/CreateWizard.js | 5 - www/manager6/qemu/OSDefaults.js | 2 +- www/manager6/qemu/OSTypeEdit.js |

[pve-devel] [PATCH manager v4 8/8] Render full name of VirtIO Block controller

This will hopefully reduce confusion with SCSI VirtIO controller --- www/manager6/form/BusTypeSelector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js index ae7c327e..8abdcf4b 100644 ---

[pve-devel] [PATCH manager v4 2/8] Remove unused noScsi parameter

SCSI is a valid bus for Disks and CD drives, so it should always be appear in the bus list. --- www/manager6/form/BusTypeSelector.js| 6 +- www/manager6/form/ControllerSelector.js | 6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git

[pve-devel] [PATCH manager v4 6/8] Update VM SCSI type based on iothread value when inside the wizard

We keep the same logic as before: once the iothread option is selected, the SCSI controller is switched to virtio-scsi-single, until iothread is unselected again. --- www/manager6/qemu/HDEdit.js | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

[pve-devel] [PATCH manager v4 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect' to select a bus position when adding a CD Drive.

[pve-devel] [PATCH manager v4 4/8] Do not use the noVirtIO property to build the controller list

This property is only used for CDEdit, so we can deduce this from the fact that autoselect is set to 'cdrom' --- www/manager6/form/ControllerSelector.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index

[pve-devel] [PATCH manager v4 3/8] Save the components we found via down() in a variable for later reuse.

--- www/manager6/form/ControllerSelector.js | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 14ad574e..15023a7a 100644 --- a/www/manager6/form/ControllerSelector.js +++

[pve-devel] [PATCH manager v4 0/8] Display the SCSI controller type when adding a new disk

bus position for CD ROM drives. * Patch 6: do not suspend change events, use temp variable to store SCSI type * Patch 7-8: fix long lines in commit log Emmanuel Kasper (8): Do not use 'autoselect' as a boolean when preselecting a bus Remove unused noScsi parameter Save the components we

Re: [pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

On 09/27/2017 10:47 AM, Thomas Lamprecht wrote: > On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >> The bus selector is displayed when we add a Hard Disk or CD Drive. >> When it is displayed, we *always* preselect the next available >> slot on the controller of our ch

Re: [pve-devel] [PATCH manager v3 5/8] Add a field to show which SCSI controller type we are currently using

On 09/27/2017 11:27 AM, Thomas Lamprecht wrote: > On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >> --- >>   www/manager6/qemu/HDEdit.js | 15 --- >>   1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/www/manager6/qemu/HDEdit.js b/www

[pve-devel] [PATCH docs 1/2] Typo correction

--- qm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 6cc8855..44d45f6 100644 --- a/qm.adoc +++ b/qm.adoc @@ -679,7 +679,7 @@ the VM. For Windows VMs, you need to install the Windows paravirtualized drivers by yourself. GNU/Linux and other

[pve-devel] [PATCH docs 2/2] Update the Windows import example to use the qm importovf command

Also create a new section, "Add an external disk image to a Virtual Machine" using the qm importdisk command. --- NB: qm.1-synopsis.adoc should be rebuilt, so the 'importovf' command is there too. qm.adoc | 74 - 1 file changed, 50

[pve-devel] [PATCH qemu-server] importovf: explicitly returns undef

We set the returns value to { type => 'null' } but we returned an empty string, which was confusing the cli handler. --- PVE/CLI/qm.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 0e17cc9..90a44ef 100755 --- a/PVE/CLI/qm.pm +++

[pve-devel] [PATCH manager v3 6/8] When inside the wizard, actualize the scsiType display field based on iothread selection

We keep the same logic as before: once the iothread option is selected, the default SCSI controller is switched to virtio-scsi-single until iothread is unselected again. --- www/manager6/qemu/HDEdit.js | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff

[pve-devel] [PATCH manager v3 5/8] Add a field to show which SCSI controller type we are currently using

--- www/manager6/qemu/HDEdit.js | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 8a415d8b..075ad667 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -24,11 +24,12 @@

  1   2   3   4   5   6   7   8   9   >