[pve-devel] [PATCH qemu-server 0/2] Add qm diskimport command

2017-04-25 Thread Emmanuel Kasper
last month ( [PATCH qemu-server v4 0/5] Initial support for OVF import ) this should allows direct import of ovf compatible exports from other hypervisors. Emmanuel Kasper (2): Add DiskImport module to import external disk images into a VM Add new qm option 'diskimport' to import external d

[pve-devel] [PATCH qemu-server 1/2] Add DiskImport module to import external disk images into a VM

2017-04-25 Thread Emmanuel Kasper
Each disk passed as paramater is add as 'unused[n]' in the vm.conf (the default) or ide[n]|scsi[n]|sata[n] We rely on qemu-img(1) convert heuristics to detect the file type, as this works in most case. --- PVE/QemuServer/DiskImport.pm | 93 PVE/QemuServ

Re: [pve-devel] [PATCH manager] set default focus and default button for edit window

2017-04-19 Thread Emmanuel Kasper
Tested OK, and looks good to me. A nice improvement for power users. On 04/18/2017 04:55 PM, Dominik Csapak wrote: > this patch sets following defaults for the edit window: > > defaultFocus: 'field' > > sets the focus on the first field it finds in its child items, > works for most edit windows

Re: [pve-devel] back from holiday, I'll more time to work on proxmox

2017-04-18 Thread Emmanuel Kasper
On 04/16/2017 05:53 PM, Alexandre DERUMIER wrote: > Hi, > > I'm back from holiday, and I'll have a little bit more time now to work on > proxmox. > > Here some tasks I would like to work: > > > finish cloudinit integration: > https://github.com/Blub/pve-qemu-server/commits/cloudinit > > >

[pve-devel] [PATCH common v3 0/2] Allow multiple base domains for DNS queries

2017-04-13 Thread Emmanuel Kasper
tains more than 255 characters * restore behaviour of multiple 'domain' entries are defined that the first one is matched, similar to previous behavious and libc. * add tests for these variations * use English so we can accessed named capture groups whith $LAST_PAREN_MATCH{$capture_name

[pve-devel] [PATCH common v3 2/2] Fix #1234: allows multiple search domains to be set

2017-04-13 Thread Emmanuel Kasper
Changes: * multiple 'search' entries (up to 6) can be now read and added like the libc resolver * a 'search' entry list of more that 255 characters will be silently skipped, like the libc resolver When multiple 'domain' entries are defined, only the first one is matched, similar to previous b

[pve-devel] [PATCH common v3 1/2] Document current handling of reading and updating resolv.conf

2017-04-13 Thread Emmanuel Kasper
also add unit tests for the two subroutines --- src/PVE/INotify.pm| 3 + test/inotify/resolv.conf_empty_search | 5 ++ test/inotify/resolv.conf_long_search | 4 + test/inotify/resolv.conf_multiple_domain | 5 ++ test/inotify/res

Re: [pve-devel] [PATCH common v2 2/2] Fix #1234: allows multiple search domains to be set

2017-04-11 Thread Emmanuel Kasper
h domains $searchdomains = $host_resolv_conf->{search}; > On Tue, Apr 04, 2017 at 03:26:24PM +0200, Emmanuel Kasper wrote: > > some short description of this commit would be nice here, especially > regarding the comments/questions below ;) > >> --- >> src/PVE/INotify.pm | 15

[pve-devel] [PATCH qemu-kvm 2/2] Disable building the qemu-guest-agent (binary + docs)

2017-04-11 Thread Emmanuel Kasper
This fixes a conflict when installing the qemu-guest-agent debian package, where our pve-qemu-kvm and the debian package both tried to install the usr/share/man/man8/qemu-ga.8.gz file --- debian/rules | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/debian/rules b/debian

[pve-devel] [PATCH qemu-kvm 1/2] Split the very long configure line to fit in 80 columns

2017-04-11 Thread Emmanuel Kasper
No functionnal changes --- debian/rules | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index ecacfa3..1d7d5c2 100755 --- a/debian/rules +++ b/debian/rules @@ -35,7 +35,15 @@ endif config.status: configure dh_testdir # Add

Re: [pve-devel] [PATCH qemu-server v4 0/5] Initial support for OVF import

2017-04-11 Thread Emmanuel Kasper
Any feedback for this patch serie ? On 03/30/2017 04:51 PM, Emmanuel Kasper wrote: > changes since V3: > * proper rebasing of patches > * move the new build dependency in a separate patch > > Emmanuel Kasper (5): > Force overwriting existing compressed man pages and symbol

[pve-devel] [PATCH common v2 1/2] Document current handling of reading and updating resolv.conf

2017-04-04 Thread Emmanuel Kasper
also add unit tests for the two subroutines --- src/PVE/INotify.pm | 3 + test/inotify/resolv.conf_multiple_search | 5 ++ .../resolv.conf_multiple_search_and_domain_first | 6 ++ .../resolv.conf_multiple_search_and_domain_last| 6 ++ test/inotif

[pve-devel] [PATCH common v2 0/2] Handle multiple search domains in the API

2017-04-04 Thread Emmanuel Kasper
Changes since V1: * improve the regexp to match only the first 'domain' entry * strip trailing white space in domain list NB: http://pve.proxmox.com/pipermail/pve-devel/2017-March/025803.html must be applied before as ssl key generation expects a single search entry Emmanuel

[pve-devel] [PATCH common v2 2/2] Fix #1234: allows multiple search domains to be set

2017-04-04 Thread Emmanuel Kasper
--- src/PVE/INotify.pm | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 074f8b3..5f08439 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -539,11 +539,16 @@ sub read_etc_resolv_conf { my $nscount = 0;

[pve-devel] [PATCH qemu-server v4 0/5] Initial support for OVF import

2017-03-30 Thread Emmanuel Kasper
changes since V3: * proper rebasing of patches * move the new build dependency in a separate patch Emmanuel Kasper (5): Force overwriting existing compressed man pages and symbolic links Add a build dependency to libxml-libxml-perl, needed for OVF parsing Initial support for importing OVF

[pve-devel] [PATCH qemu-server v4 5/5] Add a new command line option 'ovfimport', to create VMs from an OVF manifest

2017-03-30 Thread Emmanuel Kasper
Currently the following extracted parameters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ 1 file changed, 47 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439dd..12d705c 100755 --- a/PVE/CL

[pve-devel] [PATCH qemu-server v4 4/5] Add tests for ovfimport function

2017-03-30 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports from a VmWare Workstation * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc they contain a VMDK header and the rest are null characters) --- test/Makefile

[pve-devel] [PATCH qemu-server v4 2/5] Add a build dependency to libxml-libxml-perl, needed for OVF parsing

2017-03-30 Thread Emmanuel Kasper
XML::LibXML is being actively developed, and has 91 reverse depencies in Debian Stretch, no it should not go away. --- control.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/control.in b/control.in index d0601ac..7834e31 100644 --- a/control.in +++ b/control.in @@ -3,7 +3,7

[pve-devel] [PATCH qemu-server v4 3/5] Initial support for importing OVF virtual machines

2017-03-30 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 223 2 files changed, 224 insertions(+) create mode 100644

[pve-devel] [PATCH qemu-server v4 1/5] Force overwriting existing compressed man pages and symbolic links

2017-03-30 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index cdb5aa0..9fc6cd8 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

Re: [pve-devel] [PATCH qemu-server v3 0/4] Initial support for OVF import

2017-03-30 Thread Emmanuel Kasper
Please ignore this patch serie, I did a mistake when rebasing ( patch 2 should not exist, and patch 3 should be split in two differents patches ) On 03/29/2017 04:53 PM, Emmanuel Kasper wrote: > This patch serie adds initial support for creating VMs from OVF > manifests, adding a new comman

[pve-devel] [PATCH qemu-server v3 2/4] Initial parsing of OVF files

2017-03-29 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 220 2 files changed, 221 insertions(+) create mode 100644

[pve-devel] [PATCH qemu-server v3 1/4] Force overwriting existing compressed man pages and symbolic links

2017-03-29 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index cdb5aa0..9fc6cd8 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [PATCH qemu-server v3 0/4] Initial support for OVF import

2017-03-29 Thread Emmanuel Kasper
OVF manifests and a test script in /test directory Emmanuel Kasper (4): Force overwriting existing compressed man pages and symbolic links Initial parsing of OVF files Add a new command line option 'ovfimport', to create VMs from an OVF manifest Add tests for ovfimpor

[pve-devel] [PATCH qemu-server v3 4/4] Add tests for ovfimport function

2017-03-29 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports from a VmWare Workstation * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc they contain a VMDK header and the rest are null characters) --- test/Makefile

[pve-devel] [PATCH qemu-server v3 3/4] Add a new command line option 'ovfimport', to create VMs from an OVF manifest

2017-03-29 Thread Emmanuel Kasper
Currently the following extracted paramaters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ PVE/QemuServer/OVF.pm | 161 +- control.in| 2 +- 3 files changed

[pve-devel] [PATCH docs] Use 'light' here, because thin migh create confusion with lvm thin

2017-03-23 Thread Emmanuel Kasper
--- pve-storage-lvm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-storage-lvm.adoc b/pve-storage-lvm.adoc index b337c86..72083b5 100644 --- a/pve-storage-lvm.adoc +++ b/pve-storage-lvm.adoc @@ -7,7 +7,7 @@ endif::wiki[] Storage pool type: `lvm` -LVM is a thin so

[pve-devel] [PATCH docs] Fix path to block device when creating a file system on a thin volume

2017-03-23 Thread Emmanuel Kasper
The path component following /dev/ should be the volume group where the thin pool exists, not the name of the thin pool itself. (the fstab example underneath has this right) --- local-lvm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/local-lvm.adoc b/local-lvm.adoc inde

[pve-devel] [PATCH cluster] Use a real FQDN when defining the CommonName entry of SSL certs

2017-03-22 Thread Emmanuel Kasper
The proper way to set the fqdn is via /etc/hosts or via DNS -see hostname(1)- --- data/PVE/Cluster.pm | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index ab57da9..e694d93 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/

[pve-devel] [PATCH common] Use "real" Fully Qualified Domain Name for setting the common name of a ssl cert

2017-03-22 Thread Emmanuel Kasper
Names CCing Fabian for review Emmanuel Kasper (1): Add utility subroutine to get the fully qualified domain name of a host src/PVE/Tools.pm | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) -- 2.1.4 ___ pve-devel mailing

[pve-devel] [PATCH common] Add utility subroutine to get the fully qualified domain name of a host

2017-03-22 Thread Emmanuel Kasper
--- src/PVE/Tools.pm | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 69c8730..4815d61 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -4,7 +4,7 @@ use strict; use warnings; use POSIX qw(EINTR EEXIST EOPNOT

Re: [pve-devel] [PATCH manager v2 1/2] Add a new renderer for displaying dates in a human readable way

2017-03-20 Thread Emmanuel Kasper
On 03/13/2017 12:52 PM, Wolfgang Bumiller wrote: > While writing the change log I was wondering why you chose a specific > format there. Isn't there a way to tell the browser to give you a locale > dependent somewhat sane format? Otherwise why care? Yes this makes sense, I will look if there are c

[pve-devel] [PATCH common 2/2] Fix #1270: properly read multiple search domains in /etc/resolv.conf

2017-03-08 Thread Emmanuel Kasper
--- src/PVE/INotify.pm | 2 +- test/inotify/resolv.conf_multiple_search | 5 + test/inotify/run_inotify_tests.pl| 16 +++- 3 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 test/inotify/resolv.conf_multiple_search diff --git a/sr

[pve-devel] [PATCH common 1/2] Document current handling of reading and updating resolv.conf

2017-03-08 Thread Emmanuel Kasper
also add unit tests for the two subroutines --- should the unit tests be added to make check target ? src/PVE/INotify.pm | 3 ++ test/inotify/resolv.conf_single_domain | 5 test/inotify/resolv.conf_single_search | 5 test/inotify/run_inotify_tests.pl | 50

[pve-devel] [PATCH docs] Document that Sys.Audit allows also to read cluster paramaters

2017-03-06 Thread Emmanuel Kasper
--- pveum.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveum.adoc b/pveum.adoc index db196b5..6c35833 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -249,7 +249,7 @@ Node / System related privileges:: * `Sys.PowerMgmt`: Node power management (start, stop, reset, shutdown,

[pve-devel] [PATCH cluster] Require Sys.Audit to read the cluster configuration

2017-03-06 Thread Emmanuel Kasper
Up to now only root could see the corosync cluster config. Sys.Audit is the same permission required for reading the HA Config and the HA Resources Config. --- NB: a patch for the permission description in user management will folow data/PVE/API2/ClusterConfig.pm | 9 + 1 file changed, 9

Re: [pve-devel] [PATCH manager] add css fix for chrome >=56

2017-03-02 Thread Emmanuel Kasper
LGTM but can we include a link in the commit log to the sencha forum post discussing the issue ? On 03/02/2017 08:45 AM, Dominik Csapak wrote: > with chrome/chromium version 56, they changed the way how they calculate > height of text in input fields (now it is correct according to the > standard)

[pve-devel] [PATCH manager] Do not translate IT terms which should be used 'as is' in every language

2017-03-01 Thread Emmanuel Kasper
for 'Initialize GPT' we use the alternate 'Initialize Disk with GPT' string which was already existing --- www/manager6/Utils.js| 4 ++-- www/manager6/grid/FirewallOptions.js | 4 ++-- www/manager6/lxc/Options.js | 2 +- www/manager6/node/Disks.js | 2 +- 4 files

[pve-devel] [PATCH qemu-server] Use backticks instead of single quotes in qm resize description

2017-03-01 Thread Emmanuel Kasper
Single quoted text in asciidoc is rendered in man pages with underlines, which makes the '+' symbol very similar to '+/-' Backticks are rendered with monospace text in HTML, normal text in man pages, and still readable in raw format. --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1

Re: [pve-devel] [PATCH 3/3] add qmimport command

2017-03-01 Thread Emmanuel Kasper
Hi Alexandre >>> If I missed something or something is unclear or does not work as >>> expected, just shout ;) > > Ok,I'll send a patch this way. I just wanted to avoid as much as possible > duplicate code. Are you working on this ? I guest at some point we will need this for importing the dis

[pve-devel] [PATCH manager] Rename 'create' to 'isCreate' in pveWindowEdit and subclasses

2017-02-28 Thread Emmanuel Kasper
This fixes around 20 jslint type confusion warnings. Also reduce the scope and document jslint warnings along the way. No functional changes. --- www/manager6/ceph/Monitor.js | 4 ++-- www/manager6/ceph/OSD.js | 11 + www/manager6/ceph/Pool.js | 5 +

[pve-devel] [RFC PATCH qemu-server v2 2/5] Add depency to libxml-simple-perl

2017-02-28 Thread Emmanuel Kasper
XML::Simple provides a much cleaner output than XML::Parser, as XML::Parser tries to preserve everything in the document (line breaks) when we don't need this information. The current known limitation of XML::Simple is that it is not recommended for generating XMl, but this is not our aim. --- c

[pve-devel] [RFC PATCH qemu-server v2 1/5] Force overwriting existing compressed man pages and symbolic links

2017-02-28 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index d59af8c..95e647f 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [RFC PATCH qemu-server v2 5/5] Add tests for ovfimport function

2017-02-28 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports of VM from a VmWare Workstation export * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc i: they contain a VMDK header and the rest are null characters) --- tes

[pve-devel] [RFC PATCH qemu-server v2 3/5] Initial parsing of OVF files

2017-02-28 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 217 2 files changed, 218 insertions(+) create mode 100644

[pve-devel] [RFC PATCH qemu-server v2 0/5] Initial support for OVF imports

2017-02-28 Thread Emmanuel Kasper
t in /test directory Emmanuel Kasper (5): Force overwriting existing compressed man pages and symbolic links Add depency to libxml-simple-perl Initial parsing of OVF files Add a new command line option 'ovfimport', to create VMs from an OVF manifest Add tests for

[pve-devel] [RFC PATCH qemu-server v2 4/5] Add a new command line option 'ovfimport', to create VMs from an OVF manifest

2017-02-28 Thread Emmanuel Kasper
Currently the following extracted paramaters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ PVE/QemuServer/OVF.pm | 22 +- 2 files changed, 64 insertions(+), 5 deletion

Re: [pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

2017-02-27 Thread Emmanuel Kasper
On 02/22/2017 11:07 AM, Dominik Csapak wrote: > On 02/09/2017 04:13 PM, Emmanuel Kasper wrote: >> >> +emptyText: gettext('Same as source'), >> >> On 02/08/2017 07:05 PM, Dietmar Maurer wrote: >>> I would like to avoid additional gettext entr

Re: [pve-devel] [PATCH manager] correctly set 'nowritecache' on zfsplugin

2017-02-22 Thread Emmanuel Kasper
On 02/22/2017 11:12 AM, Dominik Csapak wrote: > the logic was reversed, checking writecache enabled 'nowritecache', > now the logic is correct, setting 'nowritecache' if 'writecache' is > unchecked > > Signed-off-by: Dominik Csapak > --- > i think this is a better and more elegant approach to the

[pve-devel] [RFC PATCH qemu-server 2/4] Add depency to libxml-simple-perl

2017-02-21 Thread Emmanuel Kasper
XML::Simple provides a much cleaner output than XML::Parser, as XML::Parser tries to preserve everything in the document (line breaks) when we don't need this information. The current known limitation of XML::Simple is that it is not recommended for generating XMl, but this is not our aim. --- c

[pve-devel] [RFC PATCH qemu-server 4/4] Add a new command line option 'ovfcreate', to create VMs from an OVF manifest

2017-02-21 Thread Emmanuel Kasper
Currently the following extracted paramaters are used to create a VM: * VM name * Memory * Number of cores --- PVE/CLI/qm.pm | 47 +++ 1 file changed, 47 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 44439dd..f431023 1007

[pve-devel] [RFC PATCH qemu-server 0/4] Initial support for creating VMs from OVF manifests

2017-02-21 Thread Emmanuel Kasper
finally the disk images) For testing I used the with the Windows IE Edge test VMWare machine from https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ Emmanuel Kasper (4): Force overwriting existing compressed man pages and symbolic links Add depency to libxml-simple-perl Initial

[pve-devel] [RFC PATCH qemu-server 1/4] Force overwriting existing compressed man pages and symbolic links

2017-02-21 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index d59af8c..95e647f 100644 --- a/Makefile +++ b/Makefile @@ -81,12 +81,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [RFC PATCH qemu-server 3/4] Initial parsing of OVF files

2017-02-21 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 209 2 files changed, 210 insertions(+) create mode 100644

[pve-devel] [PATCH cluster] Remove depency to libxml-parser-perl

2017-02-16 Thread Emmanuel Kasper
This xml parser was added to parser RHCM cluster.conf, we don't parse this anymore. --- data/PVE/Cluster.pm | 1 - debian/control.in | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 09ed5d7..39708c8 100644 --- a/data/PVE/Cluste

[pve-devel] [PATCH qemu-server] Improve error message when trying to shrink a volume, fix typo

2017-02-16 Thread Emmanuel Kasper
--- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a41e74f..a077ed7 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3049,7 +3049,7 @@ __PACKAGE__->register_method({ $newsize += $size if $ext;

[pve-devel] [RFC PATCH common] Fix example to latest RestHandler

2017-02-14 Thread Emmanuel Kasper
looking at the handle() sub from RestHandler.pm my $result = &$func($param); this parameters are not passed anymore --- README.dev | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.dev b/README.dev index a97f1c8..f68c169 100644 --- a/README.dev +++ b/README.dev @@ -1

Re: [pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

2017-02-09 Thread Emmanuel Kasper
+ emptyText: gettext('Same as source'), On 02/08/2017 07:05 PM, Dietmar Maurer wrote: > I would like to avoid additional gettext entries if possible. > > Do we know the source storage? If so, can we set that storage as 'emptyText'? > Other ideas? We don't know the source storage*s*, w

[pve-devel] Ack: Re: [PATCH storage 1/3] rbd: use 'rbd ls' without '-l' to find free names

2017-02-09 Thread Emmanuel Kasper
I tested this patch OK, and code looks good to me. On 02/03/2017 01:00 PM, Fabian Grünbichler wrote: > with more than a few images, 'rbd ls -l' gets rather slow > compared to a simple 'rbd ls'. since we only need to check > existing image names for finding a free one, the latter is > sufficient. >

[pve-devel] [PATCH manager] Indentation fix

2017-02-08 Thread Emmanuel Kasper
--- www/manager6/qemu/Clone.js | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index f8b71b5..471a62a 100644 --- a/www/manager6/qemu/Clone.js +++ b/www/manager6/qemu/Clone.js @@ -244,12 +244,12 @@ Ext.define('

[pve-devel] [RFC PATCH manager] Make explicit the meaning of an empty storage field

2017-02-08 Thread Emmanuel Kasper
By default when no target storage is selected in the clone panel, the clone will use the same storage*s* as the source. This was not obvious to guess that from the panel. --- www/manager6/qemu/Clone.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/q

[pve-devel] [PATCH manager 2/3] Move the snapshot API test to a static function

2017-02-06 Thread Emmanuel Kasper
This will allow code reuse in a following patch. No functional change. --- www/manager6/qemu/Clone.js | 25 +++-- www/manager6/qemu/CmdMenu.js | 18 +- 2 files changed, 24 insertions(+), 19 deletions(-) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/

[pve-devel] [PATCH manager 3/3] Add a clone button in the VM toolbar

2017-02-06 Thread Emmanuel Kasper
Up to now the Migrate function had a first class button in the toolbar, but the Clone function didn't. With this button the toolbar still fit correctly in a smaller 1280 pixel wide display. --- www/manager6/qemu/Config.js | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --gi

[pve-devel] [PATCH manager 1/3] Fix handling of failed API call verifyFeature()

2017-02-06 Thread Emmanuel Kasper
This call can for instance fails when a source VM has references to non existing storages. --- www/manager6/qemu/Clone.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index ce6e4f3..8a3b34a 100644 --- a/www/manager6/qem

[pve-devel] [PATCH manager 0/3] Add a Clone button to the VM toolbar

2017-02-06 Thread Emmanuel Kasper
Cloning a VM was up to now only accessible via right clicking the resource tree, a path that many novice PVE users did not notice. Adding this is as a general button will make the feature easier to find. Emmanuel Kasper (3): Fix handling of failed API call verifyFeature() Move the snapshot

Re: [pve-devel] LXC with 2 and more NICs

2017-02-06 Thread Emmanuel Kasper
On 02/02/2017 10:03 PM, Detlef Bracker wrote: > Dear, > > I thing so, thats a bug! > > A ping from outside to the LXC-containers to all NICs works fine! > > A ping from console via the NICs 2- is not possible! So, this can > been a big problem, when a daemon will send from the NICs 2- >

[pve-devel] [PATCH manager v2] Use ip from iproute2 package instead of net-tools

2017-02-06 Thread Emmanuel Kasper
iproute2 is a direct depency from pve-qemu-kvm and should be always available use -statistics so we get the RX/TX traffic sum like ifconfig use -details to get extra info like current vlan_protocol --- changes since v1: * add -details as suggested by w.bumiller PVE/Report.pm | 2 +- 1 file chang

Re: [pve-devel] [PATCH manager] Use ip from iproute2 package instead of net-tools

2017-02-06 Thread Emmanuel Kasper
On 02/06/2017 03:02 PM, Wolfgang Bumiller wrote: > On Mon, Feb 06, 2017 at 02:37:16PM +0100, Emmanuel Kasper wrote: >> iproute2 is a direct depency from pve-qemu-kvm and should >> be always available >> >> use -statistics so we get the RX/TX traffic sum like ifconfig &

[pve-devel] [PATCH manager] Use ip from iproute2 package instead of net-tools

2017-02-06 Thread Emmanuel Kasper
iproute2 is a direct depency from pve-qemu-kvm and should be always available use -statistics so we get the RX/TX traffic sum like ifconfig --- PVE/Report.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Report.pm b/PVE/Report.pm index 901fcf8..d32b968 100644 --- a/PVE/R

[pve-devel] [PATCH manager v2 1/2] Add a new renderer for displaying dates in a human readable way

2017-01-31 Thread Emmanuel Kasper
render_timestamp returns a Date as "2017-01-31 16:17:33" which is good for computers and column sorting but unfit for human consumption the new renderer added by this patch renders a Date as "Tuesday 31 January 2017 16:18:08" Day-month-year order is the most used ordering in the world and also co

[pve-devel] [PATCH manager v2 2/2] Fix #1266: use a renderer when displaying Unix timestamps.

2017-01-31 Thread Emmanuel Kasper
The timestamp is displayed read only in a large window, and not sortable, hence we use the human readable renderer. --- www/manager6/qemu/Snapshot.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/Snapshot.js b/www/manager6/qemu/Snapshot.js index d438d68..3

[pve-devel] [PATCH manager] Fix #1266: Convert Unix timestamps to milliseconds for JS Date() constructor

2017-01-31 Thread Emmanuel Kasper
While we're at it, use Ext.Date.format to localize the displayed dates. We use long day names and long month name on purpose since the date is displayed read only in a large window, and not sortable. Output before the patch: Sun Jan 18 1970 05:37:06 GMT+0100 (CET) Output after: Donnerstag 26 Janu

[pve-devel] [PATCH manager 1/2] Add new renderer function for toggling enabled/disabled options

2017-01-23 Thread Emmanuel Kasper
--- www/manager6/Utils.js | 6 ++ 1 file changed, 6 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 40d2fe1..c05a137 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -745,6 +745,8 @@ Ext.define('PVE.Utils', { utilities: { yesText: gettext

[pve-devel] [PATCH manager 2/2] Use the enabled/disabled toggler to render grid options

2017-01-23 Thread Emmanuel Kasper
Allows getting rid of multiple "Enable foobar" gettext strings in LXC and Firewall option panels. --- www/manager6/grid/FirewallOptions.js | 16 www/manager6/lxc/Options.js | 8 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/www/manager6/grid/F

Re: [pve-devel] Question: open virtual appliance

2017-01-19 Thread Emmanuel Kasper
On 01/19/2017 07:46 AM, Alexandre DERUMIER wrote: > Hi, > > as a first step, I have send patch to import external disk image. > > now for ova import, > I think we need a method to extract files from ova (it's a simple tar file), > > then an xml parser to parse OVF descriptor > > Does somebody

[pve-devel] [PATCH manager v2 1/2] Remove technical terms from content to be translated

2017-01-18 Thread Emmanuel Kasper
--- www/manager6/ceph/Status.js | 4 ++-- www/manager6/dc/Health.js | 2 +- www/manager6/dc/Summary.js | 2 +- www/manager6/ha/ResourceEdit.js | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js index ff71

[pve-devel] [PATCH manager v2 2/2] Split the Enable + name construct in two separate gettext strings

2017-01-18 Thread Emmanuel Kasper
This reduce the number of strings to translate. --- www/manager6/grid/FirewallOptions.js | 10 +- www/manager6/lxc/Options.js | 6 +++--- www/manager6/lxc/ResourceEdit.js | 2 +- www/manager6/qemu/ProcessorEdit.js | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-)

[pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Emmanuel Kasper
Mostly split out technical term who don't need to be translated outside of the gettext function paramater. --- www/manager6/ceph/Status.js | 4 ++-- www/manager6/dc/Health.js| 2 +- www/manager6/dc/Summary.js | 2 +- www/manager6/grid/FirewallOptions.js | 10 +

Re: [pve-devel] Question: open virtual appliance

2017-01-18 Thread Emmanuel Kasper
On 01/16/2017 10:14 PM, Gustaf Ankarloo wrote: > Are there any plans of making a import function for OVA/OVF ? > I know it's doable with a lot of manual tinkering I have this somewhere in my todo list although it is not high priority at the momment. I would like to try to following approach: * e

[pve-devel] [PATCH manager 0/3] Reduce the number of required translations

2017-01-18 Thread Emmanuel Kasper
A side note: if you use an english technical term in your own language (DHCP, DNS) it probably does not need a translation. Emmanuel Kasper (3): Remove duplicate strings Do not try to translate domain specific terms Remove redundant helper for login window www/manager6/Utils.js

[pve-devel] [PATCH manager 3/3] Remove redundant helper for login window

2017-01-18 Thread Emmanuel Kasper
the information is already provided by the label, the helper does not add meaningfull information here. --- www/manager6/ceph/Config.js| 2 +- www/manager6/window/LoginWindow.js | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/www/manager6/ceph/Config.js b/www/man

[pve-devel] [PATCH manager 1/3] Remove duplicate strings

2017-01-18 Thread Emmanuel Kasper
--- www/manager6/Utils.js| 2 +- www/manager6/node/Config.js | 2 +- www/manager6/qemu/Options.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 180b283..40d2fe1 100644 --- a/www/manager6/Utils.js +++ b/www/manage

[pve-devel] [PATCH manager 2/3] Do not try to translate domain specific terms

2017-01-18 Thread Emmanuel Kasper
No one is translating DHCP in his/her own language. --- www/manager6/ceph/Config.js | 2 +- www/manager6/ceph/Pool.js | 2 +- www/manager6/ceph/Status.js | 2 +- www/manager6/dc/Health.js | 2 +- www/manager6/lxc/Network.js | 18 +- 5 files changed, 13 insertions(+), 13 del

[pve-devel] [PATCH manager] Disable autoSelect of target storage

2017-01-12 Thread Emmanuel Kasper
autoSelect: true was surreptitiously commited with the refactoring of 3656c0b9f3742f952b1684f3b6ea9f519d8cd5bd ( Use component references via lookupReference() ) --- www/manager6/qemu/Clone.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/Clone.js b/www/man

[pve-devel] [PATCH manager v3] Use component references via lookupReference()

2017-01-12 Thread Emmanuel Kasper
This allows to add the components in each column in the order they appear in the Clone Window. References from child components are kept in an object in the parent component so it should be the same performance-wise (contrary to to Ext.ComponentQuery which is doing DOM parsing) --- changes: * cor

[pve-devel] [PATCH manager v2] Use component references via lookupReference()

2017-01-12 Thread Emmanuel Kasper
This allows to add the components in each column in the order they appear in the Clone Window. References from child components are kept in an object in the parent component so it should be the same performance-wise (contrary to to Ext.ComponentQuery which is doing DOM parsing) --- changes since v

[pve-devel] [PATCH manager v3] Update French translation

2017-01-12 Thread Emmanuel Kasper
n 11 10:58:53 2017\n" -"PO-Revision-Date: 2016-04-07 13:14+0100\n" +"PO-Revision-Date: 2017-01-12 09:40+0100\n" "Last-Translator: Emmanuel Kasper \n" "Language-Team: French\n" "Language: fr\n" @@ -30,7 +30,7 @@ msgstr "/chemin/repertoire

[pve-devel] [PATCH manager 4/9] Make the Snapshot selector an optional parameter in the Clone Window

2017-01-12 Thread Emmanuel Kasper
The snapshot selector was known to confuse first time pve users. Some wondered that they had no snapshot called 'current' in their snapshot trees, and other thought that snapshots would be included in the copied image. So before displaying the Clone Window, do an API call to verify if the source V

[pve-devel] [PATCH manager 7/9] Do not show a Clone Mode selection Window for non-templates clones

2017-01-12 Thread Emmanuel Kasper
As Non-templates clones are always a full clone. --- www/manager6/qemu/Clone.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index 3b3577e..af088b2 100644 --- a/www/manager6/qemu/Clone.js +++ b/www/manager6/qemu/Clone.js @@ -169,6 +169

[pve-devel] [PATCH manager 0/9] Usability Improvements and minor refactoring for the Clone Window

2017-01-12 Thread Emmanuel Kasper
target storage, just like in the Wizards Emmanuel Kasper (9): Better naming for kv1 comb box, document the two private functions Use correct parameter for GuestIDSelector Disable the submit button based on whole form validity Make the Snapshot selector an optional parameter in the Clone

[pve-devel] [PATCH manager 3/9] Disable the submit button based on whole form validity

2017-01-12 Thread Emmanuel Kasper
Until now we disabled the submit button, based on the feature API call where we tested if the selected VM, and its snapshot can be used as the source of a clone. This had the following problems: * the feature test for copy clone / linked clone always returned true, since the passed paramaters we

[pve-devel] [PATCH manager 1/9] Better naming for kv1 comb box, document the two private functions

2017-01-12 Thread Emmanuel Kasper
--- www/manager6/qemu/Clone.js | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index 9d6fdae..3296f5e 100644 --- a/www/manager6/qemu/Clone.js +++ b/www/manager6/qemu/Clone.js @@ -53,10 +53,14 @@ Ext.defi

[pve-devel] [PATCH manager 2/9] Use correct parameter for GuestIDSelector

2017-01-12 Thread Emmanuel Kasper
--- www/manager6/qemu/Clone.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index 3296f5e..2843921 100644 --- a/www/manager6/qemu/Clone.js +++ b/www/manager6/qemu/Clone.js @@ -191,7 +191,7 @@ Ext.define('PVE.window.Clon

[pve-devel] [PATCH manager 5/9] Group the Pool selector combobox to the VM properties

2017-01-12 Thread Emmanuel Kasper
The pool membership relates here to the VM membership, not the storage membership, so it makes sense to move it closer to the VM ID / VM name form fields. --- www/manager6/qemu/Clone.js | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/www/manager6/qemu/Clone.js b

[pve-devel] [PATCH manager 9/9] Use component references via lookupReference()

2017-01-12 Thread Emmanuel Kasper
This allows to add the components in each column in the order they appear in the Clone Window. References from child components are kept in an object in the parent component so it should be the same performance-wise (contrary to to Ext.ComponentQuery which is doing DOM parsing) --- www/manager6/q

[pve-devel] [PATCH manager 6/9] Autoselect a storage on VM Clone.

2017-01-12 Thread Emmanuel Kasper
--- www/manager6/qemu/Clone.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index 966bd06..3b3577e 100644 --- a/www/manager6/qemu/Clone.js +++ b/www/manager6/qemu/Clone.js @@ -228,7 +228,7 @@ Ext.define('PVE.window.Clon

[pve-devel] [PATCH manager 8/9] Use qcow2 as default disk format for clones fix: #1144

2017-01-12 Thread Emmanuel Kasper
When using a file based storage, qcow2 has more features as raw, this is why we recommend it for clones, similarly to when adding new disk images. --- www/manager6/qemu/Clone.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index af088b

[pve-devel] [PATCH manager v2] Update French translation

2017-01-12 Thread Emmanuel Kasper
uot;PO-Revision-Date: 2016-04-07 13:14+0100\n" +"PO-Revision-Date: 2017-01-12 09:40+0100\n" "Last-Translator: Emmanuel Kasper \n" "Language-Team: French\n" "Language: fr\n" @@ -30,7 +30,7 @@ msgstr "/chemin/repertoire/" #: ../www/manager6/lxc/R

[pve-devel] [PATCH manager] Update French translation

2017-01-11 Thread Emmanuel Kasper
+++ b/po/fr.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: pve-manager 2.0\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Wed Jan 11 10:58:53 2017\n" -"PO-Revision-Date: 2016-04-07 13:14+0100\n" +"PO-Revision-Date: 2017-01-11 16:17+01

[pve-devel] [PATCH manager v2] Reload the grid list of backups after the backup task completion

2017-01-05 Thread Emmanuel Kasper
This allows visual feedback for first time users doing a backup. --- change the way we reload by hiding the backup window instead of passing aroung the reload() function www/manager6/grid/BackupView.js | 7 ++- www/manager6/window/Backup.js | 12 ++-- 2 files changed, 16 insertions

<    1   2   3   4   5   6   7   8   9   10   >