Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> But ok, we can add my vlan version, at least to not break current > configuration if user don't define vlan interface. > I'll send a patch today. OK, thanks. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/l

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

riginal - De: "dietmar" À: "aderumier" Cc: "Wolfgang Bumiller" , "datanom.net" , "pve-devel" Envoyé: Mardi 28 Juillet 2015 21:03:48 Objet: Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2 > >>Besides, would you mind

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> >>Besides, would you mind to send your scripts to the debian maintainers? > >>They looks like an improvement to me :-) > > I'm not sure, but maybe the best way is to remove the vlan package totally. > It seem like deprecated. (vconfig, manage only old interfaces names,...) So you don't want th

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

atanom.net" , "pve-devel" Envoyé: Mardi 28 Juillet 2015 19:20:50 Objet: Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2 > (My opinion is that ifupdown is totally a mess, because it's splitted with > differents packages/scripts, > and with diff

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> (My opinion is that ifupdown is totally a mess, because it's splitted with > differents packages/scripts, > and with different maintainers and they don't seem to talk together. > Looking at debian bugs, I'm seeing pending bugs since years still not fixed) Besides, would you mind to send your s

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

Many thanks for the detailed description! > (My opinion is that ifupdown is totally a mess, because it's splitted with > differents packages/scripts, > and with different maintainers and they don't seem to talk together. > Looking at debian bugs, I'm seeing pending bugs since years still not fix

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

otally a mess, because it's splitted with differents packages/scripts, and with different maintainers and they don't seem to talk together. Looking at debian bugs, I'm seeing pending bugs since years still not fixed) ----- Mail original - De: "dietmar" À: "ade

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> But the problem, is that it's not working for vlan interface in bridge_ports > and other random named interfaces. > > here a bug report from michael : > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=742547 So we are totally incompatible with old wheezy?! Cant we make it compatible? > Anywa

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

# Test for vlan raw device (#196890, #292648) *) [ -z "$IF_VLAN_RAW_DEVICE" ] && exit 0 ;; esac if [ -e "/sys/class/net/$IFACE" ]; then ip link delete $IFACE fi - Mail original - De: "dietmar" À: "aderumier" Cc: "Wolfgang B

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> I would like to send it to debian maintainers. (I don't known how much time it > could take). > > But first, I think we could remove the vlan package, and push scripts in > pve-manager package. > I can remove the vconfig binaries, so only 2-3 scripts are needed. Ah, OK - good idea. I will also

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

ve the vlan package, and push scripts in pve-manager package. I can remove the vconfig binaries, so only 2-3 scripts are needed. - Mail original - De: "dietmar" À: "Wolfgang Bumiller" , "aderumier" Cc: "pve-devel" Envoyé: Mardi 28 Juillet 2015 1

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> I'm currently try to cleanup "vlan" ifupdown script from debian, removing > vconfig dependency. Oh, so we simply ship our own vlan package with updated vlan ifupdown script? Or you plan to send patches to debian maintainers? ___ pve-devel mailing list

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

rkd don't even support vlan aware bridge. I'm currently try to cleanup "vlan" ifupdown script from debian, removing vconfig dependency. - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "dietmar" , "pve-devel"

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

On Tue, Jul 28, 2015 at 10:55:29AM +0200, Alexandre DERUMIER wrote: > >>Also, it is quite unsure if ifupdown2 gets included in debian. > >>What if they switch to systemd-networkd instead? > >> > >>Maybe it is more future-proof to support systemd networking instead? > > I have add a look at it, br

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> Maybe it is more future-proof to support systemd networking instead? We should investigate and find out if it supports all our usecases. Other than that: Pros: * multiple files => less parse&merge work Cons: * more work for the initial implementation * debian and its incredibly fast upda

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

t of other things) So, I think it'll not be ready before 2 or 3 years. - Mail original - De: "dietmar" À: "Wolfgang Bumiller" , "aderumier" Cc: "pve-devel" Envoyé: Mardi 28 Juillet 2015 10:47:44 Objet: Re: [pve-devel] [PATCH] add vlan aware

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> I don't known if we could contribute to ifupdown2 project ? (But I'm pretty > poor in python) Same for me. I do not really like python. > It's almost working on jessie (I have 1 or 2 patches, because cumulus have > sometime different path for binaries). > > big missing part is openvswitch, a

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> yes, I think also it's really stupid to restrict to specific name. OTOH the rest of ifupdown does it, too, so it doesn't break any more than ifupdown is already breaking... Just wanted to point it out so we remember it if we start patching up ifupdown more.

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

iginal - De: "aderumier" À: "Wolfgang Bumiller" Cc: "pve-devel" Envoyé: Mardi 28 Juillet 2015 09:57:50 Objet: Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2 >> + if [[ $port =~ ^(eth|bond|wlan)[0-9]{1,2}$ ]] >>Isn't there a

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

's really stupid to restrict to specific name. ifupdown2 allow any name for vlan interface (*.*) for example https://github.com/CumulusNetworks/ifupdown2/blob/master/ifupdown2/addons/vlan.py - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: &qu

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

> + if [[ $port =~ ^(eth|bond|wlan)[0-9]{1,2}$ ]] Isn't there a better way to do this? Like checking the interface type via /proc? Because otherwise we end up with more threads like: Restricting interface

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

The best should be to merge all in the vlan file, but I don't known how to not conflict with debian vlan package. - Mail original - De: "dietmar" À: "aderumier" , "pve-devel" Envoyé: Mardi 28 Juillet 2015 09:18:05 Objet: Re: [pve-devel] [PATCH] a

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

Seems we have the same code in /etc/network/if-pre-up.d/vlan /etc/network/if-pre-up.d/vmbrvlan So what code gets executed? both? > diff --git a/vmbrvlan b/vmbrvlan > new file mode 100755 > index 000..ee570f0 > --- /dev/null > +++ b/vmbrvlan > @@ -0,0 +1,38 @@ > +#!/bin/sh > + > +# Most of t

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

fault kernel ,) I think it's almost 90% done, but it's better to wait that debian integrated it officially. - Mail original - De: "dietmar" À: "aderumier" Cc: "Wolfgang Bumiller" , "pve-devel" Envoyé: Samedi 25 Juillet 2015 10:46:09

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

> >> So we could simply copy/re-usethe old scripts? > > I'm not sure how to mix both old bash script and this new python code > Implementation of scripts are mostly done here: > https://github.com/CumulusNetworks/ifupdown2/tree/master/ifupdown2/addons Ah, OK - So I guess it is better to use norma

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

ks/ifupdown2/tree/master/ifupdown2/addons - Mail original - De: "dietmar" À: "Wolfgang Bumiller" , "aderumier" Cc: "pve-devel" Envoyé: Vendredi 24 Juillet 2015 20:11:02 Objet: Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script > I&#

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

> I'll test ifupdown2 tomorrow. (python) > > https://github.com/CumulusNetworks/ifupdown2 > > > But it missing tunnel interfaces, and I known that some users use them. > > (and it's also missing openvswitch syntax). But they claim to be fully ifupdown compatible? So we could simply copy/re-u

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

t; , "dietmar" Cc: "pve-devel" Envoyé: Vendredi 24 Juillet 2015 18:51:40 Objet: Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script > On July 24, 2015 at 6:42 PM Dietmar Maurer wrote: > > I have simply copy/paste current code from /etc/network/

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

> On July 24, 2015 at 6:42 PM Dietmar Maurer wrote: > > I have simply copy/paste current code from /etc/network/if-pre-up.d/vlan > > So, it should work with bash and dash ? > > package libpve-common-perl does not depend on bash, so its best to avoid bash? > Or should we add a dependency to make co

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

> I have simply copy/paste current code from /etc/network/if-pre-up.d/vlan > So, it should work with bash and dash ? package libpve-common-perl does not depend on bash, so its best to avoid bash? Or should we add a dependency to make code easier? ___ pv

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

On Fri, Jul 24, 2015 at 02:10:27PM +0200, Alexandre DERUMIER wrote: > >>On the vmbr interfaces we separate vlans with a 'v' (ie vmbr0v5 would > >>be vmbr0's vlan 5), or is a change to dotted notation required for this? > >>We use the dots only on physical interfaces. > > It's not a new bridge, it'

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

ail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Vendredi 24 Juillet 2015 12:12:39 Objet: Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script A couple of questions: > + vmbr*.*) On the vmbr interfaces we separate vlans

Re: [pve-devel] [PATCH] add vlan aware bridge ifupdown script

A couple of questions: > + vmbr*.*) On the vmbr interfaces we separate vlans with a 'v' (ie vmbr0v5 would be vmbr0's vlan 5), or is a change to dotted notation required for this? We use the dots only on physical interfaces. > +VLANID=`echo $IFACE|sed "s/vmbr[0-9][0-9]*\.0*//g"` Why the /0*

[pve-devel] [PATCH] add vlan aware bridge ifupdown script v2

This add support to enable vlan aware bridge, and management interfaces example: 1 bridge and 1 administration port on vlan 100 auto vmbr0 iface vmbr0 inet manual bridge_ports eth0 bridge_stp off bridge_fd 0 bridge_vlan_aware yes bridge_vids 10-15 auto vmb

[pve-devel] [PATCH] add vlan aware bridge ifupdown script

This add support to enable vlan aware bridge, and management interfaces example: 1 bridge and 1 administration port on vlan 100 auto vmbr0 iface vmbr0 inet manual bridge_ports eth0 bridge_stp off bridge_fd 0 bridge_vlan_aware yes bridge_vids 10-15 auto vmb