Re: [pve-devel] [PATCH container] Improve error handling in snapshot_create

2016-02-05 Thread Wolfgang Bumiller
On Thu, Feb 04, 2016 at 04:05:11PM +0100, Fabian Grünbichler wrote: > Set unfreeze before trying to freeze, otherwise an aborted > or failed lxc-freeze will not be reversed by our error > handling, leaving the container in a (partially) frozen > state. > > Add a call to snapshot_commit in its own

[pve-devel] [PATCH container] Improve error handling in snapshot_create

2016-02-04 Thread Fabian Grünbichler
Set unfreeze before trying to freeze, otherwise an aborted or failed lxc-freeze will not be reversed by our error handling, leaving the container in a (partially) frozen state. Add a call to snapshot_commit in its own eval block to the error handling code, because we want to cleanup and unlock