Re: [pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

2016-02-05 Thread Dietmar Maurer
> On February 5, 2016 at 11:05 AM Wolfgang Bumiller > wrote: > > > Should I resend just that patch or the whole series? whatever you like... ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-de

Re: [pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

2016-02-05 Thread Wolfgang Bumiller
Should I resend just that patch or the whole series? I also have another patch pending which I can send either separately or as part of the v2 series. > On February 5, 2016 at 10:42 AM Dietmar Maurer wrote: > > > > - PVE::Tools::run_command(['unshare', '-m', '--', 'sh', > > '

Re: [pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

2016-02-05 Thread Dietmar Maurer
> - PVE::Tools::run_command(['unshare', '-m', '--', 'sh', > '-c', $cmd]); > + eval { > + PVE::Tools::run_command(['unshare', '-m', '--', > 'sh', '-c', $cmd]); > + }; I would also add the 'warn' statement directly

Re: [pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

2016-02-05 Thread Wolfgang Bumiller
> On February 5, 2016 at 9:53 AM Dietmar Maurer wrote: > > > > } else { > > - PVE::Tools::run_command(['e2fsck', '-f', '-y', $path]); > > - PVE::Tools::run_command(['resize2fs', $path]); > > + eval { > > +

Re: [pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

2016-02-05 Thread Dietmar Maurer
> } else { > - PVE::Tools::run_command(['e2fsck', '-f', '-y', $path]); > - PVE::Tools::run_command(['resize2fs', $path]); > + eval { > + PVE::Tools::run_command(['e2fsck', '-f', '-y', > $path]); >

[pve-devel] [PATCH container 1/3] Fix #791: warn when resize2fs fails

2016-02-04 Thread Wolfgang Bumiller
At this point the underlying file has already been successfully resized which means it makes sense to refelct that change in the config, but the guest will not see the effect of it, however, a subsequent resize command will further increase the size relative to the 'new' size, so after such an erro