Re: [pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-19 Thread Dominik Csapak
On 01/18/2017 05:56 PM, Dietmar Maurer wrote: Can we simple use: gettext('Enable Firewall') => gettext('Enable') gettext('Enable DHCP') => 'DHCP' gettext('Enable XXYYYZZZ') => 'XXYYYZZZ' unless there is a real reason to use 'blah blah XXYYYZZZ blah' ... We could even display the actual val

Re: [pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Dietmar Maurer
> Can we simple use: > > gettext('Enable Firewall') => gettext('Enable') > > gettext('Enable DHCP') => 'DHCP' > > gettext('Enable XXYYYZZZ') => 'XXYYYZZZ' > > > unless there is a real reason to use 'blah blah XXYYYZZZ blah' ... We could even display the actual value as 'enabled/disabled' (i

Re: [pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Dietmar Maurer
> > if (me.fwtype === 'node') { > > - add_boolean_row('enable', gettext('Enable Firewall'), 1); > > + add_boolean_row('enable', gettext('Enable') + ': ' + > > gettext('Firewall'), 1); > > I do not think this is good, because "Enable" and "Enable something" is > not the same, e.g.

Re: [pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Dominik Csapak
Comment inline On 01/18/2017 04:25 PM, Emmanuel Kasper wrote: Mostly split out technical term who don't need to be translated outside of the gettext function paramater. --- www/manager6/ceph/Status.js | 4 ++-- www/manager6/dc/Health.js| 2 +- www/manager6/dc/Summary.js

[pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Emmanuel Kasper
Mostly split out technical term who don't need to be translated outside of the gettext function paramater. --- www/manager6/ceph/Status.js | 4 ++-- www/manager6/dc/Health.js| 2 +- www/manager6/dc/Summary.js | 2 +- www/manager6/grid/FirewallOptions.js | 10 +