Re: [pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-10-05 Thread Thomas Lamprecht
On 09/28/2017 03:35 PM, Emmanuel Kasper wrote: > On 09/27/2017 10:47 AM, Thomas Lamprecht wrote: >> On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >>> The bus selector is displayed when we add a Hard Disk or CD Drive. >>> When it is displayed, we *always* preselect the next available >>> slot on th

Re: [pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-09-28 Thread Emmanuel Kasper
On 09/27/2017 10:47 AM, Thomas Lamprecht wrote: > On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: >> The bus selector is displayed when we add a Hard Disk or CD Drive. >> When it is displayed, we *always* preselect the next available >> slot on the controller of our choice. >> So this test is not ne

Re: [pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-09-27 Thread Thomas Lamprecht
On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect'

[pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-09-26 Thread Emmanuel Kasper
The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect' to select a bus position when adding a CD Drive.