Re: [pve-devel] [PATCH node_config 1/1] node_config: Allow leading underscore in ACME aliases

2020-06-23 Thread Fabian Grünbichler
LGTM, except for one minor nit. could you please send a CLA as described in our Developer Documentation to off...@proxmox.com ? https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright Thanks in advance! On June 22, 2020 12:10 pm, Fabian Möller wrote: > --- >

[pve-devel] [PATCH node_config 1/1] node_config: Allow leading underscore in ACME aliases

2020-06-22 Thread Fabian Möller
--- PVE/NodeConfig.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/PVE/NodeConfig.pm b/PVE/NodeConfig.pm index ad49e288..017f6b30 100644 --- a/PVE/NodeConfig.pm +++ b/PVE/NodeConfig.pm @@ -25,6 +25,16 @@ PVE::JSONSchema::register_format('pve-acme-domain', sub {