Re: [pve-devel] [PATCH qemu-server] fix #2697: map netdev_add options to correct json types

2020-04-21 Thread Fabian Grünbichler
there is some issue with hot-plugging queues (with and without your patch): - virtio NIC, no queues set, start VM OR - virtio NIC, queues X set, start VM - change NIC to have a queues value of Y 400 Parameter verification failed. net0: hotplug problem - error on hot-unplugging device 'net0' - n

Re: [pve-devel] [PATCH qemu-server] fix #2697: map netdev_add options to correct json types

2020-04-21 Thread Stefan Reiter
On 21/04/2020 16:43, Dominik Csapak wrote: On 4/21/20 4:38 PM, Stefan Reiter wrote: On 21/04/2020 16:01, Dominik Csapak wrote: netdev_add is now a proper qmp command, which means that it verifies the parameter types properly The patch looks reasonable, but I'm confused how that worked before

Re: [pve-devel] [PATCH qemu-server] fix #2697: map netdev_add options to correct json types

2020-04-21 Thread Dominik Csapak
On 4/21/20 4:38 PM, Stefan Reiter wrote: On 21/04/2020 16:01, Dominik Csapak wrote: netdev_add is now a proper qmp command, which means that it verifies the parameter types properly The patch looks reasonable, but I'm confused how that worked before? 'git blame' tells me the typed QMP schema

Re: [pve-devel] [PATCH qemu-server] fix #2697: map netdev_add options to correct json types

2020-04-21 Thread Stefan Reiter
On 21/04/2020 16:01, Dominik Csapak wrote: netdev_add is now a proper qmp command, which means that it verifies the parameter types properly The patch looks reasonable, but I'm confused how that worked before? 'git blame' tells me the typed QMP schema for netdev_add has been in QEMU since 20

[pve-devel] [PATCH qemu-server] fix #2697: map netdev_add options to correct json types

2020-04-21 Thread Dominik Csapak
netdev_add is now a proper qmp command, which means that it verifies the parameter types properly instead of sending strings, we now have to choose the correct types for the parameters bool for vhost and uint64 for queues Signed-off-by: Dominik Csapak --- i checked and i found no other paramete