Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

2017-09-27 Thread Tom Weber
Am Mittwoch, den 27.09.2017, 11:51 +0200 schrieb Wolfgang Bumiller: > On Wed, Sep 27, 2017 at 11:09:29AM +0200, Tom Weber wrote: > > > > My goal are defined structures for rules, chains, macros (which i > > think > > are just arrays of "rule templates") etc and code which deals with > > these

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

2017-09-27 Thread Tom Weber
Am Mittwoch, den 27.09.2017, 11:53 +0200 schrieb Wolfgang Bumiller: > On Wed, Sep 27, 2017 at 12:02:33AM +0200, Tom Weber wrote: > > > > --- > > +'PVEFW-smurflog' => [ > > + { action => 'DROP', logmsg => 'DROP: ' }, > > +], > > +'PVEFW-logflags' => [ > > + { action => 'DROP',

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

2017-09-27 Thread Wolfgang Bumiller
On Wed, Sep 27, 2017 at 12:02:33AM +0200, Tom Weber wrote: > --- > +'PVEFW-smurflog' => [ > + { action => 'DROP', logmsg => 'DROP: ' }, > +], > +'PVEFW-logflags' => [ > + { action => 'DROP', logmsg => 'DROP: ' }, > ], > }; Just noticed this is missing in the ipv6 part

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

2017-09-27 Thread Wolfgang Bumiller
On Wed, Sep 27, 2017 at 11:09:29AM +0200, Tom Weber wrote: > My goal are defined structures for rules, chains, macros (which i think > are just arrays of "rule templates") etc and code which deals with > these structures instead of printing out iptables commands in various > places. That's long

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

2017-09-27 Thread Tom Weber
First of all, this all is work in progress. I thought I commit for easier understanding of the way i'm heading - instead of one huge commit which turns everything inside out. and for feedback of course. My goal are defined structures for rules, chains, macros (which i think are just arrays of

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

2017-09-27 Thread Wolfgang Bumiller
On Wed, Sep 27, 2017 at 12:02:33AM +0200, Tom Weber wrote: > --- > src/PVE/Firewall.pm | 220 > > 1 file changed, 117 insertions(+), 103 deletions(-) > > diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm > index f8a9300..179617a 100644 >

[pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

2017-09-26 Thread Tom Weber
--- src/PVE/Firewall.pm | 220 1 file changed, 117 insertions(+), 103 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index f8a9300..179617a 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -142,6 +142,20 @@ my