Re: [pve-devel] [PATCH v2 manager 1/3] fix #1594: add "Run now" button to cluster backup page

2019-08-07 Thread Stefan Reiter
On 8/7/19 11:40 AM, Dominik Csapak wrote: at this point, the user may have switched the panel already and it might seem weird to get an error 'out of nowhere'... you could check 'me.destroyed' (see extjs docs) if the current panel still is valid and only show the errors if it is. also, if

Re: [pve-devel] [PATCH v2 manager 1/3] fix #1594: add "Run now" button to cluster backup page

2019-08-07 Thread Dominik Csapak
at this point, the user may have switched the panel already and it might seem weird to get an error 'out of nowhere'... you could check 'me.destroyed' (see extjs docs) if the current panel still is valid and only show the errors if it is. also, if it is not, the 'unmask' in run_now_finished

Re: [pve-devel] [PATCH v2 manager 1/3] fix #1594: add "Run now" button to cluster backup page

2019-08-07 Thread Stefan Reiter
On 8/7/19 10:31 AM, Dominik Csapak wrote: looks mostly ok (did not test it), but some comments inline On 8/5/19 4:58 PM, Stefan Reiter wrote: To allow masking to be correctly handled, we use a counter variable to keep the mask visible until all tasks have been completed. Any errors that

Re: [pve-devel] [PATCH v2 manager 1/3] fix #1594: add "Run now" button to cluster backup page

2019-08-07 Thread Dominik Csapak
looks mostly ok (did not test it), but some comments inline On 8/5/19 4:58 PM, Stefan Reiter wrote: To allow masking to be correctly handled, we use a counter variable to keep the mask visible until all tasks have been completed. Any errors that occurred will be displayed in a consolidated

[pve-devel] [PATCH v2 manager 1/3] fix #1594: add "Run now" button to cluster backup page

2019-08-05 Thread Stefan Reiter
To allow masking to be correctly handled, we use a counter variable to keep the mask visible until all tasks have been completed. Any errors that occurred will be displayed in a consolidated message box. Includes a "confirm" dialog to not accidentally run a potentially large backup job.