Re: [pve-devel] [PATCH v3 container] Improve error handling in snapshot_create

2016-02-10 Thread Dietmar Maurer
applied - but the logic in snapshot_delete looks still wrong to me. The qemu-server implementation locks more reasonable to me. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v3 container] Improve error handling in snapshot_create

2016-02-10 Thread Fabian Grünbichler
> Dietmar Maurer hat am 11. Februar 2016 um 06:56 > geschrieben: > > > applied - but the logic in snapshot_delete looks still wrong to me. The > qemu-server > implementation locks more reasonable to me. I will further harmonize the code paths when implementing mountpoint

[pve-devel] [PATCH v3 container] Improve error handling in snapshot_create

2016-02-10 Thread Fabian Grünbichler
Set unfreeze before trying to freeze, otherwise an aborted or failed lxc-freeze will not be reversed by our error handling, leaving the container in a (partially) frozen state. Make snapshot_create failure handling more resembling to the QemuServer codebase and prepare for future code