Re: [pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

2018-10-02 Thread Andreas Steinel
On Tue, Oct 2, 2018 at 8:10 AM Dietmar Maurer wrote: > > I thought we all agreed that swap does not make sense on > high memory system? Very true. I'd still suggest - as I did for many years on the forums - to install zram. This can be done automatically and then you have some swap, compressed

Re: [pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

2018-10-02 Thread Dietmar Maurer
I thought we all agreed that swap does not make sense on high memory system? > On Mon, Oct 01, 2018 at 07:43:41PM +0200, Fabian Grünbichler wrote: > > > > wouldn't it make more sense to create a swap partition on all boot vdevs > > instead? if you need swap, this is very cumbersome to do after >

Re: [pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

2018-10-01 Thread Stoiko Ivanov
On Mon, Oct 01, 2018 at 07:43:41PM +0200, Fabian Grünbichler wrote: > On Mon, Oct 01, 2018 at 12:41:57PM +0200, Stoiko Ivanov wrote: > > I would propose to disable the default creation of a swap-zvol if installing > > with zfs on root currently, since it introduces deadlocks in some > >

Re: [pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

2018-10-01 Thread Fabian Grünbichler
On Mon, Oct 01, 2018 at 12:41:57PM +0200, Stoiko Ivanov wrote: > I would propose to disable the default creation of a swap-zvol if installing > with zfs on root currently, since it introduces deadlocks in some > circumstances. > > Should a solution be implemented, we can revert the changes. > >

Re: [pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

2018-10-01 Thread Andreas Steinel
On Mon, Oct 1, 2018 at 3:53 PM Thomas Lamprecht wrote: > Looks good to me, I'll let it still ripe a bit on the mailing list though, > for other possible commenters :-) Great! -- With kind regards / Mit freundlichen Grüßen Andreas Steinel M.Sc. Visual Computing M.Sc. Informatik

Re: [pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

2018-10-01 Thread Thomas Lamprecht
On 10/1/18 12:41 PM, Stoiko Ivanov wrote: > I would propose to disable the default creation of a swap-zvol if installing > with zfs on root currently, since it introduces deadlocks in some > circumstances. > > Should a solution be implemented, we can revert the changes. > > This patchset

[pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

2018-10-01 Thread Stoiko Ivanov
I would propose to disable the default creation of a swap-zvol if installing with zfs on root currently, since it introduces deadlocks in some circumstances. Should a solution be implemented, we can revert the changes. This patchset contains 4 changes: * disabling the creation of a zvol for swap