Re: [pve-devel] applied: [PATCH qemu-server 1/2] migrate: only stop NBD if we got a NBD url from the target

2020-04-30 Thread Mira Limbeck
On 4/30/20 10:13 AM, Thomas Lamprecht wrote: On 4/30/20 10:04 AM, Mira Limbeck wrote: On 4/30/20 8:41 AM, Thomas Lamprecht wrote: On 4/30/20 8:35 AM, Fabian Grünbichler wrote: On April 29, 2020 4:24 pm, Thomas Lamprecht wrote: Signed-off-by: Thomas Lamprecht --- This was rather quickly asse

Re: [pve-devel] applied: [PATCH qemu-server 1/2] migrate: only stop NBD if we got a NBD url from the target

2020-04-30 Thread Thomas Lamprecht
On 4/30/20 10:04 AM, Mira Limbeck wrote: > On 4/30/20 8:41 AM, Thomas Lamprecht wrote: >> On 4/30/20 8:35 AM, Fabian Grünbichler wrote: >>> On April 29, 2020 4:24 pm, Thomas Lamprecht wrote: Signed-off-by: Thomas Lamprecht --- This was rather quickly assembled to fix an obvious

Re: [pve-devel] applied: [PATCH qemu-server 1/2] migrate: only stop NBD if we got a NBD url from the target

2020-04-30 Thread Mira Limbeck
On 4/30/20 8:41 AM, Thomas Lamprecht wrote: On 4/30/20 8:35 AM, Fabian Grünbichler wrote: On April 29, 2020 4:24 pm, Thomas Lamprecht wrote: Signed-off-by: Thomas Lamprecht --- This was rather quickly assembled to fix an obvious issue, some in depth look at this would be nice, @Fabi or @Fabia

Re: [pve-devel] applied: [PATCH qemu-server 1/2] migrate: only stop NBD if we got a NBD url from the target

2020-04-29 Thread Thomas Lamprecht
On 4/30/20 8:35 AM, Fabian Grünbichler wrote: > On April 29, 2020 4:24 pm, Thomas Lamprecht wrote: >> Signed-off-by: Thomas Lamprecht >> --- >> >> This was rather quickly assembled to fix an obvious issue, some in depth look >> at this would be nice, @Fabi or @Fabian :) > > LGTM! > It really sh

Re: [pve-devel] applied: [PATCH qemu-server 1/2] migrate: only stop NBD if we got a NBD url from the target

2020-04-29 Thread Fabian Grünbichler
On April 29, 2020 4:24 pm, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > > This was rather quickly assembled to fix an obvious issue, some in depth look > at this would be nice, @Fabi or @Fabian :) LGTM! > > PVE/QemuMigrate.pm | 5 - > 1 file changed, 4 insertions(+),

[pve-devel] applied: [PATCH qemu-server 1/2] migrate: only stop NBD if we got a NBD url from the target

2020-04-29 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- This was rather quickly assembled to fix an obvious issue, some in depth look at this would be nice, @Fabi or @Fabian :) PVE/QemuMigrate.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 7