Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Alexandre DERUMIER
oyé: Lundi 17 Novembre 2014 16:45:35 Objet: RE: [pve-devel] qemu-server : implement pending changes v2 > >>Great, thanks! > > Ok, I can hotplug|unplug disk,nic,cpu,tablet with some small rework of my > previous patches. > > I'll send patch at the end of the day

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Dietmar Maurer
> >>Great, thanks! > > Ok, I can hotplug|unplug disk,nic,cpu,tablet with some small rework of my > previous patches. > > I'll send patch at the end of the day. > > > The only thing I can't manage currently with new code, is drive swap. (update > an > existing disk volid by another one). What

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Alexandre DERUMIER
-- Mail original - De: "Dietmar Maurer" À: "Alexandre DERUMIER" Cc: pve-devel@pve.proxmox.com Envoyé: Lundi 17 Novembre 2014 12:21:50 Objet: RE: [pve-devel] qemu-server : implement pending changes v2 > >>The question is how hard it is to implement disk/network

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Dietmar Maurer
> >>The question is how hard it is to implement disk/network hotplug on top of > this? > > I'll try to make a test hotplug patch to see if it's working fine Great, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-b

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Alexandre DERUMIER
.com Envoyé: Lundi 17 Novembre 2014 11:16:30 Objet: RE: [pve-devel] qemu-server : implement pending changes v2 > Thanks, > > I'll review them this afternoon The question is how hard it is to implement disk/network hotplug on top of this?

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Dietmar Maurer
> Thanks, > > I'll review them this afternoon The question is how hard it is to implement disk/network hotplug on top of this? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Alexandre DERUMIER
Thanks, I'll review them this afternoon - Mail original - De: "Dietmar Maurer" À: "Alexandre DERUMIER" Cc: pve-devel@pve.proxmox.com Envoyé: Lundi 17 Novembre 2014 11:01:58 Objet: RE: [pve-devel] qemu-server : implement pending changes v2 > I thin

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Dietmar Maurer
> I think I'll wait for your patches before begin to work on gui, to be sure to > have > some good. I just sent what I have so far to the list. Please can you do a short review? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Alexandre DERUMIER
vembre 2014 09:27:25 Objet: RE: [pve-devel] qemu-server : implement pending changes v2 > >>Can't we simply display the changed/new config, and return a 'diff' to > >>show what is changed. > > mmm,I really don't like this idea. I think it'll con

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Dietmar Maurer
> For pending update: > > [CONF] > virtio0: > [PENDING] > virtio0: > > > display the value "virtio0: old value(pending: new value)" OK > For pending add: > [CONF] > [PENDING] > virtio0: > > display the value "virtio0:(pending: new value)" OK > for pending delete: > > [CONF] > virtio0:

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Dietmar Maurer
> >>Can't we simply display the changed/new config, and return a 'diff' to > >>show what is changed. > > mmm,I really don't like this idea. I think it'll confuse user. > > I think we should display the running config. > > For example if user hot-unplug a disk, and it's failing, we should keep >

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Alexandre DERUMIER
7;s failing, we should keep displaying it in config, if user want to retry to unplug it again. - Mail original - De: "Dietmar Maurer" À: "Alexandre DERUMIER" Cc: pve-devel@pve.proxmox.com Envoyé: Lundi 17 Novembre 2014 09:06:04 Objet: RE: [pve-devel] qemu-serve

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Dietmar Maurer
> > but in this case, > > > > I don't know how to display > > > > [CONF] > > virtio0:oldvalue > > [PENDING] > > virtio0: newvalue > > delete: virtio0 > > > > > > "virtio0: old value (pending: delete - new value)" ? This will never happen - my current implementation avoids that. _

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-17 Thread Dietmar Maurer
t; > I don't know how to display > > [CONF] > virtio0:oldvalue > [PENDING] > virtio0: newvalue > delete: virtio0 > > > "virtio0: old value (pending: delete - new value)" ? > > > > > > > > > - Mail original - > &

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-16 Thread Alexandre DERUMIER
rtio0 "virtio0: old value (pending: delete - new value)" ? - Mail original - De: "Dietmar Maurer" À: "Alexandre DERUMIER" , pve-devel@pve.proxmox.com Envoyé: Lundi 17 Novembre 2014 08:33:40 Objet: RE: [pve-devel] qemu-server : implemen

Re: [pve-devel] qemu-server : implement pending changes v2

2014-11-16 Thread Dietmar Maurer
Do you already have an idea how to implement the GUI? > -Original Message- > From: Dietmar Maurer > Sent: Montag, 17. November 2014 08:25 > To: 'Alexandre DERUMIER' > Subject: RE: [pve-devel] qemu-server : implement pending changes v2 > > > (Do you t

Re: [pve-devel] qemu-server : implement pending changes v2

2014-10-31 Thread Cesar Peschiera
start necessaries Best regards Cesar Peschiera - Original Message - From: "Alexandre DERUMIER" To: "Cesar Peschiera" Cc: Sent: Friday, October 31, 2014 1:33 AM Subject: Re: [pve-devel] qemu-server : implement pending changes v2 Is possible that the change a n

Re: [pve-devel] qemu-server : implement pending changes v2

2014-10-31 Thread Dietmar Maurer
> Yes, I have planned to apply pending change on vm_stop and vm_start (in case > on unclean stop) > > Another way could be to add a button to apply manually the pending change. > (Don't known what is the best way) I thing we need a button on the GUI to Apply/Revert pending changes. __

Re: [pve-devel] qemu-server : implement pending changes v2

2014-10-30 Thread Alexandre DERUMIER
MIER" Cc: pve-devel@pve.proxmox.com Envoyé: Jeudi 30 Octobre 2014 23:59:12 Objet: Re: [pve-devel] qemu-server : implement pending changes v2 Hi I have a question, please see below - Original Message - From: "Alexandre DERUMIER" To: "Stanislav German-Evtushenko&q

Re: [pve-devel] qemu-server : implement pending changes v2

2014-10-30 Thread Daniel Hunsaker
av German-Evtushenko" > Cc: > Sent: Thursday, October 30, 2014 1:32 PM > Subject: Re: [pve-devel] qemu-server : implement pending changes v2 > > > Some questions regarding this patch: >>>> - What happens when we do online migration with pending changes? >>

Re: [pve-devel] qemu-server : implement pending changes v2

2014-10-30 Thread Cesar Peschiera
Hi I have a question, please see below - Original Message - From: "Alexandre DERUMIER" To: "Stanislav German-Evtushenko" Cc: Sent: Thursday, October 30, 2014 1:32 PM Subject: Re: [pve-devel] qemu-server : implement pending changes v2 Some questions regardin

Re: [pve-devel] qemu-server : implement pending changes v2

2014-10-30 Thread Alexandre DERUMIER
andre Derumier" Envoyé: Jeudi 30 Octobre 2014 17:11:37 Objet: Re: [pve-devel] qemu-server : implement pending changes v2 > Date: Thu, 30 Oct 2014 13:40:21 +0100 > From: Alexandre Derumier > To: pve-devel@pve.proxmox.com > Subject: [pve-devel] qemu-server : implement pe

Re: [pve-devel] qemu-server : implement pending changes v2

2014-10-30 Thread Stanislav German-Evtushenko
> Date: Thu, 30 Oct 2014 13:40:21 +0100 > From: Alexandre Derumier > To: pve-devel@pve.proxmox.com > Subject: [pve-devel] qemu-server : implement pending changes v2 > Message-ID: <1414672833-17829-1-git-send-email-aderum...@odiso.com> > > Hi, > > I have redone my

[pve-devel] qemu-server : implement pending changes v2

2014-10-30 Thread Alexandre Derumier
Hi, I have redone my patch with Diemar recommendations, main difference: -pending delete are now in a delete list delete: virtio0,net0 -no more unused disk in pending conf I have splitted my big patch into many smaller (I hope that nothing is missing, but I have redone tests everywhere an