Re: [pve-devel] [PATCH storage] ZFSPoolPlugin: fix #2662 get volume size correctly

2020-04-07 Thread Fabian Grünbichler
On April 7, 2020 11:28 am, Aaron Lauterer wrote: > > > On 4/3/20 5:07 PM, Fabian Grünbichler wrote: >> there's another instance of 'zfs list ...' in PVE::Storage that could >> also be switched to '-p' > > Which one do you mean? Line 610? > >1 if ($format eq 'subvol') { > > 610

Re: [pve-devel] [PATCH storage] ZFSPoolPlugin: fix #2662 get volume size correctly

2020-04-07 Thread Aaron Lauterer
On 4/3/20 5:07 PM, Fabian Grünbichler wrote: there's another instance of 'zfs list ...' in PVE::Storage that could also be switched to '-p' Which one do you mean? Line 610? 1 if ($format eq 'subvol') { 610 my $size = $class->zfs_request($scfg, undef, 'list', '-H', '-o',

Re: [pve-devel] [PATCH storage] ZFSPoolPlugin: fix #2662 get volume size correctly

2020-04-03 Thread Fabian Grünbichler
there's another instance of 'zfs list ...' in PVE::Storage that could also be switched to '-p' On April 3, 2020 2:29 pm, Aaron Lauterer wrote: > Getting the volume sizes as byte values instead of converted to human > readable units helps to avoid rounding errors in the further processing > if