Re: [pve-devel] [PATCH] HA: add the managers' FSM diagram

the image is too big... ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container] correctly set unlimited cpulimit at runtime

'-1' means no limit for this cgroup value, so use this like we already do when deleting the cpulimit. --- src/PVE/LXC/Config.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 7480fff..2ec643e 100644 ---

[pve-devel] [PATCH manager] lxc: correctly display cpulimit

the backend defaults to 0 (unlimited), so this should also be the default in the GUI if nothing is set. --- www/manager6/lxc/ResourceEdit.js | 1 + www/manager6/lxc/Resources.js| 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/ResourceEdit.js

[pve-devel] [PATCH v4 ha-manager 1/3] cleanup backup & mounted locks after recovery (fixes #1100)

This cleans up the backup and mounted locks after a service is recovered from a failed node, else it may not start if a locked action occurred during the node failure. We allow deletion of backup and mounted locks as they are secure to do so if the node which hosted the locked service is now

[pve-devel] [PATCH ha-manager 2/3] change service state to error if no recovery node is available

else we will try again endlessly if the service has no other possible node where it can run, e.g. if its restricted. This avoids various problems, especially if a service is configured to just one node we could never get the service out of the fence state again without manually hacking the

[pve-devel] [PATCH ha-manager 3/3] Sim/Hardware: not warn if a not locked gets unlocked

This adds warninga without value to the regression test stderr output, does not affects the test itself but can be annoying. Signed-off-by: Thomas Lamprecht --- trivial fix src/PVE/HA/Sim/Hardware.pm | 1 - 1 file changed, 1 deletion(-) diff --git

[pve-devel] [PATCH] qmp_snapshot_drive : add aiocontext

This fix internal snapshot for drive with iothread enabled Signed-off-by: Alexandre Derumier --- .../0056-qmp_snapshot_drive-add-aiocontext.patch | 65 ++ debian/patches/series | 1 + 2 files changed, 66 insertions(+)

Re: [pve-devel] [PATCH v2 storage 5/5] fix typo

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 storage 3/5] harmonize list_images code

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] correctly set unlimited cpulimit at runtime

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] lxc: correctly display cpulimit

Applied > --- a/www/manager6/lxc/ResourceEdit.js > +++ b/www/manager6/lxc/ResourceEdit.js > @@ -131,6 +131,7 @@ Ext.define('PVE.lxc.CPUInputPanel', { > me.column1 = items; > } else { > me.items = items; > + me.items[0].value = 0; this is not really nice - I do

Re: [pve-devel] [PATCH ha-manager v3 4/6] add possibility to simulate locks from services

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-docs] Document that virtio-scsi is the recommended controller for PVE >= 4.3

--- qm.adoc | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/qm.adoc b/qm.adoc index 375cc39..f77bd9d 100644 --- a/qm.adoc +++ b/qm.adoc @@ -122,18 +122,19 @@ on this controller. design, allowing higher throughput and a greater number of devices to be

[pve-devel] [PATCH manager 2/2] Use SCSI controller as default for l26 guests fix #1105

NB: This is only for new created VMs. --- www/manager6/qemu/OSDefaults.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js index 7ebfef0..dc13eeb 100644 --- a/www/manager6/qemu/OSDefaults.js +++

[pve-devel] [PATCH manager 2/2] add missing documentation link to firewall log

Signed-off-by: Dominik Csapak --- www/manager6/node/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index 8159a57..f987fa2 100644 --- a/www/manager6/node/Config.js +++ b/www/manager6/node/Config.js @@

Re: [pve-devel] [PATCH ha-manager v3 5/6] add check if a service is relocatable and assert it on recovery

> Add a basic check if a service is relocatable, i.e. is bound to > local resources from a node. I would prefer to restrict possible nodes in advance, for example in get_service_group? ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH manager 1/2] add tooltip hashmap/generator for help button

instead of manually setting the onlineHelpTooltip property we now have a method which maps links to the docs to titles for now this uses a static hashmap, but in the future we want to generate this by the pve-docs package also most of the subheaders we can generate instead of saving them because

[pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

--- www/manager6/qemu/HDEdit.js | 4 www/manager6/qemu/OSDefaults.js | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index c86ab44..312b218 100644 --- a/www/manager6/qemu/HDEdit.js +++

Re: [pve-devel] [PATCH manager v2 1/2] add tooltip hashmap/generator for help button

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager] check if dir /var/log/pveproxy exists.

> On September 15, 2016 at 12:25 PM Wolfgang Link wrote: > > > We will check on every start of pveproxy if the logdir are available. > If not we make a new one and give www-data permission to this dir. And you want to do that with every directory?

Re: [pve-devel] [PATCH ha-manager 2/3] change service state to error if no recovery node is available

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v4 ha-manager 1/3] cleanup backup & mounted locks after recovery (fixes #1100)

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2 2/2] add missing documentation link to firewall log

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager] check if dir /var/log/pveproxy exists.

We will check on every start of pveproxy if the logdir are available. If not we make a new one and give www-data permission to this dir. The reason for this is, if someone remove the directory /var/log/pveproxy pveproxy can't access the log. This permit the user to use the GUI after a reboot or a

Re: [pve-devel] [PATCH qemu-server] forbid restore into existing template

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager 3/3] Sim/Hardware: not warn if a not locked gets unlocked

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] qmp_snapshot_drive : add aiocontext

applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] change overflowhandler of actionmenu to scroller

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server] forbid migration of template with local base image

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server] restore: better error handling for vdisk deletion

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-docs] Document that virtio-scsi is the recommended controller for PVE >= 4.3

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v2 1/2] add tooltip hashmap/generator for help button

instead of manually setting the onlineHelpTooltip property we now have a method which maps links to the docs to titles for now this uses a static hashmap, but in the future we want to generate this by the pve-docs package also most of the subheaders we can generate instead of saving them because

[pve-devel] [PATCH manager v2 2/2] add missing documentation link to firewall log

Signed-off-by: Dominik Csapak --- www/manager6/node/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index 8159a57..f987fa2 100644 --- a/www/manager6/node/Config.js +++ b/www/manager6/node/Config.js @@

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 2/2] Use SCSI controller as default for l26 guests fix #1105

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server] forbid restore into existing template

--- PVE/API2/Qemu.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 60d653f..482b8cd 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -490,6 +490,10 @@ __PACKAGE__->register_method({ die "unable to restore vm $vmid -

Re: [pve-devel] [PATCH v2 storage 1/5] remove unused method

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 storage 2/5] move check for existing clones into own method

applied, but changed name to $volume_is_base_and_used__no_lock ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server] forbid migration of template with local base image

--- Note: requires the linked clones / list_images cleanup series in pve-storage PVE/QemuMigrate.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 6415032..22a49ef 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -317,6 +317,9 @@

[pve-devel] [PATCH qemu-server] restore: better error handling for vdisk deletion

when restoring into an existing VM, we don't want to die half-way through because we can't delete one of the existing volumes. instead, warn about the deletion failure, but continue anyway. the not deleted disk is then added as unused automatically. --- PVE/QemuServer.pm | 5 - 1 file

Re: [pve-devel] [PATCH v2 storage 4/5] add comments about LVM thin clones

this one does not apply - please can you rebase/resend? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 storage 0/5] linked clones / list_images cleanup

changes to v1 only in patch #2: - expose check including lock - move actual check to private sub - change return type to bool instead of first found child's volname Fabian Grünbichler (5): remove unused method move check for existing clones into own method harmonize list_images code add

[pve-devel] [PATCH v2 storage 1/5] remove unused method

only used by test case, which should use what the rest of the codebase uses as well --- PVE/Storage.pm | 21 - test/run_test_zfspoolplugin.pl | 21 +++-- 2 files changed, 15 insertions(+), 27 deletions(-) diff --git a/PVE/Storage.pm

[pve-devel] [PATCH manager] change overflowhandler of actionmenu to scroller

the menu overflowhandler has a few problems (alignment, no action for some entries) so we change it to type scroller Signed-off-by: Dominik Csapak --- www/manager6/panel/ConfigPanel.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pve-devel] [PATCH v2 storage 2/5] move check for existing clones into own method

and change its return type to boolean --- PVE/Storage.pm | 62 ++ 1 file changed, 41 insertions(+), 21 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 273d17d..16a835f 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@

[pve-devel] [PATCH v2 storage 4/5] add comments about LVM thin clones

--- PVE/Storage.pm | 7 +++ PVE/Storage/LvmThinPlugin.pm | 9 + 2 files changed, 16 insertions(+) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 16a835f..6e2e7a6 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -321,6 +321,9 @@ sub parse_vmid { return

[pve-devel] [PATCH v2 storage 3/5] harmonize list_images code

--- PVE/Storage/RBDPlugin.pm | 9 - PVE/Storage/ZFSPoolPlugin.pm | 19 +-- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index a965ade..de8751a 100644 --- a/PVE/Storage/RBDPlugin.pm +++

[pve-devel] [PATCH v2 storage 5/5] fix typo

--- PVE/Storage/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 8089302..cdc89ba 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -444,7 +444,7 @@ sub create_base { my ($class, $storeid, $scfg,

[pve-devel] [PATCH] HA: add the managers' FSM diagram

Signed-off-by: Thomas Lamprecht --- for now as SVG as the graphviz filter from asciidoc isn't that obedient when asked to render the FSM as vector graphic.. :( ha-manager.adoc | 6 ++ images/ha-manager-fsm.svg | 166