Re: [pve-devel] [PATCH qemu-server] use pve-edk2-firmware to load ovmf

small nit below, I'll take a look at the edk2 package itself later On Tue, Mar 13, 2018 at 04:29:25PM +0100, Thomas Lamprecht wrote: > We're able to just change it's path as we use the FD_SIZE_2MB option > to build OVMF in the new pve-edk2-firmware package, which was the > earlier implicit size

Re: [pve-devel] [PATCH qemu-server] use pve-edk2-firmware to load ovmf

On Wed, Mar 14, 2018 at 11:14:57AM +0100, Thomas Lamprecht wrote: > On 03/14/2018 10:56 AM, Fabian Grünbichler wrote: > > small nit below, I'll take a look at the edk2 package itself later > > > > On Tue, Mar 13, 2018 at 04:29:25PM +0100, Thomas Lamprecht wrote: > >> We're able to just change

Re: [pve-devel] [PATCH container v4] Fix pct skiplock

> diff --git a/src/lxc-pve-prestart-hook b/src/lxc-pve-prestart-hook > index fd29423..79297da 100755 > --- a/src/lxc-pve-prestart-hook > +++ b/src/lxc-pve-prestart-hook > @@ -57,13 +57,16 @@ __PACKAGE__->register_method ({ > return undef if $param->{name} !~ m/^\d+$/; > > my $vmid =

[pve-devel] [PATCH container v4] Fix pct skiplock

The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- note: this version

[pve-devel] [PATCH container v3] Fix pct skiplock

The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- note: after discussion

[pve-devel] [PATCH container v2] Fix pct skiplock

The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- note: after discussion

Re: [pve-devel] [RFC edk2-firmware] Initial commit

looks good all in all, some minor nits below On Tue, Mar 13, 2018 at 04:29:24PM +0100, Thomas Lamprecht wrote: > Currently builds OVMF in a simmilar fashion the Debian package does, > we just focus on a x86_64 build for now, disable secure boot (was > disabled in our binary images from pve-qemu,

Re: [pve-devel] [PATCH container v4] Fix pct skiplock

another comment inline > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 7adbcd1..4398cfd 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1545,11 +1545,20 @@ sub vm_start { > > update_lxc_config($vmid, $conf); > > -local $ENV{PVE_SKIPLOCK}=1 if $skiplock; > +my

[pve-devel] applied: [PATCH qemu-server] remove legacy vm_monitor_command

applied On Tue, Mar 13, 2018 at 08:21:59AM +0100, Thomas Lamprecht wrote: > We introduced our QMP socket with commit > c971c4f2213524f27125f558978a428b53628f34 (29.05.2012) > > Already tried to remove this with commit > 7b7c6d1b5dcee25e1194d4b8a0219bd5c31a5639 (13.07.2012) > > But reverted that

Re: [pve-devel] [PATCH container v2] Fix pct skiplock

Please send those white-space cleanups as separate patch > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 7adbcd1..acb5cfd 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -393,7 +393,7 @@ sub update_lxc_config { > > # some init scripts expect a linux terminal (turnkey). >

Re: [pve-devel] [PATCH] increase zfs default timeout to 30sec

On Tue, Mar 13, 2018 at 04:28:17PM +0200, Lauri Tirkkonen wrote: > On Tue, Mar 13 2018 16:12:27 +0200, Lauri Tirkkonen wrote: > > On Tue, Mar 13 2018 16:06:12 +0200, Lauri Tirkkonen wrote: > > > Hi, > > > > > > On Tue, Mar 13 2018 09:45:18 +0100, Fabian Grünbichler wrote: > > > > if you haven't

Re: [pve-devel] [RFC edk2-firmware] Initial commit

On 03/14/2018 12:32 PM, Fabian Grünbichler wrote: > looks good all in all, some minor nits below > > On Tue, Mar 13, 2018 at 04:29:24PM +0100, Thomas Lamprecht wrote: >> Currently builds OVMF in a simmilar fashion the Debian package does, >> we just focus on a x86_64 build for now, disable secure

Re: [pve-devel] [PATCH qemu-server] use pve-edk2-firmware to load ovmf

On 03/14/2018 10:56 AM, Fabian Grünbichler wrote: > small nit below, I'll take a look at the edk2 package itself later > > On Tue, Mar 13, 2018 at 04:29:25PM +0100, Thomas Lamprecht wrote: >> We're able to just change it's path as we use the FD_SIZE_2MB option >> to build OVMF in the new

[pve-devel] applied: [PATCH storage 01/11] Remove pool with -f parameter.

applied would maybe also make sense to trap SIG{INT,TERM,QUIT} and call the cleanup function there too, just as a general side note. On 03/13/2018 03:11 PM, Wolfgang Link wrote: > The test pool will not removed if we do not force it. > --- > test/run_test_zfspoolplugin.pl | 2 +- > 1 file

[pve-devel] applied: [PATCH qemu-server 1/3] use default hostname when none is set

applied series On Mon, Mar 12, 2018 at 04:25:04PM +0100, Dominik Csapak wrote: > use "VM$vmid" like we do in a container > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer/Cloudinit.pm | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff

Re: [pve-devel] [PATCH storage 07/11] Add CIFS dependencies in package management.

On Tue, Mar 13, 2018 at 03:11:07PM +0100, Wolfgang Link wrote: > --- > debian/control | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/debian/control b/debian/control > index 04812bb..ffaefff 100644 > --- a/debian/control > +++ b/debian/control > @@ -24,6 +24,8 @@ Depends: cstream, >

[pve-devel] applied: [PATCH qemu] build: use 3.0 source format

applied On Tue, Mar 13, 2018 at 02:40:02PM +0100, Fabian Grünbichler wrote > instead of manually including and calling quilt. resulting binary debs > are identical. > > Signed-off-by: Fabian Grünbichler > --- > note: the rules file could probably benefit from further

Re: [pve-devel] [PATCH storage 08/11] Register CIFSPlugin in the storage plugin system.

On Tue, Mar 13, 2018 at 03:11:08PM +0100, Wolfgang Link wrote: > diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm > index 6f72cee..64d4e2f 100644 > --- a/PVE/Storage/Plugin.pm > +++ b/PVE/Storage/Plugin.pm > @@ -332,7 +332,7 @@ sub parse_config { > $d->{content} =

[pve-devel] training week : students features request

Hi, we have almost finished our training week, student are very happy with the hard work done on proxmox5, bugfixes,documentation and stability improvements. They have some features requests/suggestion - vm balancing/redispatching based on cpu - auto-snapshot feature (cron like) -

Re: [pve-devel] training week : students features request

>>- ceph: add replication like zfs to a remote ceph cluster for disaster >>recovery looking at current replication implementation, I don't think it can be used for disaster recovery (as it should be another proxmox cluster, and current replication feature is more for local replication with

Re: [pve-devel] [PATCH storage 03/11] Add helper function for extract CIFS credentials.

On Tue, Mar 13, 2018 at 03:23:10PM +0100, Thomas Lamprecht wrote: > On 03/13/2018 03:11 PM, Wolfgang Link wrote: > > --- > > PVE/API2/Storage/Config.pm | 16 > > 1 file changed, 16 insertions(+) > > > > diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm > >

[pve-devel] [PATCH container v5] Fix pct skiplock

The method vm_start sets an environment variable that is not picked up anymore by systemd. This patch removes the environment variable and introduces a skiplock file that is picked up by the lxc-pve-prestart-hook. Signed-off-by: Alwin Antreich --- note: made changes by

[pve-devel] applied: [PATCH container v5] Fix pct skiplock

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage 07/11] Add CIFS dependencies in package management.

On Wed, Mar 14, 2018 at 02:39:25PM +0100, Wolfgang Bumiller wrote: > On Tue, Mar 13, 2018 at 03:11:07PM +0100, Wolfgang Link wrote: > > --- > > debian/control | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/debian/control b/debian/control > > index 04812bb..ffaefff 100644 > >