applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
apidata.js looks strange???
+ "net27" : {
+ "description" : "Specify network
devices.",
+ "format" : {
we already have net[n] there.
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC/Setup/Base.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
index 2fd04ac..f5f8b0d 100644
--- a/src/PVE/LXC/Setup/Base.pm
+++ b/src/PVE/LXC/Setup/Base.pm
@@ -242,6 +242,7 @@ DATA
Signed-off-by: Wolfgang Bumiller
---
And sorted them...
src/PVE/LXC/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 7c10f4d..3b1e2df 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -277,7 +277,7
applied
On Thu, Sep 13, 2018 at 09:40:55AM +0200, Thomas Lamprecht wrote:
> Avoids the following warning when running initial building or
> running make clean (initially, or twice):
>
> > Makefile:38: pve-doc-generator.mk: No such file or directory
>
> As we can do without this, simply tell
Avoids the following warning when running initial building or
running make clean (initially, or twice):
> Makefile:38: pve-doc-generator.mk: No such file or directory
As we can do without this, simply tell make to ignore it if missing.
Signed-off-by: Thomas Lamprecht
---
Makefile | 2 +-
1
match the interval in front of the first root
Signed-off-by: David
---
since v1:
changed the regex to accept any interval
pve-zsync | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-zsync b/pve-zsync
index 10d6bac..bf00c7a 100755
--- a/pve-zsync
+++ b/pve-zsync
@@
On Wed, Sep 12, 2018 at 02:26:57PM +0200, David wrote:
> match only the interval instead of everything in front of every "root"
>
> Signed-off-by: David
> ---
> pve-zsync | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pve-zsync b/pve-zsync
> index 10d6bac..3a137fe
Found the bug myself. We currently simply use the full 'returns' type property.
Insead, we can compress that like we do for parameters:
any objections?
patch for pve-common:
diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm
index ed76863..ebb0de3 100644
--- a/src/PVE/RESTHandler.pm
instead of overwriting the 'machine' config in the snapshot,
use its own 'runningmachine' config only for the snapshot
this way, we do not lose the machine type if it was
explicitely set during the snapshot, but deleted afterwards
we also have to adapt the tests for this
Signed-off-by: Dominik
Signed-off-by: Dominik Csapak
---
test/snapshot-expected/create/qemu-server/301.conf | 33
test/snapshot-expected/create/qemu-server/302.conf | 33
.../rollback/qemu-server/301.conf | 33
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a3e602d..5055640 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -536,7 +536,7 @@ EODESCR
optional => 1,
},
this series moves the qemu specific rollback code to qemu-server
(where it belongs), and fixes an odd behaviour in the snapshot logic regarding
machine type
it does this by introducing a rollback hook which gets called twice during
rollback and allow for data to be passed between calls
this data
On Thu, Sep 13, 2018 at 11:00:42AM +0200, Dietmar Maurer wrote:
> Found the bug myself. We currently simply use the full 'returns' type
> property. Insead, we can compress that like we do for parameters:
>
> any objections?
looks good to me!
>
> patch for pve-common:
>
> diff --git
On Thu, Sep 13, 2018 at 12:15:04PM +0200, Dominik Csapak wrote:
> this was in guest-common, makes more sense to do it here
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/QemuConfig.pm | 31 ++-
> 1 file changed, 30 insertions(+), 1 deletion(-)
>
> diff --git
On 9/13/18 9:48 AM, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> And sorted them...
thanks for that! irked me too on the last addition..
>
> src/PVE/LXC/Config.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Config.pm
On 9/13/18 11:00 AM, Dietmar Maurer wrote:
> Found the bug myself. We currently simply use the full 'returns' type
> property. Insead, we can compress that like we do for parameters:
>
> any objections?
>
> patch for pve-common:
>
> diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm
On Thu, Sep 13, 2018 at 12:15:05PM +0200, Dominik Csapak wrote:
> instead of overwriting the 'machine' config in the snapshot,
> use its own 'runningmachine' config only for the snapshot
>
> this way, we do not lose the machine type if it was
> explicitely set during the snapshot, but deleted
This convert indexed parameters like -net\d+ to -net[n], so resulting dump
is smaller.
Signed-off-by: Dietmar Maurer
---
src/PVE/RESTHandler.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm
index ed76863..f645f1b
Signed-off-by: Dietmar Maurer
---
api-viewer/PVEAPI.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/api-viewer/PVEAPI.js b/api-viewer/PVEAPI.js
index 835322f..1c34ef2 100644
--- a/api-viewer/PVEAPI.js
+++ b/api-viewer/PVEAPI.js
@@ -198,12 +198,12 @@
not used yet in container at all, so this change does not
do anything, besides keeping the interface in sync
Signed-off-by: Dominik Csapak
---
src/PVE/LXC/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index
instead do the machine logic inside qemu-server package with
the rollback hook
Signed-off-by: Dominik Csapak
---
PVE/AbstractConfig.pm | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm
index
this was in guest-common, makes more sense to do it here
Signed-off-by: Dominik Csapak
---
PVE/QemuConfig.pm | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
index b24773c..5cc2d48 100644
---
On 9/13/18 12:53 PM, Dietmar Maurer wrote:
> This convert indexed parameters like -net\d+ to -net[n], so resulting dump
> is smaller.
>
applied, thanks!
> Signed-off-by: Dietmar Maurer
> ---
> src/PVE/RESTHandler.pm | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff
On 9/12/18 2:52 PM, Rhonda D'Vine wrote:
> This one was missing. Formating got adjusted too.
>
> Signed-off-by: Rhonda D'Vine
> ---
> debian/control | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/debian/control b/debian/control
> index f991da7..b84ae1c 100644
>
On 9/12/18 2:52 PM, Rhonda D'Vine wrote:
> Signed-off-by: Rhonda D'Vine
> ---
> debian/control | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/control b/debian/control
> index b84ae1c..60bc8b0 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -7,7 +7,7 @@
comments inline:
On 9/12/18 2:52 PM, Rhonda D'Vine wrote:
> The iso 3166-1 information in the iso-codes package seems to be more
> up to par than the one that was used from tzdata.
>
> Signed-off-by: Rhonda D'Vine
> ---
> country.pl | 18 --
> debian/control | 1 +
> 2
Dear Teams,
I've followed Fabian's instruction, and build process is success.
It turns out that: submodules/ubuntu-bionic downloading by build script,
is different than git clone
git://git.proxmox.com/git/mirror_ubuntu-bionic-kernel.git
Minor suggestion: please update this tutorial
On Fri, Aug 31, 2018 at 03:43:01PM +0200, Alexandre Derumier wrote:
> This fix cpu bug on last win10 updates
> ---
> PVE/QemuServer.pm | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 9bfb4a1..52b0163 100644
> --- a/PVE/QemuServer.pm
>
just some phrasing inline
On Thu, Sep 13, 2018 at 12:15:02PM +0200, Dominik Csapak wrote:
> instead do the machine logic inside qemu-server package with
> the rollback hook
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/AbstractConfig.pm | 31 +++
> 1 file changed,
Signed-off-by: Dominik Csapak
---
src/PVE/INotify.pm | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm
index dee9a3e..8b5544e 100644
--- a/src/PVE/INotify.pm
+++ b/src/PVE/INotify.pm
@@ -19,7 +19,8 @@ use PVE::ProcFSTools;
Signed-off-by: Dominik Csapak
---
changes from v3:
* removed digest code (now in api)
src/PVE/INotify.pm | 48
1 file changed, 48 insertions(+)
diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm
index 8b5544e..bea4821 100644
---
to show/edit /etc/hosts
Signed-off-by: Dominik Csapak
---
Makefile | 1 +
node/HostsView.js | 95 +++
2 files changed, 96 insertions(+)
create mode 100644 node/HostsView.js
diff --git a/Makefile b/Makefile
index ad820a2..20dba60
On Thu, Sep 13, 2018 at 04:08:03PM +0700, The Anh Tran wrote:
> Dear Teams,
>
> I've followed Fabian's instruction, and build process is success.
that's a good start ;)
> It turns out that: submodules/ubuntu-bionic downloading by build script, is
> different than git clone
>
with adding the NodeHostsView to the node tabs
Signed-off-by: Dominik Csapak
---
www/manager6/node/Config.js | 9 +
1 file changed, 9 insertions(+)
diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index 14738296..e7a38296 100644
--- a/www/manager6/node/Config.js
to get and set the content of /etc/hosts
Signed-off-by: Dominik Csapak
---
changes from v3:
* add digest code on read
PVE/API2/Nodes.pm | 78 +++
1 file changed, 78 insertions(+)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index
this series aims to make /etc/hosts view/editable via the gui
the first 2 patches of pve-common are strictly not necessary for the series,
but improve the read_network_interfaces to also read UTF-8 comments correctly
(as in if you have utf8 characters in your /etc/network/interfaces comments,
Signed-off-by: Dominik Csapak
---
src/PVE/INotify.pm | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm
index fc9471d..dee9a3e 100644
--- a/src/PVE/INotify.pm
+++ b/src/PVE/INotify.pm
@@ -873,10 +873,9 @@ sub
Thanks to Thomas for the useful input.
One question remains: The comment block about the used files seems
outdated, or rather obsolete. I even would suggest removing it
completely because it clearly doesn't match the content anymore:
There is nothing timezone related in here, the keymaps and x11
The iso 3166-1 information in the iso-codes package seems to be more
up to par than the one that was used from tzdata.
Signed-off-by: Rhonda D'Vine
---
country.pl | 14 --
debian/control | 1 +
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/country.pl
On Tue, Sep 11, 2018 at 11:43:39AM +0200, Stoiko Ivanov wrote:
> This series bumps spl and zfs to 0.7.10, by applying the respective patchsets
> from ZOL upstream, thus superseeding the zpl_mount-deadlock patch, included in
> 0.7.10.
might want to delay this until 0.7.11 is tagged, see ZoL issue
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> changes from v3:
> * moved all of the digest code to the api (instead of INotify)
This change produce a quite ugly interface, because we now need
to return both 'data' and 'raw'. I really prefer the old code where
we compute the digest directly.
Also, we also need to compute the digest for
instead of using '$dev1' as partition,
get the information from /sys/block/$dev
Signed-off-by: Dominik Csapak
---
PVE/API2/Disks/Directory.pm | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Disks/Directory.pm b/PVE/API2/Disks/Directory.pm
index
Accessing a non-existing 'format' key in plugindata (e.g. in LvmThinPlugin),
created it by autovivication, thus breaking the fallback to the default value
'raw' upon the second access.
Signed-off-by: Stoiko Ivanov
---
PVE/Storage/Plugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
>>Why 3.0 now? I thought 2.12 fixes this?
theses flags exists since a long time (qemu 2.5), I think we didn't enabled it
on proxmox4 because of missin kernel support.
but as you said me that you are working on qemu 3.0, it was for enabled them by
default for this machine.
>>And does this
54 matches
Mail list logo
