Re: [pve-devel] [PATCH v2 manager] Split CPU Model Selector into visual sections

2019-09-06 Thread Thomas Lamprecht
On 04.09.19 16:17, Stefan Reiter wrote: > Most of the code is adapted from KVComboBox, from which it inherited > before, with some generic code removed. > > The templating code adds a header for every group transition it > encounters, thus providing support for arbitrary groups (e.g. custom >

[pve-devel] applied: [PATCH pve-manager] api2: network reload: add frr config generation and reload

2019-09-06 Thread Thomas Lamprecht
On 04.09.19 07:54, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Network.pm | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm > index 07c3e6d3..d50a808d 100644 > --- a/PVE/API2/Network.pm >

[pve-devel] [PATCH pve-docs] vxlan: allowed routing to local vm on gateway nodes

2019-09-06 Thread Alexandre Derumier
We need to redistributed connected network to be able to join a vm running on a gateway nodes. also add a prefix-list in default vrf, to not propagate theses connected routes. (avoid loop) Signed-off-by: Alexandre Derumier --- vxlan-and-evpn.adoc | 44

[pve-devel] applied: [PATCH docs] update supported browsers

2019-09-06 Thread Thomas Lamprecht
On 04.09.19 09:00, Dominik Csapak wrote: > we do not support ie11 anymore due to some es6 features we use > > Signed-off-by: Dominik Csapak > --- > pve-system-requirements.adoc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/pve-system-requirements.adoc

[pve-devel] applied: [PATCH pve-docs] vxlan: allowed routing to local vm on gateway nodes

2019-09-06 Thread Thomas Lamprecht
On 06.09.19 09:42, Alexandre Derumier wrote: > We need to redistributed connected network to be able > to join a vm running on a gateway nodes. > > also add a prefix-list in default vrf, to not propagate > theses connected routes. (avoid loop) > > Signed-off-by: Alexandre Derumier > --- >

Re: [pve-devel] [PATCH ha-manager 1/4] allow LRM lock stealing for fenced nodes

2019-09-06 Thread Fabian Grünbichler
On March 27, 2019 5:42 pm, Thomas Lamprecht wrote: > We are only allowed to recover (=steal) a service when we have its > LRMs lock, as this guarantees us that even if said LRM comes up > again during the steal operation the LRM cannot start the services > when the service config still belongs to

Re: [pve-devel] [PATCH qemu-server v2 1/5] add create and remove reboot trigger subs

2019-09-06 Thread Thomas Lamprecht
On 05.09.19 13:00, Dominik Csapak wrote: > On 9/5/19 12:42 PM, Thomas Lamprecht wrote: >> On 05.09.19 12:27, Dominik Csapak wrote: >>> On 9/5/19 11:47 AM, Thomas Lamprecht wrote: On 23.08.19 10:55, Dominik Csapak wrote: >>> it would only reboot it in case we can remove the file though, >>>

[pve-devel] [PATCH qemu-server v3 1/4] api: add missing index child links

2019-09-06 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes from v2: * now 1/4 * does not include reboot (this comes in the api patch) PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 245de80..9db8967 100644 --- a/PVE/API2/Qemu.pm +++

[pve-devel] [PATCH qemu-server v3 0/4] add reboot api

2019-09-06 Thread Dominik Csapak
this adds a reboot api call for vms, which uses a reboot trigger file that gets detected by the qm cleanup call to start the vm again this api call is useful when users want to apply pending hardware changes without waiting for the vm to shutdown changes from v2: * reordered patches (index links

[pve-devel] [PATCH qemu-server v3 4/4] api: add reboot api call

2019-09-06 Thread Dominik Csapak
this creates a reboot trigger file (inspired by pve-container) and relies on the 'qm cleanup' call by the qmeventd to detect and restart the vm afterwards includes some refactoring of the 'vm_stop' call, so that we can have a clean 'vm_reboot' sub without the many parameters of 'vm_stop'

[pve-devel] [PATCH qemu-server v3 2/4] add create and remove reboot trigger subs

2019-09-06 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes from v2: * renamed to clear/create_reboot_request PVE/QemuServer.pm | 20 1 file changed, 20 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a424720..535297d 100644 --- a/PVE/QemuServer.pm +++

[pve-devel] [PATCH qemu-server v3 3/4] qm: cleanup: detect and handle reboot trigger

2019-09-06 Thread Dominik Csapak
if the reboot trigger file was set, start the vm again also cleanup the reboot trigger on vm startup, to prevent leftover files to trigger a reboot at the next shutdown Signed-off-by: Dominik Csapak --- changes from v2: * warn on error * add explaining comment PVE/CLI/qm.pm | 14

[pve-devel] [PATCH manager] fix login window on chrome

2019-09-06 Thread Dominik Csapak
labelWidth: 'auto' is not valid since extjs simply adds 'px' and sets it as width which would result in: width: 'autopx'; which is not valid css. chrome/chromium had a change such that this now produces the wrong height in the login bottom 'button bar' 250 should be enough for all translations

[pve-devel] [PATCH pve-network 0/2] vxlan-evpn: fix routing for local vms on gateway nodes

2019-09-06 Thread Alexandre Derumier
It was not possible to route from external to a local vm on a gateway node. I have reworked the config hash with better ordering and sub keys Alexandre Derumier (2): generate_frr_config: cleanup hash and ordering vxlan: evpn: fix routing to local vms on gateway nodes PVE/Network/SDN.pm

Re: [pve-devel] [PATCH manager] Add support for 16 PCI(e) devices

2019-09-06 Thread Dominik Csapak
looks good to me On 9/5/19 6:12 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 4 ++-- www/manager6/qemu/PCIEdit.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js

Re: [pve-devel] [PATCH v2 qemu-server 1/1] Add support for up to 16 PCI(e) devices

2019-09-06 Thread Dominik Csapak
looks mostly ok, one (important) comment inline On 9/5/19 6:13 PM, Aaron Lauterer wrote: For non pci express passthrough additional addresses are reserved. For pcie passthrough pcie root ports are needed (unless guest is like windows 7). The first 4 pcie root ports are defined by default in

Re: [pve-devel] [PATCH v2 qemu-server 1/1] Add support for up to 16 PCI(e) devices

2019-09-06 Thread Aaron Lauterer
On 9/6/19 2:45 PM, Dominik Csapak wrote: looks mostly ok, one (important) comment inline   # win7 is picky about pcie assignments   hostpci0bus0 => { bus => "pcie.0", addr => 16 },   hostpci1bus0 => { bus => "pcie.0", addr => 17 },   hostpci2bus0 => { bus => "pcie.0", addr =>

[pve-devel] [PATCH pve-network 1/2] generate_frr_config: cleanup hash and ordering

2019-09-06 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 99 ++ PVE/Network/SDN/FrrPlugin.pm | 13 +++-- PVE/Network/SDN/VxlanPlugin.pm | 18 ++- 3 files changed, 87 insertions(+), 43 deletions(-) diff --git a/PVE/Network/SDN.pm

[pve-devel] [PATCH pve-network 2/2] vxlan: evpn: fix routing to local vms on gateway nodes

2019-09-06 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 2 ++ PVE/Network/SDN/FrrPlugin.pm | 8 PVE/Network/SDN/VxlanPlugin.pm | 4 3 files changed, 14 insertions(+) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index d72b94a..528437f 100644 ---

[pve-devel] [PATCH v3 qemu-server 2/3] Fix local resource check of Spice USB devices

2019-09-06 Thread Aaron Lauterer
The check relied on the fact that in a regular use case a usb device of type spice would not have any other settings like `usb3=1`. An exact match worked fine for this. This patch changes the behaviour and makes it possible to migrate VMs with Spice USB devices that have additional usb options

[pve-devel] [PATCH v3 qemu-server pve-manager 0/3] Fix #2343 Spice USB3 support

2019-09-06 Thread Aaron Lauterer
This patch series enables USB3 for the passthrough / redirection of USB devices via the Spice client. v2 -> v3: * don't modify current behavior * fix local resource check * fix and cleanup GUI code v1 -> v2: * no qemu version checks * fix local resource check on migration * add GUI support

[pve-devel] [PATCH v3 manager 3/3] Enable USB3 for Spice USB passthrough

2019-09-06 Thread Aaron Lauterer
Instead of having two times the check if the USB3 setting needs to be added to the config string it is now checked at one place only. If USB3 is checked for a non USB3 device it will be attached to the USB2 root hub of the xhci controller. Signed-off-by: Aaron Lauterer --- @Thomas: I hope I

[pve-devel] [PATCH v3 qemu-server 1/3] Add USB3 capablities to Spice USB devices

2019-09-06 Thread Aaron Lauterer
To not change current behaviour and thus breaking live migration USB3 for a Spice USB device requires Qemu v4.1. The old behavior was that even though technically it was possible to the set `usb3=1` setting, it was ignored. The bus was hardcoded to ehci. If another USB2 device was added or the

[pve-devel] applied: [PATCH v2 qemu-server 1/1] Add support for up to 16 PCI(e) devices

2019-09-06 Thread Thomas Lamprecht
On 06.09.19 14:50, Aaron Lauterer wrote: > > > On 9/6/19 2:45 PM, Dominik Csapak wrote: >> looks mostly ok, one (important) comment inline >> >>>   # win7 is picky about pcie assignments >>>   hostpci0bus0 => { bus => "pcie.0", addr => 16 }, >>>   hostpci1bus0 => { bus => "pcie.0",

Re: [pve-devel] [PATCH qemu 1/7] Trigger pve-api-updates on update

2019-09-06 Thread Fabian Grünbichler
On September 2, 2019 4:27 pm, Stefan Reiter wrote: > A QEMU update can change supported CPU flags, thus we need to restart > API services (especially pvestatd) to refresh their cached values. given the recent discussion about this exact change, we could also use

Re: [pve-devel] [PATCH ha-manager 4/4] add some infos about HW fencing to README

2019-09-06 Thread Fabian Grünbichler
On March 27, 2019 5:42 pm, Thomas Lamprecht wrote: missing S-O-B missing information about the fencing mode semantics? there's just one sentence in 'man datacenter.cfg', see patch #2/cover letter comments. looks fine for git-level readme, would need more grammaer/style cleanup for reference

Re: [pve-devel] [PATCH ha-manager 3/4] send also email on hardware fence failure

2019-09-06 Thread Fabian Grünbichler
On March 27, 2019 5:42 pm, Thomas Lamprecht wrote: > We introduced sending an email when Fencing fails/succeeds in > general some time ago, send now also an email if a HW fence > fails missing S-O-B > --- > src/PVE/HA/NodeStatus.pm | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [pve-devel] [PATCH manager 2/7] Broadcast supported CPU flags

2019-09-06 Thread Fabian Grünbichler
On September 2, 2019 4:27 pm, Stefan Reiter wrote: > pvestatd will read supported CPU flags once on startup (since these > never change during runtime, and QEMU updates trigger a service > restart), then broadcasts them as a key-value pair to the cluster. > > Signed-off-by: Stefan Reiter > --- >

Re: [pve-devel] [PATCH ha-manager 2/4] allow use of external fencing devices

2019-09-06 Thread Fabian Grünbichler
On March 27, 2019 5:42 pm, Thomas Lamprecht wrote: > A node now can be fenced with the use of external hardware fence > devices. > Those device can be configured at /etc/pve/ha/fence.cfg > also the fencing option in the datacenter configuration file must > be set to either 'hardware' or 'both',

Re: [pve-devel] [PATCH qemu-server 3/7] Add QEMU CPU flag querying helpers

2019-09-06 Thread Fabian Grünbichler
On September 2, 2019 4:27 pm, Stefan Reiter wrote: > * query_understood_cpu_flags returns all flags that QEMU/KVM knows about > * query_supported_cpu_flags returns all flags that QEMU/KVM can use on > this particular host. > > To get supported flags, a temporary VM is started with QEMU, so we

[pve-devel] [PATCH storage] fix vmid filter for backup listing

2019-09-06 Thread Dominik Csapak
$1 and $2 get set to undef from the vmid filter regex, so we have to do the name/format regex after, else we get errors like: 'use of unitiialized value $1[...]' and the listing is empty Signed-off-by: Dominik Csapak --- PVE/Storage/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1

Re: [pve-devel] [PATCH ha-manager 0/4] Add inital HW based fencing

2019-09-06 Thread Fabian Grünbichler
On March 27, 2019 5:42 pm, Thomas Lamprecht wrote: > Actually this'd be v8, but it's to old and to unreviewed for anybody do > remember anyway, so best seen as new series. > > Thomas Lamprecht (4): > allow LRM lock stealing for fenced nodes > allow use of external fencing devices > send

[pve-devel] applied: [PATCH manager] fix login window on chrome

2019-09-06 Thread Thomas Lamprecht
On 06.09.19 14:28, Dominik Csapak wrote: > labelWidth: 'auto' is not valid since extjs simply > adds 'px' and sets it as width which would result in: > > width: 'autopx'; > > which is not valid css. chrome/chromium had a change such that this now > produces the wrong height in the login bottom