Re: [pve-devel] [PATCH pve-manager] api, ui: allow to remove subscription

2020-05-26 Thread Thomas Lamprecht
On 5/26/20 3:42 PM, Moayad Almalat wrote: > Signed-off-by: Moayad Almalat > --- please add a changelog here, e.g. changes from v2 -> v3: * set returns property for API schema * ... FYI: you can add a "v2" easily by using the -v2 option in `git format-patch` or `git send-email`. >

[pve-devel] [PATCH pve-manager] api, ui: allow to remove subscription

2020-05-26 Thread Moayad Almalat
Signed-off-by: Moayad Almalat --- PVE/API2/Subscription.pm | 24 PVE/CLI/pvesubscription.pm| 1 + www/manager6/node/Subscription.js | 9 + 3 files changed, 34 insertions(+) diff --git a/PVE/API2/Subscription.pm b/PVE/API2/Subscription.pm index

[pve-devel] [PATCH pve-docs 1/3] sdn: add a note to add "source /etc/network/interfaces.d/*"

2020-05-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- pvesdn.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pvesdn.adoc b/pvesdn.adoc index f890003..0dd58ee 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -267,6 +267,12 @@ After applying the configuration through the main SDN web-interface panel,

Re: [pve-devel] [PATCH container] lxc: fall back to 'unmanaged' when no OS detected

2020-05-26 Thread Thomas Lamprecht
On 5/18/20 1:17 PM, Arnout Engelen wrote: > This is useful when the uploaded CT does not contain a full OS. When the > autodetection detects an OS, that OS is returned. When it does not > successfully detect a supported OS, but /etc/os-release exists and has an ID > other than 'unmanaged', then

[pve-devel] applied: Re: [PATCH v2 container] fix #2655: don't forget to setup securetty for centos >= 7

2020-05-26 Thread Thomas Lamprecht
On 5/25/20 2:32 PM, Oguz Bektas wrote: > in template_fixup we only call this method for version < 7, but greater > versions also need to allow lxc/tty[N] as secure. > > Signed-off-by: Oguz Bektas > --- > > v1->v2: > * call setup_securetty unconditionally > > src/PVE/LXC/Setup/CentOS.pm | 5

[pve-devel] [PATCH widget-toolkit] improve error extraction for monStoreErrors

2020-05-26 Thread Dominik Csapak
by printing the whole error body when it cannot be parsed as JSON Signed-off-by: Dominik Csapak --- Utils.js | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/Utils.js b/Utils.js index 33c9b77..56b1c9a 100644 --- a/Utils.js +++ b/Utils.js @@ -244,17 +244,22 @@

Re: [pve-devel] [PATCH container] lxc: fall back to 'unmanaged' when no OS detected

2020-05-26 Thread Arnout Engelen
On Tue, May 26, 2020 at 11:31 AM Thomas Lamprecht wrote: > On 5/18/20 1:17 PM, Arnout Engelen wrote: > > Perhaps it would be even more consistent to make 'unmanaged' a plugin > > next to the various OS plugins, but I wanted to keep the change as > > simple as possible for now. > > if (my

Re: [pve-devel] [PATCH container] lxc: fall back to 'unmanaged' when no OS detected

2020-05-26 Thread Thomas Lamprecht
On 5/26/20 11:40 AM, Arnout Engelen wrote: > On Tue, May 26, 2020 at 11:31 AM Thomas Lamprecht > wrote: >> On 5/18/20 1:17 PM, Arnout Engelen wrote: >>> Perhaps it would be even more consistent to make 'unmanaged' a plugin >>> next to the various OS plugins, but I wanted to keep the change as >>>

[pve-devel] [PATCH pve-docs 2/3] sdn: add vnet vlan-aware option

2020-05-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- pvesdn.adoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pvesdn.adoc b/pvesdn.adoc index 0dd58ee..af89bba 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -114,6 +114,9 @@ VNet properties are: * Tag: The unique VLAN or VXLAN id +* Vlan Aware:

[pve-devel] [PATCH pve-docs 3/3] sdn: fix qinq zone2 example

2020-05-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- pvesdn.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index af89bba..90a89d8 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -442,7 +442,7 @@ Create a `myvnet2' with customer VLAN-id 100 on the previously

[pve-devel] [PATCH pve-docs 0/3] sdn: improvement

2020-05-26 Thread Alexandre Derumier
Somes fixes, and add description for new vnet vlan-aware option Alexandre Derumier (3): sdn: add a note to add "source /etc/network/interfaces.d/*" sdn: add vnet vlan-aware option sdn: fix qinq zone2 example pvesdn.adoc | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) --

[pve-devel] [PATCH v2 pve-manager] api, ui: allow to remove subscriptio

2020-05-26 Thread Moayad Almalat
Signed-off-by: Moayad Almalat --- PVE/API2/Subscription.pm | 24 PVE/CLI/pvesubscription.pm| 1 + www/manager6/node/Subscription.js | 9 + 3 files changed, 34 insertions(+) diff --git a/PVE/API2/Subscription.pm b/PVE/API2/Subscription.pm index

[pve-devel] applied: Re: [PATCH v2 manager] Fix 2718: GUI: handle localtime option correctly

2020-05-26 Thread Thomas Lamprecht
On 5/19/20 10:12 AM, Fabian Ebner wrote: > The backend treats an undefined value and 0 differently. If the option > is undefined, it will still be set for Windows in config_to_command. > Replace the checkbox with a combobox covering all options. > > Signed-off-by: Fabian Ebner > --- > > Changes

[pve-devel] applied: Re: [PATCH widget-toolkit] improve error extraction for monStoreErrors

2020-05-26 Thread Thomas Lamprecht
On 5/26/20 11:55 AM, Dominik Csapak wrote: > by printing the whole error body when it cannot be parsed as JSON > > Signed-off-by: Dominik Csapak > --- > Utils.js | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > applied, thanks!

[pve-devel] [PATCH pve-manager] sdn: add vlan aware option to vnet

2020-05-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/VnetEdit.js | 5 ++--- www/manager6/sdn/VnetView.js | 5 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js index e2ace128..c5e3859d 100644 ---

[pve-devel] applied: [PATCH] form/display edit: use the 'fit' layout to avoid width glitch

2020-05-26 Thread Thomas Lamprecht
As else we get some issues with inner field adding some space on outer fieldcontainer, which let a mix of "normal" fields and this one appear asymmetrical. Signed-off-by: Thomas Lamprecht --- form/DisplayEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git