applied, thanks!
- only use firewall=1|0 from network configuration, to enable/disable fwbr
bridge
- use firewall=0 by default
- remove pve-brige-fw script. (we simply use tap firewall option in pve-brige)
___
pve-devel mailing list
- if(($newnet-{bridge} ne $oldnet-{bridge}) || ($newnet-
{tag} ne $oldnet-{tag})){
- eval{PVE::Network::tap_unplug($iface, $oldnet-{bridge},
$oldnet-{tag});};
- PVE::Network::tap_plug($iface, $newnet-{bridge},
$newnet-{tag});
+
Why do you pass all those parameters to tap_unplug?
we can remove them, this is old code.
And why do we ignore errors here?
we can remove eval too, I think before we didn't check in tap_unplug where the
tap was really plugged.
- Mail original -
De: Dietmar Maurer
Why do you pass all those parameters to tap_unplug?
we can remove them, this is old code.
And why do we ignore errors here?
we can remove eval too, I think before we didn't check in tap_unplug where
the tap was really plugged.
done
___
In the git version:
- If libiscsi1 was renamed to libiscsi2, then it needs a Replace:
libiscsi1 or it won't install correctly
- pve-qemu-kvm needs to depend on libiscsi2 rather then libiscsi1
Just my findings when trying to compile qemu 2.0 with the latest libiscsi.
Best regards,
Adrian Costin
On Tue, 6 May 2014 05:54:43 +
Dietmar Maurer diet...@proxmox.com wrote:
Thanks, that would be great. I don't really want to commit things to the ZFS
plugin
without prior acknowledge from you or Alexandre.
I have tested the following commits on FreeBSD (Istgt):
commit
- If libiscsi1 was renamed to libiscsi2, then it needs a Replace:
libiscsi1 or it won't install correctly
why? We want to be able to install both libraries.
- pve-qemu-kvm needs to depend on libiscsi2 rather then libiscsi1
Depends: iproute, bridge-utils, python, libsdl1.2debian, libaio1,
