Re: [pve-devel] [PATCH 1/2] GUI: add new email_from option to datacenter.cfg

2014-09-04 Thread Dietmar Maurer
I a still not sure this is the right way to do it. For example, what happens with other system mails sent to root? Many other tools (for example cron) send mail to system accounts, and it would be great if we can deliver that correctly. So would it be possible to add the '-f $mailfrom' flag

Re: [pve-devel] [PATCH 1/2] GUI: add new email_from option to datacenter.cfg

2014-09-04 Thread Stanislav German-Evtushenko
On Thu, Sep 4, 2014 at 11:17 AM, Dietmar Maurer diet...@proxmox.com wrote: I a still not sure this is the right way to do it. For example, what happens with other system mails sent to root? Many other tools (for example cron) send mail to system accounts, and it would be great if we can

Re: [pve-devel] [PATCH 1/2] GUI: add new email_from option to datacenter.cfg

2014-09-04 Thread Dietmar Maurer
So would it be possible to add the '-f $mailfrom' flag inside pve- magager/bin/pvemailforward.pl instead? You are right. However -f $mailfrom is not enough, we would need to change email body too. This can be done by procmail or you know something better for perl? Just adopt your patch and

Re: [pve-devel] [PATCH 1/2] GUI: add new email_from option to datacenter.cfg

2014-09-04 Thread Stanislav German-Evtushenko
On Thu, Sep 4, 2014 at 12:51 PM, Dietmar Maurer diet...@proxmox.com wrote: So would it be possible to add the '-f $mailfrom' flag inside pve- magager/bin/pvemailforward.pl instead? You are right. However -f $mailfrom is not enough, we would need to change email body too. This can be

Re: [pve-devel] [PATCH 1/2] GUI: add new email_from option to datacenter.cfg

2014-09-04 Thread Stanislav German-Evtushenko
On Thu, Sep 4, 2014 at 1:10 PM, Dietmar Maurer diet...@proxmox.com wrote: Just adopt your patch and set '-f $mailfrom' inside pvemailforward.pl. The mail from header is not really relevant for mail delivery, so I am not sure if we need/want to change it at all? This just won't look

[pve-devel] [PATCH] vhost-net: extend device allocation to vmalloc

2014-09-04 Thread Dmitry Petuhov
Backport upstream commit 23cc5a991c7a9fb7e6d6550e65cee4f4173111c5 to 3.10 kernel. In upstream, this code is modified later in patch d04257b07f2362d4eb550952d5bf5f4241a8046d, but it's unapplicable in 3.10 because there's still no open-coded kvfree() function (appeared in v3.15-rc5). Should

[pve-devel] pve-manager: add new email_from option to datacenter.cfg

2014-09-04 Thread Stanislav German-Evtushenko
This patch adds a new option email_from to datacenter.cfg and the web-interface. The update includes changes for pvemailforward.pl. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH 1/3] GUI: add new email_from option to datacenter.cfg

2014-09-04 Thread Stanislav German-Evtushenko
Signed-off-by: Stanislav German-Evtushenko ginerm...@gmail.com --- PVE/API2/APT.pm | 5 +++-- PVE/VZDump.pm| 6 -- www/manager/dc/OptionView.js | 37 + 3 files changed, 44 insertions(+), 4 deletions(-) diff --git

[pve-devel] [PATCH 3/3] email_from: apply $mailfrom changes for pvemailforward.pl

2014-09-04 Thread Stanislav German-Evtushenko
Signed-off-by: Stanislav German-Evtushenko ginerm...@gmail.com --- bin/pvemailforward.pl | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bin/pvemailforward.pl b/bin/pvemailforward.pl index 53b58a0..2f807e4 100755 --- a/bin/pvemailforward.pl +++ b/bin/pvemailforward.pl @@

[pve-devel] [PATCH 2/3] email_from: fix for insecure dependency in piped open when email_from is empty

2014-09-04 Thread Stanislav German-Evtushenko
Signed-off-by: Stanislav German-Evtushenko ginerm...@gmail.com --- PVE/API2/APT.pm | 2 +- PVE/VZDump.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index 92deeea..3327445 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -341,7

Re: [pve-devel] [PATCH 2/3] email_from: fix for insecure dependency in piped open when email_from is empty

2014-09-04 Thread Dietmar Maurer
Can't you merge this into the first patch? I see no advantage in keeping that history. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] GUI: add new email_from option to datacenter.cfg

2014-09-04 Thread Stanislav German-Evtushenko
Signed-off-by: Stanislav German-Evtushenko ginerm...@gmail.com --- PVE/API2/APT.pm | 5 +++-- PVE/VZDump.pm| 6 -- bin/pvemailforward.pl| 5 - www/manager/dc/OptionView.js | 37 + 4 files changed, 48

[pve-devel] [PATCH] allow only hotpluggable|dynamics options to be change online

2014-09-04 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier aderum...@odiso.com --- PVE/API2/Qemu.pm | 113 ++ 1 file changed, 113 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 985a9f8..e0af841 100644 --- a/PVE/API2/Qemu.pm +++

[pve-devel] qemu-server : allow only hotpluggable|dynamics options to be change online

2014-09-04 Thread Alexandre Derumier
Hi, This is a first try for filtering options change of running vms. Only hotplugable values (disk,nic,cpu), dynamics values (disk throttle, cdrom media change,balloon,..), and some options (name,onboot,...) are allowed. The main idea is to always have a config which is the same than running

Re: [pve-devel] [PATCH] vhost-net: extend device allocation to vmalloc

2014-09-04 Thread Alexandre DERUMIER
Thanks, I'll build a kernel for you tomorrow, do you have time to test it ? - Mail original - De: Dmitry Petuhov mityapetu...@gmail.com À: pve-devel@pve.proxmox.com Envoyé: Jeudi 4 Septembre 2014 12:23:18 Objet: [pve-devel] [PATCH] vhost-net: extend device allocation to vmalloc

Re: [pve-devel] qemu-server : allow only hotpluggable|dynamics options to be change online

2014-09-04 Thread Stefan Priebe - Profihost AG
Did you see my patches posted earlier this year? I already did the same. I can post also an up2date version. There are some corner cases. Like mem with virtio. Stefan Excuse my typo sent from my mobile phone. Am 04.09.2014 um 15:50 schrieb Alexandre Derumier aderum...@odiso.com: Hi,

Re: [pve-devel] qemu-server : allow only hotpluggable|dynamics options to be change online

2014-09-04 Thread Alexandre DERUMIER
Did you see my patches posted earlier this year? I already did the same. I can post also an up2date version. yes, sure, resend your patch. I would like to compare :) (I think I'm doing it early than, before going into the main loop). There are some corner cases. Like mem with virtio. Oh,

Re: [pve-devel] [PATCH] vhost-net: extend device allocation to vmalloc

2014-09-04 Thread Dmitry Petuhov
Yes. 04.09.2014 17:51, Alexandre DERUMIER пишет: Thanks, I'll build a kernel for you tomorrow, do you have time to test it ? - Mail original - De: Dmitry Petuhov mityapetu...@gmail.com À: pve-devel@pve.proxmox.com Envoyé: Jeudi 4 Septembre 2014 12:23:18 Objet: [pve-devel] [PATCH]

Re: [pve-devel] [PATCH] GUI: add new email_from option to datacenter.cfg

2014-09-04 Thread Dietmar Maurer
applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] idea: new section 'sysrules' inside vmid.fw

2014-09-04 Thread Dietmar Maurer
inside /etc/pve/firewall/vmid.fw [sysrules] group ... IN ... OUT ... [rules] ... - Where all rules inside [sysrules] have higher priority than other rules. Only System Admin can see/change those rules. good or bad idea?

Re: [pve-devel] idea: new section 'sysrules' inside vmid.fw

2014-09-04 Thread Friedrich Ramberger
A good one - I guess the rules (without sys) are userrules then (= managed by user-permission level) - maybe we can use this term in the config-file too (in order to make it more transparent) like [userrules] But, of course, which term tuo use it is neither essential nor important

Re: [pve-devel] idea: new section 'sysrules' inside vmid.fw

2014-09-04 Thread Michael Rasmussen
On Thu, 4 Sep 2014 17:47:13 + Dietmar Maurer diet...@proxmox.com wrote: Where all rules inside [sysrules] have higher priority than other rules. Only System Admin can see/change those rules. good or bad idea? I think others which are allowed to configure firewalls should be allowed

Re: [pve-devel] idea: new section 'sysrules' inside vmid.fw

2014-09-04 Thread Friedrich Ramberger
See comment below -Original Message- From: pve-devel [mailto:pve-devel-boun...@pve.proxmox.com] On Behalf Of Michael Rasmussen Sent: Donnerstag, 04. September 2014 20:10 To: pve-devel@pve.proxmox.com Subject: Re: [pve-devel] idea: new section 'sysrules' inside vmid.fw On Thu, 4 Sep 2014

Re: [pve-devel] idea: new section 'sysrules' inside vmid.fw

2014-09-04 Thread Dietmar Maurer
I think we can make [sysrules] visible to the VM admin. To hide rules from VM admin, one can put them into a group defined in cluster.fw I think others which are allowed to configure firewalls should be allowed to see the system firewall rules to prevent people from trying to debug not