Re: [pve-devel] [PATCH] memory form : hotplug improvements
does onSpinUp, onSpinDown also work if we change value manually without using up|down button ? I finally fixed that by listening to blur signal: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=5e0a288e38c8cba1faf99a5efb62a06352582d03 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
Yes, I am the new Proxmox *t*eam member. Am 10.02.15 um 17:14 schrieb Alexandre DERUMIER: Seem to be perfect here :) Thanks ! I'm going to work on cpu hotplug tommorow. BTW, is Wolfgang a new proxmox team member ? - Mail original - De: dietmar diet...@proxmox.com À: aderumier aderum...@odiso.com Cc: pve-devel pve-devel@pve.proxmox.com Envoyé: Mardi 10 Février 2015 16:42:39 Objet: Re: [pve-devel] [PATCH] memory form : hotplug improvements does onSpinUp, onSpinDown also work if we change value manually without using up|down button ? I finally fixed that by listening to blur signal: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=5e0a288e38c8cba1faf99a5efb62a06352582d03 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
Speaking of todo lists. What are the status for adding DHCP server feature to proxmox? AFAIK you are working on that? IPv6 is still missing? Or did you already implement/sent that? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
Seem to be perfect here :) Thanks ! I'm going to work on cpu hotplug tommorow. BTW, is Wolfgang a new proxmox team member ? - Mail original - De: dietmar diet...@proxmox.com À: aderumier aderum...@odiso.com Cc: pve-devel pve-devel@pve.proxmox.com Envoyé: Mardi 10 Février 2015 16:42:39 Objet: Re: [pve-devel] [PATCH] memory form : hotplug improvements does onSpinUp, onSpinDown also work if we change value manually without using up|down button ? I finally fixed that by listening to blur signal: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=5e0a288e38c8cba1faf99a5efb62a06352582d03 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] enable debug package for pve-cluster
Here are some more lines: pmxcfs[4156]: segfault at 21341873 ip 0041aa9c sp # addr2line -e /usr/bin/pmxcfs 0041aa9c /home/dietmar/pve2-devel/pve-cluster/build/src/logger.c:167 I am unable to find the bug, so I need more infos. Do you think you can generate a core file? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] [PATCH] vm_devices_list : list devices behind pci bridge
This fix hotplug for devices behind bridges, like nic6-24 for example
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
PVE/QemuServer.pm | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 59441e1..70e2ae6 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3208,8 +3208,18 @@ sub vm_devices_list {
my $devices = {};
foreach my $pcibus (@$res) {
foreach my $device (@{$pcibus-{devices}}) {
- next if !$device-{'qdev_id'};
- $devices-{$device-{'qdev_id'}} = 1;
+ if ($device-{'pci_bridge'}) {
+
+ $devices-{$device-{'qdev_id'}} = 1;
+ foreach my $bridge_device
(@{$device-{'pci_bridge'}-{devices}}) {
+ next if !$bridge_device-{'qdev_id'};
+ $devices-{$bridge_device-{'qdev_id'}} = 1;
+ $devices-{$device-{'qdev_id'}}++;
+ }
+ } else {
+ next if !$device-{'qdev_id'};
+ $devices-{$device-{'qdev_id'}} = 1;
+ }
}
}
--
1.7.10.4
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
I'm going to work on cpu hotplug tommorow. BTW, is Wolfgang a new proxmox team member ? Yes :-) Our todo lists are quite long, so we try to enlarge the team. And we are still locking for new developers: https://www.proxmox.com/about/careers - Dietmar ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
Yes, I am the new Proxmox team member. That's Great :) Nice to meet you. - Mail original - De: Wolfgang Link w.l...@proxmox.com À: aderumier aderum...@odiso.com Cc: pve-devel pve-devel@pve.proxmox.com Envoyé: Mardi 10 Février 2015 17:32:12 Objet: Re: [pve-devel] [PATCH] memory form : hotplug improvements Yes, I am the new Proxmox t eam member. Am 10.02.15 um 17:14 schrieb Alexandre DERUMIER: Seem to be perfect here :) Thanks ! I'm going to work on cpu hotplug tommorow. BTW, is Wolfgang a new proxmox team member ? - Mail original - De: dietmar diet...@proxmox.com À: aderumier aderum...@odiso.com Cc: pve-devel pve-devel@pve.proxmox.com Envoyé: Mardi 10 Février 2015 16:42:39 Objet: Re: [pve-devel] [PATCH] memory form : hotplug improvements BQ_BEGIN does onSpinUp, onSpinDown also work if we change value manually without using up|down button ? I finally fixed that by listening to blur signal: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=5e0a288e38c8cba1faf99a5efb62a06352582d03 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel BQ_END ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] enable debug package for pve-cluster
I hope so. I already prepared everything to get a core dump next time. Will report back if it happens again. OK. Ps: what's about my other patches from last week? Will try to look at them tomorrow. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
On Tue, 10 Feb 2015 17:52:27 +0100 (CET) Dietmar Maurer diet...@proxmox.com wrote: Yes :-) Our todo lists are quite long, so we try to enlarge the team. Speaking of todo lists. What are the status for adding DHCP server feature to proxmox? -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: It's always sad when the fleas leave, because that means your dog is dead. -- Wesley T. Williams pgphEsYPTng1z.pgp Description: OpenPGP digital signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] enable debug package for pve-cluster
Am 10.02.2015 um 17:42 schrieb Dietmar Maurer diet...@proxmox.com: Here are some more lines: pmxcfs[4156]: segfault at 21341873 ip 0041aa9c sp # addr2line -e /usr/bin/pmxcfs 0041aa9c /home/dietmar/pve2-devel/pve-cluster/build/src/logger.c:167 I am unable to find the bug, so I need more infos. Do you think you can generate a core file? I hope so. I already prepared everything to get a core dump next time. Will report back if it happens again. Thanks! Ps: what's about my other patches from last week? Stefan ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] [PATCH] bug 597: hotplug fix
wrap params in dopple quotes, so spaces will accept.
Signed-off-by: Wolfgang Link w.l...@proxmox.com
---
PVE/QemuServer.pm |4
1 file changed, 4 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7045c14..9b4e137 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4248,6 +4248,10 @@ sub vm_qmp_command {
sub vm_human_monitor_command {
my ($vmid, $cmdline) = @_;
+#This is necessary, so Human-Monitor accept spaces.
+$cmdline =~ s/(file=rbd:)/\$1/g;
+$cmdline .=\;
+
my $res;
my $cmd = {
--
1.7.10.4
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
applied with additional cleanups to avoid hard-coded constants - please can you test? https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=2cf71959752511f5c776fc1915e17e836acab686 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] bug 597: hotplug fix
applied, thanks!
On 02/10/2015 12:59 PM, Wolfgang Link wrote:
wrap params in dopple quotes, so spaces will accept.
Signed-off-by: Wolfgang Link w.l...@proxmox.com
---
PVE/QemuServer.pm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 556bbb7..59441e1 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3384,7 +3384,7 @@ sub qemu_driveadd {
my ($storecfg, $vmid, $device) = @_;
my $drive = print_drive_full($storecfg, $vmid, $device);
-my $ret = vm_human_monitor_command($vmid, drive_add auto $drive);
+my $ret = vm_human_monitor_command($vmid, drive_add auto \$drive\);
# If the command succeeds qemu prints: OK
return 1 if $ret =~ m/OK/s;
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] [PATCH] zfspoolplugin: fix volume_resize
copy methode volume_resize form ZFSPlugin.pm to ZFSPoolPlugin.pm
refactor volume_resize
Signed-off-by: Wolfgang Link w.l...@proxmox.com
---
PVE/Storage/ZFSPlugin.pm |7 ---
PVE/Storage/ZFSPoolPlugin.pm | 10 ++
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/PVE/Storage/ZFSPlugin.pm b/PVE/Storage/ZFSPlugin.pm
index 43cfcd8..77394b9 100644
--- a/PVE/Storage/ZFSPlugin.pm
+++ b/PVE/Storage/ZFSPlugin.pm
@@ -299,11 +299,12 @@ sub free_image {
sub volume_resize {
my ($class, $scfg, $storeid, $volname, $size, $running) = @_;
+
+my $new_size = $class-SUPER::volume_resize($scfg, $storeid, $volname,
$size, $running);
-my $new_size = ($size/1024);
-
-$class-zfs_request($scfg, undef, 'set', 'volsize=' . $new_size . 'k',
$scfg-{pool}/$volname);
$class-zfs_resize_lu($scfg, $volname, $new_size);
+
+return $new_size;
}
sub volume_snapshot_rollback {
diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
index 83dbc7f..754f29f 100644
--- a/PVE/Storage/ZFSPoolPlugin.pm
+++ b/PVE/Storage/ZFSPoolPlugin.pm
@@ -489,6 +489,16 @@ sub create_base {
return $newvolname;
}
+sub volume_resize {
+my ($class, $scfg, $storeid, $volname, $size, $running) = @_;
+
+my $new_size = ($size/1024);
+
+$class-zfs_request($scfg, undef, 'set', 'volsize=' . $new_size . 'k',
$scfg-{pool}/$volname);
+
+return $new_size;
+}
+
sub volume_has_feature {
my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running) = @_;
--
1.7.10.4
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
Fixme : apply same behaviour for maxmemory field just implemented this. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] [PATCH] bug 597: hotplug fix
wrap params in dopple quotes, so spaces will accept.
Signed-off-by: Wolfgang Link w.l...@proxmox.com
---
PVE/QemuServer.pm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 556bbb7..59441e1 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3384,7 +3384,7 @@ sub qemu_driveadd {
my ($storecfg, $vmid, $device) = @_;
my $drive = print_drive_full($storecfg, $vmid, $device);
-my $ret = vm_human_monitor_command($vmid, drive_add auto $drive);
+my $ret = vm_human_monitor_command($vmid, drive_add auto \$drive\);
# If the command succeeds qemu prints: OK
return 1 if $ret =~ m/OK/s;
--
1.7.10.4
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
I'll try tomorrow does onSpinUp, onSpinDown also work if we change value manually without using up|down button ? - Mail original - De: dietmar diet...@proxmox.com À: aderumier aderum...@odiso.com, pve-devel pve-devel@pve.proxmox.com Envoyé: Mardi 10 Février 2015 11:46:10 Objet: Re: [pve-devel] [PATCH] memory form : hotplug improvements applied with additional cleanups to avoid hard-coded constants - please can you test? https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=2cf71959752511f5c776fc1915e17e836acab686 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
I was under the impression that a decision whether to develop one from scratch in Perl or to use dnsmasq, unbound etc. was not made yet so I stopped with the IPv4 implementation waiting for a decision. If the decision was dnsmasq, unbound etc. there was no idea going any further since this would just be a waist of time. If an implementation in Perl is favored I will start looking into IPv6. There seems to be little help from CPAN so I'm afraid doing the IPv6 server requires implementing rfc3315 from scratch. These does not scare me since I have implemented rfc's in the past but the time required to implement and test will obviously be extended considerably. I would favior a Perl implementation, but only if code base is not too large. Managing the whole IPv6 dhcp stack looks too much overhead for me. Do you (or alexandre) have time to update the dnsmasqd based patch? Maybe the new firewall can help to implement all features we need? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
On Tue, 10 Feb 2015 20:11:20 +0100 (CET) Dietmar Maurer diet...@proxmox.com wrote: Do you (or alexandre) have time to update the dnsmasqd based patch? Maybe the new firewall can help to implement all features we need? I will look in to this. I can't seem to find the git repo for dnsmasq in git.proxmox.com? We should disable DNS and TFTP and only use DHCP? -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: PARDON me, am I speaking ENGLISH? pgpd86PTSNLO_.pgp Description: OpenPGP digital signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Optimizing CPU flags
On 01/30/2015 10:23 PM, Stefan Priebe wrote: For mixed clusters, use the lowest available CPU version, so if one host is Penryn and the other Nehalem, use Penryn on both. If you are using RHEV or oVirt, this is already built in. VMWare have this called EVC and position it as a huge feature. What exactly is a fixed cluster? The admin can always add an additional node, and it is not possible to know the CPU features of new nodes in advance. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
Do you (or alexandre) have time to update the dnsmasqd based patch? Maybe the new firewall can help to implement all features we need? I will look in to this. I can't seem to find the git repo for dnsmasq in git.proxmox.com? Cant we use the debian package? https://packages.debian.org/wheezy/dnsmasq We should disable DNS and TFTP and only use DHCP? No idea. But we want to start with DHCP. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH 1/2] Fix next_unused_port already bin detection
applied both patches, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] QemuServer: fix wrong binding of pci root ports, bridges or switches to vfio
applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] Optimizing CPU flags
this might also need the enforce parameter. enforce is currently buggy on 2.6.32, but works fine with 3.10 kernel. - Mail original - De: Stefan Priebe s.pri...@profihost.ag À: dietmar diet...@proxmox.com, pve-devel pve-devel@pve.proxmox.com Envoyé: Mercredi 11 Février 2015 08:17:01 Objet: Re: [pve-devel] Optimizing CPU flags Am 11.02.2015 um 06:28 schrieb Dietmar Maurer: On 01/30/2015 10:23 PM, Stefan Priebe wrote: For mixed clusters, use the lowest available CPU version, so if one host is Penryn and the other Nehalem, use Penryn on both. If you are using RHEV or oVirt, this is already built in. VMWare have this called EVC and position it as a huge feature. What exactly is a fixed cluster? The admin can always add an additional node, and it is not possible to know the CPU features of new nodes in advance. Sure live migration may fail - but this is also true for using the host option. The optimize option has the advantage that the maximum features will be used for new VMs - this might also need the enforce parameter. Stefan ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH] memory form : hotplug improvements
does onSpinUp, onSpinDown also work if we change value manually without using up|down button ? no, I need to fix that. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
