Re: [pve-devel] [PATCH] qmp drive_add : remove backslashes from $drive string

2015-03-02 Thread Dietmar Maurer
On 03/02/2015 08:54 AM, Alexandre DERUMIER wrote $drive string: 'file=rbd:poolceph1/vm-101-disk-6:mon_host=10.5.0.11\;10.5.0.12\;10.5.0.13:id=admin:auth_supported=cephx:keyring=/etc/pve/priv/ceph/cephzimbra.keyring,if=none,id=drive-virtio1,aio=native,cache=none,detect-zeroes=on' I am

Re: [pve-devel] StartAll permissions

2015-03-02 Thread Alexandre DERUMIER
Should we allow an admin to do that? Maybe can we allow to start all vms on which user have start right, and skip others ? - Mail original - De: dietmar diet...@proxmox.com À: pve-devel pve-devel@pve.proxmox.com, aderumier aderum...@odiso.com Envoyé: Mardi 3 Mars 2015 06:04:45 Objet:

Re: [pve-devel] [PATCH] qmp drive_add : remove backslashes from $drive string

2015-03-02 Thread Alexandre DERUMIER
I am starting to wonder where those \; comes from. Its form PVE::Storage::RBDPlugin::addslashes(). It's me who have done this. But I don't remember why exactly. I have try to start a vm without addslashes, and it seem to works fine. I need to check other qmp queries. - Mail original

Re: [pve-devel] [PATCH] bugfix : allow manual balloning if shares = 0

2015-03-02 Thread Dietmar Maurer
applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] StartAll permissions

2015-03-02 Thread Dietmar Maurer
Should we allow an admin to do that? http://forum.proxmox.com/threads/21083-Proxmox-VE-3-4-released!?p=108191#post108191 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] StartAll permissions

2015-03-02 Thread Dietmar Maurer
Should we allow an admin to do that? Maybe can we allow to start all vms on which user have start right, and skip others ? yes, sounds good for me. ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] StartAll permissions

2015-03-02 Thread Michael Rasmussen
On Tue, 3 Mar 2015 07:08:34 +0100 (CET) Alexandre DERUMIER aderum...@odiso.com wrote: Should we allow an admin to do that? Maybe can we allow to start all vms on which user have start right, and skip others ? For security I never work as root in gui. I have created a user for myself with

Re: [pve-devel] [PATCH] qmp drive_add : remove backslashes from $drive string

2015-03-02 Thread Stefan Priebe - Profihost AG
Am 03.03.2015 um 08:32 schrieb Alexandre DERUMIER: Oh, ok,I remember now. It's when you defined ceph monitors with ports 10.5.0.11:6789;10.5.0.12:6789;10.5.0.13:6789 you need to addslashes : character, because qemu think it's a separator. But then the part where the qemu command is

Re: [pve-devel] [PATCH] qmp drive_add : remove backslashes from $drive string

2015-03-02 Thread Stefan Priebe - Profihost AG
Am 03.03.2015 um 06:24 schrieb Dietmar Maurer: On 03/02/2015 08:54 AM, Alexandre DERUMIER wrote $drive string:

Re: [pve-devel] [PATCH] qmp drive_add : remove backslashes from $drive string

2015-03-02 Thread Alexandre DERUMIER
Oh, ok,I remember now. It's when you defined ceph monitors with ports 10.5.0.11:6789;10.5.0.12:6789;10.5.0.13:6789 you need to addslashes : character, because qemu think it's a separator. kvm: -drive

[pve-devel] [PATCH] bugfix : allow manual balloning if shares = 0

2015-03-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier aderum...@odiso.com --- PVE/QemuServer.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8769cb8..a3d8912 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3866,7 +3866,7 @@ sub