On Sun, 21 Jun 2015 13:06:27 +0200
Alexandre Derumier aderum...@odiso.com wrote:
+ my ($key, $value) = $byte =~ /(Read|Write) (\d+)/;
I think this would be more secure:
my ($key, $value) = $byte =~ /(Read|Write)\s+(\d+)/;
--
Hilsen/Regards
Michael Rasmussen
Get my public GnuPG keys:
I'll try to improve that tomorrow.
- Mail original -
De: dietmar diet...@proxmox.com
À: aderumier aderum...@odiso.com, pve-devel pve-devel@pve.proxmox.com
Envoyé: Dimanche 21 Juin 2015 10:26:34
Objet: Re: [pve-devel] [PATCH] lxc: add hotplug memory cpus cgroups value V2
+
+sub
applied, with small improvement requested by mir (just to be safe).
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
using cgroup blkio.throttle.io_service_bytes
They are also another cgroup blkio.io_service_bytes,
but it's only work with cfq io scheduler.
blkio.throttle.io_service_bytes works with any io scheduler
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
src/PVE/LXC.pm | 8
1 file
We just want to remove the 'die' for hot-plug-able values. Please
can you modify your patch?
Maybe die only if we have at least 1 non hotplugglable option ?
Yes. (simply die when we detect non-hotplugglable options)
___
pve-devel mailing list
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
src/PVE/LXC.pm | 65 --
1 file changed, 63 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 068b46f..0f21bcb 100644
--- a/src/PVE/LXC.pm
+++
+
+sub hotplug_lxc_config {
+my ($vmid, $conf, $param, $delete) = @_;
+
+if (defined($delete)) {
+ foreach my $opt (@$delete) {
+ if ($opt eq 'swap') {
+ cgroups_write(memory, $vmid, memory.memsw.limit_in_bytes,
-1);
+ } elsif ($opt =~ m/^net\d$/)
mounting with qemu-nbd is not really possible if you have a
generic kvm VM (ufs, zfs, complex lvm setups, ...). I guess we
should use the 'iso' approach for kvm.
yes indeed, iso is better.
But it would be easy to do with lxc, as we already have the code to
loop/qemu-nbd mount
the root
We just want to remove the 'die' for hot-plug-able values. Please
can you modify your patch?
Maybe die only if we have at least 1 non hotplugglable option ?
- Mail original -
De: dietmar diet...@proxmox.com
À: aderumier aderum...@odiso.com
Cc: pve-devel pve-devel@pve.proxmox.com
