it's up for me
- Mail original -
De: datanom.net m...@datanom.net
À: pve-devel pve-devel@pve.proxmox.com
Envoyé: Lundi 29 Juin 2015 14:33:07
Objet: [pve-devel] Forum down
Hi all,
It seems that the forum is down?
--
Hilsen/Regards
Michael Rasmussen
Get my public GnuPG keys:
changelog: find lxc pid from /proc/
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
src/PVE/LXC.pm | 191 -
1 file changed, 161 insertions(+), 30 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 76c512d..5df5a5e
On June 29, 2015 at 2:09 PM Alexandre DERUMIER aderum...@odiso.com wrote:
- die no network bridge defined\n if !$net-{bridge};
-
- my $res = bridge=$net-{bridge};
+ my $res = {};
why?
In case we want to switch to a new bridge, and a failure occur
- unplug tap from
Hi all,
It seems that the forum is down?
--
Hilsen/Regards
Michael Rasmussen
Get my public GnuPG keys:
michael at rasmussen dot cc
http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E
mir at datanom dot net
http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C
mir at miras dot org
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
www/manager/VNCConsole.js | 15 +--
www/manager/node/Config.js | 7 +++
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/www/manager/VNCConsole.js b/www/manager/VNCConsole.js
index 4dd983c..db90388 100644
applied, thanks!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
- die no network bridge defined\n if !$net-{bridge};
-
- my $res = bridge=$net-{bridge};
+ my $res = {};
why?
In case we want to switch to a new bridge, and a failure occur
- unplug tap from initial bridge
write config
- plug tap to new bridge -failed
Technically, it's not a
I wonder if we can avoid running lxc-info, by using something similar
we have in:
sub find_lxc_console_pids { ... }
We can get the pids of all running containers, including pids for console,
and we can also replace list_active_containers() ?
yes, I think it better too if we can need to run
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 76c512d..2b7069b 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -775,11 +775,9 @@ sub vmstatus {
sub print_lxc_network {
my $net = shift;
-die no network bridge defined\n if !$net-{bridge};
-
-my $res =
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
src/PVE/LXC.pm | 185 +++--
1 file changed, 155 insertions(+), 30 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 76c512d..2b7069b 100644
--- a/src/PVE/LXC.pm
+++
But why do you set $rest to '{}', instead of ''?
And I think the resulting value starts with ','?
oh,yes, don't known what I have done here...
I think I have mixed print_lxc_network and parse_lxc_network, ... sorry ...
maybe simply
sub print_lxc_network {
my ($data) = @_;
die no
changelog:
V2: find lxc pid from /proc/
V3: fix parse_lxc_network (name is mandatory, bridge optionnal)
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
src/PVE/LXC.pm | 191 -
1 file changed, 162 insertions(+), 29 deletions(-)
I am not sure if that always works. AFAIK the init process can be an arbitrary
name,
and that is why lxc-info calls a monitor command to get the PID?
Also, your code opens/close many files. So I think the original approach
calling lxc-info is better for now. And it is more efficient once we
have
Signed-off-by: Alen Grizonic a.grizo...@proxmox.com
---
www/manager/grid/FirewallOptions.js | 80 -
www/manager/window/Edit.js | 2 +
2 files changed, 80 insertions(+), 2 deletions(-)
diff --git a/www/manager/grid/FirewallOptions.js
I am not sure if that always works. AFAIK the init process can be an arbitrary
name,
oh, ok, didn't known that
and that is why lxc-info calls a monitor command to get the PID?
I really don't known, don't have dig inside the lxc-info code
Also, your code opens/close many files. So I think the
changelog:
V2: find lxc pid from /proc/
V3: fix parse_lxc_network (name is mandatory, bridge optionnal)
V4: revert find_lxc_pid
Signed-off-by: Alexandre Derumier aderum...@odiso.com
---
src/PVE/LXC.pm | 185 -
1 file changed, 156
+sub find_lxc_pid {
+my ($vmid) = @_;
+
+my $pid = undef;
+my $parser = sub {
+ my $line = shift;
+ $pid = $1 if $line =~ m/PID:\s+(\d+)/;
+};
+PVE::Tools::run_command(['lxc-info', '-n', $vmid], outfunc = $parser);
+
+ return $pid;
+}
+
I wonder if we
Why not?
I wanted to say : do you want that I make a patch to add console for host too
? ;)
Yes, please.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
(do we need it for hosts console too ?)
Why not?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Why not?
I wanted to say : do you want that I make a patch to add console for host too ?
;)
- Mail original -
De: dietmar diet...@proxmox.com
À: aderumier aderum...@odiso.com
Cc: pve-devel pve-devel@pve.proxmox.com
Envoyé: Lundi 29 Juin 2015 09:48:59
Objet: Re: [pve-devel] [PATCH 1/2]
20 matches
Mail list logo
