Re: [pve-devel] [PATCH RFC container] include custom lxc options when displaying config

2016-06-15 Thread Wolfgang Bumiller
> On June 15, 2016 at 3:54 PM Dietmar Maurer wrote: > > > > > > > > > + my $v = > > > > PVE::Tools::encode_text(@$lxc_opt[1]); > > > > > > why do you call PVE::Tools::encode_text() here? > > > > because this is an unvalidated, user provided value that is printe

Re: [pve-devel] [PATCH V3 qemu-server 1/3] Add LVM and LVMThin to QemuMigration

2016-06-15 Thread Dietmar Maurer
applied a simplified version ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [zfsonlinux 1/2] Update to pkg-zfs/pkg-spl jessie/0.6.5.6-3

2016-06-15 Thread Lee Lists
Hi, Did you notice that zfs 0.6.5.7 was released ? https://github.com/zfsonlinux/zfs/releases/tag/zfs-0.6.5.7 Is there a mean to upgrade to this version ? Regards, Lee - Mail original - De: "Fabian Grünbichler" À: pve-devel@pve.proxmox.com Envoyé: Vendredi 15 Avril 2016 10:36:20 Objet

Re: [pve-devel] ceph 10.2.2 released (debian systemd missing target fixed)

2016-06-15 Thread Dietmar Maurer
> >>Still waiting for an answer: > >> > >>http://tracker.ceph.com/issues/16255 > > I think they forgot to update documentation > > >>Because I am not sure how to fix that.. > > do you really need to use --cap mds ? > > (as we don't need mds daemon, only mon && rbd daemons) No, I do not care

Re: [pve-devel] [PATCH ha-manager v2 6/7] Manager: record tried node on relocation policy

2016-06-15 Thread Dietmar Maurer
comments inline: > # remove stale relocation try entries > -foreach my $sid (keys %{$ms->{relocate_trial}}) { > - delete $ms->{relocate_trial}->{$sid} if !$ss->{$sid}; Maybe its worth to keep above code? > +foreach my $sid (keys %{$ms->{relocate_tried_nodes}}) { > + delete

Re: [pve-devel] ceph 10.2.2 released (debian systemd missing target fixed)

2016-06-15 Thread Alexandre DERUMIER
>>Still waiting for an answer: >> >>http://tracker.ceph.com/issues/16255 I think they forgot to update documentation >>Because I am not sure how to fix that.. do you really need to use --cap mds ? (as we don't need mds daemon, only mon && rbd daemons) - Mail original - De: "dietma

Re: [pve-devel] [PATCH ha-manager v2 5/7] send email on fence failure and success

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager v2 4/7] Env: add sendmail

2016-06-15 Thread Dietmar Maurer
applied, but it is unclear to me why we do not log them for regression tests? > Can be used to sen mails to the admin on certain important events > Do not log sent mails in regressions tests but in the simulator ___ pve-devel mailing list pve-devel@pve.

Re: [pve-devel] [PATCH ha-manager v2 3/7] Sim/Hardware: check if testdir exists

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager v2 2/7] Manager, LRM: sort service keys for deterministic tests

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager v2 1/7] bump version to 1.0-32

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] ceph 10.2.2 released (debian systemd missing target fixed)

2016-06-15 Thread Dietmar Maurer
> http://docs.ceph.com/docs/master/release-notes/#v10-2-2-jewel Still waiting for an answer: http://tracker.ceph.com/issues/16255 Because I am not sure how to fix that... ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi

[pve-devel] ceph 10.2.2 released (debian systemd missing target fixed)

2016-06-15 Thread Alexandre DERUMIER
http://docs.ceph.com/docs/master/release-notes/#v10-2-2-jewel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH ha-manager v2 5/7] send email on fence failure and success

2016-06-15 Thread Thomas Lamprecht
Fencing is something which should not happen often in the real world and has most time a really bad cause, thus send a email when starting to fence a node and on success to root@localhost to inform the cluster admin of said failures so he can check the hardware and cluster status as soon as possibl

[pve-devel] [PATCH ha-manager v2 7/7] relocate policy: do not try failed nodes again if possible

2016-06-15 Thread Thomas Lamprecht
If the failure policy triggers more often than 2 times we used an already tried node again, even if there where other untried nodes. This does not make real sense as when it failed to start on a node a short time ago it probably will also fail now (e.g. storage is offline), whereas an untried node

[pve-devel] [PATCH ha-manager v2 6/7] Manager: record tried node on relocation policy

2016-06-15 Thread Thomas Lamprecht
Instead of simply counting up an integer on each failed relocation trial record the already tried nodes. We still have the try count through the size of the array, so no information lost and no behavioural change. Use this for now to log on which nodes we failed to recover, may be useful for an us

[pve-devel] [PATCH ha-manager v2 1/7] bump version to 1.0-32

2016-06-15 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- Makefile | 2 +- changelog.Debian | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index be5c3d2..89b2fbf 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ RELEASE=4.2 VERSION=1.0 PACKAGE=pve-ha-manager

[pve-devel] [PATCH ha-manager v2 0/7] [ha-manager] various patches

2016-06-15 Thread Thomas Lamprecht
Almost same series as sent two weeks ago, bumped versions as first patch as the fix for priorities isn't in the repos, but it would be nice if. As previously, I picked a few patches from my feature branches which aren't directly related to those features, to get them upstream. All in all nothing

[pve-devel] [PATCH ha-manager v2 3/7] Sim/Hardware: check if testdir exists

2016-06-15 Thread Thomas Lamprecht
avoids stranges error like "could not open dir/group.tmp.PID" Signed-off-by: Thomas Lamprecht --- src/PVE/HA/Sim/Hardware.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index a212671..be1037d 100644 --- a/src/PVE/HA/Sim/Hardware.

[pve-devel] [PATCH ha-manager v2 4/7] Env: add sendmail

2016-06-15 Thread Thomas Lamprecht
Can be used to sen mails to the admin on certain important events Do not log sent mails in regressions tests but in the simulator Signed-off-by: Thomas Lamprecht --- changes since previous version: * dismiss senmail logs in regression test, they bring no real value there but clutter the output

[pve-devel] [PATCH ha-manager v2 2/7] Manager, LRM: sort service keys for deterministic tests

2016-06-15 Thread Thomas Lamprecht
Else we the regression test produce a indeterministic output. As the hashs would else be traversed in random order it makes no real difference for the PVE2 environment, so just sort keys when we add them to the cluster or spawn resource agent workers to avoid that problem. Signed-off-by: Thomas La

Re: [pve-devel] [PATCH manager v2 5/5] remove unnecessary information on template summary

2016-06-15 Thread Dominik Csapak
On 06/15/2016 04:49 PM, Dietmar Maurer wrote: applied. But we also want this for LXC templates? yes, i'll do that tomorrow ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 4/5] move notepanel padding out of the class

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 3/5] add 'edit' tool to notes panel

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2 5/5] remove unnecessary information on template summary

2016-06-15 Thread Dietmar Maurer
applied. But we also want this for LXC templates? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 2/5] add a 'bootdisk size' entry to the status view

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/5] remove RAM column from lxc snapshottree (temporarily)

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH kernel] move /lib/modules/.../build as file into .deb

2016-06-15 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH RFC container] include custom lxc options when displaying config

2016-06-15 Thread Dietmar Maurer
> > > > > + my $v = PVE::Tools::encode_text(@$lxc_opt[1]); > > > > why do you call PVE::Tools::encode_text() here? > > because this is an unvalidated, user provided value that is printed to the > shell/terminal IMHO that is not really dangerous > (we do the same for the

[pve-devel] [PATCH manager v2 5/5] remove unnecessary information on template summary

2016-06-15 Thread Dominik Csapak
since most of the information on the summary page is irrelevant for templates (e.g. status,ha,using memory,graphs, etc), we only show just the information which is available and helpful since we then have the vertical space, we move the notes panel below the statuspanel, to allow visually more spa

[pve-devel] [PATCH kernel] move /lib/modules/.../build as file into .deb

2016-06-15 Thread Fabian Grünbichler
this symlink should not be created in the postinst, but simply included in the pve-headers-xx .deb this is a followup to the recently dropped dependency of pve-headers-xx on pve-kernel-xx, and makes this more consistent with how upstream (Ubuntu) handles the creation of this symlink. --- Makefile

Re: [pve-devel] [PATCH manager 5/5] remove unnecessary information on template summary

2016-06-15 Thread Dominik Csapak
please ignore this patch (only the 5/5), i will send a better version (removing also the tbar and the rrdstore) On 06/15/2016 03:13 PM, Dominik Csapak wrote: since most of the information on the summary page is irrelevant for templates (e.g. status,ha,using memory,graphs, etc), we only show just

[pve-devel] [PATCH manager 2/5] add a 'bootdisk size' entry to the status view

2016-06-15 Thread Dominik Csapak
to show the size of the current bootdisk of the vm/container Signed-off-by: Dominik Csapak --- www/manager6/lxc/StatusView.js | 1 + www/manager6/qemu/StatusView.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager6/lxc/StatusView.js b/www/manager6/lxc/StatusView.js index 1d6649

[pve-devel] [PATCH manager 4/5] move notepanel padding out of the class

2016-06-15 Thread Dominik Csapak
it makes more sense to define the padding in context, rather than directly in the component especially if we want to use this panel elsewhere in the future Signed-off-by: Dominik Csapak --- also this is necessary for the next patch in this series, otherwise it looks ugly www/manager6/lxc/Summar

[pve-devel] [PATCH manager 5/5] remove unnecessary information on template summary

2016-06-15 Thread Dominik Csapak
since most of the information on the summary page is irrelevant for templates (e.g. status,ha,using memory,graphs, etc), we only show just the information which is available and helpful since we then have the vertical space, we move the notes panel below the statuspanel, to allow visually more spa

[pve-devel] [PATCH manager 3/5] add 'edit' tool to notes panel

2016-06-15 Thread Dominik Csapak
this adds a tool to the note panel to edit it, this is clearer than just double clicking the notes field (also makes it easier on tablets) Signed-off-by: Dominik Csapak --- www/manager6/panel/NotesView.js | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/www/manag

[pve-devel] [PATCH manager 1/5] remove RAM column from lxc snapshottree (temporarily)

2016-06-15 Thread Dominik Csapak
since we cannot save the ram state for lxc containers currently, it makes no sense to display a column, where every entry is 'no' i left it there but commented it out, so that when we implement it, we just have to reenable the column Signed-off-by: Dominik Csapak --- www/manager6/lxc/SnapshotTr

Re: [pve-devel] [PATCH RFC container] include custom lxc options when displaying config

2016-06-15 Thread Fabian Grünbichler
comments inline > Dietmar Maurer hat am 15. Juni 2016 um 12:27 > geschrieben: > > > comments inline > > ... > > diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm > > index ca87229..748ace3 100755 > > --- a/src/PVE/CLI/pct.pm > > +++ b/src/PVE/CLI/pct.pm > > @@ -542,12 +542,22 @@ our $cmdde

Re: [pve-devel] [PATCH RFC container] include custom lxc options when displaying config

2016-06-15 Thread Dietmar Maurer
comments inline ... > diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm > index ca87229..748ace3 100755 > --- a/src/PVE/CLI/pct.pm > +++ b/src/PVE/CLI/pct.pm > @@ -542,12 +542,22 @@ our $cmddef = { > my $config = shift; > foreach my $k (sort (keys %$config))

[pve-devel] [PATCH RFC container] include custom lxc options when displaying config

2016-06-15 Thread Fabian Grünbichler
this makes the "pct config" output more complete, the object returned by the API path contains the lxc options as parsed by our config parser, e.g.: "lxc" : [ [ "lxc.cap.keep", "sys_time" ], [ "lxc.cap.drop", "abc" ], [

[pve-devel] [PATCH V3 pve-manager] fix #146 add name to backup log.

2016-06-15 Thread Wolfgang Link
--- PVE/VZDump.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 1e00c2d..ea6577d 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -853,6 +853,16 @@ sub exec_backup_task { # lock VM (prevent config changes) $plugin->lock_vm ($vm