Re: [pve-devel] [PATCH manager] implement checks for ceph version & binaries

some comments inline On 08/23/2017 07:02 PM, Alwin Antreich wrote: add version check to ceph init to require luminous or higher and fix #1481: check existence of ceph binaries before use Signed-off-by: Alwin Antreich --- PVE/API2/Ceph.pm | 17 -

Re: [pve-devel] [PATCH qemu-server 1/2] Fix #1441: Do not unplug controllers when the mirroring is finished

On 08/23/2017 07:15 PM, Alexandre DERUMIER wrote: for me, this patch is ok. if the job is complete, we don't need to unplug. (and that mean that vm need to support unplug too, we can't be sure that guest support this). Is it possible that the problem was the previous bug with unix socket,

[pve-devel] [PATCH manager] Reflect changed output for 'ceph pg dump -f json'.

Reflect changed output for 'ceph pg dump -f json'. Signed-off-by: Martin Waschbüsch --- Without this patch, all osds will show a latency of 0. Sadly, that is not true. :-) PVE/API2/Ceph.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [pve-devel] [PATCH qemu-server 1/2] Fix #1441: Do not unplug controllers when the mirroring is finished

for me, this patch is ok. if the job is complete, we don't need to unplug. (and that mean that vm need to support unplug too, we can't be sure that guest support this). Is it possible that the problem was the previous bug with unix socket, were the target vm was not paused after migration ?

Re: [pve-devel] [PATCH manager v2] Introduce check to disable quota usage for unprivileged containers

On 08/23/2017 05:30 PM, Philip Abernethy wrote: Disables the quota checkbox for unprivileged containers in the creation wizard, as well as when editing or adding mountpoints. --- With the editor windows I got confused by the caps.vms['Config.VM.Disk'] earlier, but that's access control. Removed

Re: [pve-devel] [PATCH manager] Introduce check to disable quota usage for unprivileged containers

On 08/23/2017 05:20 PM, Dietmar Maurer wrote: nitpick: I know JS standard is weird for not allowing trailing commas, but you can always add it in between to avoid touching multiple lines. So far we do not add trailing commas as defined in the standard. Yes, I never stated the difference :) I

[pve-devel] [PATCH manager v2] Introduce check to disable quota usage for unprivileged containers

Disables the quota checkbox for unprivileged containers in the creation wizard, as well as when editing or adding mountpoints. --- With the editor windows I got confused by the caps.vms['Config.VM.Disk'] earlier, but that's access control. Removed the distinction altogether. Recarding the commas

Re: [pve-devel] [PATCH manager] Introduce check to disable quota usage for unprivileged containers

> nitpick: I know JS standard is weird for not allowing trailing commas, > but you can always add it in between to avoid touching multiple lines. So far we do not add trailing commas as defined in the standard. ___ pve-devel mailing list

[pve-devel] [PATCH container v4] close #1478: add check for unsupported config

Adds a check if an unprivileged container is configured to use quota on any of its mountpoints. If so an understandable error message is given. Ideally I'd like to catch those configurations on the GUI, too, to avoid users just running into it. --- That suggestion evidently slipped my mind.

Re: [pve-devel] [PATCH container v3] close #1478: add check for unsupported config

On 08/23/2017 04:27 PM, Philip Abernethy wrote: Adds a check if an unprivileged container is configured to use quota on any of its mountpoints. If so an understandable error message is given. Ideally I'd like to catch those configurations on the GUI, too, to avoid users just running into it. ---

Re: [pve-devel] [PATCH manager] Introduce check to disable quota usage for unprivileged containers

some comments inline. On 08/23/2017 04:31 PM, Philip Abernethy wrote: Disables the quota checkbox for unprivileged containers in the creation wizard, as well as when editing or adding mountpoints. --- www/manager6/lxc/CreateWizard.js | 20 +++-

Re: [pve-devel] [PATCH container v3] close #1478: add check for unsupported config

I wonder if this simplified version works: if ($conf->{unprivileged}) { PVE::LXC::Config->foreach_mountpoint($conf, sub { my ($ms, $mountpoint) = @_; die "Quotas are not supported by unprivileged containers.\n" if

[pve-devel] [PATCH container v3] close #1478: add check for unsupported config

Adds a check if an unprivileged container is configured to use quota on any of its mountpoints. If so an understandable error message is given. Ideally I'd like to catch those configurations on the GUI, too, to avoid users just running into it. --- Done. GUI fix coming up.

Re: [pve-devel] [PATCH manager 00/17] gui storage and other improvements

On 07/19/2017 03:45 PM, Dominik Csapak wrote: this series does a few things: (i did not split it up, because the hunks are near each other, and then only the first applied series would work or none at all) patches 01/17 - 03/17 are for preparing to resolve a cyclic dependency in

Re: [pve-devel] [PATCH manager 04/17] get storage type info in /version api call

On 07/19/2017 03:45 PM, Dominik Csapak wrote: this will be used in the gui, for selecting/creating disks/mps/etc. this means, that we get the information about a storage from the backend, instead of hardcoding types in the frontend (like the lun selector for iscsi) The api calls: GET /storage

Re: [pve-devel] [PATCH manager 01/17] copy api permission calculation to /version api call

On 07/19/2017 03:45 PM, Dominik Csapak wrote: the code is copied from the /access/ticket api call from the pve-access-control package I see why you did this. But am really not happy with it... I'd try to remove the PVE:::Storage usage in AccessControl completely, the compute_api_permission

Re: [pve-devel] [PATCH pve-storage] We allow uppercase characters in snapshot names. pvesm import and export must allow uppercase characters too.

On Wed, Aug 23, 2017 at 10:59:55AM +0200, Wolfgang Link wrote: > --- > PVE/CLI/pvesm.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm > index 9455595..6b37c05 100755 > --- a/PVE/CLI/pvesm.pm > +++ b/PVE/CLI/pvesm.pm > @@ -183,7

Re: [pve-devel] [PATCH qemu-server 1/2] Fix #1441: Do not unplug controllers when the mirroring is finished

Any feedback on this ? The current status of local migration with ide disks if quite ugly at the moment, as the source VM hangs suspended and locked when reaching the unplug step, since IDE disks do not hotplug. If we prefer to have the disk unplugging around, then we should exclude VMs with ide

Re: [pve-devel] [PATCH manager 15/17] hide migrate in contextmenu when no cluster or no rights

On 08/23/2017 11:27 AM, Thomas Lamprecht wrote: diff --git a/www/manager6/qemu/CmdMenu.js b/www/manager6/qemu/CmdMenu.js index 0fb832d4..c76c511b 100644 --- a/www/manager6/qemu/CmdMenu.js +++ b/www/manager6/qemu/CmdMenu.js @@ -111,7 +111,10 @@ Ext.define('PVE.qemu.CmdMenu', {   

Re: [pve-devel] [PATCH manager v2 16/17] disable discard for non-scsi disks

In general OK, but same problem as IOThread has, the checkbox should be cleared on disable. Else, it may confuse users or give them the idea that they can outsmart the wizard and set discard on sata (for example). I sent a patch which addresses this with IOThread, and some other which will

Re: [pve-devel] [PATCH manager 15/17] hide migrate in contextmenu when no cluster or no rights

base idea OK, comments inline. On 07/19/2017 03:45 PM, Dominik Csapak wrote: Signed-off-by: Dominik Csapak --- www/manager6/lxc/CmdMenu.js | 9 - www/manager6/qemu/CmdMenu.js | 3 ++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git

Re: [pve-devel] [PATCH manager 14/17] hide migrate button in lxc for non cluster setups

Reviewed and tested, looks good. As this checks is now in a few places a PVE.Utils helper could be appropriate? On 07/19/2017 03:45 PM, Dominik Csapak wrote: Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [pve-devel] [PATCH manager 13/17] hide not usable buttons for qemu

Reviewed and tested, looks good to me. On 07/19/2017 03:45 PM, Dominik Csapak wrote: this hides not usuable buttons for qemu e.g. start/shutdown for templates migrate for non-cluster setups Signed-off-by: Dominik Csapak --- www/manager6/qemu/Config.js | 10 +-

[pve-devel] [PATCH pve-storage] We allow uppercase characters in snapshot names. pvesm import and export must allow uppercase characters too.

--- PVE/CLI/pvesm.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..6b37c05 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -183,7 +183,7 @@ __PACKAGE__->register_method ({ base => {

[pve-devel] stable-4 [PATCH cluster] fix #1486 pmxcfs spelling mistake

Signed-off-by: Alwin Antreich --- data/src/pmxcfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/src/pmxcfs.c b/data/src/pmxcfs.c index 8fa3bcc..5547d5d 100644 --- a/data/src/pmxcfs.c +++ b/data/src/pmxcfs.c @@ -909,7 +909,7 @@ int main(int

[pve-devel] [PATCH cluster] fix #1486 pmxcfs spelling mistake

Signed-off-by: Alwin Antreich --- data/src/pmxcfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/src/pmxcfs.c b/data/src/pmxcfs.c index 8fa3bcc..5547d5d 100644 --- a/data/src/pmxcfs.c +++ b/data/src/pmxcfs.c @@ -909,7 +909,7 @@ int main(int

[pve-devel] applied+cleanup: [PATCH ha-manager v2] fix #1073: do not count backup-suspended VMs as running

On Wed, Aug 23, 2017 at 10:15:49AM +0200, Thomas Lamprecht wrote: > when a stopped VM managed by HA got backuped the HA stack > continuously tried to shut it down as check_running returns only if a > PID for the VM exists. > As the VM was locked the shutdown tries were blocked, but still a lot >

[pve-devel] [PATCH ha-manager v2] fix #1073: do not count backup-suspended VMs as running

when a stopped VM managed by HA got backuped the HA stack continuously tried to shut it down as check_running returns only if a PID for the VM exists. As the VM was locked the shutdown tries were blocked, but still a lot of annoying messages and task spawns happened during the backup period. As

[pve-devel] applied: [PATCH qemu-server v2 1/2] remove unused obsolete vmtar

___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server v2 2/2] remove legacy sparsecp

___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC cluster] update SSH Ciphers for Debian Stretch

ping On Wed, May 31, 2017 at 09:38:00AM +0200, Fabian Grünbichler wrote: > blowfish, 3des and arcfour are not enabled by default on the > server side anyway. > > on most hardware, AES is about 3 times faster than Chacha20 > because of hardware accelerated AES, hence the changed order > of

[pve-devel] [PATCH manager 1/3] create: clear iothread on disable

A user may set the `iothread` option and then change the bus type to something which does not support it (sata, ide), while we disable it the previously set value remains, which is confusing. An user could think he coulkd trick the Wizard into using iothreads for SATA/IDE but we just ignore the

[pve-devel] [PATCH manager 3/3] HDEdit: push more items in the same call

Signed-off-by: Thomas Lamprecht --- www/manager6/qemu/HDEdit.js | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index c97f530c..09fd1a0b 100644 ---

[pve-devel] [PATCH manager 2/3] disk/controllerselector: adapt flex

The bus tye selector gets now 2/3 of the space and the bus number spinner gets 1/3. It looked a bit strange with both of them getting half of the space, as on a lot of GUIs the spinner get less space (its just a number (max 13) vs a wider text). Signed-off-by: Thomas Lamprecht