[pve-devel] [PATCH manager v2 25/29] use LogView from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile| 1 - www/manager6/grid/Replication.js | 2 +- www/manager6/lxc/Config.js | 2 +- www/manager6/node/Config.js | 6 +- www/manager6/panel/LogView.js| 274

[pve-devel] [PATCH manager v2 15/29] use TaskViewer & TaskProgress window from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/ceph/Monitor.js| 4 +- www/manager6/ceph/OSD.js| 2 +- www/manager6/dc/Tasks.js| 2 +- www/manager6/lxc/CreateWizard.js| 2 +-

[pve-devel] [PATCH manager v2 26/29] use InputPanel from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/dc/ACLView.js| 2 +- www/manager6/dc/AuthEdit.js | 2 +- www/manager6/dc/Backup.js | 2 +- www/manager6/dc/SecurityGroups.js | 2

[pve-devel] [PATCH manager v2 14/29] use windowEdit from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/ceph/Monitor.js | 2 +- www/manager6/ceph/OSD.js | 4 +- www/manager6/ceph/Pool.js | 2 +- www/manager6/dc/ACLView.js| 2

[pve-devel] [PATCH manager v2 23/29] use RestProxy from widget toolkit

Split PVE specific models, which where not moved to the general widget toolkit, in a separate folder: data/models/ Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 2 +- www/manager6/ceph/Monitor.js | 2 +-

[pve-devel] [PATCH manager v2 28/29] use Toolkit from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/Toolkit.js | 511 2 files changed, 512 deletions(-) delete mode 100644 www/manager6/Toolkit.js diff --git a/www/manager6/Makefile

[pve-devel] [PATCH manager v2 19/29] use TimezoneStore from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/data/TimezoneStore.js | 418 - www/manager6/node/TimeEdit.js | 2 +- 3 files changed, 1 insertion(+), 420 deletions(-) delete mode

[pve-devel] [PATCH manager v2 04/29] use Checkbox from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/ceph/OSD.js | 4 ++-- www/manager6/ceph/Pool.js | 2 +- www/manager6/dc/ACLView.js| 2 +- www/manager6/dc/AuthEdit.js | 4

[pve-devel] [PATCH manager v2 06/29] use KVCombobox from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/dc/AuthEdit.js| 2 +- www/manager6/dc/Backup.js | 4 +- www/manager6/dc/OptionView.js | 2 +-

[pve-devel] [PATCH manager v2 11/29] grid/FireWallOptions: cleanup & use new features from ObjectGrid

switch add_boolean and add_integer row to a simple wrapper. We really use it often and can save quite some lines with it so it does not make sense to remove it completely yet. Signed-off-by: Thomas Lamprecht --- www/manager6/grid/FirewallOptions.js | 125

[pve-devel] [PATCH manager v2 29/29] buildsys: we need pve-doc-generator to build package

E.g., for ascidoc-pver scan-extjs to generate the OnlineHelp info map Signed-off-by: Thomas Lamprecht --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index c5469c50..112e82f0 100644 --- a/debian/control +++

[pve-devel] [PATCH manager v2 22/29] use ObjectStore from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/data/ObjectStore.js| 35 --- www/manager6/ha/Status.js | 2 +- www/manager6/lxc/Config.js | 2 +-

[pve-devel] [PATCH manager v2 20/29] TimeEdit: use schematic declaration

Signed-off-by: Thomas Lamprecht --- www/manager6/node/TimeEdit.js | 47 +-- 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/www/manager6/node/TimeEdit.js b/www/manager6/node/TimeEdit.js index e2d884d5..f05dc16e

[pve-devel] [PATCH manager v2 17/29] use HelpButton from widget toolkit

Proxmox.button.Help renamed the css class for the button styling, as this class is only used rarely and the widget toolkit does not provides a (shared) css file itself, just rename it here too. Signed-off-by: Thomas Lamprecht --- www/css/ext6-pve.css | 2

[pve-devel] [PATCH manager v2 21/29] use JsonObject reader from widget toolkit

Alias stayed the same and we had only a single direct user (ObjectStore) which uses said alias to refer to this reader. Also ObjectStore itself will get replaced by the proxmox widget toolkit version in the next patch anyway. Signed-off-by: Thomas Lamprecht ---

[pve-devel] [PATCH manager v2 18/29] use DiffStore from widget toolkit

The alias stayed the same (store.diff) so we need to change direct usage of 'PVE.data.DiffStore' only. Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile| 1 - www/manager6/ceph/Monitor.js | 2 +- www/manager6/ceph/Pool.js| 2 +-

[pve-devel] [PATCH manager v2 24/29] use GaugeWidget from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/ceph/Status.js | 2 +- www/manager6/dc/Summary.js| 2 +- www/manager6/panel/GaugeWidget.js | 96 --- 4 files changed, 2

[pve-devel] [PATCH manager v2 13/29] use PendingObjectGrid from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/grid/PendingObjectGrid.js | 95 -- www/manager6/qemu/HardwareView.js | 2 +- www/manager6/qemu/Options.js | 2 +- 4 files

[pve-devel] [PATCH manager v2 27/29] RealmComboBox: use schematic declaration and ViewController

Signed-off-by: Thomas Lamprecht --- www/manager6/form/RealmComboBox.js | 56 -- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/www/manager6/form/RealmComboBox.js b/www/manager6/form/RealmComboBox.js index

[pve-devel] [PATCH manager v2 10/29] lxc/Options: cleanup & use a few new features from ObjectGrid

Use also same store update interval as qemu/Options Signed-off-by: Thomas Lamprecht --- www/manager6/lxc/Options.js | 52 +++-- 1 file changed, 12 insertions(+), 40 deletions(-) diff --git a/www/manager6/lxc/Options.js

[pve-devel] [PATCH manager v2 02/29] use LanguageSelector from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/Utils.js | 42 --- www/manager6/form/LanguageSelector.js | 5 - www/manager6/window/LoginWindow.js| 2 +- 4 files

[pve-devel] [PATCH manager v2 16/29] use window.PasswordEdit from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/dc/UserView.js | 55 + 1 file changed, 1 insertion(+), 54 deletions(-) diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js index 740465f4..1fc8a2d2 100644 ---

[pve-devel] [PATCH manager v2 12/29] qemu/Options: cleanup & use new features from ObjectGrid

Ther's a little delay with the revert button on pending changes, but that was the case previously too, so don't worry for that in this patch Signed-off-by: Thomas Lamprecht --- www/manager6/qemu/Options.js | 51 1 file

[pve-devel] [PATCH manager v2 08/29] dc/OptionView: cleanup & use new features from ObjectGrid

Signed-off-by: Thomas Lamprecht --- www/manager6/Toolkit.js | 6 + www/manager6/Utils.js | 6 + www/manager6/dc/OptionView.js | 255 -- 3 files changed, 56 insertions(+), 211 deletions(-) diff --git

[pve-devel] [PATCH manager v2 03/29] use BondModeSelector & BondPolicySelector from widget toolkit

widget name stayed the same, so no need to change Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/form/BondModeSelector.js | 42 --- 2 files changed, 43 deletions(-) delete mode 100644

[pve-devel] [PATCH manager v2 07/29] use ObjectGrid from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile | 1 - www/manager6/dc/OptionView.js | 2 +- www/manager6/grid/FirewallOptions.js | 2 +- www/manager6/grid/ObjectGrid.js| 132 -

[pve-devel] [PATCH manager v2 01/29] add proxmox-widget-toolkit to pve gui

From: Dominik Csapak we will use components from proxmox-widget-toolkit rather than directly from pve-manager Signed-off-by: Dominik Csapak Signed-off-by: Thomas Lamprecht --- PVE/Service/pveproxy.pm | 3 +++ debian/control

[pve-devel] [PATCH manager v2 09/29] lxc/Resources: cleanup & use new features from ObjectGrid

Signed-off-by: Thomas Lamprecht --- www/manager6/lxc/Resources.js | 87 ++- 1 file changed, 20 insertions(+), 67 deletions(-) diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js index ad7712b6..e9411e16

[pve-devel] [PATCH manager v2 05/29] use RRDTypeSelector from widget toolkit

Signed-off-by: Thomas Lamprecht --- www/manager6/Makefile| 1 - www/manager6/data/RRDStore.js| 2 +- www/manager6/form/RRDTypeSelector.js | 49 www/manager6/lxc/Summary.js | 2 +-

[pve-devel] [PATCH manager v2 00/29] Integrate widget toolkit into PVE webUI

Changes v1 -> v2: * move the 'pve-domains' model in a own folder, as we will get a few other models this makes things more maintainable in the long run. * check for success in 27/28 (now 27/29) * Also look at Toolkit.js While the changes are neither much or big I decided to resend the whole

[pve-devel] [PATCH widget-toolkit 3/5] toolkit: fix #1510: don't scroll back to focus when view refreshes

adds a workaround, so that we restore the scroll position when we restore the focus. Fixies an annoying issue where, if a user had an ellemtn selected, scrolled down and then a store refresh re-rendered the view it was scrolled back to the selected item and the user lost his scrolling position.

[pve-devel] [PATCH widget-toolkit 0/5] Toolkit.js: port over fixes since fork

All but the last of this patches are fixes which happened to the Toolkit.js fixes and helper collection since we forked of proxmox-widget-toolkit from pve-manager. The last one is not yet in pve-manager but I posted and used it in my big "migrate to widget toolkit" series, so I put it in here

[pve-devel] [PATCH widget-toolkit 4/5] toolkit: fix #1516: mouse-scrolling of overflowhandlers in firefox

this is a workaround for scrolling in toolbars, etc. in firefox with the mouse. while the result is not very "pretty", it maintains the old behaviour for all other browsers and makes it work in firefox we may drop this when we update to a new extjs release commit

[pve-devel] [PATCH widget-toolkit 2/5] toolkit: fix #1307: don\'t use language dependent separator

by default, extjs submits the language dependent decimal separator, e.g., ',' (comma) for german and '.' (dot) for english. We always want the dot. commit 5c660b6d1302a5fbb3dcf477cf8b5adc9f798530 from pve-manager Signed-off-by: Thomas Lamprecht --- Toolkit.js | 6

[pve-devel] [PATCH widget-toolkit 1/5] toolkit: remove unneeded applyEmptyText

The parent method does this already in ExtJS 6 commit d19ffc1bb078e42a042c5c73797d713aa9cf9bcc from pve-manager Signed-off-by: Thomas Lamprecht --- Toolkit.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Toolkit.js b/Toolkit.js index d6a277b..bcfdf8e 100644 ---

[pve-devel] [PATCH widget-toolkit 5/5] toolkit: add MacPrefix vtype

useful for our PVE dc/options panel Signed-off-by: Thomas Lamprecht --- Toolkit.js | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Toolkit.js b/Toolkit.js index e4e9dca..9487c7e 100644 --- a/Toolkit.js +++ b/Toolkit.js @@ -53,6 +53,12 @@

[pve-devel] [PATCH common] Tools/df: reuse run_fork_with_timeout

Use the later added run_fork_with_timeout for encapsulating df in a safely manner. Signed-off-by: Thomas Lamprecht --- src/PVE/Tools.pm | 49 - 1 file changed, 8 insertions(+), 41 deletions(-) diff --git

[pve-devel] applied: [PATCH common v2 1/3] fork_worker: refactor passing $upid to parent for sync

applied whole series On Fri, Dec 15, 2017 at 05:00:29PM +0100, Thomas Lamprecht wrote: > STDOUT and $psync[1] are the same here, so no need to differ. > Also we do this only for letting the parent know tha we're ready, the > parent knows the UPID already as it was generated before forking. > >

[pve-devel] [PATCH manager 2/2] Set ZFS over ISCSI window to proper title

This will now Display 'ZFS over iSCSI'. This was reported by users during a Proxmox Training. Signed-off-by: Emmanuel Kasper --- NB: Strings returned by format_storage_type() are not gettext'ed. This is fine, as nobody should try to translate 'LVM-thin' or 'ZFS over ISCSI'

[pve-devel] [PATCH manager 1/2] Fix Indentation to use Proxmox style

Signed-off-by: Emmanuel Kasper --- www/manager6/storage/ZFSEdit.js | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/www/manager6/storage/ZFSEdit.js b/www/manager6/storage/ZFSEdit.js index bc9d8baf..22f24cb2 100644

[pve-devel] [PATCH widget-toolkit 4/4] pass given defaults in Edit window

this is a port of the change for the Edit window from pve-manager commit: ff740ccbeed1e7e2131b14c9ce50f300f24201f6 which passes the given defaults to the items Signed-off-by: Dominik Csapak --- window/Edit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[pve-devel] [PATCH widget-toolkit 0/4] preparations/ports for use in pve-manager

this series ports some new features from pve-manager since it was copied, and adds the version as a comment, so that the proxy can use its cache prevention mechanism also on the widget toolkit Dominik Csapak (4): add version as comment to js file check earlier if the logview is destroyed

[pve-devel] [PATCH widget-toolkit 3/4] add the missing explanation of onlineHelp

Signed-off-by: Dominik Csapak --- window/Edit.js | 5 + 1 file changed, 5 insertions(+) diff --git a/window/Edit.js b/window/Edit.js index 0a98e46..b736a85 100644 --- a/window/Edit.js +++ b/window/Edit.js @@ -38,6 +38,11 @@ Ext.define('Proxmox.window.Edit', {

[pve-devel] [PATCH widget-toolkit 2/4] check earlier if the logview is destroyed

this is a port from pve-manager commit: bde1efbf66cf8794d99708b41d92b2106c44f192 which fixes a problem with destroying the logview in extjs 6.2 Signed-off-by: Dominik Csapak --- panel/LogView.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[pve-devel] [PATCH widget-toolkit 1/4] add version as comment to js file

this can be used in the proxy to read the installed version of the widget toolkit (without needing to read the info from apt/dpkg/etc.) Signed-off-by: Dominik Csapak --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile

Re: [pve-devel] PVE Minimal Debian Appliance

On 12/18/2017 12:09 AM, c.mo...@web.de wrote: > Hello! > > Can you consider to provide a PVE Minimal Debian Appliance considering > things like > "Removing Packages for dealing with hardware. This is not usually done > within a container" und "Removing Packages for interactive use." BTW, the

[pve-devel] [PATCH common v2 7/9] cli: allow specifying sub commands through $cmddef

allow to use sub commands alá # pveum user add The new resolve_cmd traverses $cmddef, resolves one level of aliases and returns the respective sub command, its cmddef, arguments and if it was expanded (e.g., pveum u d ... => pveum user delete ...) which allows quite easy integration in the

[pve-devel] [PATCH common v2 4/9] cli: refactor print_bash_completion

move variables nearer to where they actually used. drop program name early from argv array drop unnecessary variables Signed-off-by: Thomas Lamprecht --- src/PVE/CLIHandler.pm | 39 +++ 1 file changed, 15 insertions(+), 24

[pve-devel] [PATCH common v2 3/9] cli: refactor comand name helper

use shorter and also a bit faster methods to expand and get comand names Signed-off-by: Thomas Lamprecht --- src/PVE/CLIHandler.pm | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/src/PVE/CLIHandler.pm

[pve-devel] [PATCH common v2 9/9] cli: document $cmddef structure

Signed-off-by: Thomas Lamprecht Reviewed-by: Dominik Csapak --- src/PVE/CLIHandler.pm | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 76b14c9..fd57d0f 100644 ---

[pve-devel] [PATCH common v2 2/9] cli: factor out initialisation check

Signed-off-by: Thomas Lamprecht Reviewed-by: Dominik Csapak --- src/PVE/CLIHandler.pm | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index c6f11f6..f50611d 100644

[pve-devel] [PATCH common v2 6/9] cli: factor out generate usage string

reduce code reuse and prepare for sub commands Signed-off-by: Thomas Lamprecht --- src/PVE/CLIHandler.pm | 138 -- 1 file changed, 77 insertions(+), 61 deletions(-) diff --git a/src/PVE/CLIHandler.pm

[pve-devel] [PATCH common v2 0/9]

Changes RFC v1 -> PATCH v2: * 3/9: escape $cmd in grep * 5/9: do not use new $cmd_str variable before it gets introduced in 7/9 * 6/9: no intermediate "break" of the help command, i.e., do show full help if a specific command was passed * 9/9: add an alias example Previous cover letter for

[pve-devel] [PATCH common v2 8/9] cli: allow to pass sub commands to help as array

Improves usabillity by allowing to pass a sub copmmand unquoted to the help command, e.g.: # pveum help user delete without this only a quoted version worked, e.g.: # pveum help "user delete" Signed-off-by: Thomas Lamprecht --- src/PVE/CLIHandler.pm | 14

[pve-devel] [PATCH common v2 5/9] cli: factor out abort

will be reused in later patches too Signed-off-by: Thomas Lamprecht Reviewed-by: Dominik Csapak --- src/PVE/CLIHandler.pm | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/PVE/CLIHandler.pm

Re: [pve-devel] PVE Minimal Debian Appliance

> we get our container images from: http://uk.images.linuxcontainers.org/ > There are all scripts available to build your own container. This is not really true for debian and ubuntu - we use 'dab' to build those packages: https://git.proxmox.com/?p=dab.git;a=summary

Re: [pve-devel] PVE Minimal Debian Appliance

Hello Thomas, On Mon, Dec 18, 2017 at 12:09:01AM +0100, c.mo...@web.de wrote: > Hello! > > Can you consider to provide a PVE Minimal Debian Appliance considering > things like > "Removing Packages for dealing with hardware. This is not usually done > within a container" und "Removing Packages for