Re: [pve-devel] cpuflag: pcid needed in guest for good performance after meltdown

2018-01-08 Thread Stefan Priebe - Profihost AG
Am 08.01.2018 um 23:23 schrieb Alexandre DERUMIER: > I think it's not exposed in current cpu model > > it can be enabled with "+pcid" > > > I don't known what it's the best way to add it in proxmox. > We could do it with qemu version upgrade, but qemu 2.10 are not ready. Yes but that was

Re: [pve-devel] cpuflag: pcid needed in guest for good performance after meltdown

2018-01-08 Thread Alexandre DERUMIER
I think it's not exposed in current cpu model it can be enabled with "+pcid" I don't known what it's the best way to add it in proxmox. We could do it with qemu version upgrade, but qemu 2.10 are not ready. Maybe add new cpumodel with +pcid enabled ? or add code to manage custom cpuflags and

Re: [pve-devel] cpuflag: pcid needed in guest for good performance after meltdown

2018-01-08 Thread Stefan Priebe - Profihost AG
Am 08.01.2018 um 22:11 schrieb Michael Rasmussen: > On Mon, 8 Jan 2018 21:34:57 +0100 > Stefan Priebe - Profihost AG wrote: > >> Hello, >> >> for meltdown mitigation and performance it's important to have the pcid >> flag passed down to the guest (f.e. >>

Re: [pve-devel] cpuflag: pcid needed in guest for good performance after meltdown

2018-01-08 Thread Michael Rasmussen
On Mon, 8 Jan 2018 21:34:57 +0100 Stefan Priebe - Profihost AG wrote: > Hello, > > for meltdown mitigation and performance it's important to have the pcid > flag passed down to the guest (f.e. > https://groups.google.com/forum/m/#!topic/mechanical-sympathy/L9mHTbeQLNU). >

[pve-devel] cpuflag: pcid needed in guest for good performance after meltdown

2018-01-08 Thread Stefan Priebe - Profihost AG
Hello, for meltdown mitigation and performance it's important to have the pcid flag passed down to the guest (f.e. https://groups.google.com/forum/m/#!topic/mechanical-sympathy/L9mHTbeQLNU). My host shows the flag: # grep ' pcid ' /proc/cpuinfo | wc -l 56 But the guest does not: # grep pcid

Re: [pve-devel] [PATCH] improve serial terminal handling

2018-01-08 Thread Thomas Lamprecht
On 1/3/18 1:04 PM, Dominik Csapak wrote: > this series adds the ability to show serial ports on the gui, > and disabling the xtermjs button when no serial device exists for the vm > > qemu-server: > > Dominik Csapak (1): > add serial:1 to vmstatus when config has a serial device configured >

Re: [pve-devel] [PATCH manager 1/4] add icon/class for serial ports

2018-01-08 Thread Thomas Lamprecht
On 1/3/18 1:04 PM, Dominik Csapak wrote: > > + xmlns="http://www.w3.org/2000/svg;> Is this not effectively: http://fontawesome.io/icon/ellipsis-h/ If we make our own I'd maybe use a modified version of https://upload.wikimedia.org/wikipedia/commons/f/f7/DE9_Diagram.svg It looks like

[pve-devel] [PATCH v2 qemu-server] fix efi disk format detection

2018-01-08 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller Fixes: 2bfbee039bbe ("include format for efidisk") --- Changes since v1: * When the disk was specified as a path instead of as storage:volume the format property is now mandatory. PVE/QemuServer.pm | 11 +-- 1 file changed, 9

Re: [pve-devel] [PATCH qemu-server] fix efi disk format detection

2018-01-08 Thread Thomas Lamprecht
On 12/28/17 2:33 PM, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > Fixes: 2bfbee039bbe ("include format for efidisk") > --- > PVE/QemuServer.pm | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuServer.pm

Re: [pve-devel] [PATCH manager 2/2] jslint: fix trailing commas

2018-01-08 Thread Thomas Lamprecht
Just for the record: This patch (2/2) is obsolete, it was already addressed by: commit 44dfcab37ee63d58f7ab537012e335ec74164e07 Author: Emmanuel Kasper Date: Tue Dec 19 14:09:58 2017 +0100 jslint: remove trailing comma after last objects property On 12/13/17 11:34

Re: [pve-devel] [PATCH manager 00/19] moving to widget-toolkit

2018-01-08 Thread Thomas Lamprecht
On 12/21/17 1:36 PM, Dominik Csapak wrote: > this series is my part of the move to the widget-toolkit > (excluding Utils.js; this needs more time in january) > > it includes an additional feature in the api (filtering > the syslog by service), which was nicer than changing > the gui component to

Re: [pve-devel] [PATCH manager 09/19] add rrd models

2018-01-08 Thread Thomas Lamprecht
On 12/21/17 1:36 PM, Dominik Csapak wrote: > they will be used with the rrdstore > > Signed-off-by: Dominik Csapak > --- > www/manager6/Makefile | 1 + > www/manager6/data/models/RRDModels.js | 62 > +++ > 2 files changed,

Re: [pve-devel] [PATCH manager 06/19] use NetworkView/NetworkEdit from widget toolkit

2018-01-08 Thread Thomas Lamprecht
On 12/21/17 1:36 PM, Dominik Csapak wrote: > diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js > index 5ead4878..6131790e 100644 > --- a/www/manager6/node/Config.js > +++ b/www/manager6/node/Config.js > @@ -165,7 +165,8 @@ Ext.define('PVE.node.Config', { >

Re: [pve-devel] [PATCH manager 04/19] use IntegerField from widget toolkit

2018-01-08 Thread Thomas Lamprecht
On 12/21/17 1:36 PM, Dominik Csapak wrote: > diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js > index 4a438877..4a855d52 100644 > --- a/www/manager6/lxc/Options.js > +++ b/www/manager6/lxc/Options.js > @@ -81,23 +81,14 @@ Ext.define('PVE.lxc.Options', { >

Re: [pve-devel] [PATCH manager 02/19] use ComboGrid from proxmox-widget-toolkit

2018-01-08 Thread Thomas Lamprecht
On 12/21/17 1:36 PM, Dominik Csapak wrote: > [snip] > -initComponent: function() { > - var me = this; > - > - Ext.apply(me, { > - queryMode: 'local', > - matchFieldWidth: false > - }); > - > - Ext.applyIf(me, { value: ''}); // hack: avoid ExtJS validate() bug >

Re: [pve-devel] [PATCH jslint] improve jslint

2018-01-08 Thread Thomas Lamprecht
IMHO, it would have been good to split this in three patches, for the sake of a nice git history: * add Proxmox to predefined global variables * do not abort on first error but check all files * print errors at the end But, the end result looks OK, besides whitespace/indentation problems -

Re: [pve-devel] [PATCH manager 1/2] add defaultSize parameter for DiskStorageSelector and set it to 8 for lxc

2018-01-08 Thread Thomas Lamprecht
Reviewed-by: Thomas Lamprecht On 12/13/17 11:34 AM, Dominik Csapak wrote: > we had it previously on 8GB for containers, but with the refactoring, > this got lost. this patch changes this back > > Signed-off-by: Dominik Csapak > --- >

Re: [pve-devel] [PATCH common 1/2] fork_worker: use correct handle type for POSIX::write

2018-01-08 Thread Thomas Lamprecht
Series looks good, reviewed and tested a bit around: Reviewed-by: Thomas Lamprecht On 12/27/17 11:15 AM, Wolfgang Bumiller wrote: > $resfh can be a pipe from POSIX::pipe() or the upid output > handle, which is an IO::File, so we need to take its > fileno(). > >

Re: [pve-devel] [PATCH apiclient v2 1/3] add APIClient/Exception.pm class

2018-01-08 Thread Thomas Lamprecht
any comment on this series? Would be nice for me to advance my cluster over API series a bit easier :) On 12/14/17 11:12 AM, Thomas Lamprecht wrote: > As we do not want to depend on PVE libraries with this I forked of > the PVE::Exception class, removed all raise_* methods so that only > raise()

[pve-devel] [PATCH common v2] JSONSchema: add fingerprint-sha256 standard option

2018-01-08 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- changes v1 -> v2: * remove anchors, their already applied on parsing * do not allow double colon separation, Net::SSLeay::X509_get_fingerprint only emits single colon separated * allow case insensitive hex values, users of the format