Hi,
Thanks for the patches !
>>While creating the patches I got quite inconsistent behaviour w.r.t the
>>effectiveness of the fstrim (I used lvmthin as storage) - sometimes (quite
>>often) the fstrim didn't free any space or just 1-2% (remaining on 98%-100%
>>usage with the image being only 45% f
> On July 5, 2018 at 5:00 PM Thomas Lamprecht wrote:
>
>
> On 7/5/18 4:43 PM, Dietmar Maurer wrote:
> > What is the purpose of the print wrapper function?
> >
> >> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> >> index 5829e4c..90bf745 100644
> >> --- a/PVE/QemuServer.pm
> >> +++ b/PVE
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Qemu.pm | 3 +--
PVE/QemuConfig.pm | 2 +-
PVE/QemuServer.pm | 38 +-
3 files changed, 35 insertions(+), 8 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index db28ed0..6dc2489 100644
--- a/PVE/API2/Q
Change to Qemu Guest Agent now being a property_string, and including
fstrim_cloned_disks.
Signed-off-by: Stoiko Ivanov
---
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 10 +
www/manager6/form/AgentFeatureSelector.js | 65 +
Signed-off-by: Stoiko Ivanov
---
PVE/QemuMigrate.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index ab2258d..ca09469 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -968,7 +968,7 @@ sub phase3_cleanup {
}
as conditional when trimming after move_disk, migrate or clone
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Qemu.pm | 4 ++--
PVE/QemuMigrate.pm | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 6dc2489..d157ba6 100644
--- a/PVE/API2/
Fix #1242.
As suggested in the ticket this changes make the trimming after a move_disk,
clone or migrate depending on the new fstrim_cloned_disks property.
The patchset is based on Alexandre's Patch sent on 28.05.2018 (Thanks!).
One minor fixup is included (the vmid was missing in the invocation
On 7/5/18 11:20 AM, Dietmar Maurer wrote:
> This is useful to generate usage information with pveclient, where we do not
> have
> handler classes at all.
>
> Signed-off-by: Dietmar Maurer
> ---
> src/PVE/RESTHandler.pm | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
On 7/5/18 9:26 AM, Dietmar Maurer wrote:
> Signed-off-by: Dietmar Maurer
> ---
> src/PVE/CLIFormatter.pm | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm
> index 052ed6d..08907fb 100644
> --- a/src/PVE/CLIFormatte
On 6/26/18 5:17 PM, Alwin Antreich wrote:
> * Combine sections from the wiki
> * add section for avoiding RAID controllers
> * correct command line for bluestore DB device creation
> * minor rewording
>
> Signed-off-by: Alwin Antreich
> ---
> pveceph.adoc | 92
>
On 6/25/18 6:51 PM, Alwin Antreich wrote:
> Signed-off-by: Alwin Antreich
> ---
> pve-storage-cephfs.adoc | 106
>
> pvesm.adoc | 3 ++
> 2 files changed, 109 insertions(+)
> create mode 100644 pve-storage-cephfs.adoc
>
applied w
On 7/5/18 4:43 PM, Dietmar Maurer wrote:
> What is the purpose of the print wrapper function?
>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index 5829e4c..90bf745 100644
>> --- a/PVE/QemuServer.pm
>> +++ b/PVE/QemuServer.pm
>> @@ -5539,6 +5539,8 @@ sub update_disksize {
>>
>> m
What is the purpose of the print wrapper function?
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 5829e4c..90bf745 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -5539,6 +5539,8 @@ sub update_disksize {
>
> my $changes;
>
> +my $print = sub { print "VM $
This is a bit annoying because we need to define NOVIEW everywhere in
our buildsystems.
And for repeated edit-compile-view cycles there's alway the
shell/bash/zsh history to quickly (re)open a file in man...
Signed-off-by: Thomas Lamprecht
---
pve-doc-generator.mk.in | 3 ---
1 file changed, 3 d
Hi,
On 7/4/18 1:51 PM, Dzmitry Kotsikau wrote:
> Signed-off-by: Dzmitry Kotsikau
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index d6efb3a..68aef83 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuSer
Else an user has no idea what, or if something happened.
Gets printed to tty when using qm rescan or to tasklog for the case
where we do a rescan after restoring a backup.
Signed-off-by: Thomas Lamprecht
---
PVE/QemuServer.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff -
tells an user what would get touched, so he has a chance to fix
unwanted things before changes are actually made.
Signed-off-by: Thomas Lamprecht
---
PVE/CLI/qm.pm | 14 +-
PVE/QemuServer.pm | 6 +++---
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/PVE/CLI/qm.p
On Thu, Jul 05, 2018 at 12:23:13PM +0200, Thomas Lamprecht wrote:
> On 7/5/18 11:29 AM, Alwin Antreich wrote:
> > Patch tested and works. Two small nits below.
> >
>
> much thanks!
>
> > On Tue, Jul 03, 2018 at 03:55:10PM +0200, Thomas Lamprecht wrote:
> >> Combine both dialogues. This not only h
On 7/5/18 11:29 AM, Alwin Antreich wrote:
> Patch tested and works. Two small nits below.
>
much thanks!
> On Tue, Jul 03, 2018 at 03:55:10PM +0200, Thomas Lamprecht wrote:
>> Combine both dialogues. This not only helps to reuse code but also
>> reduces storage choices from the Storage -> Add men
Patch tested and works. Two small nits below.
On Tue, Jul 03, 2018 at 03:55:10PM +0200, Thomas Lamprecht wrote:
> Combine both dialogues. This not only helps to reuse code but also
> reduces storage choices from the Storage -> Add menu, and thus
> improves usability.
>
> Signed-off-by: Thomas Lam
This is useful to generate usage information with pveclient, where we do not
have
handler classes at all.
Signed-off-by: Dietmar Maurer
---
src/PVE/RESTHandler.pm | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.p
On 7/3/18 5:41 PM, Alwin Antreich wrote:
> Unused disk(s) appeared after a rescan of storages. Especially shown
> with ceph pools, where two storage entries are made, _ct and
> _vm. The rescan method did include images from both storages.
>
> This patch filters any storage not containing the conte
On Sat, Jun 30, 2018 at 01:18:49PM +0200, Alexandre Derumier wrote:
> if we try to delete a snapshot, and that is disk from the snapshot
> is not attached anymore (unused), we can't delete the snapshot
> with qemu snapshot delete command (for storage which use it (qcow2,rbd,...))
>
> example:
>
>
Signed-off-by: Dietmar Maurer
---
src/PVE/CLIFormatter.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm
index 052ed6d..08907fb 100644
--- a/src/PVE/CLIFormatter.pm
+++ b/src/PVE/CLIFormatter.pm
@@ -384,14 +384,17 @@
24 matches
Mail list logo
