[pve-devel] [PATCH storage] Add check to overrule krbd setting on RBD storage

2018-07-25 Thread Alwin Antreich
The scfg variable holds an extra parameter to verify that it's lxc that needs krbd regardless its storage config entry. Without this there would be the need for an extra storage entry to use the same RBD pool with LXC (krbd 0/1). Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 12

[pve-devel] [PATCH container] LXC needs krbd regardless of storage entry

2018-07-25 Thread Alwin Antreich
This patch adds the lxc_krbd flag to the storage config, so the RBD storage plugin is aware of the need for krbd from lxc. Removed the check for krbd. Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC.pm | 10 +- src/PVE/LXC.pm | 20 ++-- 2 files changed, 19

[pve-devel] [RFC container 0/1] Removes need for two RBD storage entries

2018-07-25 Thread Alwin Antreich
This is one of the ideas, how to remove the need for two RBD storage entries to get LXC and KVM (through librbd) run on the same RBD pool. Now needed if the ceph cluster is not under PVE control (eg. hosted ceph service). See the discussion for reference.

Re: [pve-devel] api-viewer: allow to re-use ExtJS + Theme when on PVE

2018-07-25 Thread Dominik Csapak
On 07/25/2018 04:30 PM, Dominik Csapak wrote: On 07/25/2018 04:27 PM, Thomas Lamprecht wrote: Am 07/25/2018 um 01:12 PM schrieb Dominik Csapak: On 07/25/2018 11:21 AM, Thomas Lamprecht wrote: changes from v1 [0]: * add 2 docs (1/3, 2/3) patches to move from debug to release extjs and from   

Re: [pve-devel] api-viewer: allow to re-use ExtJS + Theme when on PVE

2018-07-25 Thread Dominik Csapak
On 07/25/2018 04:27 PM, Thomas Lamprecht wrote: Am 07/25/2018 um 01:12 PM schrieb Dominik Csapak: On 07/25/2018 11:21 AM, Thomas Lamprecht wrote: changes from v1 [0]: * add 2 docs (1/3, 2/3) patches to move from debug to release extjs and from    touch to normal theme. Those are independent

Re: [pve-devel] api-viewer: allow to re-use ExtJS + Theme when on PVE

2018-07-25 Thread Thomas Lamprecht
Am 07/25/2018 um 01:12 PM schrieb Dominik Csapak: On 07/25/2018 11:21 AM, Thomas Lamprecht wrote: changes from v1 [0]: * add 2 docs (1/3, 2/3) patches to move from debug to release extjs and from    touch to normal theme. Those are independent from the manager patch, only    docs 3/3 needs

[pve-devel] [pve-common] cli: print_text_table: correctly handle sort_key 0

2018-07-25 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index 22cd8f2..8bb42ca 100644 --- a/src/PVE/CLIFormatter.pm +++ b/src/PVE/CLIFormatter.pm @@ -132,7 +132,7 @@

Re: [pve-devel] api-viewer: allow to re-use ExtJS + Theme when on PVE

2018-07-25 Thread Dominik Csapak
On 07/25/2018 11:21 AM, Thomas Lamprecht wrote: changes from v1 [0]: * add 2 docs (1/3, 2/3) patches to move from debug to release extjs and from touch to normal theme. Those are independent from the manager patch, only docs 3/3 needs it. * s/Build-Depends/Depends/ in the pve-docs control

Re: [pve-devel] [pve-manager] use new schema option 'addStandardCliParameters'

2018-07-25 Thread Dietmar Maurer
> That's like saying the system shell ls command is useless because you > can use bash/zsh/XYZ completion to get directory/file listings... > What about other shell's (zsh, fish, dash, ...)? Or piping to awk/sed? > > But actually it won't be needed because you can just do a GET on the >

[pve-devel] [pve-manager] pvesh: implement 'ls' command

2018-07-25 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- As requested by Thomas. NOTE: needs previous patches for pve-common which are not applied so far bin/pvesh | 93 +++ 1 file changed, 93 insertions(+) diff --git a/bin/pvesh b/bin/pvesh index

Re: [pve-devel] [PATCH cluster v2] buildsys: replace autotools with plain makefiles

2018-07-25 Thread Thomas Lamprecht
Am 07/24/2018 um 12:30 PM schrieb Wolfgang Bumiller: On Tue, Jul 24, 2018 at 11:17:43AM +0200, Thomas Lamprecht wrote: Am 07/12/2018 um 10:06 AM schrieb Thomas Lamprecht: pve-cluster is not a big project with to much dependencies, so autotools was a bit of an overkill for it. Omit it, plus a

[pve-devel] [PATCH docs v2 3/3] api-viewer: use our extjs package

2018-07-25 Thread Thomas Lamprecht
The loading of an external hosted ExtJS is from a time where we did not have a extra ExtJS package as it still was in the pve-manager one, which was not desired to be installed on a non-pve machine. Add a dependency on libjs-extjs and a link from api-viewer/extjs to the installation directory of

[pve-devel] api-viewer: allow to re-use ExtJS + Theme when on PVE

2018-07-25 Thread Thomas Lamprecht
changes from v1 [0]: * add 2 docs (1/3, 2/3) patches to move from debug to release extjs and from touch to normal theme. Those are independent from the manager patch, only docs 3/3 needs it. * s/Build-Depends/Depends/ in the pve-docs control file - addressing Fabians rightful nit [0]:

[pve-devel] [PATCH docs v2 1/3] api-viewer: use much smaller minified extjs

2018-07-25 Thread Thomas Lamprecht
Use the over 4 times smaller minfied version of ExtJS, not the debug one. Any developer can easily use the debug version if needed, but most of the times it this isn't the case. Signed-off-by: Thomas Lamprecht --- * new in v2 api-viewer/index.html | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH manager v2] pveproxy: add link to extjs for api-viewer

2018-07-25 Thread Thomas Lamprecht
allows us to remove the external loading of extjs from the cloudflare cdn in pve-docs easier with having the external hosted version in mind. Signed-off-by: Thomas Lamprecht --- same as in v1 PVE/Service/pveproxy.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Service/pveproxy.pm

[pve-devel] [PATCH docs v2 2/3] api-viewer: use 'normal' over 'touch' theme

2018-07-25 Thread Thomas Lamprecht
The touch feels super zoomed, and the api-viewer is probably much more viewed through a desktop/laptop not a mobile device with small high-dpi touch screen. Signed-off-by: Thomas Lamprecht --- * new in v2 api-viewer/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pve-devel] applied: [PATCH manager] ui: permissions: allow to select root path '/' directly

2018-07-25 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- www/manager6/data/PermPathStore.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js index 15edc181..90837d1c 100644 --- a/www/manager6/data/PermPathStore.js +++

[pve-devel] [pve-common v2 0/2] cli output formatter cleanups

2018-07-25 Thread Dietmar Maurer
As suggested by Thomas, it is now possible to define additional properties with $cmddef. Those properties are extracted and only passed to the output formatter function. Dietmar Maurer (2): cli: remove all output formatter magic from CLIHandler PVE::CLIHandler - allow to define additional

[pve-devel] [pve-common v2 1/2] cli: remove all output formatter magic from CLIHandler

2018-07-25 Thread Dietmar Maurer
- and rename format to 'output-format' - provide a method to add properties to schema: PVE::RESTHandler::add_standard_output_properties - provide methods to extract output properties: PVE::RESTHandler::extract_standard_output_properties() Signed-off-by: Dietmar Maurer ---

[pve-devel] [pve-common v2 2/2] PVE::CLIHandler - allow to define additional parameters for output formatter

2018-07-25 Thread Dietmar Maurer
Best shown with a example: my $test_formatter = sub { my ($res, $result_schema, $fmt_param) = @_; PVE::CLIFormatter::print_api_result($res, $result_schema, undef, $fmt_param); }; $cmddef = [ __PACKAGE__, 'test', [], undef, $test_formatter, $PVE::RESTHandler::standard_output_options],