[pve-devel] applied: [pve-manager] correctly install PVE/CLI/pvesh.pm

Signed-off-by: Dietmar Maurer --- PVE/CLI/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/Makefile b/PVE/CLI/Makefile index 88cd99c9..93b3f3c6 100644 --- a/PVE/CLI/Makefile +++ b/PVE/CLI/Makefile @@ -1,6 +1,6 @@ include ../../defines.mk -SOURCES=vzdump.pm

[pve-devel] applied [pve-manager] pvesh: add standard_output_properties to set/create/delete

Most of those API calls return simple strings, so it does not really matter. Nethertheless, some calls return complex data structures and we want to set output format for them. Signed-off-by: Dietmar Maurer --- PVE/CLI/pvesh.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[pve-devel] applied: [pve-common] getopt_usage: always remove $standard_output_options

Tools like pvesh and pveclient pass them as normal arguments. We use a simply heuristic to test if there is an 'output_format' parameter. If so, we remove all $standard_output_options and display [FORMAT_OPTIONS] instead. Signed-off-by: Dietmar Maurer --- src/PVE/RESTHandler.pm | 10 ++

Re: [pve-devel] [PATCH V3 storage 0/4] updated Linux targetcli/LIO support

On Wed, 2018-07-11 at 19:50 +0200, Stoiko Ivanov wrote: > Hi, > > I finally got around to give your patches a spin, and can report that > they work for my preliminary tests. > > One thing, which I think is not a good idea is the reuse of the > comstar_tg property for the tpg of LIO (from my

[pve-devel] [PATCH v2 manager 1/1] Linux LIO/targetcli support

adding LIO option and dedicated "LIO target portal group" input field to the "Add: ZFS via iSCSI" dialog --- www/manager6/form/iScsiProviderSelector.js | 3 ++- www/manager6/storage/ZFSEdit.js| 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[pve-devel] [PATCH v2 manager 0/1] refactored Linux LIO/targetcli support

UI changes required to support Linux LIO iSCSI targets. Udo Rader (1): Linux LIO/targetcli support www/manager6/form/iScsiProviderSelector.js | 3 ++- www/manager6/storage/ZFSEdit.js| 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) -- 2.18.0

[pve-devel] [PATCH v4 storage 1/1] Linux LIO/targetcli support

Introducing LIO/targetcli support allowing to use recent linux distributions as iSCSI targets for ZFS volumes. In order for this to work, two preconditions have to be met: 1. the portal has to be set up correctly using targetcli 2. the initiator has to be authorized to connect to the target

[pve-devel] [PATCH v4 storage 0/1] refactored Linux LIO/targetcli support

Following Stoiko's review, I refactored the LIO code according to his remarks, dropping some unneeded code copied from the iet implementation. Instead of (ab)using the comstar_tg property, I've introduced a new "lio_tpg" property. So if you apply this patch, be sure to also apply the fitting

Re: [pve-devel] [pve-manager v2 0/5] pvesh: implement 'ls' command

Am 07/26/2018 um 02:26 PM schrieb Dietmar Maurer: Please give me some more time to test - lets bump tomorrow OK, sounds good. On July 26, 2018 at 2:11 PM Thomas Lamprecht wrote: Am 07/26/2018 um 01:17 PM schrieb Dietmar Maurer: Just commited my changes to pve-common and pve-manager.

[pve-devel] applied: [pve-common] getopt_usage: do not display $standard_output_options

Instead, simply add [FORMAT_OPTIONS] to the usage string. Signed-off-by: Dietmar Maurer --- src/PVE/RESTHandler.pm | 73 +- 1 file changed, 43 insertions(+), 30 deletions(-) diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm index

Re: [pve-devel] [pve-manager v2 0/5] pvesh: implement 'ls' command

Please give me some more time to test - lets bump tomorrow > On July 26, 2018 at 2:11 PM Thomas Lamprecht wrote: > > > Am 07/26/2018 um 01:17 PM schrieb Dietmar Maurer: > > Just commited my changes to pve-common and pve-manager. > > OK, great. I'd then bump manager and common if you have no

[pve-devel] applied: [PATCH docs v2 3/3] api-viewer: use our extjs package

applied > On July 25, 2018 at 11:21 AM Thomas Lamprecht wrote: > > > The loading of an external hosted ExtJS is from a time where we did > not have a extra ExtJS package as it still was in the pve-manager > one, which was not desired to be installed on a non-pve machine. > Add a dependency on

[pve-devel] applied: [PATCH docs v2 2/3] api-viewer: use 'normal' over 'touch' theme

applied > On July 25, 2018 at 11:21 AM Thomas Lamprecht wrote: > > > The touch feels super zoomed, and the api-viewer is probably much > more viewed through a desktop/laptop not a mobile device with small > high-dpi touch screen. ___ pve-devel

Re: [pve-devel] [pve-manager v2 0/5] pvesh: implement 'ls' command

Am 07/26/2018 um 01:17 PM schrieb Dietmar Maurer: Just commited my changes to pve-common and pve-manager. OK, great. I'd then bump manager and common if you have no objections. ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] applied : [PATCH docs v2 1/3] api-viewer: use much smaller minified extjs

applied > On July 25, 2018 at 11:21 AM Thomas Lamprecht wrote: > > > Use the over 4 times smaller minfied version of ExtJS, not the debug > one. > > Any developer can easily use the debug version if needed, but most of > the times it this isn't the case. > > Signed-off-by: Thomas Lamprecht

Re: [pve-devel] [pve-manager v2 0/5] pvesh: implement 'ls' command

> OLD: > > # pvesh ls > Dr--- access > Dr--- cluster > Dr--- nodes > Dr-c- pools > Dr-c- storage > -r--- version > > (output size is 863 bytes vs 79 bytes, just as a side note) > > But besides disliking of the default formatting choice, the code changes OK, changed 'ls' back to old format.

[pve-devel] applied: [pve-manager 1/6] pvesh: do not use CLIHandler $option parameter, simplify code

Signed-off-by: Dietmar Maurer --- bin/pvesh | 83 +-- 1 file changed, 44 insertions(+), 39 deletions(-) diff --git a/bin/pvesh b/bin/pvesh index 36c9a900..5dab90c3 100755 --- a/bin/pvesh +++ b/bin/pvesh @@ -103,18 +103,17 @@ sub

[pve-devel] applied: [pve-manager 4/6] pvenode: use print_api_result to print certificate information

Signed-off-by: Dietmar Maurer --- PVE/CLI/pvenode.pm | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index 9dee6ce9..8a6a924d 100644 --- a/PVE/CLI/pvenode.pm +++ b/PVE/CLI/pvenode.pm @@

[pve-devel] applied: [pve-manager 6/6] pvenode: remove useless call to query_terminal_options

Signed-off-by: Dietmar Maurer --- PVE/CLI/pvenode.pm | 6 -- 1 file changed, 6 deletions(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index 5b06b674..5cd855be 100644 --- a/PVE/CLI/pvenode.pm +++ b/PVE/CLI/pvenode.pm @@ -145,8 +145,6 @@ our $cmddef = { info => [

[pve-devel] applied: [pve-manager 2/6] pvesh: implement 'ls' command

Signed-off-by: Dietmar Maurer --- now use --noborder and --noheader by default bin/pvesh | 97 ++- 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/bin/pvesh b/bin/pvesh index 5dab90c3..a0245764 100755 --- a/bin/pvesh

[pve-devel] applied: [pve-manager 5/6] pvenode: use print_api_result to print acme account information

Signed-off-by: Dietmar Maurer --- PVE/API2/ACMEAccount.pm | 1 + PVE/CLI/pvenode.pm | 29 + 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/PVE/API2/ACMEAccount.pm b/PVE/API2/ACMEAccount.pm index 2743cfbb..90620dea 100644 ---

[pve-devel] applied: [pve-manager 3/6] pvenode: fixup output formatting

Signed-off-by: Dietmar Maurer --- PVE/CLI/pvenode.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index 9092a6c9..9dee6ce9 100644 --- a/PVE/CLI/pvenode.pm +++ b/PVE/CLI/pvenode.pm @@ -17,6 +17,8 @@ use PVE::JSONSchema

[pve-devel] applied: [pve-common 6/7] PVE::CLIFormatter - pass terminal option as separate parameter

This simplifies usage, because we can simple omit the $terminal_opts parameter in most cases (automatically call query_terminal_option) while still setting $options. Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 40 1 file changed, 20

[pve-devel] applied: [pve-common 4/7] PVE::CLIFormatter - new 'yaml' renderer

Generates nice and readable output for list of string and simple objects. Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 12 1 file changed, 12 insertions(+) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index 8bb42ca..f9eb03f 100644 ---

[pve-devel] applied: [pve-common 5/7] PVE::Certificate - set renderers for unix epoch and 'san'

Signed-off-by: Dietmar Maurer --- src/PVE/Certificate.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm index b0b9bbf..691e70b 100644 --- a/src/PVE/Certificate.pm +++ b/src/PVE/Certificate.pm @@ -54,17 +54,20 @@

[pve-devel] applied: [pve-common 3/7] cli: print_text_table: correctly handle sort_key 0

Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index 22cd8f2..8bb42ca 100644 --- a/src/PVE/CLIFormatter.pm +++ b/src/PVE/CLIFormatter.pm @@ -132,7 +132,7 @@

[pve-devel] applied: [pve-common 1/7] cli: remove all output formatter magic from CLIHandler

- and rename format to 'output-format' - provide a method to add properties to schema: PVE::RESTHandler::add_standard_output_properties - provide methods to extract output properties: PVE::RESTHandler::extract_standard_output_properties() Signed-off-by: Dietmar Maurer ---

[pve-devel] applied: [pve-common 7/7] introcude new output format 'yaml'

Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 4 +++- src/PVE/JSONSchema.pm | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index 61b313b..f6ad459 100644 --- a/src/PVE/CLIFormatter.pm +++

[pve-devel] applied: [pve-common 2/7] PVE::CLIHandler - allow to define additional parameters for output formatter

Best shown with a example: my $test_formatter = sub { my ($res, $result_schema, $fmt_param) = @_; PVE::CLIFormatter::print_api_result($res, $result_schema, undef, $fmt_param); }; $cmddef = [ __PACKAGE__, 'test', [], undef, $test_formatter, $PVE::RESTHandler::standard_output_options],

Re: [pve-devel] [pve-manager v2 0/5] pvesh: implement 'ls' command

> # pvesh ls > Dr--- access > Dr--- cluster > Dr--- nodes > Dr-c- pools > Dr-c- storage > -r--- version > > (output size is 863 bytes vs 79 bytes, just as a side note) You can still get that with: # pvesh ls / --noborder --noheader > > But besides disliking of the default formatting choice,

Re: [pve-devel] [pve-manager v2 0/5] pvesh: implement 'ls' command

Am 07/26/2018 um 11:04 AM schrieb Dietmar Maurer: NOTE: needs previous patches for pve-common which are not applied so far Also contains changes for pvenode - consider them a RFC Dietmar Maurer (5): pvesh: do not use CLIHandler $option parameter, simplify code pvesh: implement 'ls'

[pve-devel] [pve-common] introcude new output format 'yaml'

Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 4 +++- src/PVE/JSONSchema.pm | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index 61b313b..f6ad459 100644 --- a/src/PVE/CLIFormatter.pm +++

[pve-devel] [pve-common v2] PVE::CLIFormatter - new 'yaml' renderer

Generates nice and readable output for list of string and simple objects. Signed-off-by: Dietmar Maurer --- changes in v2: use CPAN::Meta::YAML src/PVE/CLIFormatter.pm | 12 1 file changed, 12 insertions(+) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index

[pve-devel] [pve-common] PVE::CLIFormatter - pass terminal option as separate parameter

This simplifies usage, because we can simple omit the $terminal_opts parameter in most cases (automatically call query_terminal_option) while still setting $options. Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 40 1 file changed, 20

Re: [pve-devel] [pve-manager] pvesh: implement 'ls' command

> I have still the $format_result outsub here, i.e.: > > get => [ __PACKAGE__, 'get', ['api_path'], {}, $format_result ], > > thus this context does not match and I cannot apply it. just resent a patch serie, please test again. ___ pve-devel mailing

[pve-devel] [pve-manager 1/5] pvesh: do not use CLIHandler $option parameter, simplify code

Signed-off-by: Dietmar Maurer --- bin/pvesh | 83 +-- 1 file changed, 44 insertions(+), 39 deletions(-) diff --git a/bin/pvesh b/bin/pvesh index 36c9a900..ae5a62c2 100755 --- a/bin/pvesh +++ b/bin/pvesh @@ -103,18 +103,17 @@ sub

[pve-devel] [pve-manager v2 0/5] pvesh: implement 'ls' command

NOTE: needs previous patches for pve-common which are not applied so far Also contains changes for pvenode - consider them a RFC Dietmar Maurer (5): pvesh: do not use CLIHandler $option parameter, simplify code pvesh: implement 'ls' command pvenode: fixup output formatting pvenode: use

[pve-devel] [pve-manager 4/5] pvenode: use print_api_result to print certificate information

Signed-off-by: Dietmar Maurer --- PVE/CLI/pvenode.pm | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index 9dee6ce9..8a6a924d 100644 --- a/PVE/CLI/pvenode.pm +++ b/PVE/CLI/pvenode.pm @@

[pve-devel] [pve-manager 3/5] pvenode: fixup output formatting

Signed-off-by: Dietmar Maurer --- PVE/CLI/pvenode.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index 9092a6c9..9dee6ce9 100644 --- a/PVE/CLI/pvenode.pm +++ b/PVE/CLI/pvenode.pm @@ -17,6 +17,8 @@ use PVE::JSONSchema

[pve-devel] [pve-manager 2/5] pvesh: implement 'ls' command

Signed-off-by: Dietmar Maurer --- bin/pvesh | 94 +++ 1 file changed, 94 insertions(+) diff --git a/bin/pvesh b/bin/pvesh index ae5a62c2..190d7158 100755 --- a/bin/pvesh +++ b/bin/pvesh @@ -164,6 +164,45 @@ sub dir_info { return

[pve-devel] [pve-manager 5/5] pvenode: use print_api_result to print acme account information

Signed-off-by: Dietmar Maurer --- PVE/API2/ACMEAccount.pm | 1 + PVE/CLI/pvenode.pm | 29 + 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/PVE/API2/ACMEAccount.pm b/PVE/API2/ACMEAccount.pm index 2743cfbb..90620dea 100644 ---

Re: [pve-devel] [pve-manager] pvesh: implement 'ls' command

Am 07/25/2018 um 11:38 AM schrieb Dietmar Maurer: Signed-off-by: Dietmar Maurer --- As requested by Thomas. much thanks, hope I do not cause to much trouble... NOTE: needs previous patches for pve-common which are not applied so far Hmm, but are some patches for manager also needed,

[pve-devel] [pve-common] PVE::ACME - untaint saved account data

Signed-off-by: Dietmar Maurer --- src/PVE/ACME.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm index e827aa9..38a14a5 100644 --- a/src/PVE/ACME.pm +++ b/src/PVE/ACME.pm @@ -152,7 +152,9 @@ sub load { my ($self) = @_; return if

[pve-devel] [pve-common] PVE::CLIFormatter - new 'yaml' renderer

Generates nice and readable output for list of string and simple objects. Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 37 + 1 file changed, 37 insertions(+) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index 8bb42ca..0424804

[pve-devel] applied: [PATCH cluster v2] buildsys: replace autotools with plain makefiles

Am 07/12/2018 um 10:06 AM schrieb Thomas Lamprecht: pve-cluster is not a big project with to much dependencies, so autotools was a bit of an overkill for it. Omit it, plus a ./configure step in general and just use a plain Makefile - in combination with pkg-config - like we do in our other

Re: [pve-devel] [PATCH container] LXC needs krbd regardless of storage entry

Am 07/25/2018 um 06:18 PM schrieb Alwin Antreich: This patch adds the lxc_krbd flag to the storage config, so the RBD storage plugin is aware of the need for krbd from lxc. Removed the check for krbd. Signed-off-by: Alwin Antreich --- src/PVE/API2/LXC.pm | 10 +- src/PVE/LXC.pm

Re: [pve-devel] [PATCH cluster v2] buildsys: replace autotools with plain makefiles

On Wed, Jul 25, 2018 at 11:33:54AM +0200, Thomas Lamprecht wrote: > Am 07/24/2018 um 12:30 PM schrieb Wolfgang Bumiller: > > On Tue, Jul 24, 2018 at 11:17:43AM +0200, Thomas Lamprecht wrote: > > > Am 07/12/2018 um 10:06 AM schrieb Thomas Lamprecht: > > > > pve-cluster is not a big project with to