Re: [pve-devel] Use of uninitialized value in string eq at /usr/share/perl5/PVE/CLIFormatter.pm line 390.

2018-09-24 Thread Dietmar Maurer
I am unable to reproduce that here. Please can you test with latest version pve-common from git? > On September 24, 2018 at 8:43 PM Eduard Ahmatgareev > wrote: > > > Hi All, > > Does anybody has issue with CLI on latest version? > > root@cluster-13-1:~# pvesh get /access/users

[pve-devel] Use of uninitialized value in string eq at /usr/share/perl5/PVE/CLIFormatter.pm line 390.

2018-09-24 Thread Eduard Ahmatgareev
Hi All, Does anybody has issue with CLI on latest version? root@cluster-13-1:~# pvesh get /access/users --output-format json-pretty [ { "enable" : 1, "expire" : 0, "userid" : "apicontrol1@pve" }, { "email" : "apicont...@admin.ru", "enable" : 1,

Re: [pve-devel] [RFC 1/2 pve-storage] implement map_volume and unmap_volume

2018-09-24 Thread Fabian Grünbichler
On Mon, Sep 24, 2018 at 09:40:04AM +0200, Dietmar Maurer wrote: > > > I though somebody will suggest a better name for that parameter so that > > > it looks more reasonable? > > > > FWIW, I like Thomas suggestion of pulling out the bdev path generation > > into a private sub (or, since we are

Re: [pve-devel] Please help: beginner trying to compile Proxmox kernel 4.15

2018-09-24 Thread Fabian Grünbichler
On Sat, Sep 22, 2018 at 12:19:02PM +0700, The Anh Tran wrote: > Dear Teams, > > I have Dell EMC ScaleIO (renamed to VxFlexOS) license. > > ScaleIO has 3 components: > SDS: server storage provider. This component could be installed on Proxmox > ok. > MDM: distributed storage metadata management.

Re: [pve-devel] [PATCH v2 pve-manager] API2 : Network : add network config reload

2018-09-24 Thread Alexandre DERUMIER
>>Any idea why json output is not supported? seem to work with -o instead -t: ifquery -a -o json -o {native,json}, --format {native,json} interface display format -t seem to be for input format. BTW, it seem possible to compare running vs

[pve-devel] applied: [PATCH qemu-server] use qemu's blockdev-snapshot functions

2018-09-24 Thread Thomas Lamprecht
On 9/24/18 10:44 AM, Wolfgang Bumiller wrote: > Instead of our own. The code is almost the same, but the > upstream implementation uses qemu's transactional system and > performs a drain() on the block device first. This seems to > help avoid some issues we run into with qcow2 files when >

Re: [pve-devel] [PATCH v2 pve-manager] API2 : Network : add network config reload

2018-09-24 Thread Dietmar Maurer
> I'm not sure if it's possible to try to reload directly > /etc/network/interfaces.new, then if it's ok, overwrite > /etc/network/interfaces. I'll look at this. Thanks. Unrelated topic, but I get the following with ifquery: # ifquery -a -t json error: No JSON object could be decoded Any

Re: [pve-devel] [PATCH v2 pve-manager] API2 : Network : add network config reload

2018-09-24 Thread Alexandre DERUMIER
>>This looks fragile. Maybe we should first 'reload', and only rewrite if >>reload is successful? Even better, a 'reload' should return the applied >>configuration, and we only commit that? It's possible to test the syntax of configuration with "ifreload -a -s" ifupdown2 reload should work

[pve-devel] [RFC 1/2 v2 pve-storage] implement map_volume and unmap_volume

2018-09-24 Thread Dietmar Maurer
This allows to request a mapped device/path explicitly, regardles of the storage option, eg. krbd option in the RBDplugin. Signed-off-by: Dietmar Maurer --- PVE/Storage.pm | 24 + PVE/Storage/Plugin.pm| 12 + PVE/Storage/RBDPlugin.pm | 69

[pve-devel] [PATCH qemu-server] use qemu's blockdev-snapshot functions

2018-09-24 Thread Wolfgang Bumiller
Instead of our own. The code is almost the same, but the upstream implementation uses qemu's transactional system and performs a drain() on the block device first. This seems to help avoid some issues we run into with qcow2 files when creating snapshots. Signed-off-by: Wolfgang Bumiller ---

Re: [pve-devel] [PATCH storage] fix #1929: refactor requirements check for disks

2018-09-24 Thread Thomas Lamprecht
On 9/21/18 4:32 PM, Dominik Csapak wrote: > and check correctly that the storage exists only when the user > want to create a storage strange line break here > this is useful if you want to create the same storage on > multiple nodes > could we please split this the next time? 1. Refactor out

[pve-devel] [PATCH pve-common 1/2] Inotify: add support for 802.1ad stacked vlans

2018-09-24 Thread Alexandre Derumier
--- src/PVE/INotify.pm | 26 - test/etc_network_interfaces/t.create_network.pl | 14 + 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index f837596..de61d79 100644 ---

[pve-devel] [PATCH pve-common 0/2] Add support for 802.1ad stacked vlans

2018-09-24 Thread Alexandre Derumier
add support of vlan-protocol option (ifupdown2), to enable 802.1ad vlans (QinQ). and add support for stacked vlan interface example --- auto eth0.100 iface eth0.100 inet manual vlan-protocol 802.1ad auto eth0.100.10 iface eth0.100.10 inet manual Alexandre Derumier (2): Inotify:

[pve-devel] [PATCH pve-common 2/2] improve lookup_type_prio

2018-09-24 Thread Alexandre Derumier
- use d->{type} instead regex on ifname - add stacked vlan support --- src/PVE/INotify.pm | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index de61d79..9d4f6d4 100644 --- a/src/PVE/INotify.pm +++

Re: [pve-devel] [RFC 1/2 pve-storage] implement map_volume and unmap_volume

2018-09-24 Thread Dietmar Maurer
> > I though somebody will suggest a better name for that parameter so that it > > looks more reasonable? > > FWIW, I like Thomas suggestion of pulling out the bdev path generation > into a private sub (or, since we are already adding to the storage > API[1], evaluate whether "give me the block

Re: [pve-devel] [PATCH v2 pve-manager] API2 : Network : add network config reload

2018-09-24 Thread Dietmar Maurer
> + raise_param_exc({ config => "reloading config with ovs changes is not > possible currently\n" }) > + if $ovs_changes && !$param->{restart}; > + > + foreach my $bridge (keys %$bridges_delete) { > + > + my (undef, $interface) = dir_glob_regex("/sys/class/net/$bridge/brif", >