Re: [pve-devel] rfc : pve-network : idea to generate and reload config accross the nodes

2019-04-03 Thread Dietmar Maurer
> > >>I think of this like deploying a network configuration with ansible (or > > >>other tools). > > > > Do you have an idea where to report a local error configuration ? > > Maybe an extra file inside /etc/pve/nodes// ... > > (not sure about that). Please ignore that suggestion. I guess

[pve-devel] applied: [PATCH pve-network] fix generateconfig.pl test

2019-04-03 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-network] merge Transport && Vnet to PVE::Network::Network

2019-04-03 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] rfc : pve-network : idea to generate and reload config accross the nodes

2019-04-03 Thread Dietmar Maurer
> >>I is still unclear to me how you do those tests? AFAIK, ifreload does not > >>have a --dry-run option. > with ifupdown2, ifreload -a --no-act. > (+ tests with our currrent read_networt_interface code) Ok, thanks. (This flag is not documented in the manual page). > > >>Even when it has

Re: [pve-devel] [PATCH docs 1/4] Change heading style for Multiple Active MDS

2019-04-03 Thread Thomas Lamprecht
On 4/3/19 4:23 PM, Alwin Antreich wrote: > The current heading style produces the below warning when executing make: > asciidoc: WARNING: pveceph.adoc: line 505: missing section: [sect5] > > With the heading style used in this patch the warning is gone and the > heading style is aligned with

Re: [pve-devel] rfc : pve-network : idea to generate and reload config accross the nodes

2019-04-03 Thread Stoiko Ivanov
Hi, Since I'm quite interested in networking I would like to support you with this topic (and learn new things). Am still reading up on the theory and our current code (will try to setup a test-environment soon in order to get some hands-on experience). Two ideas that came up in my head (not

[pve-devel] [PATCH pve-network] fix generateconfig.pl test

2019-04-03 Thread Alexandre Derumier
--- test/generateconfig.pl | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/test/generateconfig.pl b/test/generateconfig.pl index 3279838..cf55192 100644 --- a/test/generateconfig.pl +++ b/test/generateconfig.pl @@ -3,14 +3,15 @@ use warnings;

[pve-devel] [PATCH qemu-server] qm create: Set the NICs firewall to enabled by default on container creation

2019-04-03 Thread Christian Ebner
Signed-off-by: Christian Ebner --- PVE/API2/Qemu.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 5469089..f9ce355 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -526,6 +526,10 @@ __PACKAGE__->register_method({

[pve-devel] [PATCH docs 4/4] Add monitoring & troubleshooting section

2019-04-03 Thread Alwin Antreich
To give a little overview on where to look if trouble arise. Signed-off-by: Alwin Antreich --- pveceph.adoc | 24 1 file changed, 24 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index b7378d5..7db2039 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -580,6

[pve-devel] [PATCH docs 1/4] Change heading style for Multiple Active MDS

2019-04-03 Thread Alwin Antreich
The current heading style produces the below warning when executing make: asciidoc: WARNING: pveceph.adoc: line 505: missing section: [sect5] With the heading style used in this patch the warning is gone and the heading style is aligned with others of the same indentation. Signed-off-by: Alwin

[pve-devel] [PATCH docs 0/4] extend pveceph docs

2019-04-03 Thread Alwin Antreich
With the current addition of the ceph installation on our GUI, I put some patches together that extend our pveceph documentation to include help on choosing hardware for a hyper-converged PVE + Ceph cluster and where one can find log files and status information on Ceph's health. Sure the last

[pve-devel] [PATCH docs 3/4] Expand the Precondition section

2019-04-03 Thread Alwin Antreich
This patch adds more information about hardware preconditions and practices. Signed-off-by: Alwin Antreich --- pveceph.adoc | 57 +++-- 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index

[pve-devel] [PATCH container] pct create: Set the NICs firewall to enabled by default on container creation

2019-04-03 Thread Christian Ebner
Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 4 1 file changed, 4 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 5a8a9c9..8234df4 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -296,6 +296,10 @@ __PACKAGE__->register_method({

[pve-devel] [PATCH V2 pve-cluster] add 'networks.cfg' to observed files

2019-04-03 Thread Alexandre Derumier
--- data/PVE/Cluster.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 1d8ac85..05864da 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -90,6 +90,7 @@ my $observed = { 'ha/fence.cfg' => 1, 'status.cfg' => 1,

[pve-devel] [PATCH V3 pve-manager 1/1] api2 : cluster: add network

2019-04-03 Thread Alexandre Derumier
--- PVE/API2/Cluster.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index c72a075b..649b5859 100644 --- a/PVE/API2/Cluster.pm +++ b/PVE/API2/Cluster.pm @@ -23,6 +23,7 @@ use PVE::Firewall; use PVE::API2::Firewall::Cluster; use

[pve-devel] [PATCH V3 pve-manager 0/1] add network cluster api

2019-04-03 Thread Alexandre Derumier
changelog v3: merge cluster && vnet api paths to /cluster/network changelog V2: change api paths to /cluster/network/transport /cluster/network/vnet Alexandre Derumier (1): api2 : cluster: add network PVE/API2/Cluster.pm | 7 +++ 1 file changed, 7 insertions(+) -- 2.11.0

[pve-devel] [PATCH v5 pve-common 2/5] INotify : add vnet as bridge type

2019-04-03 Thread Alexandre Derumier
--- src/PVE/INotify.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index d1c563f..fe6cad8 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -1049,7 +1049,7 @@ sub __read_etc_network_interfaces { } else {

[pve-devel] [PATCH v5 pve-common 4/5] INotify: check duplicate interface name by family

2019-04-03 Thread Alexandre Derumier
--- src/PVE/INotify.pm | 4 1 file changed, 4 insertions(+) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 0dae177..70c34b1 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -914,6 +914,10 @@ sub __read_etc_network_interfaces { my $f = { method => $3 }; #

[pve-devel] [PATCH v5 pve-common 3/5] INotify: add vrf support

2019-04-03 Thread Alexandre Derumier
--- src/PVE/INotify.pm | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index fe6cad8..0dae177 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -955,6 +955,8 @@ sub __read_etc_network_interfaces {

[pve-devel] [PATCH v5 pve-common 5/5] json schema : add pve-network-id

2019-04-03 Thread Alexandre Derumier
fix me : fix parsing of vnet(\d+) different than other plugins --- src/PVE/JSONSchema.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index f0fc2aa..1b45398 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@

[pve-devel] [PATCH v5 pve-common 0/5] INotify network interfaces improvments

2019-04-03 Thread Alexandre Derumier
changelog v5: jsonschema : merge pve-transport-id && pve-vnet-id to pve-network-id changelog v4: add pve-net-id in jsonschema for network vnet api changelog v3: add pve-transport-id in jsonschema for network transport api Alexandre Derumier (5): INotify : add uplink-id option INotify : add

[pve-devel] [PATCH v5 pve-common 1/5] INotify : add uplink-id option

2019-04-03 Thread Alexandre Derumier
uplink-id is an integer it's used to abstract the interface name (could be different on differents hosts) and map it to a transportzone. uplink-id is only allowed on physical interfaces (bond,eth,vlan) as it's used for traffic to external example: auto eth0 iface eth0 inet manual

[pve-devel] [PATCH pve-network] merge Transport && Vnet to PVE::Network::Network

2019-04-03 Thread Alexandre Derumier
config is now merged in /etc/pve/networks.cfg Vnet is a Plugin --- PVE/API2/Makefile | 4 - PVE/API2/Network/Makefile | 2 +- PVE/API2/Network/Transport.pm | 235 - PVE/API2/Network/Vnet.pm

[pve-devel] applied: [PATCH v2 pve 0/20] U2F authentication + TFA improvements

2019-04-03 Thread Thomas Lamprecht
On 4/2/19 12:21 PM, Wolfgang Bumiller wrote: > This should bring the TFA improvements closer to a finish. > Changes to v1: > * Moved libu2f-server bindings to a separate package > * Changed .../u2f api endpoints to be named .../tfa, because: > * Added support for user-configured TOTP (also

[pve-devel] [PATCH zsync v2] close #1933: add -dest-config-path option

2019-04-03 Thread Mira Limbeck
this allows the config dir to be set on the destination target. this can be useful if the default path in $CONFIG_PATH (/var/lib/pve-zsync) is not persistent. the option is optional and falls back to $CONFIG_PATH if not specified. Signed-off-by: Mira Limbeck --- v2: - applies cleanly on master

Re: [pve-devel] [PATCH zsync] close #1933: add -dest-config-path option

2019-04-03 Thread Mira Limbeck
On 4/3/19 12:25 PM, Thomas Lamprecht wrote: On 4/3/19 11:59 AM, Mira Limbeck wrote: this allows the config dir to be set on the destination target. this can be useful if the default path in $CONFIG_PATH (/var/lib/pve-zsync) is not persistent. the option is optional and falls back to

[pve-devel] [PATCH manager] fix: #1218 Expose unique MAC address generation on restore of VMs and CTs in UI

2019-04-03 Thread Christian Ebner
Adds a checkbox to the restore window, allowing the user to avoid MAC address collisions when restoring a VM/CT to a different vmid. When restoring to the same vmid the checkbox is not visible. Signed-off-by: Christian Ebner --- www/manager6/window/Restore.js | 10 +- 1 file changed, 9

[pve-devel] applied: [PATCH v2 manager] Add Ceph, iscsi and more disk and zfs information to pvereport

2019-04-03 Thread Thomas Lamprecht
On 4/3/19 10:25 AM, Friedrich Ramberger wrote: > Following items added to pvereport: > > * more details about disks > * iscsi information > * more zfs information > * ceph information (only when ceph.conf exists) > > When running from command line now report progress is shown at the console >

Re: [pve-devel] [PATCH storage 1/1] Fix #318: Delete vzdump log when deleting a backup

2019-04-03 Thread Thomas Lamprecht
On 4/3/19 12:39 PM, Dominik Csapak wrote: > On 4/3/19 12:27 PM, Dominic Jaeger wrote: >> Signed-off-by: Dominic Jaeger >> --- >>   PVE/API2/Storage/Content.pm | 5 + >>   1 file changed, 5 insertions(+) >> >> diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm >> index

Re: [pve-devel] [PATCH storage 1/1] Fix #318: Delete vzdump log when deleting a backup

2019-04-03 Thread Dominik Csapak
On 4/3/19 12:27 PM, Dominic Jaeger wrote: Signed-off-by: Dominic Jaeger --- PVE/API2/Storage/Content.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index e941cb6..cbee77d 100644 --- a/PVE/API2/Storage/Content.pm +++

[pve-devel] [PATCH storage 0/1] Delete logs for backups

2019-04-03 Thread Dominic Jaeger
Vzdump logs were not deleted when deleting a backup Dominic Jaeger (1): Fix #318: Delete vzdump log when deleting a backup PVE/API2/Storage/Content.pm | 5 + 1 file changed, 5 insertions(+) -- 2.11.0 ___ pve-devel mailing list

[pve-devel] [PATCH storage 1/1] Fix #318: Delete vzdump log when deleting a backup

2019-04-03 Thread Dominic Jaeger
Signed-off-by: Dominic Jaeger --- PVE/API2/Storage/Content.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index e941cb6..cbee77d 100644 --- a/PVE/API2/Storage/Content.pm +++ b/PVE/API2/Storage/Content.pm @@ -308,6 +308,11 @@

Re: [pve-devel] [PATCH zsync] close #1933: add -dest-config-path option

2019-04-03 Thread Thomas Lamprecht
On 4/3/19 11:59 AM, Mira Limbeck wrote: > this allows the config dir to be set on the destination target. this can > be useful if the default path in $CONFIG_PATH (/var/lib/pve-zsync) is not > persistent. the option is optional and falls back to $CONFIG_PATH if not > specified. does not applies

[pve-devel] applied: [PATCH storage] zfs: don't generate/update cachefile on pool import

2019-04-03 Thread Thomas Lamprecht
On 4/3/19 11:06 AM, Fabian Grünbichler wrote: > during storage activation. > > for pools that don't get imported at boot (e.g. because their vdevs are > not available when zfs-import-*.service runs) it is fatal to include > them in the cachefile, for those that do get imported at boot this code >

[pve-devel] [PATCH zsync] close #1933: add -dest-config-path option

2019-04-03 Thread Mira Limbeck
this allows the config dir to be set on the destination target. this can be useful if the default path in $CONFIG_PATH (/var/lib/pve-zsync) is not persistent. the option is optional and falls back to $CONFIG_PATH if not specified. Signed-off-by: Mira Limbeck --- pve-zsync | 19

[pve-devel] applied: [PATCH manager] fix: #1145 enable CT/VM firewall by default on creation via WebUI

2019-04-03 Thread Dominik Csapak
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH storage] zfs: don't generate/update cachefile on pool import

2019-04-03 Thread Fabian Grünbichler
during storage activation. for pools that don't get imported at boot (e.g. because their vdevs are not available when zfs-import-*.service runs) it is fatal to include them in the cachefile, for those that do get imported at boot this code should never run anyway as they are already imported. in

Re: [pve-devel] applied: [PATCH pve-network 0/3] vnet api && cleanups

2019-04-03 Thread Alexandre DERUMIER
>>I wonder if it would be possible to use a single vnet config file? >>You currently use: >> >>/etc/pve/network/vnet.cfg >>/etc/pve/network/transports.cfg >> >>Both implementations use SectionConfig.pm, so it should be easy to merge that >>into a single config file? >> >>I am just curious if

[pve-devel] [PATCH v2 manager] Add Ceph, iscsi and more disk and zfs information to pvereport

2019-04-03 Thread Friedrich Ramberger
Following items added to pvereport: * more details about disks * iscsi information * more zfs information * ceph information (only when ceph.conf exists) When running from command line now report progress is shown at the console (STDERR) --- v2: avoid whitespace errors in the patch

Re: [pve-devel] [PATCH v2 access-control 1/7] more general 2FA configuration via priv/tfa.cfg

2019-04-03 Thread Thomas Lamprecht
On 4/2/19 12:21 PM, Wolfgang Bumiller wrote: > Adds a priv/tfa.cfg file usable in place of user.cfg. > (Otherwise the user.cfg can potentially grow too big with > u2f keys.) > > Also contains some preparation code for u2f and > user-opt-in totp. > > Signed-off-by: Wolfgang Bumiller > --- >

[pve-devel] [PATCH manager] fix: #1145 enable CT/VM firewall by default on creation via WebUI

2019-04-03 Thread Christian Ebner
Signed-off-by: Christian Ebner --- www/manager6/lxc/Network.js | 1 + www/manager6/qemu/HardwareView.js | 3 ++- www/manager6/qemu/NetworkEdit.js | 6 -- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/www/manager6/lxc/Network.js b/www/manager6/lxc/Network.js index

Re: [pve-devel] rfc : pve-network : idea to generate and reload config accross the nodes

2019-04-03 Thread Alexandre DERUMIER
>>I is still unclear to me how you do those tests? AFAIK, ifreload does not >>have a --dry-run option. with ifupdown2, ifreload -a --no-act. (+ tests with our currrent read_networt_interface code) >>Even when it has such option, it would need access to the local node? (to see >>what interfaces