Thanks for the feedback. I’ll look at modifying the patch to work with
Illumos distribution (I have an OpenIndiana VM I can experiment with), as
well as moving the get_initiator_name() method to pve-common.
I’ll get back with updated changes in a little bit.
On May 16, 2019 at 05:29:43, Michael
similar to how we handle the cluster wide tasklist and rrd data,
have an interface that can sync data across the cluster
this data is only transient and will not be written to disk
we can use this for a number of things, e.g. listing ceph services
across the cluster, etc.
Signed-off-by: Dominik
this series add a new generic interface to broadcast (transient) data
to the cluster members
Dominik Csapak (2):
pmxcfs: make status entry removable
add generic data broadcast interface
data/PVE/Cluster.pm | 54 +
data/src/status.c | 4
we can now do a CFS_IPC_SET_STATUS with no data, which results in
removal of the entry in the kv entries
Signed-off-by: Dominik Csapak
---
new in v4
data/PVE/Cluster.pm | 6 ++
data/src/status.c | 4 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/data/PVE/Cluster.pm
On 5/16/19 12:22 PM, Dominik Csapak wrote:
> fixes various type issues and changes to fwrite_unlocked from write
> for more details see the commit messages
>
> changes from v1:
> * more detailed commit messages
>
> Dominik Csapak (5):
> add static to functions
> fix implicit type conversions
i would really like to have some kind of multiselect combobox instead
of 4+ new checkboxes
On 5/15/19 6:15 PM, Oguz Bektas wrote:
adds atime related options (noatime, nodiratime, relatime,
strictatime) and other extra mount options for performance (nobarrier) and
security (noexec, nosuid,
hmm, i am not sure if we want to add a seperate option for each one?
maybe it would be better to have one 'mountoptions' option
that is a ';' seperated list like the qemu cpu flags?
@Wolfgang, @Thomas what do you say?
On 5/15/19 6:15 PM, Oguz Bektas wrote:
added atime-related options (noatime,
with commit 64d1a6a it's now possible to specify a format other than raw
or qcow2 when creating VMs. This can lead to an error when cloning the
VMs and a cloudinit disk with a different format is attached (e.g.
vmdk).
We use QEMU_FORMAT_RE in drive_is_cloudinit and according to the
QEMU_FORMAT_RE
On Thu, 16 May 2019 14:02:30 +0200
Dominik Csapak wrote:
>
> first i looked at omnios (current release) and there
> 'stmfadm list-view' has no '-v' argument and fails
>
This is true and I guess it will never have that option.
> as i know that at least the original author uses omnios with
Resolves the issue of restoring a VM that has a cloudinit drive
configured to a new VMID. The VMID of the disk name gets now remapped
correctly and in the process the cloudinit disk is created with the same size
as in PVE/API2/Qemu.pm create_disks and in PVE/QemuServer/Cloudinit
The variable is used instead of the literal value so we have one single
place to change the actual value of every use.
Signed-off-by: Mira Limbeck
---
v3: no changes
v2:
made CLOUDINIT_DISK_SIZE a constant instead of a variable
PVE/API2/Qemu.pm| 4 ++--
the first patch is a simple cleanup as we're introducing a third spot
where the cloudinit disk size is required in the 2nd patch. we now define one
constant that's used in all 3 spots. this means the 2nd patch requires
the first one to be applied.
the second patch is the actual fix for restoring
On 5/15/19 5:19 PM, David Hedbor wrote:
I'm testing out ZFS over iSCSI with a Oracle Solaris 11.3 server
(Sparc based specifically). It almost works - what doesn't work is
when I try to act on the disk in any way (such as start
KVM). Specifically it is unable to find the LUN.
Looking at the
contains an error
On 5/16/19 11:38 AM, Mira Limbeck wrote:
Resolves the issue of restoring a VM that has a cloudinit drive
configured to a new VMID. The VMID of the disk name gets now remapped
correctly and in the process the cloudinit disk is created with the same size
as in PVE/API2/Qemu.pm
faster since it does not have to look for '\0'
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 3be348e..d5c55fd 100644
--- a/src/mini-journalreader.c
by either fixing the type, or manually casting
this makes the types more explicit
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index fd229b9..0747d7c
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 0747d7c..1586592 100644
--- a/src/mini-journalreader.c
+++ b/src/mini-journalreader.c
@@ -110,11 +110,9
this changes link behaviour and those functions are not exported to other
files when some c code is linked against our code
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git
fixes various type issues and changes to fwrite_unlocked from write
for more details see the commit messages
changes from v1:
* more detailed commit messages
Dominik Csapak (5):
add static to functions
fix implicit type conversions
reuse get_timestamp
use fwrite_unlocked instead of
this does the same as our old code, but is a lot shorter,
so it was uneccessary to have and the performance is the same
(no measureable difference)
we still need a wrapper to be sure that we wrote everything
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 34
Resolves the issue of restoring a VM that has a cloudinit drive
configured to a new VMID. The VMID of the disk name gets now remapped
correctly and in the process the cloudinit disk is created with the same size
as in PVE/API2/Qemu.pm create_disks and in PVE/QemuServer/Cloudinit
The variable is used instead of the literal value so we have one single
place to change the actual value of every use.
Signed-off-by: Mira Limbeck
---
v2:
made CLOUDINIT_DISK_SIZE a constant instead of a variable
PVE/API2/Qemu.pm| 4 ++--
PVE/QemuServer/Cloudinit.pm | 2 ++
2
the first patch is a simple cleanup as we're introducing a third spot
where the cloudinit disk size is required in the 2nd patch. we now define one
constant that's used in all 3 spots. this means the 2nd patch requires
the first one to be applied.
the second patch is the actual fix for restoring
we still need a wrapper to be sure that we wrote everything
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 34 ++
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 3be348e..d5c55fd 100644
--- a/src/mini-journalreader.c
+++ b/src/mini-journalreader.c
@@ -91,12 +91,12 @@
fixes various type issues and changes to fwrite_unlocked from write
Dominik Csapak (5):
add static to functions
fix implicit type conversions
reuse get_timestamp
use fwrite_unlocked instead of manually printing to buffer
use memcpy/cmp instead of strncpy/cmp
src/mini-journalreader.c |
by either fixing the type, or manually casting
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index fd229b9..0747d7c 100644
--- a/src/mini-journalreader.c
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 508de02..fd229b9 100644
--- a/src/mini-journalreader.c
+++ b/src/mini-journalreader.c
Signed-off-by: Dominik Csapak
---
src/mini-journalreader.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/mini-journalreader.c b/src/mini-journalreader.c
index 0747d7c..1586592 100644
--- a/src/mini-journalreader.c
+++ b/src/mini-journalreader.c
@@ -110,11 +110,9
applied
On Wed, May 15, 2019 at 05:09:13PM +0200, Christian Ebner wrote:
> Incomming and outgoing packets passing the firewall bridge were unneccessarily
> logged, leading to double entries.
> The first log entry occurred when passing the bridge, the second when the
> packets
> fate was decided
On 5/16/19 9:04 AM, Alexandre DERUMIER wrote:
>>> When we added this we had some discussion about the sensible default, IIRC,
>>> I initially was for no ratelimit per default, but Christian argued that with
>>> the bucket burst limit we have a sensible balance between spamming the logs
>>> (if
>>When we added this we had some discussion about the sensible default, IIRC,
>>I initially was for no ratelimit per default, but Christian argued that with
>>the bucket burst limit we have a sensible balance between spamming the logs
>>(if something is off, and a lot of packets get generated) but
>>but all Windows >= 8 or >= 2012 support it for sure, so we could enable it
>>for
>>those.
yes indeed.
>>If I read the table correctly then 512e is even "more" supported (older
>>ones with service pack or KB) as 4K native.
I don't known if we can switch an existing disk without need to
On 5/16/19 1:18 AM, Alexandre DERUMIER wrote:
> Thanks !
>
> Also,
> about new log ratelimit
>
On 5/16/19 8:40 AM, Alexandre DERUMIER wrote:
>>> Sounds like a good idea. Maybe we can even set a better default (512e)?
>
> don't seem to works with all windows version (including KB on some versions)
>
>>Sounds like a good idea. Maybe we can even set a better default (512e)?
don't seem to works with all windows version (including KB on some versions)
https://support.microsoft.com/en-us/help/2510009/microsoft-support-policy-for-4k-sector-hard-drives-in-windows
Alexandre Derumier
36 matches
Mail list logo
