Re: [pve-devel] [PATCH qemu-server] Fix #2343 Add USB3 support for Spice USB redirection

2019-08-28 Thread Aaron Lauterer
In a discussion with Stefan we came to the conclusion / realization that all the checks for $kvmver and $machine may not be necessary. This patch is most likely not correct the way it is now. More feedback is welcome :) On 8/28/19 4:26 PM, Aaron Lauterer wrote: If USB3 is enabled for a USB

[pve-devel] applied: [PATCH ifupdown2] fix bridge_port_condone_regex default value

2019-08-28 Thread Thomas Lamprecht
On 28.08.19 16:05, Alexandre Derumier wrote: > --- > ...-veth-fwpr-interfaces-from-bridge-on.patch | 22 +++ > 1 file changed, 18 insertions(+), 4 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH qemu-server] Fix #2343 Add USB3 support for Spice USB redirection

2019-08-28 Thread Aaron Lauterer
If USB3 is enabled for a USB port of host type spice add a USB3 controller and use it. To not break live migration this is only enabled for qemu 4.1 and higher. Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 4 ++-- PVE/QemuServer/USB.pm | 22 -- 2 files

Re: [pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

2019-08-28 Thread Alexandre DERUMIER
>>It seems that the >>"pve/0002-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch" >>can be replaced by setting a default "bridge-ports-condone-regex" in >>ifupdown2/addon/bridge.py , the rest applied just fine. I just sent a small fix because the default value was not used. Others

[pve-devel] [PATCH ifupdown2] fix bridge_port_condone_regex default value

2019-08-28 Thread Alexandre Derumier
--- ...-veth-fwpr-interfaces-from-bridge-on.patch | 22 +++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/debian/patches/pve/0001-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch

Re: [pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

2019-08-28 Thread Alexandre DERUMIER
>>1.2.8 seemed OK, but did only basic checks, it's now available on pvetest >>if you want to take a look at it. Yes sure. I was planning to update to 1.2.8, but you have been faster than me ;) - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Envoyé: Mercredi 28

[pve-devel] applied: [PATCH i18n] Add hebrew translation

2019-08-28 Thread Thomas Lamprecht
On 23.08.19 11:27, Dominic Jäger wrote: > Contributed-by: Condless > Signed-off-by: Dominic Jäger > --- > Looks good according to Google Translate. > > Makefile |2 +- > he.po| 6156 ++ > 2 files changed, 6157 insertions(+), 1

Re: [pve-devel] [PATCH manager] pve5to6: Add warning for some Gluster versions

2019-08-28 Thread Dominic Jäger
After Fabian had sent his patch [0] we actually thought that this patch for pve5to6 would be obsolete. Upgrades as well as fresh installs worked flawlessly in my tests. Consequently, I removed the hint from the upgrade documentation [1] and marked the bug [2] as fixed. Before writing you this,

Re: [pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

2019-08-28 Thread Thomas Lamprecht
On 28.08.19 08:58, Thomas Lamprecht wrote: > Hi, > > On 27.08.19 16:28, Alexandre DERUMIER wrote: >> Hi, >> >> the ifupdown2 pve package is missing from buster/proxmox6 repo. >> >> Could you add it ? > > yes, as we had the same version as Debian Buster it seemed I missed to > re-upload it.. >

[pve-devel] [PATCH common 1/2] Fix 2339: Handle multiple blank lines correctly

2019-08-28 Thread Fabian Ebner
It turns out that the line number counting was also broken (even on files without multiple blanks), since the body of the while inside the nextline subroutine would not be executed for a blank. I guess the subroutine was intended to skip comments and blanks, but since we use blanks to recognize

[pve-devel] [PATCH common 2/2] Cleanup to make style consistent

2019-08-28 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- src/PVE/SectionConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm index a760459..394aae6 100644 --- a/src/PVE/SectionConfig.pm +++ b/src/PVE/SectionConfig.pm @@ -334,7 +334,7 @@ sub

Re: [pve-devel] [PATCH i18n] Add hebrew translation

2019-08-28 Thread Thomas Lamprecht
On 23.08.19 11:27, Dominic Jäger wrote: > Contributed-by: Condless > Signed-off-by: Dominic Jäger > --- > Looks good according to Google Translate. I got a issue when trying to update the po files with this applied: # make update ... snip ... he: he.po:523:14: invalid control sequence

[pve-devel] [PATCH v3 docs 2/5] Add cluster create screenshot

2019-08-28 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- images/screenshot/gui-cluster-create.png | Bin 0 -> 18124 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 images/screenshot/gui-cluster-create.png diff --git a/images/screenshot/gui-cluster-create.png

[pve-devel] [PATCH v3 docs 4/5] Add cluster join screenshot

2019-08-28 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- images/screenshot/gui-cluster-join.png | Bin 0 -> 61710 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 images/screenshot/gui-cluster-join.png diff --git a/images/screenshot/gui-cluster-join.png

[pve-devel] [PATCH v3 docs 3/5] Add cluster join information screenshot

2019-08-28 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- .../screenshot/gui-cluster-join-information.png | Bin 0 -> 53366 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 images/screenshot/gui-cluster-join-information.png diff --git a/images/screenshot/gui-cluster-join-information.png

[pve-devel] [PATCH v3 docs 5/5] Add screenshot references to cluster GUI section

2019-08-28 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- pvecm.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pvecm.adoc b/pvecm.adoc index c41e691..7bccaa7 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -114,6 +114,8 @@ cluster name follows the same rules as node names. Create via Web GUI

[pve-devel] [PATCH v3 docs 1/5] Mention GUI for creating a cluster and adding nodes

2019-08-28 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- Sorry for missing 2/2 on previous patch series, had some trouble with the mailing list not accepting my mails. v3: * Changed "Add Node" section to allow better image placement v2: * Changed some wording to remove "you"s and made sections clearer. Big thanks

[pve-devel] applied: [PATCH container] don't leave fstrim lock if mount_all fails

2019-08-28 Thread Thomas Lamprecht
On 26.08.19 16:06, Oguz Bektas wrote: > when a container has a mountpoint which can't be mounted for some reason, > mount_all dies and the fstrim lock stays. prevent this by moving the call into > eval, warn if any error occurs. applied, but added a little bit information here about the

Re: [pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

2019-08-28 Thread Thomas Lamprecht
On 28.08.19 10:10, Aaron Lauterer wrote: > > > On 8/28/19 9:42 AM, Thomas Lamprecht wrote: >> On 27.08.19 16:31, Aaron Lauterer wrote: >>> On 8/27/19 12:27 PM, Christian Ebner wrote: Signed-off-by: Christian Ebner >>> +In contrast to Linux virtual bridges, OVS bridges can carry

Re: [pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

2019-08-28 Thread Aaron Lauterer
On 8/28/19 9:42 AM, Thomas Lamprecht wrote: On 27.08.19 16:31, Aaron Lauterer wrote: On 8/27/19 12:27 PM, Christian Ebner wrote: Signed-off-by: Christian Ebner +In contrast to Linux virtual bridges, OVS bridges can carry multiple VLANs over +a sinlge bridge. # this is not true. by now

Re: [pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

2019-08-28 Thread Thomas Lamprecht
On 27.08.19 16:31, Aaron Lauterer wrote: > On 8/27/19 12:27 PM, Christian Ebner wrote: >> Signed-off-by: Christian Ebner >> +see the https://pve.proxmox.com/wiki/Open_vSwitch[Open vSwitch wiki page] >> for >> +further details. >> + >> +OVS Bridge >> +^^ >> + >> +Just like a Linux

Re: [pve-devel] ifupdown2 pve package missing in buster/proxmox6 repo

2019-08-28 Thread Thomas Lamprecht
Hi, On 27.08.19 16:28, Alexandre DERUMIER wrote: > Hi, > > the ifupdown2 pve package is missing from buster/proxmox6 repo. > > Could you add it ? yes, as we had the same version as Debian Buster it seemed I missed to re-upload it.. I'd then already update to 1.2.8 or? Currently in the

Re: [pve-devel] [PATCH common] Fix 2339: Handle multiple blank lines correctly

2019-08-28 Thread Thomas Lamprecht
On 27.08.19 09:01, Fabian Ebner wrote: > Otherwise two blank lines between sections cause the loop to end prematurely. > > Signed-off-by: Fabian Ebner > --- > src/PVE/SectionConfig.pm | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/SectionConfig.pm