Re: [pve-devel] [PATCH container] add 'lock' as a fastplug option

2019-10-24 Thread Thomas Lamprecht
On 10/24/19 5:19 PM, Oguz Bektas wrote: > On Thu, Oct 24, 2019 at 05:12:20PM +0200, Thomas Lamprecht wrote: >> On 10/24/19 3:58 PM, Oguz Bektas wrote: >>> lock option needs to be fastpluggable when modifying with 'pct set'. >>> otherwise it registers as a pending change. >>> >> possible stupid ques

Re: [pve-devel] [PATCH container] add 'lock' as a fastplug option

2019-10-24 Thread Oguz Bektas
On Thu, Oct 24, 2019 at 05:12:20PM +0200, Thomas Lamprecht wrote: > On 10/24/19 3:58 PM, Oguz Bektas wrote: > > lock option needs to be fastpluggable when modifying with 'pct set'. > > otherwise it registers as a pending change. > > > possible stupid question ahead: do I want to be able to set/cle

Re: [pve-devel] [PATCH container] add 'lock' as a fastplug option

2019-10-24 Thread Thomas Lamprecht
On 10/24/19 3:58 PM, Oguz Bektas wrote: > lock option needs to be fastpluggable when modifying with 'pct set'. > otherwise it registers as a pending change. > possible stupid question ahead: do I want to be able to set/clear a lock at all with pct set?? Same for qm, I'd guess. But it works there,

[pve-devel] [PATCH container] add 'lock' as a fastplug option

2019-10-24 Thread Oguz Bektas
lock option needs to be fastpluggable when modifying with 'pct set'. otherwise it registers as a pending change. Signed-off-by: Oguz Bektas --- src/PVE/LXC/Config.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index b744d4f..d624b0b 100644 --

[pve-devel] [PATCH v2 qemu-server 1/2] parser/writer: namespace pending section

2019-10-24 Thread Oguz Bektas
to make the pct/qemu config formats more similar, we can namespace the pending section using the 'pve:' prefix like in pct parser. the new format is optional in the parser, but default in the writer. with PVE 7.0, we can make it default in parser too. Signed-off-by: Oguz Bektas --- PVE/QemuSer

[pve-devel] [PATCH v2 qemu-server 2/2] fix #2367: do not allow snapshot with name PENDING

2019-10-24 Thread Oguz Bektas
or any other variant of the word 'pending'. note that we can actually allow this snapshot after PVE 7.0, since pending section and snapshots will be properly namespaced. ([pve:pending] and [snap:$snapname] or similar). Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 5 - 1 file changed,

Re: [pve-devel] [PATCH qemu-server 1/2] parser/writer: namespace pending section

2019-10-24 Thread Thomas Lamprecht
On 10/22/19 12:12 PM, Oguz Bektas wrote: > to make the pct/qemu config formats more similar, we can namespace the > pending section using the 'pve:' prefix like in pct parser. > > the new format is optional in the parser, but default in the writer. > > with PVE 7.0, we can make it default in pars

Re: [pve-devel] [PATCH qemu-server 2/2] fix #2367: do not allow snapshot with name PENDING

2019-10-24 Thread Thomas Lamprecht
On 10/22/19 12:23 PM, Oguz Bektas wrote: > On Tue, Oct 22, 2019 at 12:15:35PM +0200, Stefan Reiter wrote: >> On 10/22/19 12:12 PM, Oguz Bektas wrote: >>> or any other variant of the word 'pending' >>> >>> note that we can actually allow this snapshot after PVE 7.0, since >>> pending section and sna

[pve-devel] applied-series: [PATCH qemu 1/3] backup_job_create: pass cluster size for dump

2019-10-24 Thread Thomas Lamprecht
On 10/24/19 8:06 AM, Dietmar Maurer wrote: > Signed-off-by: Dietmar Maurer > --- > block/backup.c| 8 +++- > block/replication.c | 2 +- > blockdev.c| 10 ++ > include/block/block_int.h | 4 > 4 files changed, 18 insertions(+), 6 deletions(-)